[INFO] updating cached repository Cyberrebell/rust-sample-geometry [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Cyberrebell/rust-sample-geometry [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Cyberrebell/rust-sample-geometry" "work/ex/clippy-test-run/sources/stable/gh/Cyberrebell/rust-sample-geometry"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Cyberrebell/rust-sample-geometry'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Cyberrebell/rust-sample-geometry" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cyberrebell/rust-sample-geometry"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cyberrebell/rust-sample-geometry'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fae7b435db5b8034e36675daa78ba16100ee001b [INFO] sha for GitHub repo Cyberrebell/rust-sample-geometry: fae7b435db5b8034e36675daa78ba16100ee001b [INFO] validating manifest of Cyberrebell/rust-sample-geometry on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Cyberrebell/rust-sample-geometry on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Cyberrebell/rust-sample-geometry [INFO] finished frobbing Cyberrebell/rust-sample-geometry [INFO] frobbed toml for Cyberrebell/rust-sample-geometry written to work/ex/clippy-test-run/sources/stable/gh/Cyberrebell/rust-sample-geometry/Cargo.toml [INFO] started frobbing Cyberrebell/rust-sample-geometry [INFO] finished frobbing Cyberrebell/rust-sample-geometry [INFO] frobbed toml for Cyberrebell/rust-sample-geometry written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cyberrebell/rust-sample-geometry/Cargo.toml [INFO] crate Cyberrebell/rust-sample-geometry has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Cyberrebell/rust-sample-geometry against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cyberrebell/rust-sample-geometry:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6ee2d8b638e806dd22a8cb4af533538f3526c480d1cf5dfa929e5be44c3f1870 [INFO] running `"docker" "start" "-a" "6ee2d8b638e806dd22a8cb4af533538f3526c480d1cf5dfa929e5be44c3f1870"` [INFO] [stderr] Checking sample-geometry v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometries/cube.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | return self.a.powi(3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.a.powi(3)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometries/cube.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return self.a.powi(2) * 6.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.a.powi(2) * 6.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometries/sphere.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return (PI / 6.0) * self.d.powi(3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(PI / 6.0) * self.d.powi(3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometries/sphere.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return PI * self.d.powi(2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PI * self.d.powi(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometries/pyramid.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return self.a.powi(2) * self.h / 3.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.a.powi(2) * self.h / 3.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometries/pyramid.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return self.a.powi(2) + (self.a * (4.0 * self.h.powi(2) + self.a.powi(2)).sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.a.powi(2) + (self.a * (4.0 * self.h.powi(2) + self.a.powi(2)).sqrt())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometries/cube.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | return self.a.powi(3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.a.powi(3)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometries/cube.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return self.a.powi(2) * 6.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.a.powi(2) * 6.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometries/sphere.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return (PI / 6.0) * self.d.powi(3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(PI / 6.0) * self.d.powi(3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometries/sphere.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return PI * self.d.powi(2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PI * self.d.powi(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometries/pyramid.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return self.a.powi(2) * self.h / 3.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.a.powi(2) * self.h / 3.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometries/pyramid.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return self.a.powi(2) + (self.a * (4.0 * self.h.powi(2) + self.a.powi(2)).sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.a.powi(2) + (self.a * (4.0 * self.h.powi(2) + self.a.powi(2)).sqrt())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.35s [INFO] running `"docker" "inspect" "6ee2d8b638e806dd22a8cb4af533538f3526c480d1cf5dfa929e5be44c3f1870"` [INFO] running `"docker" "rm" "-f" "6ee2d8b638e806dd22a8cb4af533538f3526c480d1cf5dfa929e5be44c3f1870"` [INFO] [stdout] 6ee2d8b638e806dd22a8cb4af533538f3526c480d1cf5dfa929e5be44c3f1870