[INFO] updating cached repository ConnorGray/rs-regexp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ConnorGray/rs-regexp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ConnorGray/rs-regexp" "work/ex/clippy-test-run/sources/stable/gh/ConnorGray/rs-regexp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ConnorGray/rs-regexp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ConnorGray/rs-regexp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ConnorGray/rs-regexp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ConnorGray/rs-regexp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d296052d811c15684f90b1c59223c4aaebfd3a9d [INFO] sha for GitHub repo ConnorGray/rs-regexp: d296052d811c15684f90b1c59223c4aaebfd3a9d [INFO] validating manifest of ConnorGray/rs-regexp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ConnorGray/rs-regexp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ConnorGray/rs-regexp [INFO] finished frobbing ConnorGray/rs-regexp [INFO] frobbed toml for ConnorGray/rs-regexp written to work/ex/clippy-test-run/sources/stable/gh/ConnorGray/rs-regexp/Cargo.toml [INFO] started frobbing ConnorGray/rs-regexp [INFO] finished frobbing ConnorGray/rs-regexp [INFO] frobbed toml for ConnorGray/rs-regexp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ConnorGray/rs-regexp/Cargo.toml [INFO] crate ConnorGray/rs-regexp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ConnorGray/rs-regexp against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ConnorGray/rs-regexp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 596dda98086fb0bf3122c0cc1a11a1024c42f28540dc121907ba6ed1a5cbdfa5 [INFO] running `"docker" "start" "-a" "596dda98086fb0bf3122c0cc1a11a1024c42f28540dc121907ba6ed1a5cbdfa5"` [INFO] [stderr] Checking regexp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/create.rs:151:22 [INFO] [stderr] | [INFO] [stderr] 151 | 1 => return Result::Ok(stack.pop().unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(stack.pop().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/create.rs:152:22 [INFO] [stderr] | [INFO] [stderr] 152 | _ => return Result::Ok(Concatenation(stack)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(Concatenation(stack))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/thompson_nfa.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 49 | | if c == cur_char { [INFO] [stderr] 50 | | addthread(&mut cur_stack, Thread { saw_char: true, [INFO] [stderr] 51 | | pc: thread_pc + 1}); [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 48 | } else if c == cur_char { [INFO] [stderr] 49 | addthread(&mut cur_stack, Thread { saw_char: true, [INFO] [stderr] 50 | pc: thread_pc + 1}); [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/matching.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/matching.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | let result = thompson_nfa::thompson_vm(&insts, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/create.rs:151:22 [INFO] [stderr] | [INFO] [stderr] 151 | 1 => return Result::Ok(stack.pop().unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(stack.pop().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/create.rs:152:22 [INFO] [stderr] | [INFO] [stderr] 152 | _ => return Result::Ok(Concatenation(stack)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(Concatenation(stack))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/thompson_nfa.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 49 | | if c == cur_char { [INFO] [stderr] 50 | | addthread(&mut cur_stack, Thread { saw_char: true, [INFO] [stderr] 51 | | pc: thread_pc + 1}); [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 48 | } else if c == cur_char { [INFO] [stderr] 49 | addthread(&mut cur_stack, Thread { saw_char: true, [INFO] [stderr] 50 | pc: thread_pc + 1}); [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/matching.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/matching.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | let result = thompson_nfa::thompson_vm(&insts, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/create.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | if stack.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/thompson_nfa.rs:18:27 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn thompson_vm(insts: &Vec, input: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Inst]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/create.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | if stack.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/thompson_nfa.rs:18:27 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn thompson_vm(insts: &Vec, input: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Inst]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.35s [INFO] running `"docker" "inspect" "596dda98086fb0bf3122c0cc1a11a1024c42f28540dc121907ba6ed1a5cbdfa5"` [INFO] running `"docker" "rm" "-f" "596dda98086fb0bf3122c0cc1a11a1024c42f28540dc121907ba6ed1a5cbdfa5"` [INFO] [stdout] 596dda98086fb0bf3122c0cc1a11a1024c42f28540dc121907ba6ed1a5cbdfa5