[INFO] updating cached repository Chronum94/Knight_vs_Dragon [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Chronum94/Knight_vs_Dragon [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Chronum94/Knight_vs_Dragon" "work/ex/clippy-test-run/sources/stable/gh/Chronum94/Knight_vs_Dragon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Chronum94/Knight_vs_Dragon'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Chronum94/Knight_vs_Dragon" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Chronum94/Knight_vs_Dragon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Chronum94/Knight_vs_Dragon'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2cf0501b6aa34f6ca54fb7077c501c54a969fb79 [INFO] sha for GitHub repo Chronum94/Knight_vs_Dragon: 2cf0501b6aa34f6ca54fb7077c501c54a969fb79 [INFO] validating manifest of Chronum94/Knight_vs_Dragon on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Chronum94/Knight_vs_Dragon on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Chronum94/Knight_vs_Dragon [INFO] finished frobbing Chronum94/Knight_vs_Dragon [INFO] frobbed toml for Chronum94/Knight_vs_Dragon written to work/ex/clippy-test-run/sources/stable/gh/Chronum94/Knight_vs_Dragon/Cargo.toml [INFO] started frobbing Chronum94/Knight_vs_Dragon [INFO] finished frobbing Chronum94/Knight_vs_Dragon [INFO] frobbed toml for Chronum94/Knight_vs_Dragon written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Chronum94/Knight_vs_Dragon/Cargo.toml [INFO] crate Chronum94/Knight_vs_Dragon has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Chronum94/Knight_vs_Dragon against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Chronum94/Knight_vs_Dragon:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5d8c3fa6f53bcae574ec9c1c62ecda147a1d1115e367e1e07cdb3427eb2dab85 [INFO] running `"docker" "start" "-a" "5d8c3fa6f53bcae574ec9c1c62ecda147a1d1115e367e1e07cdb3427eb2dab85"` [INFO] [stderr] Checking Knights_vs_Dragons v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | return dmg; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `dmg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | return dmg; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `dmg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | return dmg; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `dmg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | return dmg; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `dmg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | return dmg; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `dmg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | return dmg; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `dmg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dfn_f2` [INFO] [stderr] --> src/main.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | fn attack(&self, dfn_f2: i32, dodge: f32) -> f32 { [INFO] [stderr] | ^^^^^^ help: consider using `_dfn_f2` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | let mut knight_dmg: f32 = knight.attack(dragon.dfn, dragon.dodge); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | let mut dragon_dmg: f32 = dragon.attack(knight.dfn, knight.dodge); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | let mut acc = rand::thread_rng().gen::(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:24:21 [INFO] [stderr] | [INFO] [stderr] 24 | let mut crit = rand::thread_rng().gen::(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: crate `Knights_vs_Dragons` should have a snake case name such as `knights_vs_dragons` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dfn_f2` [INFO] [stderr] --> src/main.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | fn attack(&self, dfn_f2: i32, dodge: f32) -> f32 { [INFO] [stderr] | ^^^^^^ help: consider using `_dfn_f2` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | let mut knight_dmg: f32 = knight.attack(dragon.dfn, dragon.dodge); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | let mut dragon_dmg: f32 = dragon.attack(knight.dfn, knight.dodge); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | let mut acc = rand::thread_rng().gen::(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:24:21 [INFO] [stderr] | [INFO] [stderr] 24 | let mut crit = rand::thread_rng().gen::(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: crate `Knights_vs_Dragons` should have a snake case name such as `knights_vs_dragons` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.49s [INFO] running `"docker" "inspect" "5d8c3fa6f53bcae574ec9c1c62ecda147a1d1115e367e1e07cdb3427eb2dab85"` [INFO] running `"docker" "rm" "-f" "5d8c3fa6f53bcae574ec9c1c62ecda147a1d1115e367e1e07cdb3427eb2dab85"` [INFO] [stdout] 5d8c3fa6f53bcae574ec9c1c62ecda147a1d1115e367e1e07cdb3427eb2dab85