[INFO] updating cached repository ChristopherRabotin/ephem [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ChristopherRabotin/ephem [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ChristopherRabotin/ephem" "work/ex/clippy-test-run/sources/stable/gh/ChristopherRabotin/ephem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ChristopherRabotin/ephem'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ChristopherRabotin/ephem" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristopherRabotin/ephem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristopherRabotin/ephem'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c90a819a774134e5d44208fdbc3e1fd33c41b15b [INFO] sha for GitHub repo ChristopherRabotin/ephem: c90a819a774134e5d44208fdbc3e1fd33c41b15b [INFO] validating manifest of ChristopherRabotin/ephem on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ChristopherRabotin/ephem on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ChristopherRabotin/ephem [INFO] finished frobbing ChristopherRabotin/ephem [INFO] frobbed toml for ChristopherRabotin/ephem written to work/ex/clippy-test-run/sources/stable/gh/ChristopherRabotin/ephem/Cargo.toml [INFO] started frobbing ChristopherRabotin/ephem [INFO] finished frobbing ChristopherRabotin/ephem [INFO] frobbed toml for ChristopherRabotin/ephem written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristopherRabotin/ephem/Cargo.toml [INFO] crate ChristopherRabotin/ephem has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ChristopherRabotin/ephem against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristopherRabotin/ephem:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2e9b437be386dad81f17c8fab53afba626be575e88abee26faf9751e39510caf [INFO] running `"docker" "start" "-a" "2e9b437be386dad81f17c8fab53afba626be575e88abee26faf9751e39510caf"` [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking mybin v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `le_f32`, `le_u64` [INFO] [stderr] --> src/main.rs:3:11 [INFO] [stderr] | [INFO] [stderr] 3 | use nom::{le_f32, le_f64, le_u32, le_u64}; [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `le_f32`, `le_u64` [INFO] [stderr] --> src/main.rs:3:11 [INFO] [stderr] | [INFO] [stderr] 3 | use nom::{le_f32, le_f64, le_u32, le_u64}; [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `summary_hdr_size` [INFO] [stderr] --> src/main.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | let summary_hdr_size = 3 * 8; // 2: NI; 6: ND; 8 = sizeof(double); 6 = sizeof(int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_summary_hdr_size` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `summaries_per_record` [INFO] [stderr] --> src/main.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | let summaries_per_record = (1024 - 8 * 3) / summary_length; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `_summaries_per_record` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rem` [INFO] [stderr] --> src/main.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | let rem = seek_to_end_of_comment(rem).unwrap().0; [INFO] [stderr] | ^^^ help: consider using `_rem` instead [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ElementRecordMetadata` [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | struct ElementRecordMetadata { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:265:52 [INFO] [stderr] | [INFO] [stderr] 265 | let mut cur_data = data.get(&naif_id).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&data[&naif_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:270:56 [INFO] [stderr] | [INFO] [stderr] 270 | let mut cur_data = data.get(&p_id).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&data[&p_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:295:56 [INFO] [stderr] | [INFO] [stderr] 295 | let mut cur_data = data.get(&naif_id).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&data[&naif_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:352:12 [INFO] [stderr] | [INFO] [stderr] 352 | if rem_array.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rem_array.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused variable: `summary_hdr_size` [INFO] [stderr] --> src/main.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | let summary_hdr_size = 3 * 8; // 2: NI; 6: ND; 8 = sizeof(double); 6 = sizeof(int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_summary_hdr_size` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `summaries_per_record` [INFO] [stderr] --> src/main.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | let summaries_per_record = (1024 - 8 * 3) / summary_length; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `_summaries_per_record` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rem` [INFO] [stderr] --> src/main.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | let rem = seek_to_end_of_comment(rem).unwrap().0; [INFO] [stderr] | ^^^ help: consider using `_rem` instead [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ElementRecordMetadata` [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | struct ElementRecordMetadata { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:265:52 [INFO] [stderr] | [INFO] [stderr] 265 | let mut cur_data = data.get(&naif_id).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&data[&naif_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:270:56 [INFO] [stderr] | [INFO] [stderr] 270 | let mut cur_data = data.get(&p_id).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&data[&p_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:295:56 [INFO] [stderr] | [INFO] [stderr] 295 | let mut cur_data = data.get(&naif_id).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&data[&naif_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:352:12 [INFO] [stderr] | [INFO] [stderr] 352 | if rem_array.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rem_array.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.93s [INFO] running `"docker" "inspect" "2e9b437be386dad81f17c8fab53afba626be575e88abee26faf9751e39510caf"` [INFO] running `"docker" "rm" "-f" "2e9b437be386dad81f17c8fab53afba626be575e88abee26faf9751e39510caf"` [INFO] [stdout] 2e9b437be386dad81f17c8fab53afba626be575e88abee26faf9751e39510caf