[INFO] updating cached repository ChristophWurst/nn_async [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ChristophWurst/nn_async [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ChristophWurst/nn_async" "work/ex/clippy-test-run/sources/stable/gh/ChristophWurst/nn_async"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ChristophWurst/nn_async'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ChristophWurst/nn_async" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristophWurst/nn_async"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristophWurst/nn_async'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 80ac2bc888c9038711b85a30ddcc6cbb343b00a0 [INFO] sha for GitHub repo ChristophWurst/nn_async: 80ac2bc888c9038711b85a30ddcc6cbb343b00a0 [INFO] validating manifest of ChristophWurst/nn_async on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ChristophWurst/nn_async on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ChristophWurst/nn_async [INFO] finished frobbing ChristophWurst/nn_async [INFO] frobbed toml for ChristophWurst/nn_async written to work/ex/clippy-test-run/sources/stable/gh/ChristophWurst/nn_async/Cargo.toml [INFO] started frobbing ChristophWurst/nn_async [INFO] finished frobbing ChristophWurst/nn_async [INFO] frobbed toml for ChristophWurst/nn_async written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristophWurst/nn_async/Cargo.toml [INFO] crate ChristophWurst/nn_async has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ChristophWurst/nn_async against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristophWurst/nn_async:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3f89c4a2eea0eb785172fa6ec0cce92029b7426f659e77596aae13f470bdba40 [INFO] running `"docker" "start" "-a" "3f89c4a2eea0eb785172fa6ec0cce92029b7426f659e77596aae13f470bdba40"` [INFO] [stderr] Checking futures-cpupool v0.1.7 [INFO] [stderr] Checking nn_async v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/nn.rs:14:31 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn find_closest(p_points: &Vec, idx: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | let x = idx.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `idx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:71:29 [INFO] [stderr] | [INFO] [stderr] 71 | let c: Vec = chunk.iter().map(|x| *x).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `chunk.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/nn.rs:14:31 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn find_closest(p_points: &Vec, idx: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | let x = idx.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `idx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:71:29 [INFO] [stderr] | [INFO] [stderr] 71 | let c: Vec = chunk.iter().map(|x| *x).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `chunk.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.41s [INFO] running `"docker" "inspect" "3f89c4a2eea0eb785172fa6ec0cce92029b7426f659e77596aae13f470bdba40"` [INFO] running `"docker" "rm" "-f" "3f89c4a2eea0eb785172fa6ec0cce92029b7426f659e77596aae13f470bdba40"` [INFO] [stdout] 3f89c4a2eea0eb785172fa6ec0cce92029b7426f659e77596aae13f470bdba40