[INFO] updating cached repository ChristianLowe/rdp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ChristianLowe/rdp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ChristianLowe/rdp" "work/ex/clippy-test-run/sources/stable/gh/ChristianLowe/rdp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ChristianLowe/rdp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ChristianLowe/rdp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristianLowe/rdp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristianLowe/rdp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0668d5a66218cb17f1615743fedc906890a7005f [INFO] sha for GitHub repo ChristianLowe/rdp: 0668d5a66218cb17f1615743fedc906890a7005f [INFO] validating manifest of ChristianLowe/rdp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ChristianLowe/rdp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ChristianLowe/rdp [INFO] finished frobbing ChristianLowe/rdp [INFO] frobbed toml for ChristianLowe/rdp written to work/ex/clippy-test-run/sources/stable/gh/ChristianLowe/rdp/Cargo.toml [INFO] started frobbing ChristianLowe/rdp [INFO] finished frobbing ChristianLowe/rdp [INFO] frobbed toml for ChristianLowe/rdp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristianLowe/rdp/Cargo.toml [INFO] crate ChristianLowe/rdp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ChristianLowe/rdp against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristianLowe/rdp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c62fc09d5b4038392955211a95ab94483688b45873374b820550447761e50efc [INFO] running `"docker" "start" "-a" "c62fc09d5b4038392955211a95ab94483688b45873374b820550447761e50efc"` [INFO] [stderr] Checking rdp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/lexer.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/lexer.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: the `ch @ _` pattern can be written as just `ch` [INFO] [stderr] --> src/lexer.rs:118:18 [INFO] [stderr] | [INFO] [stderr] 118 | Some(ch @ _) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:18:36 [INFO] [stderr] | [INFO] [stderr] 18 | let mut lexer = Lexer::new(&mut line); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the `ch @ _` pattern can be written as just `ch` [INFO] [stderr] --> src/lexer.rs:118:18 [INFO] [stderr] | [INFO] [stderr] 118 | Some(ch @ _) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:18:36 [INFO] [stderr] | [INFO] [stderr] 18 | let mut lexer = Lexer::new(&mut line); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.98s [INFO] running `"docker" "inspect" "c62fc09d5b4038392955211a95ab94483688b45873374b820550447761e50efc"` [INFO] running `"docker" "rm" "-f" "c62fc09d5b4038392955211a95ab94483688b45873374b820550447761e50efc"` [INFO] [stdout] c62fc09d5b4038392955211a95ab94483688b45873374b820550447761e50efc