[INFO] updating cached repository Chabare/Sonos [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Chabare/Sonos [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Chabare/Sonos" "work/ex/clippy-test-run/sources/stable/gh/Chabare/Sonos"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Chabare/Sonos'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Chabare/Sonos" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Chabare/Sonos"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Chabare/Sonos'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5839e7f4300d6db6d0dc8c74578c5d7d83752334 [INFO] sha for GitHub repo Chabare/Sonos: 5839e7f4300d6db6d0dc8c74578c5d7d83752334 [INFO] validating manifest of Chabare/Sonos on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Chabare/Sonos on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Chabare/Sonos [INFO] finished frobbing Chabare/Sonos [INFO] frobbed toml for Chabare/Sonos written to work/ex/clippy-test-run/sources/stable/gh/Chabare/Sonos/Cargo.toml [INFO] started frobbing Chabare/Sonos [INFO] finished frobbing Chabare/Sonos [INFO] frobbed toml for Chabare/Sonos written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Chabare/Sonos/Cargo.toml [INFO] crate Chabare/Sonos has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Chabare/Sonos against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Chabare/Sonos:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4cf9deb253f3ae300bda7f310a912be8fd928cd0a1fa6a49893c5bcf1e33e601 [INFO] running `"docker" "start" "-a" "4cf9deb253f3ae300bda7f310a912be8fd928cd0a1fa6a49893c5bcf1e33e601"` [INFO] [stderr] Checking fern v0.4.2 [INFO] [stderr] Checking num-bigint v0.1.40 [INFO] [stderr] Checking num-rational v0.1.39 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking socket v0.0.7 [INFO] [stderr] Checking sonos_discovery v0.0.1 [INFO] [stderr] Checking sonos v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors/base.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | error_kind: error_kind [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors/base.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | error_kind: error_kind [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/device/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod device; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/zone/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | mod zone; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/device/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod device; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/zone/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | mod zone; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: method is never used: `empty` [INFO] [stderr] --> src/zone/info.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn empty() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `empty` [INFO] [stderr] --> src/zone/info.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn empty() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | assert!(match setup_logging(log::LogLevelFilter::Debug, None) { [INFO] [stderr] | _________________^ [INFO] [stderr] 56 | | Ok(_) => true, [INFO] [stderr] 57 | | Err(_) => false [INFO] [stderr] 58 | | }); [INFO] [stderr] | |_________^ help: try this: `setup_logging(log::LogLevelFilter::Debug, None).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | assert!(match setup_logging(log::LogLevelFilter::Debug, None) { [INFO] [stderr] | _________________^ [INFO] [stderr] 62 | | Ok(_) => false, [INFO] [stderr] 63 | | Err(_) => true [INFO] [stderr] 64 | | }); [INFO] [stderr] | |_________^ help: try this: `setup_logging(log::LogLevelFilter::Debug, None).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.63s [INFO] running `"docker" "inspect" "4cf9deb253f3ae300bda7f310a912be8fd928cd0a1fa6a49893c5bcf1e33e601"` [INFO] running `"docker" "rm" "-f" "4cf9deb253f3ae300bda7f310a912be8fd928cd0a1fa6a49893c5bcf1e33e601"` [INFO] [stdout] 4cf9deb253f3ae300bda7f310a912be8fd928cd0a1fa6a49893c5bcf1e33e601