[INFO] updating cached repository Catman155/four-in-a-row
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Catman155/four-in-a-row
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Catman155/four-in-a-row" "work/ex/clippy-test-run/sources/stable/gh/Catman155/four-in-a-row"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Catman155/four-in-a-row'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Catman155/four-in-a-row" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Catman155/four-in-a-row"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Catman155/four-in-a-row'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 057c1a1df18fea122ba7b7e0fc3731c2dc1b24c9
[INFO] sha for GitHub repo Catman155/four-in-a-row: 057c1a1df18fea122ba7b7e0fc3731c2dc1b24c9
[INFO] validating manifest of Catman155/four-in-a-row on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Catman155/four-in-a-row on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Catman155/four-in-a-row
[INFO] finished frobbing Catman155/four-in-a-row
[INFO] frobbed toml for Catman155/four-in-a-row written to work/ex/clippy-test-run/sources/stable/gh/Catman155/four-in-a-row/Cargo.toml
[INFO] started frobbing Catman155/four-in-a-row
[INFO] finished frobbing Catman155/four-in-a-row
[INFO] frobbed toml for Catman155/four-in-a-row written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Catman155/four-in-a-row/Cargo.toml
[INFO] crate Catman155/four-in-a-row has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Catman155/four-in-a-row against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Catman155/four-in-a-row:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e860776d1ddd7e34b33f352d747128744aed4103caeac99d708980e39d6629e6
[INFO] running `"docker" "start" "-a" "e860776d1ddd7e34b33f352d747128744aed4103caeac99d708980e39d6629e6"`
[INFO] [stderr]     Checking four_in_a_row v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/draw_board.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         print!("\n")
[INFO] [stderr]    |         ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/draw_board.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         print!("\n")
[INFO] [stderr]    |         ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `BOARD_SIZE`
[INFO] [stderr]  --> src/objects/ai.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use BOARD_SIZE;
[INFO] [stderr]   |     ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/winner_calc.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 | /             if x > 2 {
[INFO] [stderr] 18 | |                 if direction_taken(UP_RIGHT, &x, &y,  &positions) {
[INFO] [stderr] 19 | |                     return p.player;
[INFO] [stderr] 20 | |                 }
[INFO] [stderr] 21 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 17 |             if x > 2 && direction_taken(UP_RIGHT, &x, &y,  &positions) {
[INFO] [stderr] 18 |     return p.player;
[INFO] [stderr] 19 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/winner_calc.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 | /             if x < (BOARD_SIZE - 3)  {
[INFO] [stderr] 23 | |                 if direction_taken(UP_LEFT, &x, &y, &positions) {
[INFO] [stderr] 24 | |                     return p.player;
[INFO] [stderr] 25 | |                 }
[INFO] [stderr] 26 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 22 |             if x < (BOARD_SIZE - 3) && direction_taken(UP_LEFT, &x, &y, &positions) {
[INFO] [stderr] 23 |     return p.player;
[INFO] [stderr] 24 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/winner_calc.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 | /         if x < (BOARD_SIZE - 3) {
[INFO] [stderr] 29 | |             if direction_taken(RIGHT, &x, &y,  &positions) {
[INFO] [stderr] 30 | |                 return p.player;
[INFO] [stderr] 31 | |             } 
[INFO] [stderr] 32 | |         } 
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 28 |         if x < (BOARD_SIZE - 3) && direction_taken(RIGHT, &x, &y,  &positions) {
[INFO] [stderr] 29 |     return p.player;
[INFO] [stderr] 30 | } 
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/winner_calc.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 | /         if player > 0 {
[INFO] [stderr] 54 | |             if last.player == player {
[INFO] [stderr] 55 | |                 counter += 1;
[INFO] [stderr] 56 | |             }
[INFO] [stderr] 57 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 53 |         if player > 0 && last.player == player {
[INFO] [stderr] 54 |     counter += 1;
[INFO] [stderr] 55 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `BOARD_SIZE`
[INFO] [stderr]  --> src/objects/ai.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use BOARD_SIZE;
[INFO] [stderr]   |     ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/winner_calc.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 | /             if x > 2 {
[INFO] [stderr] 18 | |                 if direction_taken(UP_RIGHT, &x, &y,  &positions) {
[INFO] [stderr] 19 | |                     return p.player;
[INFO] [stderr] 20 | |                 }
[INFO] [stderr] 21 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 17 |             if x > 2 && direction_taken(UP_RIGHT, &x, &y,  &positions) {
[INFO] [stderr] 18 |     return p.player;
[INFO] [stderr] 19 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/winner_calc.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 | /             if x < (BOARD_SIZE - 3)  {
[INFO] [stderr] 23 | |                 if direction_taken(UP_LEFT, &x, &y, &positions) {
[INFO] [stderr] 24 | |                     return p.player;
[INFO] [stderr] 25 | |                 }
[INFO] [stderr] 26 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 22 |             if x < (BOARD_SIZE - 3) && direction_taken(UP_LEFT, &x, &y, &positions) {
[INFO] [stderr] 23 |     return p.player;
[INFO] [stderr] 24 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/winner_calc.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 | /         if x < (BOARD_SIZE - 3) {
[INFO] [stderr] 29 | |             if direction_taken(RIGHT, &x, &y,  &positions) {
[INFO] [stderr] 30 | |                 return p.player;
[INFO] [stderr] 31 | |             } 
[INFO] [stderr] 32 | |         } 
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 28 |         if x < (BOARD_SIZE - 3) && direction_taken(RIGHT, &x, &y,  &positions) {
[INFO] [stderr] 29 |     return p.player;
[INFO] [stderr] 30 | } 
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/winner_calc.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 | /         if player > 0 {
[INFO] [stderr] 54 | |             if last.player == player {
[INFO] [stderr] 55 | |                 counter += 1;
[INFO] [stderr] 56 | |             }
[INFO] [stderr] 57 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 53 |         if player > 0 && last.player == player {
[INFO] [stderr] 54 |     counter += 1;
[INFO] [stderr] 55 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `direction`
[INFO] [stderr]   --> src/objects/ai.rs:19:17
[INFO] [stderr]    |
[INFO] [stderr] 19 |             let direction = self.get_possible_directions(positions);
[INFO] [stderr]    |                 ^^^^^^^^^ help: consider using `_direction` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/objects/ai.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |         let mut possible = Vec::<[(i64, i64); 4]>::new();
[INFO] [stderr]    |             ----^^^^^^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/draw_board.rs:4:30
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn draw_board(positions: &Vec<Position>) {
[INFO] [stderr]   |                              ^^^^^^^^^^^^^^ help: change this to: `&[Position]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/objects/position.rs:9:19
[INFO] [stderr]   |
[INFO] [stderr] 9 |     pub fn new(x: &i64, y: &i64, player: &i64) -> Self {
[INFO] [stderr]   |                   ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/objects/position.rs:9:28
[INFO] [stderr]   |
[INFO] [stderr] 9 |     pub fn new(x: &i64, y: &i64, player: &i64) -> Self {
[INFO] [stderr]   |                            ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/objects/position.rs:9:42
[INFO] [stderr]   |
[INFO] [stderr] 9 |     pub fn new(x: &i64, y: &i64, player: &i64) -> Self {
[INFO] [stderr]   |                                          ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/objects/ai.rs:15:39
[INFO] [stderr]    |
[INFO] [stderr] 15 |     pub fn get_move(&self, positions: &Vec<Position>) -> i64 {
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^ help: change this to: `&[Position]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/objects/ai.rs:30:50
[INFO] [stderr]    |
[INFO] [stderr] 30 |     fn get_possible_directions(&self, positions: &Vec<Position>) -> Vec<[(i64, i64); 4]> {
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^ help: change this to: `&[Position]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/winner_calc.rs:9:36
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn calculate_winner(positions: &Vec<Position>) -> i64 {
[INFO] [stderr]   |                                    ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn calculate_winner(positions: &[Position]) -> i64 {
[INFO] [stderr]   |                                    ^^^^^^^^^^^
[INFO] [stderr] help: change `positions.clone()` to
[INFO] [stderr]   |
[INFO] [stderr] 10|     for p in positions.to_owned() {
[INFO] [stderr]   |              ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/winner_calc.rs:10:14
[INFO] [stderr]    |
[INFO] [stderr] 10 |     for p in positions.clone() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 10 |     for p in &(*positions).clone() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 10 |     for p in &std::vec::Vec<objects::position::Position>::clone(positions) {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/winner_calc.rs:37:45
[INFO] [stderr]    |
[INFO] [stderr] 37 | pub fn get_pos(x: &i64, y: &i64, positions: &Vec<Position>) -> i64 {
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^ help: change this to: `&[Position]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/winner_calc.rs:37:19
[INFO] [stderr]    |
[INFO] [stderr] 37 | pub fn get_pos(x: &i64, y: &i64, positions: &Vec<Position>) -> i64 {
[INFO] [stderr]    |                   ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/winner_calc.rs:37:28
[INFO] [stderr]    |
[INFO] [stderr] 37 | pub fn get_pos(x: &i64, y: &i64, positions: &Vec<Position>) -> i64 {
[INFO] [stderr]    |                            ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/winner_calc.rs:46:77
[INFO] [stderr]    |
[INFO] [stderr] 46 | fn direction_taken(direction: [(i64, i64); 4], x: &i64, y: &i64, positions: &Vec<Position>) -> bool {
[INFO] [stderr]    |                                                                             ^^^^^^^^^^^^^^ help: change this to: `&[Position]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/winner_calc.rs:46:51
[INFO] [stderr]    |
[INFO] [stderr] 46 | fn direction_taken(direction: [(i64, i64); 4], x: &i64, y: &i64, positions: &Vec<Position>) -> bool {
[INFO] [stderr]    |                                                   ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/winner_calc.rs:46:60
[INFO] [stderr]    |
[INFO] [stderr] 46 | fn direction_taken(direction: [(i64, i64); 4], x: &i64, y: &i64, positions: &Vec<Position>) -> bool {
[INFO] [stderr]    |                                                            ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `direction`
[INFO] [stderr]   --> src/objects/ai.rs:19:17
[INFO] [stderr]    |
[INFO] [stderr] 19 |             let direction = self.get_possible_directions(positions);
[INFO] [stderr]    |                 ^^^^^^^^^ help: consider using `_direction` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:22:34
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let ai_enabled =enable_ai == "y".to_string();
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^ help: try: `"y"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:81:30
[INFO] [stderr]    |
[INFO] [stderr] 81 | fn get_y(x: &i64, positions: &Vec<Position>) -> i64 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^ help: change this to: `&[Position]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:81:13
[INFO] [stderr]    |
[INFO] [stderr] 81 | fn get_y(x: &i64, positions: &Vec<Position>) -> i64 {
[INFO] [stderr]    |             ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/objects/ai.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |         let mut possible = Vec::<[(i64, i64); 4]>::new();
[INFO] [stderr]    |             ----^^^^^^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/draw_board.rs:4:30
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn draw_board(positions: &Vec<Position>) {
[INFO] [stderr]   |                              ^^^^^^^^^^^^^^ help: change this to: `&[Position]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `four_in_a_row`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/objects/position.rs:9:19
[INFO] [stderr]   |
[INFO] [stderr] 9 |     pub fn new(x: &i64, y: &i64, player: &i64) -> Self {
[INFO] [stderr]   |                   ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/objects/position.rs:9:28
[INFO] [stderr]   |
[INFO] [stderr] 9 |     pub fn new(x: &i64, y: &i64, player: &i64) -> Self {
[INFO] [stderr]   |                            ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/objects/position.rs:9:42
[INFO] [stderr]   |
[INFO] [stderr] 9 |     pub fn new(x: &i64, y: &i64, player: &i64) -> Self {
[INFO] [stderr]   |                                          ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/objects/ai.rs:15:39
[INFO] [stderr]    |
[INFO] [stderr] 15 |     pub fn get_move(&self, positions: &Vec<Position>) -> i64 {
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^ help: change this to: `&[Position]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/objects/ai.rs:30:50
[INFO] [stderr]    |
[INFO] [stderr] 30 |     fn get_possible_directions(&self, positions: &Vec<Position>) -> Vec<[(i64, i64); 4]> {
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^ help: change this to: `&[Position]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/winner_calc.rs:9:36
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn calculate_winner(positions: &Vec<Position>) -> i64 {
[INFO] [stderr]   |                                    ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn calculate_winner(positions: &[Position]) -> i64 {
[INFO] [stderr]   |                                    ^^^^^^^^^^^
[INFO] [stderr] help: change `positions.clone()` to
[INFO] [stderr]   |
[INFO] [stderr] 10|     for p in positions.to_owned() {
[INFO] [stderr]   |              ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/winner_calc.rs:10:14
[INFO] [stderr]    |
[INFO] [stderr] 10 |     for p in positions.clone() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 10 |     for p in &(*positions).clone() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 10 |     for p in &std::vec::Vec<objects::position::Position>::clone(positions) {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/winner_calc.rs:37:45
[INFO] [stderr]    |
[INFO] [stderr] 37 | pub fn get_pos(x: &i64, y: &i64, positions: &Vec<Position>) -> i64 {
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^ help: change this to: `&[Position]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/winner_calc.rs:37:19
[INFO] [stderr]    |
[INFO] [stderr] 37 | pub fn get_pos(x: &i64, y: &i64, positions: &Vec<Position>) -> i64 {
[INFO] [stderr]    |                   ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/winner_calc.rs:37:28
[INFO] [stderr]    |
[INFO] [stderr] 37 | pub fn get_pos(x: &i64, y: &i64, positions: &Vec<Position>) -> i64 {
[INFO] [stderr]    |                            ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/winner_calc.rs:46:77
[INFO] [stderr]    |
[INFO] [stderr] 46 | fn direction_taken(direction: [(i64, i64); 4], x: &i64, y: &i64, positions: &Vec<Position>) -> bool {
[INFO] [stderr]    |                                                                             ^^^^^^^^^^^^^^ help: change this to: `&[Position]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/winner_calc.rs:46:51
[INFO] [stderr]    |
[INFO] [stderr] 46 | fn direction_taken(direction: [(i64, i64); 4], x: &i64, y: &i64, positions: &Vec<Position>) -> bool {
[INFO] [stderr]    |                                                   ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/winner_calc.rs:46:60
[INFO] [stderr]    |
[INFO] [stderr] 46 | fn direction_taken(direction: [(i64, i64); 4], x: &i64, y: &i64, positions: &Vec<Position>) -> bool {
[INFO] [stderr]    |                                                            ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:22:34
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let ai_enabled =enable_ai == "y".to_string();
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^ help: try: `"y"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:81:30
[INFO] [stderr]    |
[INFO] [stderr] 81 | fn get_y(x: &i64, positions: &Vec<Position>) -> i64 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^ help: change this to: `&[Position]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:81:13
[INFO] [stderr]    |
[INFO] [stderr] 81 | fn get_y(x: &i64, positions: &Vec<Position>) -> i64 {
[INFO] [stderr]    |             ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `four_in_a_row`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "e860776d1ddd7e34b33f352d747128744aed4103caeac99d708980e39d6629e6"`
[INFO] running `"docker" "rm" "-f" "e860776d1ddd7e34b33f352d747128744aed4103caeac99d708980e39d6629e6"`
[INFO] [stdout] e860776d1ddd7e34b33f352d747128744aed4103caeac99d708980e39d6629e6