[INFO] updating cached repository CasperN/mpcs_cache_emulator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CasperN/mpcs_cache_emulator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CasperN/mpcs_cache_emulator" "work/ex/clippy-test-run/sources/stable/gh/CasperN/mpcs_cache_emulator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CasperN/mpcs_cache_emulator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/CasperN/mpcs_cache_emulator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CasperN/mpcs_cache_emulator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CasperN/mpcs_cache_emulator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eed1c82f4dd80db0e7cd186e6e52c341784057c9 [INFO] sha for GitHub repo CasperN/mpcs_cache_emulator: eed1c82f4dd80db0e7cd186e6e52c341784057c9 [INFO] validating manifest of CasperN/mpcs_cache_emulator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CasperN/mpcs_cache_emulator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CasperN/mpcs_cache_emulator [INFO] finished frobbing CasperN/mpcs_cache_emulator [INFO] frobbed toml for CasperN/mpcs_cache_emulator written to work/ex/clippy-test-run/sources/stable/gh/CasperN/mpcs_cache_emulator/Cargo.toml [INFO] started frobbing CasperN/mpcs_cache_emulator [INFO] finished frobbing CasperN/mpcs_cache_emulator [INFO] frobbed toml for CasperN/mpcs_cache_emulator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CasperN/mpcs_cache_emulator/Cargo.toml [INFO] crate CasperN/mpcs_cache_emulator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CasperN/mpcs_cache_emulator against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CasperN/mpcs_cache_emulator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1dcfedb8c651508ae4c069d09a2560cff2589d9d6d18cdebdfb7dc965ab93f48 [INFO] running `"docker" "start" "-a" "1dcfedb8c651508ae4c069d09a2560cff2589d9d6d18cdebdfb7dc965ab93f48"` [INFO] [stderr] Checking termcolor v0.3.3 [INFO] [stderr] Checking clap v2.29.2 [INFO] [stderr] Checking env_logger v0.5.3 [INFO] [stderr] Checking pretty_env_logger v0.2.0 [INFO] [stderr] Checking cache_emulator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cpu.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | random_line [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cpu.rs:129:27 [INFO] [stderr] | [INFO] [stderr] 129 | let random_line = index * self.associativity + r; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cpu.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | random_line [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cpu.rs:129:27 [INFO] [stderr] | [INFO] [stderr] 129 | let random_line = index * self.associativity + r; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithms.rs:91:61 [INFO] [stderr] | [INFO] [stderr] 91 | assert!((cpu.load(i) - (i - 16) as f64 * 4.0).abs() < 0.0000001, cpu.load(i)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.000_000_1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithms.rs:104:38 [INFO] [stderr] | [INFO] [stderr] 104 | assert!((cpu.load(i) - 48.0) < 0.0000001, cpu.load(i)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithms.rs:117:38 [INFO] [stderr] | [INFO] [stderr] 117 | assert!((cpu.load(i) - 48.0) < 0.0000001, cpu.load(i)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/cpu.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | data: Box> [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/cpu.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | pub ram: Box>, // Public to initialize random f64s [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/cpu.rs:42:10 [INFO] [stderr] | [INFO] [stderr] 42 | cache: Box> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/cpu.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | data: Box> [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/cpu.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | pub ram: Box>, // Public to initialize random f64s [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/cpu.rs:42:10 [INFO] [stderr] | [INFO] [stderr] 42 | cache: Box> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cpu.rs:257:7 [INFO] [stderr] | [INFO] [stderr] 257 | assert_eq!(cpu.load(i), i as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cpu.rs:257:7 [INFO] [stderr] | [INFO] [stderr] 257 | assert_eq!(cpu.load(i), i as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cache_emulator`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1dcfedb8c651508ae4c069d09a2560cff2589d9d6d18cdebdfb7dc965ab93f48"` [INFO] running `"docker" "rm" "-f" "1dcfedb8c651508ae4c069d09a2560cff2589d9d6d18cdebdfb7dc965ab93f48"` [INFO] [stdout] 1dcfedb8c651508ae4c069d09a2560cff2589d9d6d18cdebdfb7dc965ab93f48