[INFO] updating cached repository CarloMicieli/rust_tutorial [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CarloMicieli/rust_tutorial [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CarloMicieli/rust_tutorial" "work/ex/clippy-test-run/sources/stable/gh/CarloMicieli/rust_tutorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CarloMicieli/rust_tutorial'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/CarloMicieli/rust_tutorial" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CarloMicieli/rust_tutorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CarloMicieli/rust_tutorial'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 40e53e04214f9147c7e45942a4cb2c041f235287 [INFO] sha for GitHub repo CarloMicieli/rust_tutorial: 40e53e04214f9147c7e45942a4cb2c041f235287 [INFO] validating manifest of CarloMicieli/rust_tutorial on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CarloMicieli/rust_tutorial on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CarloMicieli/rust_tutorial [INFO] finished frobbing CarloMicieli/rust_tutorial [INFO] frobbed toml for CarloMicieli/rust_tutorial written to work/ex/clippy-test-run/sources/stable/gh/CarloMicieli/rust_tutorial/Cargo.toml [INFO] started frobbing CarloMicieli/rust_tutorial [INFO] finished frobbing CarloMicieli/rust_tutorial [INFO] frobbed toml for CarloMicieli/rust_tutorial written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CarloMicieli/rust_tutorial/Cargo.toml [INFO] crate CarloMicieli/rust_tutorial has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CarloMicieli/rust_tutorial against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CarloMicieli/rust_tutorial:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c663ec6bce10eb3641f647ff37f5cd529f8080e4187239be5b533abe069322c4 [INFO] running `"docker" "start" "-a" "c663ec6bce10eb3641f647ff37f5cd529f8080e4187239be5b533abe069322c4"` [INFO] [stderr] Checking rust_tutorial v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/control_flow/ifs.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | val [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/control_flow/ifs.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | let val = if x > 0 { "positive" } else { "negative" }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/custom_types/expressions.rs:14:35 [INFO] [stderr] | [INFO] [stderr] 14 | Exp::Variable { name, exp: _ } => write!(f, "{}", name), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Variable { name, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/custom_types/expressions.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | Exp::Variable { name: _, exp: e } => Exp::eval(&e), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Variable { exp: e, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/functions/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod functions; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/collections/arrays.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/collections/vectors.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/control_flow/ifs.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | val [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/control_flow/ifs.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | let val = if x > 0 { "positive" } else { "negative" }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/custom_types/expressions.rs:14:35 [INFO] [stderr] | [INFO] [stderr] 14 | Exp::Variable { name, exp: _ } => write!(f, "{}", name), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Variable { name, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/custom_types/expressions.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | Exp::Variable { name: _, exp: e } => Exp::eval(&e), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Variable { exp: e, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/functions/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod functions; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: function is never used: `thruth` [INFO] [stderr] --> src/control_flow/ifs.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn thruth(x: i32) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `if_as_expression` [INFO] [stderr] --> src/control_flow/ifs.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn if_as_expression(x: i32) -> &'static str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sum` [INFO] [stderr] --> src/control_flow/loops.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub fn sum(from: i32, to: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sum2` [INFO] [stderr] --> src/control_flow/loops.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn sum2(from: i32, to: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sum3` [INFO] [stderr] --> src/control_flow/loops.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn sum3(from: i32, to: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Val` [INFO] [stderr] --> src/custom_types/expressions.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | Val { n: i32 }, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Variable` [INFO] [stderr] --> src/custom_types/expressions.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Variable { name: String, exp: Box }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Sum` [INFO] [stderr] --> src/custom_types/expressions.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | Sum { lhs: Box, rhs: Box }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `constant` [INFO] [stderr] --> src/custom_types/expressions.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn constant(val: i32) -> Exp { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `variable` [INFO] [stderr] --> src/custom_types/expressions.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn variable(name: &str, exp: Exp) -> Exp { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sum` [INFO] [stderr] --> src/custom_types/expressions.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn sum(lhs: Exp, rhs: Exp) -> Exp { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `eval` [INFO] [stderr] --> src/custom_types/expressions.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn eval(exp: &Exp) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `numerator` [INFO] [stderr] --> src/custom_types/rational.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn numerator(&self) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `denominator` [INFO] [stderr] --> src/custom_types/rational.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn denominator(&self) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from` [INFO] [stderr] --> src/custom_types/rational.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn from(num: i32) -> Rational { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sum` [INFO] [stderr] --> src/functions/functions.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | fn sum(a: i32, b: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DividedByZero` [INFO] [stderr] --> src/functions/functions.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | DividedByZero, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `div` [INFO] [stderr] --> src/functions/functions.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | fn div(a: i32, b: i32) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `fib` [INFO] [stderr] --> src/functions/functions.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn fib(n: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `max` [INFO] [stderr] --> src/functions/functions.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / fn max(a: T, b: T) -> T [INFO] [stderr] 29 | | where [INFO] [stderr] 30 | | T: PartialOrd, [INFO] [stderr] 31 | | { [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `hello` [INFO] [stderr] --> src/primitive_types/strings.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | fn hello(name: &str) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/control_flow/ifs.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | / if x == 42 { [INFO] [stderr] 3 | | true [INFO] [stderr] 4 | | } else { [INFO] [stderr] 5 | | false [INFO] [stderr] 6 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `x == 42` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/custom_types/rational.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn numerator(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/custom_types/rational.rs:30:24 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn denominator(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/custom_types/rational.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn is_positive(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/custom_types/rational.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn is_negative(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the `d:` in this pattern is redundant [INFO] [stderr] --> src/custom_types/rational.rs:80:30 [INFO] [stderr] | [INFO] [stderr] 80 | let Rational { n: c, d: d } = other; [INFO] [stderr] | --^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_shorthand_field_patterns)] on by default [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/custom_types/rational.rs:103:49 [INFO] [stderr] | [INFO] [stderr] 103 | Rational::new((n1 * d2) - (d1 * n2), d1 * d2) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/custom_types/rational.rs:125:26 [INFO] [stderr] | [INFO] [stderr] 125 | Rational::new(n1 * d2, n2 * d1) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/custom_types/rational.rs:125:35 [INFO] [stderr] | [INFO] [stderr] 125 | Rational::new(n1 * d2, n2 * d1) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/custom_types/rational.rs:145:49 [INFO] [stderr] | [INFO] [stderr] 145 | Rational::new((n1 * d2) + (d1 * n2), d1 * d2) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_tutorial`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/control_flow/ifs.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | / if x == 42 { [INFO] [stderr] 3 | | true [INFO] [stderr] 4 | | } else { [INFO] [stderr] 5 | | false [INFO] [stderr] 6 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `x == 42` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/custom_types/rational.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn numerator(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/custom_types/rational.rs:30:24 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn denominator(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/custom_types/rational.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn is_positive(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/custom_types/rational.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn is_negative(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the `d:` in this pattern is redundant [INFO] [stderr] --> src/custom_types/rational.rs:80:30 [INFO] [stderr] | [INFO] [stderr] 80 | let Rational { n: c, d: d } = other; [INFO] [stderr] | --^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_shorthand_field_patterns)] on by default [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/custom_types/rational.rs:103:49 [INFO] [stderr] | [INFO] [stderr] 103 | Rational::new((n1 * d2) - (d1 * n2), d1 * d2) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/custom_types/rational.rs:125:26 [INFO] [stderr] | [INFO] [stderr] 125 | Rational::new(n1 * d2, n2 * d1) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/custom_types/rational.rs:125:35 [INFO] [stderr] | [INFO] [stderr] 125 | Rational::new(n1 * d2, n2 * d1) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/custom_types/rational.rs:145:49 [INFO] [stderr] | [INFO] [stderr] 145 | Rational::new((n1 * d2) + (d1 * n2), d1 * d2) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/custom_types/rational.rs:246:17 [INFO] [stderr] | [INFO] [stderr] 246 | assert!(r.is_negative() == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!r.is_negative()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/custom_types/rational.rs:303:17 [INFO] [stderr] | [INFO] [stderr] 303 | assert!(one_half == one_half); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/functions/functions.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | assert_eq!(m, 42.45f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/functions/functions.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | assert_eq!(m, 42.45f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_tutorial`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c663ec6bce10eb3641f647ff37f5cd529f8080e4187239be5b533abe069322c4"` [INFO] running `"docker" "rm" "-f" "c663ec6bce10eb3641f647ff37f5cd529f8080e4187239be5b533abe069322c4"` [INFO] [stdout] c663ec6bce10eb3641f647ff37f5cd529f8080e4187239be5b533abe069322c4