[INFO] updating cached repository CJStadler/rust_hzip [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CJStadler/rust_hzip [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CJStadler/rust_hzip" "work/ex/clippy-test-run/sources/stable/gh/CJStadler/rust_hzip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CJStadler/rust_hzip'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/CJStadler/rust_hzip" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CJStadler/rust_hzip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CJStadler/rust_hzip'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c13657ee8dfd38a46cc04ab47d7b4a58e5b23b11 [INFO] sha for GitHub repo CJStadler/rust_hzip: c13657ee8dfd38a46cc04ab47d7b4a58e5b23b11 [INFO] validating manifest of CJStadler/rust_hzip on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CJStadler/rust_hzip on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CJStadler/rust_hzip [INFO] finished frobbing CJStadler/rust_hzip [INFO] frobbed toml for CJStadler/rust_hzip written to work/ex/clippy-test-run/sources/stable/gh/CJStadler/rust_hzip/Cargo.toml [INFO] started frobbing CJStadler/rust_hzip [INFO] finished frobbing CJStadler/rust_hzip [INFO] frobbed toml for CJStadler/rust_hzip written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CJStadler/rust_hzip/Cargo.toml [INFO] crate CJStadler/rust_hzip has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CJStadler/rust_hzip against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CJStadler/rust_hzip:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9626afc5880fb5e1ccd2e0a4066d43d0e84239175d9c3d41e96b84e39da592b5 [INFO] running `"docker" "start" "-a" "9626afc5880fb5e1ccd2e0a4066d43d0e84239175d9c3d41e96b84e39da592b5"` [INFO] [stderr] Checking rust_hzip v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_tree.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | CodeTree { root: root } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_tree.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | CodeTree { root: root } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `bit_vec::BitVec` [INFO] [stderr] --> src/decoder.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use bit_vec::BitVec; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `code_map::CodeMap` [INFO] [stderr] --> src/decoder.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use code_map::CodeMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `code_tree::CodeTree` [INFO] [stderr] --> src/decoder.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use code_tree::CodeTree; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `bit_vec::BitVec` [INFO] [stderr] --> src/decoder.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use bit_vec::BitVec; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `code_map::CodeMap` [INFO] [stderr] --> src/decoder.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use code_map::CodeMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `code_tree::CodeTree` [INFO] [stderr] --> src/decoder.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use code_tree::CodeTree; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bits_in_last_byte` [INFO] [stderr] --> src/decoder.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | let bits_in_last_byte = encoded_bytes.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using `_bits_in_last_byte` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `code_tree_length` [INFO] [stderr] --> src/decoder.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | let mut code_tree_length = LittleEndian::read_u16(encoded_bytes.get(0..2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_code_tree_length` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/decoder.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | let mut code_tree_length = LittleEndian::read_u16(encoded_bytes.get(0..2).unwrap()); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `write_bits_to_file` [INFO] [stderr] --> src/write_file.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn write_bits_to_file(filename: &str, contents: &BitVec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bits_in_last_byte` [INFO] [stderr] --> src/decoder.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | let bits_in_last_byte = encoded_bytes.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using `_bits_in_last_byte` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `code_tree_length` [INFO] [stderr] --> src/decoder.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | let mut code_tree_length = LittleEndian::read_u16(encoded_bytes.get(0..2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_code_tree_length` instead [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/code_map.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn get(&self, k: &u8) -> Option<&BitVec> { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/decoder.rs:7:29 [INFO] [stderr] | [INFO] [stderr] 7 | let bits_in_last_byte = encoded_bytes.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&encoded_bytes[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/decoder.rs:8:55 [INFO] [stderr] | [INFO] [stderr] 8 | let mut code_tree_length = LittleEndian::read_u16(encoded_bytes.get(0..2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `encoded_bytes[0..2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/decoder.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | let mut code_tree_length = LittleEndian::read_u16(encoded_bytes.get(0..2).unwrap()); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `write_bits_to_file` [INFO] [stderr] --> src/write_file.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn write_bits_to_file(filename: &str, contents: &BitVec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/code_map.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn get(&self, k: &u8) -> Option<&BitVec> { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/decoder.rs:7:29 [INFO] [stderr] | [INFO] [stderr] 7 | let bits_in_last_byte = encoded_bytes.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&encoded_bytes[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/decoder.rs:8:55 [INFO] [stderr] | [INFO] [stderr] 8 | let mut code_tree_length = LittleEndian::read_u16(encoded_bytes.get(0..2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `encoded_bytes[0..2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.97s [INFO] running `"docker" "inspect" "9626afc5880fb5e1ccd2e0a4066d43d0e84239175d9c3d41e96b84e39da592b5"` [INFO] running `"docker" "rm" "-f" "9626afc5880fb5e1ccd2e0a4066d43d0e84239175d9c3d41e96b84e39da592b5"` [INFO] [stdout] 9626afc5880fb5e1ccd2e0a4066d43d0e84239175d9c3d41e96b84e39da592b5