[INFO] updating cached repository BurNiinTRee/ticktacktoe [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BurNiinTRee/ticktacktoe [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BurNiinTRee/ticktacktoe" "work/ex/clippy-test-run/sources/stable/gh/BurNiinTRee/ticktacktoe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BurNiinTRee/ticktacktoe'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BurNiinTRee/ticktacktoe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BurNiinTRee/ticktacktoe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BurNiinTRee/ticktacktoe'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a48702b764f521765997dc2265d47c46f1aad0b6 [INFO] sha for GitHub repo BurNiinTRee/ticktacktoe: a48702b764f521765997dc2265d47c46f1aad0b6 [INFO] validating manifest of BurNiinTRee/ticktacktoe on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BurNiinTRee/ticktacktoe on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BurNiinTRee/ticktacktoe [INFO] finished frobbing BurNiinTRee/ticktacktoe [INFO] frobbed toml for BurNiinTRee/ticktacktoe written to work/ex/clippy-test-run/sources/stable/gh/BurNiinTRee/ticktacktoe/Cargo.toml [INFO] started frobbing BurNiinTRee/ticktacktoe [INFO] finished frobbing BurNiinTRee/ticktacktoe [INFO] frobbed toml for BurNiinTRee/ticktacktoe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BurNiinTRee/ticktacktoe/Cargo.toml [INFO] crate BurNiinTRee/ticktacktoe has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BurNiinTRee/ticktacktoe against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BurNiinTRee/ticktacktoe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 516365d8ba9973bb9b6fde99fa38cf6d48921169afa9d3de7f611264d7a8680a [INFO] running `"docker" "start" "-a" "516365d8ba9973bb9b6fde99fa38cf6d48921169afa9d3de7f611264d7a8680a"` [INFO] [stderr] Checking ticktacktoe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ttt.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return self.read_input(player); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.read_input(player)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ttt.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return Field::Empty; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Field::Empty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ttt.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return self.read_input(player); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.read_input(player)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ttt.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return Field::Empty; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Field::Empty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Cross` [INFO] [stderr] --> src/tests.rs:4:37 [INFO] [stderr] | [INFO] [stderr] 4 | use super::ttt::Field::{Circle, Cross, Empty}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/ttt.rs:75:31 [INFO] [stderr] | [INFO] [stderr] 75 | for player in players.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/ttt.rs:76:32 [INFO] [stderr] | [INFO] [stderr] 76 | for win in WINNERS.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/ttt.rs:77:34 [INFO] [stderr] | [INFO] [stderr] 77 | for field in win.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ttt.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | / match self.board[*field as usize] == *player { [INFO] [stderr] 79 | | true => { [INFO] [stderr] 80 | | winner += 1; [INFO] [stderr] 81 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 78 | if self.board[*field as usize] == *player { [INFO] [stderr] 79 | winner += 1; [INFO] [stderr] 80 | continue; [INFO] [stderr] 81 | } else { [INFO] [stderr] 82 | winner = 0; [INFO] [stderr] 83 | break; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ticktacktoe`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/ttt.rs:75:31 [INFO] [stderr] | [INFO] [stderr] 75 | for player in players.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/ttt.rs:76:32 [INFO] [stderr] | [INFO] [stderr] 76 | for win in WINNERS.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/ttt.rs:77:34 [INFO] [stderr] | [INFO] [stderr] 77 | for field in win.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ttt.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | / match self.board[*field as usize] == *player { [INFO] [stderr] 79 | | true => { [INFO] [stderr] 80 | | winner += 1; [INFO] [stderr] 81 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 78 | if self.board[*field as usize] == *player { [INFO] [stderr] 79 | winner += 1; [INFO] [stderr] 80 | continue; [INFO] [stderr] 81 | } else { [INFO] [stderr] 82 | winner = 0; [INFO] [stderr] 83 | break; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: function `Ttt_is_won` should have a snake case name such as `ttt_is_won` [INFO] [stderr] --> src/tests.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | / fn Ttt_is_won() { [INFO] [stderr] 4 | | use super::ttt::Field::{Circle, Cross, Empty}; [INFO] [stderr] 5 | | use super::ttt::Ttt; [INFO] [stderr] 6 | | let mut game = Ttt::new(); [INFO] [stderr] 7 | | game.board = [Circle, Circle, Circle, Empty, Empty, Empty, Empty, Empty, Empty]; [INFO] [stderr] 8 | | assert_eq!(game.is_won(), Circle); [INFO] [stderr] 9 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ticktacktoe`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "516365d8ba9973bb9b6fde99fa38cf6d48921169afa9d3de7f611264d7a8680a"` [INFO] running `"docker" "rm" "-f" "516365d8ba9973bb9b6fde99fa38cf6d48921169afa9d3de7f611264d7a8680a"` [INFO] [stdout] 516365d8ba9973bb9b6fde99fa38cf6d48921169afa9d3de7f611264d7a8680a