[INFO] updating cached repository BlueTeleco/i3themes
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/BlueTeleco/i3themes
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/BlueTeleco/i3themes" "work/ex/clippy-test-run/sources/stable/gh/BlueTeleco/i3themes"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BlueTeleco/i3themes'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/BlueTeleco/i3themes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BlueTeleco/i3themes"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BlueTeleco/i3themes'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6b3eb8562ef2a6efd3243c03451e22084afe47e9
[INFO] sha for GitHub repo BlueTeleco/i3themes: 6b3eb8562ef2a6efd3243c03451e22084afe47e9
[INFO] validating manifest of BlueTeleco/i3themes on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of BlueTeleco/i3themes on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing BlueTeleco/i3themes
[INFO] finished frobbing BlueTeleco/i3themes
[INFO] frobbed toml for BlueTeleco/i3themes written to work/ex/clippy-test-run/sources/stable/gh/BlueTeleco/i3themes/Cargo.toml
[INFO] started frobbing BlueTeleco/i3themes
[INFO] finished frobbing BlueTeleco/i3themes
[INFO] frobbed toml for BlueTeleco/i3themes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BlueTeleco/i3themes/Cargo.toml
[INFO] crate BlueTeleco/i3themes has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting BlueTeleco/i3themes against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BlueTeleco/i3themes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 950d4f8c9fd8a170023c2c0b30a287d12cab32751c545375ed0d6a57be9f4ea6
[INFO] running `"docker" "start" "-a" "950d4f8c9fd8a170023c2c0b30a287d12cab32751c545375ed0d6a57be9f4ea6"`
[INFO] [stderr]     Checking i3themes v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/lib.rs:35:27
[INFO] [stderr]    |
[INFO] [stderr] 35 |     println!("{} \n\n{}", "Usage:", opts.usage("i3themes <theme> [options]"));
[INFO] [stderr]    |                           ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/lib.rs:35:27
[INFO] [stderr]    |
[INFO] [stderr] 35 |     println!("{} \n\n{}", "Usage:", opts.usage("i3themes <theme> [options]"));
[INFO] [stderr]    |                           ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/yaml.rs:31:45
[INFO] [stderr]    |
[INFO] [stderr] 31 |         let color = wstate_colors(theme, e).unwrap_or("".to_string());
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/yaml.rs:45:45
[INFO] [stderr]    |
[INFO] [stderr] 45 |         let color = bstate_colors(theme, e).unwrap_or("".to_string());
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/config_file.rs:39:29
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 .filter(|l| l.len() < 6 || !(&l[0..6] == "client"))
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `l.len() < 6 || &l[0..6] != "client"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]   --> src/config_file.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |     let mut bar = false;
[INFO] [stderr]    |             ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/config_file.rs:52:16
[INFO] [stderr]    |
[INFO] [stderr] 52 |             if l.len() > 0 && &l[0..1] == "}" {
[INFO] [stderr]    |                ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!l.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/config_file.rs:53:28
[INFO] [stderr]    |
[INFO] [stderr] 53 |                 let line = format!("{}", block);
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `block.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]   --> src/config_file.rs:67:19
[INFO] [stderr]    |
[INFO] [stderr] 67 | fn replace_colors(bar: String, colors: &str) -> String {
[INFO] [stderr]    |                   ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:63:22
[INFO] [stderr]    |
[INFO] [stderr] 63 |                     .unwrap_or("Description not found".to_string());
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Description not found".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/yaml.rs:31:45
[INFO] [stderr]    |
[INFO] [stderr] 31 |         let color = wstate_colors(theme, e).unwrap_or("".to_string());
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/yaml.rs:45:45
[INFO] [stderr]    |
[INFO] [stderr] 45 |         let color = bstate_colors(theme, e).unwrap_or("".to_string());
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/config_file.rs:39:29
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 .filter(|l| l.len() < 6 || !(&l[0..6] == "client"))
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `l.len() < 6 || &l[0..6] != "client"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]   --> src/config_file.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |     let mut bar = false;
[INFO] [stderr]    |             ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/config_file.rs:52:16
[INFO] [stderr]    |
[INFO] [stderr] 52 |             if l.len() > 0 && &l[0..1] == "}" {
[INFO] [stderr]    |                ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!l.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/config_file.rs:53:28
[INFO] [stderr]    |
[INFO] [stderr] 53 |                 let line = format!("{}", block);
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `block.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]   --> src/config_file.rs:67:19
[INFO] [stderr]    |
[INFO] [stderr] 67 | fn replace_colors(bar: String, colors: &str) -> String {
[INFO] [stderr]    |                   ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:63:22
[INFO] [stderr]    |
[INFO] [stderr] 63 |                     .unwrap_or("Description not found".to_string());
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Description not found".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.39s
[INFO] running `"docker" "inspect" "950d4f8c9fd8a170023c2c0b30a287d12cab32751c545375ed0d6a57be9f4ea6"`
[INFO] running `"docker" "rm" "-f" "950d4f8c9fd8a170023c2c0b30a287d12cab32751c545375ed0d6a57be9f4ea6"`
[INFO] [stdout] 950d4f8c9fd8a170023c2c0b30a287d12cab32751c545375ed0d6a57be9f4ea6