[INFO] updating cached repository BlockCat/rust-cactpot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BlockCat/rust-cactpot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BlockCat/rust-cactpot" "work/ex/clippy-test-run/sources/stable/gh/BlockCat/rust-cactpot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BlockCat/rust-cactpot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BlockCat/rust-cactpot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BlockCat/rust-cactpot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BlockCat/rust-cactpot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 50fedb25c65956d47fab0b3d08e077c0ed228ef0 [INFO] sha for GitHub repo BlockCat/rust-cactpot: 50fedb25c65956d47fab0b3d08e077c0ed228ef0 [INFO] validating manifest of BlockCat/rust-cactpot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BlockCat/rust-cactpot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BlockCat/rust-cactpot [INFO] finished frobbing BlockCat/rust-cactpot [INFO] frobbed toml for BlockCat/rust-cactpot written to work/ex/clippy-test-run/sources/stable/gh/BlockCat/rust-cactpot/Cargo.toml [INFO] started frobbing BlockCat/rust-cactpot [INFO] finished frobbing BlockCat/rust-cactpot [INFO] frobbed toml for BlockCat/rust-cactpot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BlockCat/rust-cactpot/Cargo.toml [INFO] crate BlockCat/rust-cactpot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BlockCat/rust-cactpot against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BlockCat/rust-cactpot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7f47ce0db942985dc028ffd7e8c158e8241369aa9790dacb91802272a0dbce7f [INFO] running `"docker" "start" "-a" "7f47ce0db942985dc028ffd7e8c158e8241369aa9790dacb91802272a0dbce7f"` [INFO] [stderr] Checking rust-test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:182:4 [INFO] [stderr] | [INFO] [stderr] 182 | return calculate_expected_value(grid, payouts, [grid.grid[row as usize][0], grid.grid[row as usize][1], grid.grid[row as usize][2]]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `calculate_expected_value(grid, payouts, [grid.grid[row as usize][0], grid.grid[row as usize][1], grid.grid[row as usize][2]])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | return calculate_expected_value(grid, payouts, [grid.grid[0][column as usize], grid.grid[1][column as usize], grid.grid[2][column as usize]]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `calculate_expected_value(grid, payouts, [grid.grid[0][column as usize], grid.grid[1][column as usize], grid.grid[2][column as usize]])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | return max_size / size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `max_size / size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:182:4 [INFO] [stderr] | [INFO] [stderr] 182 | return calculate_expected_value(grid, payouts, [grid.grid[row as usize][0], grid.grid[row as usize][1], grid.grid[row as usize][2]]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `calculate_expected_value(grid, payouts, [grid.grid[row as usize][0], grid.grid[row as usize][1], grid.grid[row as usize][2]])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | return calculate_expected_value(grid, payouts, [grid.grid[0][column as usize], grid.grid[1][column as usize], grid.grid[2][column as usize]]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `calculate_expected_value(grid, payouts, [grid.grid[0][column as usize], grid.grid[1][column as usize], grid.grid[2][column as usize]])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | return max_size / size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `max_size / size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:126:60 [INFO] [stderr] | [INFO] [stderr] 126 | let a = self.grid[i][0].map(|s| s.to_string()).unwrap_or(String::from(" ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(" "))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:127:60 [INFO] [stderr] | [INFO] [stderr] 127 | let b = self.grid[i][1].map(|s| s.to_string()).unwrap_or(String::from(" ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(" "))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:128:60 [INFO] [stderr] | [INFO] [stderr] 128 | let c = self.grid[i][2].map(|s| s.to_string()).unwrap_or(String::from(" ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(" "))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:153:20 [INFO] [stderr] | [INFO] [stderr] 153 | if let None = grid.grid[i][j] { [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 154 | | let dif = &calculate_average_increase(&grid, payouts, (i as i32, j as i32)) - &original_score; [INFO] [stderr] 155 | | [INFO] [stderr] 156 | | println!("R ({}, {}): {:?}", i, j, dif.sum()); [INFO] [stderr] 157 | | [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________- help: try this: `if grid.grid[i][j].is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:216:44 [INFO] [stderr] | [INFO] [stderr] 216 | 3 => vec!(used.into_iter().map(|x| x as i32).sum()), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:126:60 [INFO] [stderr] | [INFO] [stderr] 126 | let a = self.grid[i][0].map(|s| s.to_string()).unwrap_or(String::from(" ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(" "))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:127:60 [INFO] [stderr] | [INFO] [stderr] 127 | let b = self.grid[i][1].map(|s| s.to_string()).unwrap_or(String::from(" ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(" "))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:128:60 [INFO] [stderr] | [INFO] [stderr] 128 | let c = self.grid[i][2].map(|s| s.to_string()).unwrap_or(String::from(" ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(" "))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:153:20 [INFO] [stderr] | [INFO] [stderr] 153 | if let None = grid.grid[i][j] { [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 154 | | let dif = &calculate_average_increase(&grid, payouts, (i as i32, j as i32)) - &original_score; [INFO] [stderr] 155 | | [INFO] [stderr] 156 | | println!("R ({}, {}): {:?}", i, j, dif.sum()); [INFO] [stderr] 157 | | [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________- help: try this: `if grid.grid[i][j].is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:216:44 [INFO] [stderr] | [INFO] [stderr] 216 | 3 => vec!(used.into_iter().map(|x| x as i32).sum()), [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.61s [INFO] running `"docker" "inspect" "7f47ce0db942985dc028ffd7e8c158e8241369aa9790dacb91802272a0dbce7f"` [INFO] running `"docker" "rm" "-f" "7f47ce0db942985dc028ffd7e8c158e8241369aa9790dacb91802272a0dbce7f"` [INFO] [stdout] 7f47ce0db942985dc028ffd7e8c158e8241369aa9790dacb91802272a0dbce7f