[INFO] updating cached repository Bkindmonk/RustPractice [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Bkindmonk/RustPractice [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Bkindmonk/RustPractice" "work/ex/clippy-test-run/sources/stable/gh/Bkindmonk/RustPractice"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Bkindmonk/RustPractice'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Bkindmonk/RustPractice" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Bkindmonk/RustPractice"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Bkindmonk/RustPractice'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dddc1c842ad316fb93f1f4a3a9741aea4ff490c9 [INFO] sha for GitHub repo Bkindmonk/RustPractice: dddc1c842ad316fb93f1f4a3a9741aea4ff490c9 [INFO] validating manifest of Bkindmonk/RustPractice on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Bkindmonk/RustPractice on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Bkindmonk/RustPractice [INFO] finished frobbing Bkindmonk/RustPractice [INFO] frobbed toml for Bkindmonk/RustPractice written to work/ex/clippy-test-run/sources/stable/gh/Bkindmonk/RustPractice/Cargo.toml [INFO] started frobbing Bkindmonk/RustPractice [INFO] finished frobbing Bkindmonk/RustPractice [INFO] frobbed toml for Bkindmonk/RustPractice written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Bkindmonk/RustPractice/Cargo.toml [INFO] crate Bkindmonk/RustPractice has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Bkindmonk/RustPractice against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Bkindmonk/RustPractice:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 79714a207c5d7149629c82e3c516431c26e086e41861df4b212121a21226eed7 [INFO] running `"docker" "start" "-a" "79714a207c5d7149629c82e3c516431c26e086e41861df4b212121a21226eed7"` [INFO] [stderr] Checking mergesort v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return output.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `output.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return output.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `output.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | let mut realhalves = (*real).split_at_mut(halflength); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | let mut scratchhalves = (*scratch).split_at_mut(halflength); [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | let mut realhalves = (*real).split_at_mut(halflength); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | let mut scratchhalves = (*scratch).split_at_mut(halflength); [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.95s [INFO] running `"docker" "inspect" "79714a207c5d7149629c82e3c516431c26e086e41861df4b212121a21226eed7"` [INFO] running `"docker" "rm" "-f" "79714a207c5d7149629c82e3c516431c26e086e41861df4b212121a21226eed7"` [INFO] [stdout] 79714a207c5d7149629c82e3c516431c26e086e41861df4b212121a21226eed7