[INFO] updating cached repository Berteun/rust-toy-list [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Berteun/rust-toy-list [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Berteun/rust-toy-list" "work/ex/clippy-test-run/sources/stable/gh/Berteun/rust-toy-list"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Berteun/rust-toy-list'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Berteun/rust-toy-list" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Berteun/rust-toy-list"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Berteun/rust-toy-list'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8c02b9732a93b89c6528d053069dafac7f7b6bfe [INFO] sha for GitHub repo Berteun/rust-toy-list: 8c02b9732a93b89c6528d053069dafac7f7b6bfe [INFO] validating manifest of Berteun/rust-toy-list on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Berteun/rust-toy-list on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Berteun/rust-toy-list [INFO] finished frobbing Berteun/rust-toy-list [INFO] frobbed toml for Berteun/rust-toy-list written to work/ex/clippy-test-run/sources/stable/gh/Berteun/rust-toy-list/Cargo.toml [INFO] started frobbing Berteun/rust-toy-list [INFO] finished frobbing Berteun/rust-toy-list [INFO] frobbed toml for Berteun/rust-toy-list written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Berteun/rust-toy-list/Cargo.toml [INFO] crate Berteun/rust-toy-list has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Berteun/rust-toy-list against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Berteun/rust-toy-list:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e78fd10b27c8052aa3ac2732300c1510f0cce19264df230ad80f616a09d19c84 [INFO] running `"docker" "start" "-a" "e78fd10b27c8052aa3ac2732300c1510f0cce19264df230ad80f616a09d19c84"` [INFO] [stderr] Checking reverse v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list/mod.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | Node{ data : data , next : None } [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list/mod.rs:55:41 [INFO] [stderr] | [INFO] [stderr] 55 | List{head : Some(Box::new(Node{ data : data, next : None}))} [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list/mod.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | Node{ data : data , next : None } [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list/mod.rs:55:41 [INFO] [stderr] | [INFO] [stderr] 55 | List{head : Some(Box::new(Node{ data : data, next : None}))} [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/list/mod.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | Node{data : _, next : Some(ref next)} => 1 + next.length(), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Node { next : Some(ref next), .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/list/mod.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | Node{data : _, next : _} => 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Node { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/list/mod.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | Node{data : _, next : Some(ref next)} => next.last(), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Node { next : Some(ref next), .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/list/mod.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | Node{data : _, next : _} => self [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Node { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/list/mod.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | Node{data : _, next : Some(ref mut next)} => next.last_mut(), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Node { next : Some(ref mut next), .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/list/mod.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | Node{data : _, next : _} => self [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Node { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/list/mod.rs:117:18 [INFO] [stderr] | [INFO] [stderr] 117 | Node{data : _, next : Some(ref tail)} => write!(f, "{}->{}", self.data, tail), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Node { next : Some(ref tail), .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/list/mod.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | Node{data : _, next : _ } => write!(f, "{}" , self.data) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Node { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: private type `list::Node` in public interface (error E0446) [INFO] [stderr] --> src/list/mod.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn first(&self) -> Option<&Node> [INFO] [stderr] 66 | | { [INFO] [stderr] 67 | | match self.head [INFO] [stderr] 68 | | { [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `list::Node` in public interface (error E0446) [INFO] [stderr] --> src/list/mod.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn last(&self) -> Option<&Node> [INFO] [stderr] 75 | | { [INFO] [stderr] 76 | | match self.head { [INFO] [stderr] 77 | | Some(ref boxed_node) => Some(boxed_node.last()), [INFO] [stderr] 78 | | None => None [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/list/mod.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | Node{data : _, next : Some(ref next)} => 1 + next.length(), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Node { next : Some(ref next), .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/list/mod.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | Node{data : _, next : _} => 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Node { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/list/mod.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | Node{data : _, next : Some(ref next)} => next.last(), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Node { next : Some(ref next), .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/list/mod.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | Node{data : _, next : _} => self [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Node { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/list/mod.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | Node{data : _, next : Some(ref mut next)} => next.last_mut(), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Node { next : Some(ref mut next), .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/list/mod.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | Node{data : _, next : _} => self [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Node { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/list/mod.rs:117:18 [INFO] [stderr] | [INFO] [stderr] 117 | Node{data : _, next : Some(ref tail)} => write!(f, "{}->{}", self.data, tail), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Node { next : Some(ref tail), .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/list/mod.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | Node{data : _, next : _ } => write!(f, "{}" , self.data) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Node { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: private type `list::Node` in public interface (error E0446) [INFO] [stderr] --> src/list/mod.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn first(&self) -> Option<&Node> [INFO] [stderr] 66 | | { [INFO] [stderr] 67 | | match self.head [INFO] [stderr] 68 | | { [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `list::Node` in public interface (error E0446) [INFO] [stderr] --> src/list/mod.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn last(&self) -> Option<&Node> [INFO] [stderr] 75 | | { [INFO] [stderr] 76 | | match self.head { [INFO] [stderr] 77 | | Some(ref boxed_node) => Some(boxed_node.last()), [INFO] [stderr] 78 | | None => None [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.50s [INFO] running `"docker" "inspect" "e78fd10b27c8052aa3ac2732300c1510f0cce19264df230ad80f616a09d19c84"` [INFO] running `"docker" "rm" "-f" "e78fd10b27c8052aa3ac2732300c1510f0cce19264df230ad80f616a09d19c84"` [INFO] [stdout] e78fd10b27c8052aa3ac2732300c1510f0cce19264df230ad80f616a09d19c84