[INFO] updating cached repository BenjyWiener/deboggle [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BenjyWiener/deboggle [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BenjyWiener/deboggle" "work/ex/clippy-test-run/sources/stable/gh/BenjyWiener/deboggle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BenjyWiener/deboggle'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BenjyWiener/deboggle" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BenjyWiener/deboggle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BenjyWiener/deboggle'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5f32396ac7153f371b17e2ba583fd861ff230093 [INFO] sha for GitHub repo BenjyWiener/deboggle: 5f32396ac7153f371b17e2ba583fd861ff230093 [INFO] validating manifest of BenjyWiener/deboggle on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BenjyWiener/deboggle on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BenjyWiener/deboggle [INFO] finished frobbing BenjyWiener/deboggle [INFO] frobbed toml for BenjyWiener/deboggle written to work/ex/clippy-test-run/sources/stable/gh/BenjyWiener/deboggle/Cargo.toml [INFO] started frobbing BenjyWiener/deboggle [INFO] finished frobbing BenjyWiener/deboggle [INFO] frobbed toml for BenjyWiener/deboggle written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BenjyWiener/deboggle/Cargo.toml [INFO] crate BenjyWiener/deboggle has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BenjyWiener/deboggle against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BenjyWiener/deboggle:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3ab045277fbc6e703caf02219f3eed05084dc2b3ef65d093fd899331173a1eb4 [INFO] running `"docker" "start" "-a" "3ab045277fbc6e703caf02219f3eed05084dc2b3ef65d093fd899331173a1eb4"` [INFO] [stderr] Checking deboggle v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | let point = Point { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:165:39 [INFO] [stderr] | [INFO] [stderr] 165 | let point = Point { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | let point = Point { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:165:39 [INFO] [stderr] | [INFO] [stderr] 165 | let point = Point { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:181:133 [INFO] [stderr] | [INFO] [stderr] 181 | println!("{} word(s) found in {} seconds:", sorted_results.len(), (elapsed.as_secs() as f64) + (elapsed.subsec_nanos() as f64 / 1000000000f64)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:181:133 [INFO] [stderr] | [INFO] [stderr] 181 | println!("{} word(s) found in {} seconds:", sorted_results.len(), (elapsed.as_secs() as f64) + (elapsed.subsec_nanos() as f64 / 1000000000f64)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:48:68 [INFO] [stderr] | [INFO] [stderr] 48 | for word in WORDS_FILE.to_lowercase().replace("qu", "_").split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:65:34 [INFO] [stderr] | [INFO] [stderr] 65 | prefixes.insert(word[..i + 1].to_string()); [INFO] [stderr] | ^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:86:45 [INFO] [stderr] | [INFO] [stderr] 86 | fn get_adjacent_points(point: &Point, size: &usize) -> HashSet { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:181:101 [INFO] [stderr] | [INFO] [stderr] 181 | println!("{} word(s) found in {} seconds:", sorted_results.len(), (elapsed.as_secs() as f64) + (elapsed.subsec_nanos() as f64 / 1000000000f64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:48:68 [INFO] [stderr] | [INFO] [stderr] 48 | for word in WORDS_FILE.to_lowercase().replace("qu", "_").split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:65:34 [INFO] [stderr] | [INFO] [stderr] 65 | prefixes.insert(word[..i + 1].to_string()); [INFO] [stderr] | ^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:86:45 [INFO] [stderr] | [INFO] [stderr] 86 | fn get_adjacent_points(point: &Point, size: &usize) -> HashSet { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:181:101 [INFO] [stderr] | [INFO] [stderr] 181 | println!("{} word(s) found in {} seconds:", sorted_results.len(), (elapsed.as_secs() as f64) + (elapsed.subsec_nanos() as f64 / 1000000000f64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.61s [INFO] running `"docker" "inspect" "3ab045277fbc6e703caf02219f3eed05084dc2b3ef65d093fd899331173a1eb4"` [INFO] running `"docker" "rm" "-f" "3ab045277fbc6e703caf02219f3eed05084dc2b3ef65d093fd899331173a1eb4"` [INFO] [stdout] 3ab045277fbc6e703caf02219f3eed05084dc2b3ef65d093fd899331173a1eb4