[INFO] updating cached repository Basti110/Tracks-database-Traktor
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Basti110/Tracks-database-Traktor
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Basti110/Tracks-database-Traktor" "work/ex/clippy-test-run/sources/stable/gh/Basti110/Tracks-database-Traktor"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Basti110/Tracks-database-Traktor'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Basti110/Tracks-database-Traktor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Basti110/Tracks-database-Traktor"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Basti110/Tracks-database-Traktor'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] cdd08e7b0210a79669dbe09319f977c7813d9153
[INFO] sha for GitHub repo Basti110/Tracks-database-Traktor: cdd08e7b0210a79669dbe09319f977c7813d9153
[INFO] validating manifest of Basti110/Tracks-database-Traktor on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Basti110/Tracks-database-Traktor on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Basti110/Tracks-database-Traktor
[INFO] finished frobbing Basti110/Tracks-database-Traktor
[INFO] frobbed toml for Basti110/Tracks-database-Traktor written to work/ex/clippy-test-run/sources/stable/gh/Basti110/Tracks-database-Traktor/Cargo.toml
[INFO] started frobbing Basti110/Tracks-database-Traktor
[INFO] finished frobbing Basti110/Tracks-database-Traktor
[INFO] frobbed toml for Basti110/Tracks-database-Traktor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Basti110/Tracks-database-Traktor/Cargo.toml
[INFO] crate Basti110/Tracks-database-Traktor has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Basti110/Tracks-database-Traktor against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Basti110/Tracks-database-Traktor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9cfd61fc3672bff7fab4edc2f3e842d065c4028ef1123fcbcee488bb669b70b1
[INFO] running `"docker" "start" "-a" "9cfd61fc3672bff7fab4edc2f3e842d065c4028ef1123fcbcee488bb669b70b1"`
[INFO] [stderr]     Checking hello_world v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `BufReader`
[INFO] [stderr]  --> src/string_traits.rs:2:33
[INFO] [stderr]   |
[INFO] [stderr] 2 | use std::io::{Error, ErrorKind, BufReader};
[INFO] [stderr]   |                                 ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/string_traits.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return new_string;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_string`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:224:5
[INFO] [stderr]     |
[INFO] [stderr] 224 |     return remove_first_p(title);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `remove_first_p(title)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `BufReader`
[INFO] [stderr]  --> src/string_traits.rs:2:33
[INFO] [stderr]   |
[INFO] [stderr] 2 | use std::io::{Error, ErrorKind, BufReader};
[INFO] [stderr]   |                                 ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/string_traits.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return new_string;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_string`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:224:5
[INFO] [stderr]     |
[INFO] [stderr] 224 |     return remove_first_p(title);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `remove_first_p(title)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `x`
[INFO] [stderr]    --> src/main.rs:245:18
[INFO] [stderr]     |
[INFO] [stderr] 245 |             Some(x) => return SEPARATE_VERSION[i].to_string(),
[INFO] [stderr]     |                  ^ help: consider using `_x` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `e`
[INFO] [stderr]    --> src/main.rs:303:17
[INFO] [stderr]     |
[INFO] [stderr] 303 |             Err(e) => continue,
[INFO] [stderr]     |                 ^ help: consider using `_e` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `line` is never read
[INFO] [stderr]    --> src/org_parser.rs:103:17
[INFO] [stderr]     |
[INFO] [stderr] 103 |         let mut line = "".to_string();
[INFO] [stderr]     |                 ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `x`
[INFO] [stderr]    --> src/main.rs:245:18
[INFO] [stderr]     |
[INFO] [stderr] 245 |             Some(x) => return SEPARATE_VERSION[i].to_string(),
[INFO] [stderr]     |                  ^ help: consider using `_x` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `e`
[INFO] [stderr]    --> src/main.rs:303:17
[INFO] [stderr]     |
[INFO] [stderr] 303 |             Err(e) => continue,
[INFO] [stderr]     |                 ^ help: consider using `_e` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `line` is never read
[INFO] [stderr]    --> src/org_parser.rs:103:17
[INFO] [stderr]     |
[INFO] [stderr] 103 |         let mut line = "".to_string();
[INFO] [stderr]     |                 ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:150:9
[INFO] [stderr]     |
[INFO] [stderr] 150 |     let mut pos = match file_name.find(" - ") {
[INFO] [stderr]     |         ----^^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:150:9
[INFO] [stderr]     |
[INFO] [stderr] 150 |     let mut pos = match file_name.find(" - ") {
[INFO] [stderr]     |         ----^^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/org_parser.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |         let mut orgList = OrgList::new();
[INFO] [stderr]     |             ----^^^^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `OrgEntry`
[INFO] [stderr]  --> src/org_parser.rs:6:1
[INFO] [stderr]   |
[INFO] [stderr] 6 | pub struct OrgEntry {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/org_parser.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     pub fn new() -> OrgEntry {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `to_string`
[INFO] [stderr]   --> src/org_parser.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub fn to_string(self) -> String {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `OrgList`
[INFO] [stderr]   --> src/org_parser.rs:83:1
[INFO] [stderr]    |
[INFO] [stderr] 83 | pub struct OrgList {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/org_parser.rs:88:5
[INFO] [stderr]    |
[INFO] [stderr] 88 |     pub fn new() -> OrgList {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `add`
[INFO] [stderr]   --> src/org_parser.rs:93:5
[INFO] [stderr]    |
[INFO] [stderr] 93 |     pub fn add(&mut self, value: OrgEntry) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `parse_file`
[INFO] [stderr]   --> src/org_parser.rs:97:5
[INFO] [stderr]    |
[INFO] [stderr] 97 |     pub fn parse_file(path: &String) -> io::Result<OrgList> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `find_entry`
[INFO] [stderr]    --> src/org_parser.rs:183:5
[INFO] [stderr]     |
[INFO] [stderr] 183 |     pub fn find_entry(&mut self, name: String) -> Option<&mut OrgEntry> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/org_parser.rs:33:22
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub fn to_string(self) -> String {
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/org_parser.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |         let mut orgList = OrgList::new();
[INFO] [stderr]     |             ----^^^^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:38:27
[INFO] [stderr]    |
[INFO] [stderr] 38 |         if self.author != "".to_string() {
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:43:31
[INFO] [stderr]    |
[INFO] [stderr] 43 |         if self.author_add != "".to_string() {
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:48:26
[INFO] [stderr]    |
[INFO] [stderr] 48 |         if self.title != "".to_string() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:53:30
[INFO] [stderr]    |
[INFO] [stderr] 53 |         if self.title_add != "".to_string() {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:58:28
[INFO] [stderr]    |
[INFO] [stderr] 58 |         if self.version != "".to_string() {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:63:25
[INFO] [stderr]    |
[INFO] [stderr] 63 |         if self.year != "".to_string() {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:68:28
[INFO] [stderr]    |
[INFO] [stderr] 68 |         if self.release != "".to_string() {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:73:26
[INFO] [stderr]    |
[INFO] [stderr] 73 |         if self.notes != "".to_string() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/org_parser.rs:97:29
[INFO] [stderr]    |
[INFO] [stderr] 97 |     pub fn parse_file(path: &String) -> io::Result<OrgList> {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: variable `orgList` should have a snake case name such as `org_list`
[INFO] [stderr]    --> src/org_parser.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |         let mut orgList = OrgList::new();
[INFO] [stderr]     |             ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `OrgEntry`
[INFO] [stderr]  --> src/org_parser.rs:6:1
[INFO] [stderr]   |
[INFO] [stderr] 6 | pub struct OrgEntry {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/org_parser.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     pub fn new() -> OrgEntry {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `to_string`
[INFO] [stderr]   --> src/org_parser.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub fn to_string(self) -> String {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `OrgList`
[INFO] [stderr]   --> src/org_parser.rs:83:1
[INFO] [stderr]    |
[INFO] [stderr] 83 | pub struct OrgList {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/org_parser.rs:88:5
[INFO] [stderr]    |
[INFO] [stderr] 88 |     pub fn new() -> OrgList {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `add`
[INFO] [stderr]   --> src/org_parser.rs:93:5
[INFO] [stderr]    |
[INFO] [stderr] 93 |     pub fn add(&mut self, value: OrgEntry) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `parse_file`
[INFO] [stderr]   --> src/org_parser.rs:97:5
[INFO] [stderr]    |
[INFO] [stderr] 97 |     pub fn parse_file(path: &String) -> io::Result<OrgList> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `find_entry`
[INFO] [stderr]    --> src/org_parser.rs:183:5
[INFO] [stderr]     |
[INFO] [stderr] 183 |     pub fn find_entry(&mut self, name: String) -> Option<&mut OrgEntry> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/org_parser.rs:33:22
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub fn to_string(self) -> String {
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:38:27
[INFO] [stderr]    |
[INFO] [stderr] 38 |         if self.author != "".to_string() {
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:43:31
[INFO] [stderr]    |
[INFO] [stderr] 43 |         if self.author_add != "".to_string() {
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:48:26
[INFO] [stderr]    |
[INFO] [stderr] 48 |         if self.title != "".to_string() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:53:30
[INFO] [stderr]    |
[INFO] [stderr] 53 |         if self.title_add != "".to_string() {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:58:28
[INFO] [stderr]    |
[INFO] [stderr] 58 |         if self.version != "".to_string() {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:63:25
[INFO] [stderr]    |
[INFO] [stderr] 63 |         if self.year != "".to_string() {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:68:28
[INFO] [stderr]    |
[INFO] [stderr] 68 |         if self.release != "".to_string() {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/org_parser.rs:73:26
[INFO] [stderr]    |
[INFO] [stderr] 73 |         if self.notes != "".to_string() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/org_parser.rs:97:29
[INFO] [stderr]    |
[INFO] [stderr] 97 |     pub fn parse_file(path: &String) -> io::Result<OrgList> {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: variable `orgList` should have a snake case name such as `org_list`
[INFO] [stderr]    --> src/org_parser.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |         let mut orgList = OrgList::new();
[INFO] [stderr]     |             ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:55:46
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let mut dirs: Vec<&str> = line.split("/").collect();
[INFO] [stderr]    |                                              ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `dirs`.
[INFO] [stderr]   --> src/main.rs:58:18
[INFO] [stderr]    |
[INFO] [stderr] 58 |         for i in 0..(dirs.len() - 1) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 58 |         for <item> in dirs.iter().take((dirs.len() - 1)) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/main.rs:59:27
[INFO] [stderr]    |
[INFO] [stderr] 59 |             path.push_str(dirs[i].clone());
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 59 |             path.push_str(&(*dirs[i]).clone());
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 59 |             path.push_str(&str::clone(dirs[i]));
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/main.rs:65:23
[INFO] [stderr]    |
[INFO] [stderr] 65 |         path.push_str(dirs[dirs.len() - 1].clone());
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 65 |         path.push_str(&(*dirs[dirs.len() - 1]).clone());
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 65 |         path.push_str(&str::clone(dirs[dirs.len() - 1]));
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:55:46
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let mut dirs: Vec<&str> = line.split("/").collect();
[INFO] [stderr]    |                                              ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `dirs`.
[INFO] [stderr]   --> src/main.rs:58:18
[INFO] [stderr]    |
[INFO] [stderr] 58 |         for i in 0..(dirs.len() - 1) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 58 |         for <item> in dirs.iter().take((dirs.len() - 1)) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/main.rs:59:27
[INFO] [stderr]    |
[INFO] [stderr] 59 |             path.push_str(dirs[i].clone());
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 59 |             path.push_str(&(*dirs[i]).clone());
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 59 |             path.push_str(&str::clone(dirs[i]));
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/main.rs:65:23
[INFO] [stderr]    |
[INFO] [stderr] 65 |         path.push_str(dirs[dirs.len() - 1].clone());
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 65 |         path.push_str(&(*dirs[dirs.len() - 1]).clone());
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 65 |         path.push_str(&str::clone(dirs[dirs.len() - 1]));
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:101:30
[INFO] [stderr]     |
[INFO] [stderr] 101 |         Err(e) => return Err(e.into()),
[INFO] [stderr]     |                              ^^^^^^^^ help: consider removing `.into()`: `e`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:114:30
[INFO] [stderr]     |
[INFO] [stderr] 114 | fn get_name_parts(file_name: &String) -> io::Result<()> {
[INFO] [stderr]     |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:147:35
[INFO] [stderr]     |
[INFO] [stderr] 147 | fn get_author_name_pos(file_name: &String) -> io::Result<usize> {
[INFO] [stderr]     |                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:158:27
[INFO] [stderr]     |
[INFO] [stderr] 158 | fn shorter_author(author: &String) -> String {
[INFO] [stderr]     |                           ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 158 | fn shorter_author(author: &str) -> String {
[INFO] [stderr]     |                           ^^^^
[INFO] [stderr] help: change `author.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 179 |             None => return author.to_string(),
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: change `author.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 182 |     author.to_string()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is only used to index `SEPARATE_AUTHOR`.
[INFO] [stderr]    --> src/main.rs:161:14
[INFO] [stderr]     |
[INFO] [stderr] 161 |     for x in 0..len {
[INFO] [stderr]     |              ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 161 |     for <item> in SEPARATE_AUTHOR.iter().take(len) {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:185:25
[INFO] [stderr]     |
[INFO] [stderr] 185 | fn remove_first_p(name: &String) -> String {
[INFO] [stderr]     |                         ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 185 | fn remove_first_p(name: &str) -> String {
[INFO] [stderr]     |                         ^^^^
[INFO] [stderr] help: change `name.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 220 |     name.to_string()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:194:9
[INFO] [stderr]     |
[INFO] [stderr] 194 | /         loop {
[INFO] [stderr] 195 | |             let c = match chars.next() {
[INFO] [stderr] 196 | |                 Some(x) => x,
[INFO] [stderr] 197 | |                 None => break,
[INFO] [stderr] ...   |
[INFO] [stderr] 214 | |             char_pos += c.len_utf8();
[INFO] [stderr] 215 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(x) = chars.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:201:20
[INFO] [stderr]     |
[INFO] [stderr] 201 |                 if found_open == false {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!found_open`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/main.rs:217:32
[INFO] [stderr]     |
[INFO] [stderr] 217 |     if open_pos < close_pos && found_open == true {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `found_open`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:223:25
[INFO] [stderr]     |
[INFO] [stderr] 223 | fn shorter_title(title: &String) -> String {
[INFO] [stderr]     |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:227:29
[INFO] [stderr]     |
[INFO] [stderr] 227 | fn shorter_version(version: &String) -> String {
[INFO] [stderr]     |                             ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 227 | fn shorter_version(version: &str) -> String {
[INFO] [stderr]     |                             ^^^^
[INFO] [stderr] help: change `version.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 230 |         None => return version.to_string(),
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: change `version.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 235 |         None => return version.to_string(),
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: change `version.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 249 |     version.to_string()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:228:40
[INFO] [stderr]     |
[INFO] [stderr] 228 |     let first_pos = match version.find("(") {
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `'('`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:233:39
[INFO] [stderr]     |
[INFO] [stderr] 233 |     let last_pos = match version.find(")") {
[INFO] [stderr]     |                                       ^^^ help: try using a char instead: `')'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `SEPARATE_VERSION`.
[INFO] [stderr]    --> src/main.rs:243:14
[INFO] [stderr]     |
[INFO] [stderr] 243 |     for i in 0..len {
[INFO] [stderr]     |              ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 243 |     for <item> in SEPARATE_VERSION.iter().take(len) {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:252:36
[INFO] [stderr]     |
[INFO] [stderr] 252 | fn get_version_name_pos(file_name: &String) -> io::Result<usize> {
[INFO] [stderr]     |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:260:38
[INFO] [stderr]     |
[INFO] [stderr] 260 |         let pos1 = match slice.rfind(")") {
[INFO] [stderr]     |                                      ^^^ help: try using a char instead: `')'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:280:32
[INFO] [stderr]     |
[INFO] [stderr] 280 | fn move_file_to_year(path_src: &String, path_dst: &str, ext: &str) -> io::Result<()> {
[INFO] [stderr]     |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:101:30
[INFO] [stderr]     |
[INFO] [stderr] 101 |         Err(e) => return Err(e.into()),
[INFO] [stderr]     |                              ^^^^^^^^ help: consider removing `.into()`: `e`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:114:30
[INFO] [stderr]     |
[INFO] [stderr] 114 | fn get_name_parts(file_name: &String) -> io::Result<()> {
[INFO] [stderr]     |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:147:35
[INFO] [stderr]     |
[INFO] [stderr] 147 | fn get_author_name_pos(file_name: &String) -> io::Result<usize> {
[INFO] [stderr]     |                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:158:27
[INFO] [stderr]     |
[INFO] [stderr] 158 | fn shorter_author(author: &String) -> String {
[INFO] [stderr]     |                           ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 158 | fn shorter_author(author: &str) -> String {
[INFO] [stderr]     |                           ^^^^
[INFO] [stderr] help: change `author.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 179 |             None => return author.to_string(),
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: change `author.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 182 |     author.to_string()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is only used to index `SEPARATE_AUTHOR`.
[INFO] [stderr]    --> src/main.rs:161:14
[INFO] [stderr]     |
[INFO] [stderr] 161 |     for x in 0..len {
[INFO] [stderr]     |              ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 161 |     for <item> in SEPARATE_AUTHOR.iter().take(len) {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:185:25
[INFO] [stderr]     |
[INFO] [stderr] 185 | fn remove_first_p(name: &String) -> String {
[INFO] [stderr]     |                         ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 185 | fn remove_first_p(name: &str) -> String {
[INFO] [stderr]     |                         ^^^^
[INFO] [stderr] help: change `name.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 220 |     name.to_string()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should use the `starts_with` method
[INFO] [stderr]    --> src/main.rs:292:12
[INFO] [stderr]     |
[INFO] [stderr] 292 |         if extension_with_year.chars().next().unwrap() != '.' {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!extension_with_year.starts_with('.')`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::chars_next_cmp)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:194:9
[INFO] [stderr]     |
[INFO] [stderr] 194 | /         loop {
[INFO] [stderr] 195 | |             let c = match chars.next() {
[INFO] [stderr] 196 | |                 Some(x) => x,
[INFO] [stderr] 197 | |                 None => break,
[INFO] [stderr] ...   |
[INFO] [stderr] 214 | |             char_pos += c.len_utf8();
[INFO] [stderr] 215 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(x) = chars.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:201:20
[INFO] [stderr]     |
[INFO] [stderr] 201 |                 if found_open == false {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!found_open`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/main.rs:217:32
[INFO] [stderr]     |
[INFO] [stderr] 217 |     if open_pos < close_pos && found_open == true {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `found_open`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:223:25
[INFO] [stderr]     |
[INFO] [stderr] 223 | fn shorter_title(title: &String) -> String {
[INFO] [stderr]     |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:227:29
[INFO] [stderr]     |
[INFO] [stderr] 227 | fn shorter_version(version: &String) -> String {
[INFO] [stderr]     |                             ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 227 | fn shorter_version(version: &str) -> String {
[INFO] [stderr]     |                             ^^^^
[INFO] [stderr] help: change `version.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 230 |         None => return version.to_string(),
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: change `version.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 235 |         None => return version.to_string(),
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: change `version.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 249 |     version.to_string()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:228:40
[INFO] [stderr]     |
[INFO] [stderr] 228 |     let first_pos = match version.find("(") {
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `'('`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:233:39
[INFO] [stderr]     |
[INFO] [stderr] 233 |     let last_pos = match version.find(")") {
[INFO] [stderr]     |                                       ^^^ help: try using a char instead: `')'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `SEPARATE_VERSION`.
[INFO] [stderr]    --> src/main.rs:243:14
[INFO] [stderr]     |
[INFO] [stderr] 243 |     for i in 0..len {
[INFO] [stderr]     |              ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 243 |     for <item> in SEPARATE_VERSION.iter().take(len) {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:252:36
[INFO] [stderr]     |
[INFO] [stderr] 252 | fn get_version_name_pos(file_name: &String) -> io::Result<usize> {
[INFO] [stderr]     |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:260:38
[INFO] [stderr]     |
[INFO] [stderr] 260 |         let pos1 = match slice.rfind(")") {
[INFO] [stderr]     |                                      ^^^ help: try using a char instead: `')'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:280:32
[INFO] [stderr]     |
[INFO] [stderr] 280 | fn move_file_to_year(path_src: &String, path_dst: &str, ext: &str) -> io::Result<()> {
[INFO] [stderr]     |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] warning: you should use the `starts_with` method
[INFO] [stderr]    --> src/main.rs:292:12
[INFO] [stderr]     |
[INFO] [stderr] 292 |         if extension_with_year.chars().next().unwrap() != '.' {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!extension_with_year.starts_with('.')`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::chars_next_cmp)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `hello_world`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: Could not compile `hello_world`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "9cfd61fc3672bff7fab4edc2f3e842d065c4028ef1123fcbcee488bb669b70b1"`
[INFO] running `"docker" "rm" "-f" "9cfd61fc3672bff7fab4edc2f3e842d065c4028ef1123fcbcee488bb669b70b1"`
[INFO] [stdout] 9cfd61fc3672bff7fab4edc2f3e842d065c4028ef1123fcbcee488bb669b70b1