[INFO] updating cached repository BarePotato/bares_MUD [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BarePotato/bares_MUD [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BarePotato/bares_MUD" "work/ex/clippy-test-run/sources/stable/gh/BarePotato/bares_MUD"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BarePotato/bares_MUD'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BarePotato/bares_MUD" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BarePotato/bares_MUD"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BarePotato/bares_MUD'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dc16e20ca7b9e432bdd14f9613b4795e700cab2d [INFO] sha for GitHub repo BarePotato/bares_MUD: dc16e20ca7b9e432bdd14f9613b4795e700cab2d [INFO] validating manifest of BarePotato/bares_MUD on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BarePotato/bares_MUD on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BarePotato/bares_MUD [INFO] finished frobbing BarePotato/bares_MUD [INFO] frobbed toml for BarePotato/bares_MUD written to work/ex/clippy-test-run/sources/stable/gh/BarePotato/bares_MUD/Cargo.toml [INFO] started frobbing BarePotato/bares_MUD [INFO] finished frobbing BarePotato/bares_MUD [INFO] frobbed toml for BarePotato/bares_MUD written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BarePotato/bares_MUD/Cargo.toml [INFO] crate BarePotato/bares_MUD has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BarePotato/bares_MUD against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BarePotato/bares_MUD:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1719d7b157c6aca682816a4775436f8424368a005c0c8a10d51ccfea839c629d [INFO] running `"docker" "start" "-a" "1719d7b157c6aca682816a4775436f8424368a005c0c8a10d51ccfea839c629d"` [INFO] [stderr] Checking bares_MUD v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: crate `bares_MUD` should have a snake case name such as `bares_mud` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:74:47 [INFO] [stderr] | [INFO] [stderr] 74 | if client.state != Conn::Disco && client.inp.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!client.inp.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:77:24 [INFO] [stderr] | [INFO] [stderr] 77 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 78 | | // parse input guided by state [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:75:50 [INFO] [stderr] | [INFO] [stderr] 75 | if client.state == Conn::Playing { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 76 | | // parse input to game [INFO] [stderr] 77 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | let output = clients.get(cli).unwrap().inp.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&clients[cli]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:103:23 [INFO] [stderr] | [INFO] [stderr] 103 | } else if client.out.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!client.out.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / let mut sleep = Duration::from_millis(0); [INFO] [stderr] 130 | | [INFO] [stderr] 131 | | if elapsed < TICK { [INFO] [stderr] 132 | | sleep = TICK - elapsed; [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let sleep = if elapsed < TICK { TICK - elapsed } else { Duration::from_millis(0) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | / loop { [INFO] [stderr] 169 | | let mut buffer = [0; BUFLEN]; [INFO] [stderr] 170 | | match client.socket.read(&mut buffer) { [INFO] [stderr] 171 | | Ok(0) => break, [INFO] [stderr] ... | [INFO] [stderr] 190 | | } [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bares_MUD`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: crate `bares_MUD` should have a snake case name such as `bares_mud` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:74:47 [INFO] [stderr] | [INFO] [stderr] 74 | if client.state != Conn::Disco && client.inp.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!client.inp.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:77:24 [INFO] [stderr] | [INFO] [stderr] 77 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 78 | | // parse input guided by state [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:75:50 [INFO] [stderr] | [INFO] [stderr] 75 | if client.state == Conn::Playing { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 76 | | // parse input to game [INFO] [stderr] 77 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | let output = clients.get(cli).unwrap().inp.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&clients[cli]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:103:23 [INFO] [stderr] | [INFO] [stderr] 103 | } else if client.out.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!client.out.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / let mut sleep = Duration::from_millis(0); [INFO] [stderr] 130 | | [INFO] [stderr] 131 | | if elapsed < TICK { [INFO] [stderr] 132 | | sleep = TICK - elapsed; [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let sleep = if elapsed < TICK { TICK - elapsed } else { Duration::from_millis(0) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | / loop { [INFO] [stderr] 169 | | let mut buffer = [0; BUFLEN]; [INFO] [stderr] 170 | | match client.socket.read(&mut buffer) { [INFO] [stderr] 171 | | Ok(0) => break, [INFO] [stderr] ... | [INFO] [stderr] 190 | | } [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bares_MUD`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1719d7b157c6aca682816a4775436f8424368a005c0c8a10d51ccfea839c629d"` [INFO] running `"docker" "rm" "-f" "1719d7b157c6aca682816a4775436f8424368a005c0c8a10d51ccfea839c629d"` [INFO] [stdout] 1719d7b157c6aca682816a4775436f8424368a005c0c8a10d51ccfea839c629d