[INFO] updating cached repository AustinC/succotash-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AustinC/succotash-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AustinC/succotash-rust" "work/ex/clippy-test-run/sources/stable/gh/AustinC/succotash-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AustinC/succotash-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AustinC/succotash-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AustinC/succotash-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AustinC/succotash-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e5900ee6e183bf56a625e6d5468cfc4ff0dcd2e6 [INFO] sha for GitHub repo AustinC/succotash-rust: e5900ee6e183bf56a625e6d5468cfc4ff0dcd2e6 [INFO] validating manifest of AustinC/succotash-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AustinC/succotash-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AustinC/succotash-rust [INFO] finished frobbing AustinC/succotash-rust [INFO] frobbed toml for AustinC/succotash-rust written to work/ex/clippy-test-run/sources/stable/gh/AustinC/succotash-rust/Cargo.toml [INFO] started frobbing AustinC/succotash-rust [INFO] finished frobbing AustinC/succotash-rust [INFO] frobbed toml for AustinC/succotash-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AustinC/succotash-rust/Cargo.toml [INFO] crate AustinC/succotash-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AustinC/succotash-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AustinC/succotash-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f456aa617b1994dab85029f15d7e9de2e43ced0aeb2b621ebaf9e2aad36d93d3 [INFO] running `"docker" "start" "-a" "f456aa617b1994dab85029f15d7e9de2e43ced0aeb2b621ebaf9e2aad36d93d3"` [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking succotash-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/printer.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | / match v { [INFO] [stderr] 6 | | &Str(ref s) => format!("\"{}\"", s), [INFO] [stderr] 7 | | &List(ref vals) => { [INFO] [stderr] 8 | | let innervals: Vec = vals.iter().map(|x| print_form(x)).collect(); [INFO] [stderr] ... | [INFO] [stderr] 18 | | &Fn(_) | &StructFn { .. } => String::from("#"), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 5 | match *v { [INFO] [stderr] 6 | Str(ref s) => format!("\"{}\"", s), [INFO] [stderr] 7 | List(ref vals) => { [INFO] [stderr] 8 | let innervals: Vec = vals.iter().map(|x| print_form(x)).collect(); [INFO] [stderr] 9 | let joined = innervals.join(" "); [INFO] [stderr] 10 | format!("({})", joined) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/evaluation.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / match ast { [INFO] [stderr] 14 | | &Sym(ref s) => { [INFO] [stderr] 15 | | // lookup sym in environment [INFO] [stderr] 16 | | let result = env.get_sym(s); [INFO] [stderr] ... | [INFO] [stderr] 30 | | _ => Ok(ast.clone()), // evaluates to itself [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *ast { [INFO] [stderr] 14 | Sym(ref s) => { [INFO] [stderr] 15 | // lookup sym in environment [INFO] [stderr] 16 | let result = env.get_sym(s); [INFO] [stderr] 17 | match result { [INFO] [stderr] 18 | Ok(sym) => Ok(sym.clone()), // the env owns it, figure out how to use reference here [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/evaluation.rs:40:21 [INFO] [stderr] | [INFO] [stderr] 40 | / match &elems[0] { [INFO] [stderr] 41 | | &Sym(ref v) if v == "def" => { [INFO] [stderr] 42 | | let evaluated = eval(&elems[2], env)?; [INFO] [stderr] 43 | | env.set_sym(sym_to_str(&elems[1]), evaluated); [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 40 | match elems[0] { [INFO] [stderr] 41 | Sym(ref v) if v == "def" => { [INFO] [stderr] 42 | let evaluated = eval(&elems[2], env)?; [INFO] [stderr] 43 | env.set_sym(sym_to_str(&elems[1]), evaluated); [INFO] [stderr] 44 | Ok(elems[1].clone()) [INFO] [stderr] 45 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/evaluation.rs:124:29 [INFO] [stderr] | [INFO] [stderr] 124 | / match operator { [INFO] [stderr] 125 | | &Fn(f) => Ok(f(args)), [INFO] [stderr] 126 | | &StructFn { [INFO] [stderr] 127 | | ref param_syms, [INFO] [stderr] ... | [INFO] [stderr] 142 | | )), [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 124 | match *operator { [INFO] [stderr] 125 | Fn(f) => Ok(f(args)), [INFO] [stderr] 126 | StructFn { [INFO] [stderr] 127 | ref param_syms, [INFO] [stderr] 128 | ref body, [INFO] [stderr] 129 | ref env, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/env.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | / match &self.parent { [INFO] [stderr] 28 | | &Some(ref v) => v.find_sym(sym), [INFO] [stderr] 29 | | _ => None, [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 27 | match self.parent { [INFO] [stderr] 28 | Some(ref v) => v.find_sym(sym), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/env.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | Some(e) => Ok(&e.sym_map.get(sym).unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&e.sym_map[sym]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/env.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / if let &Int(val) = i { [INFO] [stderr] 67 | | accum += val; [INFO] [stderr] 68 | | } else { [INFO] [stderr] 69 | | panic!("bad args. expected ints") [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 66 | if let Int(val) = *i { [INFO] [stderr] | ^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/env.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / if let &Int(val) = i { [INFO] [stderr] 79 | | accum *= val; [INFO] [stderr] 80 | | } else { [INFO] [stderr] 81 | | panic!("bad args. expected ints") [INFO] [stderr] 82 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 78 | if let Int(val) = *i { [INFO] [stderr] | ^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | / match v { [INFO] [stderr] 6 | | &False | &Nil => false, [INFO] [stderr] 7 | | _ => true, [INFO] [stderr] 8 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 5 | match *v { [INFO] [stderr] 6 | False | Nil => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / if let &ScType::List(ref s) = v { [INFO] [stderr] 13 | | s [INFO] [stderr] 14 | | } else { [INFO] [stderr] 15 | | panic!("Failed to extract Vec from list. Maybe it wasn't a list.") [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 12 | if let ScType::List(ref s) = *v { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / if let &ScType::Sym(ref s) = v { [INFO] [stderr] 21 | | &s [INFO] [stderr] 22 | | } else { [INFO] [stderr] 23 | | panic!("Failed to extract string from symbol") [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | if let ScType::Sym(ref s) = *v { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / if let &Int(i) = v { [INFO] [stderr] 33 | | i [INFO] [stderr] 34 | | } else { [INFO] [stderr] 35 | | panic!("Failed to extract int") [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | if let Int(i) = *v { [INFO] [stderr] | ^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / if let &Str(ref s) = v { [INFO] [stderr] 41 | | s [INFO] [stderr] 42 | | } else { [INFO] [stderr] 43 | | panic!("Failed to extract string") [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | if let Str(ref s) = *v { [INFO] [stderr] | ^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / match v { [INFO] [stderr] 49 | | &List(ref elems) if !elems.is_empty() => true, [INFO] [stderr] 50 | | _ => false, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *v { [INFO] [stderr] 49 | List(ref elems) if !elems.is_empty() => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / match v { [INFO] [stderr] 56 | | &Sym(ref name) if name == s => true, [INFO] [stderr] 57 | | _ => false, [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 55 | match *v { [INFO] [stderr] 56 | Sym(ref name) if name == s => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / match v { [INFO] [stderr] 63 | | &List(ref elems) if !elems.is_empty() => &elems[0], [INFO] [stderr] 64 | | _ => &Nil, [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | match *v { [INFO] [stderr] 63 | List(ref elems) if !elems.is_empty() => &elems[0], [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / match v { [INFO] [stderr] 70 | | &List(ref elems) if elems.len() > 1 => &elems[1], [INFO] [stderr] 71 | | _ => &Nil, [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | match *v { [INFO] [stderr] 70 | List(ref elems) if elems.len() > 1 => &elems[1], [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/quasiquote.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / match ast { [INFO] [stderr] 7 | | &List(ref elems) if !elems.is_empty() => match &elems[0] { [INFO] [stderr] 8 | | &Sym(ref s) if s == "unquote" => elems[1].clone(), [INFO] [stderr] 9 | | _ => { [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 6 | match *ast { [INFO] [stderr] 7 | List(ref elems) if !elems.is_empty() => match &elems[0] { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/quasiquote.rs:7:50 [INFO] [stderr] | [INFO] [stderr] 7 | &List(ref elems) if !elems.is_empty() => match &elems[0] { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 8 | | &Sym(ref s) if s == "unquote" => elems[1].clone(), [INFO] [stderr] 9 | | _ => { [INFO] [stderr] 10 | | if is_non_empty_list(&elems[0]) && sym_match("splice-unquote", ffirst(ast)) { [INFO] [stderr] ... | [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 7 | &List(ref elems) if !elems.is_empty() => match elems[0] { [INFO] [stderr] 8 | Sym(ref s) if s == "unquote" => elems[1].clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/macroexpansion.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / if let &List(ref elems) = ast { [INFO] [stderr] 11 | | if elems.is_empty() { [INFO] [stderr] 12 | | return false; [INFO] [stderr] 13 | | } [INFO] [stderr] ... | [INFO] [stderr] 26 | | false [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 10 | if let List(ref elems) = *ast { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/macroexpansion.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / if let &Sym(ref s) = &elems[0] { [INFO] [stderr] 15 | | match env.get_sym(s) { [INFO] [stderr] 16 | | Err(_) => false, [INFO] [stderr] 17 | | Ok(val) => match val { [INFO] [stderr] ... | [INFO] [stderr] 23 | | false [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 14 | if let Sym(ref s) = elems[0] { [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/macroexpansion.rs:17:28 [INFO] [stderr] | [INFO] [stderr] 17 | Ok(val) => match val { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 18 | | &StructFn { is_macro, .. } if is_macro => true, [INFO] [stderr] 19 | | _ => false, [INFO] [stderr] 20 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | Ok(val) => match *val { [INFO] [stderr] 18 | StructFn { is_macro, .. } if is_macro => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/macroexpansion.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / if let &StructFn { [INFO] [stderr] 36 | | ref param_syms, [INFO] [stderr] 37 | | ref body, [INFO] [stderr] 38 | | ref env, [INFO] [stderr] ... | [INFO] [stderr] 49 | | panic!("Error in macroexpansion. Symbol did not map to macro.") [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | if let StructFn { [INFO] [stderr] 36 | ref param_syms, [INFO] [stderr] 37 | ref body, [INFO] [stderr] 38 | ref env, [INFO] [stderr] 39 | .. [INFO] [stderr] 40 | } = *mac [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/printer.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | / match v { [INFO] [stderr] 6 | | &Str(ref s) => format!("\"{}\"", s), [INFO] [stderr] 7 | | &List(ref vals) => { [INFO] [stderr] 8 | | let innervals: Vec = vals.iter().map(|x| print_form(x)).collect(); [INFO] [stderr] ... | [INFO] [stderr] 18 | | &Fn(_) | &StructFn { .. } => String::from("#"), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 5 | match *v { [INFO] [stderr] 6 | Str(ref s) => format!("\"{}\"", s), [INFO] [stderr] 7 | List(ref vals) => { [INFO] [stderr] 8 | let innervals: Vec = vals.iter().map(|x| print_form(x)).collect(); [INFO] [stderr] 9 | let joined = innervals.join(" "); [INFO] [stderr] 10 | format!("({})", joined) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/evaluation.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / match ast { [INFO] [stderr] 14 | | &Sym(ref s) => { [INFO] [stderr] 15 | | // lookup sym in environment [INFO] [stderr] 16 | | let result = env.get_sym(s); [INFO] [stderr] ... | [INFO] [stderr] 30 | | _ => Ok(ast.clone()), // evaluates to itself [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *ast { [INFO] [stderr] 14 | Sym(ref s) => { [INFO] [stderr] 15 | // lookup sym in environment [INFO] [stderr] 16 | let result = env.get_sym(s); [INFO] [stderr] 17 | match result { [INFO] [stderr] 18 | Ok(sym) => Ok(sym.clone()), // the env owns it, figure out how to use reference here [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/evaluation.rs:40:21 [INFO] [stderr] | [INFO] [stderr] 40 | / match &elems[0] { [INFO] [stderr] 41 | | &Sym(ref v) if v == "def" => { [INFO] [stderr] 42 | | let evaluated = eval(&elems[2], env)?; [INFO] [stderr] 43 | | env.set_sym(sym_to_str(&elems[1]), evaluated); [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 40 | match elems[0] { [INFO] [stderr] 41 | Sym(ref v) if v == "def" => { [INFO] [stderr] 42 | let evaluated = eval(&elems[2], env)?; [INFO] [stderr] 43 | env.set_sym(sym_to_str(&elems[1]), evaluated); [INFO] [stderr] 44 | Ok(elems[1].clone()) [INFO] [stderr] 45 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/evaluation.rs:124:29 [INFO] [stderr] | [INFO] [stderr] 124 | / match operator { [INFO] [stderr] 125 | | &Fn(f) => Ok(f(args)), [INFO] [stderr] 126 | | &StructFn { [INFO] [stderr] 127 | | ref param_syms, [INFO] [stderr] ... | [INFO] [stderr] 142 | | )), [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 124 | match *operator { [INFO] [stderr] 125 | Fn(f) => Ok(f(args)), [INFO] [stderr] 126 | StructFn { [INFO] [stderr] 127 | ref param_syms, [INFO] [stderr] 128 | ref body, [INFO] [stderr] 129 | ref env, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/env.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | / match &self.parent { [INFO] [stderr] 28 | | &Some(ref v) => v.find_sym(sym), [INFO] [stderr] 29 | | _ => None, [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 27 | match self.parent { [INFO] [stderr] 28 | Some(ref v) => v.find_sym(sym), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/env.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | Some(e) => Ok(&e.sym_map.get(sym).unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&e.sym_map[sym]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/env.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / if let &Int(val) = i { [INFO] [stderr] 67 | | accum += val; [INFO] [stderr] 68 | | } else { [INFO] [stderr] 69 | | panic!("bad args. expected ints") [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 66 | if let Int(val) = *i { [INFO] [stderr] | ^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/env.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / if let &Int(val) = i { [INFO] [stderr] 79 | | accum *= val; [INFO] [stderr] 80 | | } else { [INFO] [stderr] 81 | | panic!("bad args. expected ints") [INFO] [stderr] 82 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 78 | if let Int(val) = *i { [INFO] [stderr] | ^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | / match v { [INFO] [stderr] 6 | | &False | &Nil => false, [INFO] [stderr] 7 | | _ => true, [INFO] [stderr] 8 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 5 | match *v { [INFO] [stderr] 6 | False | Nil => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / if let &ScType::List(ref s) = v { [INFO] [stderr] 13 | | s [INFO] [stderr] 14 | | } else { [INFO] [stderr] 15 | | panic!("Failed to extract Vec from list. Maybe it wasn't a list.") [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 12 | if let ScType::List(ref s) = *v { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / if let &ScType::Sym(ref s) = v { [INFO] [stderr] 21 | | &s [INFO] [stderr] 22 | | } else { [INFO] [stderr] 23 | | panic!("Failed to extract string from symbol") [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | if let ScType::Sym(ref s) = *v { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / if let &Int(i) = v { [INFO] [stderr] 33 | | i [INFO] [stderr] 34 | | } else { [INFO] [stderr] 35 | | panic!("Failed to extract int") [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | if let Int(i) = *v { [INFO] [stderr] | ^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / if let &Str(ref s) = v { [INFO] [stderr] 41 | | s [INFO] [stderr] 42 | | } else { [INFO] [stderr] 43 | | panic!("Failed to extract string") [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | if let Str(ref s) = *v { [INFO] [stderr] | ^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / match v { [INFO] [stderr] 49 | | &List(ref elems) if !elems.is_empty() => true, [INFO] [stderr] 50 | | _ => false, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *v { [INFO] [stderr] 49 | List(ref elems) if !elems.is_empty() => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / match v { [INFO] [stderr] 56 | | &Sym(ref name) if name == s => true, [INFO] [stderr] 57 | | _ => false, [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 55 | match *v { [INFO] [stderr] 56 | Sym(ref name) if name == s => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / match v { [INFO] [stderr] 63 | | &List(ref elems) if !elems.is_empty() => &elems[0], [INFO] [stderr] 64 | | _ => &Nil, [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | match *v { [INFO] [stderr] 63 | List(ref elems) if !elems.is_empty() => &elems[0], [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / match v { [INFO] [stderr] 70 | | &List(ref elems) if elems.len() > 1 => &elems[1], [INFO] [stderr] 71 | | _ => &Nil, [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | match *v { [INFO] [stderr] 70 | List(ref elems) if elems.len() > 1 => &elems[1], [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/quasiquote.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / match ast { [INFO] [stderr] 7 | | &List(ref elems) if !elems.is_empty() => match &elems[0] { [INFO] [stderr] 8 | | &Sym(ref s) if s == "unquote" => elems[1].clone(), [INFO] [stderr] 9 | | _ => { [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 6 | match *ast { [INFO] [stderr] 7 | List(ref elems) if !elems.is_empty() => match &elems[0] { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/quasiquote.rs:7:50 [INFO] [stderr] | [INFO] [stderr] 7 | &List(ref elems) if !elems.is_empty() => match &elems[0] { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 8 | | &Sym(ref s) if s == "unquote" => elems[1].clone(), [INFO] [stderr] 9 | | _ => { [INFO] [stderr] 10 | | if is_non_empty_list(&elems[0]) && sym_match("splice-unquote", ffirst(ast)) { [INFO] [stderr] ... | [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 7 | &List(ref elems) if !elems.is_empty() => match elems[0] { [INFO] [stderr] 8 | Sym(ref s) if s == "unquote" => elems[1].clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/macroexpansion.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / if let &List(ref elems) = ast { [INFO] [stderr] 11 | | if elems.is_empty() { [INFO] [stderr] 12 | | return false; [INFO] [stderr] 13 | | } [INFO] [stderr] ... | [INFO] [stderr] 26 | | false [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 10 | if let List(ref elems) = *ast { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/macroexpansion.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / if let &Sym(ref s) = &elems[0] { [INFO] [stderr] 15 | | match env.get_sym(s) { [INFO] [stderr] 16 | | Err(_) => false, [INFO] [stderr] 17 | | Ok(val) => match val { [INFO] [stderr] ... | [INFO] [stderr] 23 | | false [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 14 | if let Sym(ref s) = elems[0] { [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/macroexpansion.rs:17:28 [INFO] [stderr] | [INFO] [stderr] 17 | Ok(val) => match val { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 18 | | &StructFn { is_macro, .. } if is_macro => true, [INFO] [stderr] 19 | | _ => false, [INFO] [stderr] 20 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | Ok(val) => match *val { [INFO] [stderr] 18 | StructFn { is_macro, .. } if is_macro => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/macroexpansion.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / if let &StructFn { [INFO] [stderr] 36 | | ref param_syms, [INFO] [stderr] 37 | | ref body, [INFO] [stderr] 38 | | ref env, [INFO] [stderr] ... | [INFO] [stderr] 49 | | panic!("Error in macroexpansion. Symbol did not map to macro.") [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | if let StructFn { [INFO] [stderr] 36 | ref param_syms, [INFO] [stderr] 37 | ref body, [INFO] [stderr] 38 | ref env, [INFO] [stderr] 39 | .. [INFO] [stderr] 40 | } = *mac [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.22s [INFO] running `"docker" "inspect" "f456aa617b1994dab85029f15d7e9de2e43ced0aeb2b621ebaf9e2aad36d93d3"` [INFO] running `"docker" "rm" "-f" "f456aa617b1994dab85029f15d7e9de2e43ced0aeb2b621ebaf9e2aad36d93d3"` [INFO] [stdout] f456aa617b1994dab85029f15d7e9de2e43ced0aeb2b621ebaf9e2aad36d93d3