[INFO] updating cached repository AugustinLF/advent-of-code-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AugustinLF/advent-of-code-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AugustinLF/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/AugustinLF/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AugustinLF/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AugustinLF/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AugustinLF/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AugustinLF/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d2b26e4b9904cb85adbe2a6301b9bba5f679b215 [INFO] sha for GitHub repo AugustinLF/advent-of-code-2018: d2b26e4b9904cb85adbe2a6301b9bba5f679b215 [INFO] validating manifest of AugustinLF/advent-of-code-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AugustinLF/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AugustinLF/advent-of-code-2018 [INFO] finished frobbing AugustinLF/advent-of-code-2018 [INFO] frobbed toml for AugustinLF/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/AugustinLF/advent-of-code-2018/Cargo.toml [INFO] started frobbing AugustinLF/advent-of-code-2018 [INFO] finished frobbing AugustinLF/advent-of-code-2018 [INFO] frobbed toml for AugustinLF/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AugustinLF/advent-of-code-2018/Cargo.toml [INFO] crate AugustinLF/advent-of-code-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AugustinLF/advent-of-code-2018 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AugustinLF/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3a8a498dabb35117e437e58274c57e3d0b3d5587d1e8f62a80b611b6d0f22299 [INFO] running `"docker" "start" "-a" "3a8a498dabb35117e437e58274c57e3d0b3d5587d1e8f62a80b611b6d0f22299"` [INFO] [stderr] Checking advent-of-code-2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex1.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / return match elem { [INFO] [stderr] 8 | | Some(value) => generate_frequency(initial_frequency + value, input), [INFO] [stderr] 9 | | None => initial_frequency, [INFO] [stderr] 10 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 7 | match elem { [INFO] [stderr] 8 | Some(value) => generate_frequency(initial_frequency + value, input), [INFO] [stderr] 9 | None => initial_frequency, [INFO] [stderr] 10 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex1.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | return input; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex1.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return process(0, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process(0, input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex2.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return (doubles, triplets); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(doubles, triplets)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex2.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return val.0 * val.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `val.0 * val.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex2.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | return (acc.0 + doubles, acc.1 + triplets); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(acc.0 + doubles, acc.1 + triplets)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex2.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | return ids; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex2.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | return find_base_id(new_ids); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `find_base_id(new_ids)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex2.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | return calculate_checksum(ids); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `calculate_checksum(ids)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex2.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | return find_base_id(ids); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `find_base_id(ids)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex3.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return fabric; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `fabric` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex3.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / return match claims.pop() { [INFO] [stderr] 65 | | Some(claim) => get_covered_fabric_for_claims(claims, get_covered_fabric(claim, fabric)), [INFO] [stderr] 66 | | None => fabric, [INFO] [stderr] 67 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | match claims.pop() { [INFO] [stderr] 65 | Some(claim) => get_covered_fabric_for_claims(claims, get_covered_fabric(claim, fabric)), [INFO] [stderr] 66 | None => fabric, [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex3.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex3.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | return find_fabric_for_claims(claims); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `find_fabric_for_claims(claims)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `generate_frequency` [INFO] [stderr] --> src/ex1.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | fn generate_frequency(initial_frequency: i32, mut input: Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `from_string_to_frequencies` [INFO] [stderr] --> src/ex1.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | fn from_string_to_frequencies(content: String) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve_exercise` [INFO] [stderr] --> src/ex1.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn solve_exercise(process: fn(i32, Vec) -> i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `find_repeated_frequency` [INFO] [stderr] --> src/ex1.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | fn find_repeated_frequency(base_frequency: i32, input: Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_product_checksum` [INFO] [stderr] --> src/ex2.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | fn get_product_checksum(id: &str) -> (i32, i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `calculate_checksum` [INFO] [stderr] --> src/ex2.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | fn calculate_checksum(ids: Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `are_ids_similar` [INFO] [stderr] --> src/ex2.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | fn are_ids_similar<'a>(first: &'a str, second: &'a str) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_ids` [INFO] [stderr] --> src/ex2.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | fn get_ids() -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `find_base_id` [INFO] [stderr] --> src/ex2.rs:67:1 [INFO] [stderr] | [INFO] [stderr] 67 | fn find_base_id(mut ids: Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve_exercise_1` [INFO] [stderr] --> src/ex2.rs:81:1 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn solve_exercise_1() -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve_exercise_2` [INFO] [stderr] --> src/ex2.rs:87:1 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn solve_exercise_2() -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_claim` [INFO] [stderr] --> src/ex3.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | fn parse_claim<'a>(claim: &'a str) -> Claim<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_covered_fabric` [INFO] [stderr] --> src/ex3.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | fn get_covered_fabric(claim: Claim, mut fabric: HashMap) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_covered_fabric_for_claims` [INFO] [stderr] --> src/ex3.rs:60:1 [INFO] [stderr] | [INFO] [stderr] 60 | / fn get_covered_fabric_for_claims( [INFO] [stderr] 61 | | mut claims: Vec, [INFO] [stderr] 62 | | fabric: HashMap, [INFO] [stderr] 63 | | ) -> HashMap { [INFO] [stderr] ... | [INFO] [stderr] 67 | | }; [INFO] [stderr] 68 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `find_fabric_for_claims` [INFO] [stderr] --> src/ex3.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | fn find_fabric_for_claims(claims: Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve_exercise_1` [INFO] [stderr] --> src/ex3.rs:81:1 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn solve_exercise_1() -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/ex1.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / if found_frequencies.contains_key(¤t_frequency) { [INFO] [stderr] 44 | | return current_frequency; [INFO] [stderr] 45 | | } else { [INFO] [stderr] 46 | | found_frequencies.insert(current_frequency, true); [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_____________^ help: consider using: `found_frequencies.entry(current_frequency)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/ex2.rs:41:34 [INFO] [stderr] | [INFO] [stderr] 41 | while let Some(first_char) = first.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for first_char in first { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ex3.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / fn parse_claim<'a>(claim: &'a str) -> Claim<'a> { [INFO] [stderr] 17 | | let mut split_str = claim.split_whitespace(); [INFO] [stderr] 18 | | [INFO] [stderr] 19 | | let (_, id) = split_str.next().unwrap().split_at(1); [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ex3.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | .split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ex3.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | .split(":") [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ex3.rs:34:52 [INFO] [stderr] | [INFO] [stderr] 34 | let mut size = split_str.next().unwrap().split("x"); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex1.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / return match elem { [INFO] [stderr] 8 | | Some(value) => generate_frequency(initial_frequency + value, input), [INFO] [stderr] 9 | | None => initial_frequency, [INFO] [stderr] 10 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 7 | match elem { [INFO] [stderr] 8 | Some(value) => generate_frequency(initial_frequency + value, input), [INFO] [stderr] 9 | None => initial_frequency, [INFO] [stderr] 10 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex1.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | return input; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex1.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return process(0, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process(0, input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex2.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return (doubles, triplets); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(doubles, triplets)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex2.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return val.0 * val.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `val.0 * val.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex2.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | return (acc.0 + doubles, acc.1 + triplets); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(acc.0 + doubles, acc.1 + triplets)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex2.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | return ids; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex2.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | return find_base_id(new_ids); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `find_base_id(new_ids)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex2.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | return calculate_checksum(ids); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `calculate_checksum(ids)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex2.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | return find_base_id(ids); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `find_base_id(ids)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex3.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return fabric; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `fabric` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex3.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / return match claims.pop() { [INFO] [stderr] 65 | | Some(claim) => get_covered_fabric_for_claims(claims, get_covered_fabric(claim, fabric)), [INFO] [stderr] 66 | | None => fabric, [INFO] [stderr] 67 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | match claims.pop() { [INFO] [stderr] 65 | Some(claim) => get_covered_fabric_for_claims(claims, get_covered_fabric(claim, fabric)), [INFO] [stderr] 66 | None => fabric, [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex3.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ex3.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | return find_fabric_for_claims(claims); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `find_fabric_for_claims(claims)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ex3.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | assert_eq!(107043, solve_exercise_1()) [INFO] [stderr] | ^^^^^^ help: consider: `107_043` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/ex1.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / if found_frequencies.contains_key(¤t_frequency) { [INFO] [stderr] 44 | | return current_frequency; [INFO] [stderr] 45 | | } else { [INFO] [stderr] 46 | | found_frequencies.insert(current_frequency, true); [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_____________^ help: consider using: `found_frequencies.entry(current_frequency)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/ex2.rs:41:34 [INFO] [stderr] | [INFO] [stderr] 41 | while let Some(first_char) = first.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for first_char in first { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ex3.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / fn parse_claim<'a>(claim: &'a str) -> Claim<'a> { [INFO] [stderr] 17 | | let mut split_str = claim.split_whitespace(); [INFO] [stderr] 18 | | [INFO] [stderr] 19 | | let (_, id) = split_str.next().unwrap().split_at(1); [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ex3.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | .split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ex3.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | .split(":") [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ex3.rs:34:52 [INFO] [stderr] | [INFO] [stderr] 34 | let mut size = split_str.next().unwrap().split("x"); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `"docker" "inspect" "3a8a498dabb35117e437e58274c57e3d0b3d5587d1e8f62a80b611b6d0f22299"` [INFO] running `"docker" "rm" "-f" "3a8a498dabb35117e437e58274c57e3d0b3d5587d1e8f62a80b611b6d0f22299"` [INFO] [stdout] 3a8a498dabb35117e437e58274c57e3d0b3d5587d1e8f62a80b611b6d0f22299