[INFO] updating cached repository AtomicMegaNerd/learning_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AtomicMegaNerd/learning_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AtomicMegaNerd/learning_rust" "work/ex/clippy-test-run/sources/stable/gh/AtomicMegaNerd/learning_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AtomicMegaNerd/learning_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AtomicMegaNerd/learning_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AtomicMegaNerd/learning_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AtomicMegaNerd/learning_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d273a33409bbaf55a0995a94fe86968009715868 [INFO] sha for GitHub repo AtomicMegaNerd/learning_rust: d273a33409bbaf55a0995a94fe86968009715868 [INFO] validating manifest of AtomicMegaNerd/learning_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AtomicMegaNerd/learning_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AtomicMegaNerd/learning_rust [INFO] finished frobbing AtomicMegaNerd/learning_rust [INFO] frobbed toml for AtomicMegaNerd/learning_rust written to work/ex/clippy-test-run/sources/stable/gh/AtomicMegaNerd/learning_rust/Cargo.toml [INFO] started frobbing AtomicMegaNerd/learning_rust [INFO] finished frobbing AtomicMegaNerd/learning_rust [INFO] frobbed toml for AtomicMegaNerd/learning_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AtomicMegaNerd/learning_rust/Cargo.toml [INFO] crate AtomicMegaNerd/learning_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AtomicMegaNerd/learning_rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AtomicMegaNerd/learning_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e038a67a218fa598bd04be1c5bb42e541d65f453880f0d8fd28cd758d1feff00 [INFO] running `"docker" "start" "-a" "e038a67a218fa598bd04be1c5bb42e541d65f453880f0d8fd28cd758d1feff00"` [INFO] [stderr] Checking learning_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | let b: &[i32] = &a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | let c = &a[0..4]; // From 0 up to (excluding) 4 ix [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | let b: &[i32] = &a; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | let c = &a[0..4]; // From 0 up to (excluding) 4 ix [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basics.rs:3:3 [INFO] [stderr] | [INFO] [stderr] 3 | return a + b; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `a + b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basics.rs:3:3 [INFO] [stderr] | [INFO] [stderr] 3 | return a + b; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `a + b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/control_flows.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | let list_type = match is_allowed { [INFO] [stderr] | _____________________^ [INFO] [stderr] 15 | | true => "Full", [INFO] [stderr] 16 | | false => "Restricted", // no default/ _ condition can be skipped [INFO] [stderr] 17 | | // Because data type of is_allowed is boolean and all possibilities checked on conditions [INFO] [stderr] 18 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if is_allowed { "Full" } else { "Restricted" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner_while` [INFO] [stderr] --> src/control_flows.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / 'inner_while: while c2 < 6 { [INFO] [stderr] 65 | | println!("Current Value : [{}][{}]", c1, c2); [INFO] [stderr] 66 | | if c1 == 2 && c2 == 2 { [INFO] [stderr] 67 | | break 'outer_while; [INFO] [stderr] 68 | | } //kill outer_while [INFO] [stderr] 69 | | c2 += 1; [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner_loop` [INFO] [stderr] --> src/control_flows.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / 'inner_loop: loop { [INFO] [stderr] 106 | | println!("Current Value : [{}][{}]", b1, b2); [INFO] [stderr] 107 | | if b1 == 2 && b2 == 2 { [INFO] [stderr] 108 | | break 'outer_loop; // kill outer_loop [INFO] [stderr] ... | [INFO] [stderr] 112 | | b2 += 1; [INFO] [stderr] 113 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner_for` [INFO] [stderr] --> src/control_flows.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | / 'inner_for: for c2 in 1..6 { [INFO] [stderr] 144 | | println!("Current Value : [{}][{}]", c1, c2); [INFO] [stderr] 145 | | if c1 == 2 && c2 == 2 { [INFO] [stderr] 146 | | break 'outer_for; [INFO] [stderr] 147 | | } //kill outer_for [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is only used to index `group`. [INFO] [stderr] --> src/control_flows.rs:154:14 [INFO] [stderr] | [INFO] [stderr] 154 | for n in 0..group.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 154 | for in &group { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | let roar = (sauce as f64) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(sauce)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/control_flows.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | let list_type = match is_allowed { [INFO] [stderr] | _____________________^ [INFO] [stderr] 15 | | true => "Full", [INFO] [stderr] 16 | | false => "Restricted", // no default/ _ condition can be skipped [INFO] [stderr] 17 | | // Because data type of is_allowed is boolean and all possibilities checked on conditions [INFO] [stderr] 18 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if is_allowed { "Full" } else { "Restricted" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner_while` [INFO] [stderr] --> src/control_flows.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / 'inner_while: while c2 < 6 { [INFO] [stderr] 65 | | println!("Current Value : [{}][{}]", c1, c2); [INFO] [stderr] 66 | | if c1 == 2 && c2 == 2 { [INFO] [stderr] 67 | | break 'outer_while; [INFO] [stderr] 68 | | } //kill outer_while [INFO] [stderr] 69 | | c2 += 1; [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner_loop` [INFO] [stderr] --> src/control_flows.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / 'inner_loop: loop { [INFO] [stderr] 106 | | println!("Current Value : [{}][{}]", b1, b2); [INFO] [stderr] 107 | | if b1 == 2 && b2 == 2 { [INFO] [stderr] 108 | | break 'outer_loop; // kill outer_loop [INFO] [stderr] ... | [INFO] [stderr] 112 | | b2 += 1; [INFO] [stderr] 113 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner_for` [INFO] [stderr] --> src/control_flows.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | / 'inner_for: for c2 in 1..6 { [INFO] [stderr] 144 | | println!("Current Value : [{}][{}]", c1, c2); [INFO] [stderr] 145 | | if c1 == 2 && c2 == 2 { [INFO] [stderr] 146 | | break 'outer_for; [INFO] [stderr] 147 | | } //kill outer_for [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is only used to index `group`. [INFO] [stderr] --> src/control_flows.rs:154:14 [INFO] [stderr] | [INFO] [stderr] 154 | for n in 0..group.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 154 | for in &group { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | let roar = (sauce as f64) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(sauce)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.83s [INFO] running `"docker" "inspect" "e038a67a218fa598bd04be1c5bb42e541d65f453880f0d8fd28cd758d1feff00"` [INFO] running `"docker" "rm" "-f" "e038a67a218fa598bd04be1c5bb42e541d65f453880f0d8fd28cd758d1feff00"` [INFO] [stdout] e038a67a218fa598bd04be1c5bb42e541d65f453880f0d8fd28cd758d1feff00