[INFO] updating cached repository AndrewGi/ULP-Interpreter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AndrewGi/ULP-Interpreter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AndrewGi/ULP-Interpreter" "work/ex/clippy-test-run/sources/stable/gh/AndrewGi/ULP-Interpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AndrewGi/ULP-Interpreter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AndrewGi/ULP-Interpreter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AndrewGi/ULP-Interpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AndrewGi/ULP-Interpreter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 85b00ffd0177023c4ea05f41c79a2bbe1a617eed [INFO] sha for GitHub repo AndrewGi/ULP-Interpreter: 85b00ffd0177023c4ea05f41c79a2bbe1a617eed [INFO] validating manifest of AndrewGi/ULP-Interpreter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AndrewGi/ULP-Interpreter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AndrewGi/ULP-Interpreter [INFO] finished frobbing AndrewGi/ULP-Interpreter [INFO] frobbed toml for AndrewGi/ULP-Interpreter written to work/ex/clippy-test-run/sources/stable/gh/AndrewGi/ULP-Interpreter/Cargo.toml [INFO] started frobbing AndrewGi/ULP-Interpreter [INFO] finished frobbing AndrewGi/ULP-Interpreter [INFO] frobbed toml for AndrewGi/ULP-Interpreter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AndrewGi/ULP-Interpreter/Cargo.toml [INFO] crate AndrewGi/ULP-Interpreter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AndrewGi/ULP-Interpreter against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AndrewGi/ULP-Interpreter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a91ee12d8a50dff7f4fdaae23060286ab42b30fd2221318d92c5238a6d3b82dc [INFO] running `"docker" "start" "-a" "a91ee12d8a50dff7f4fdaae23060286ab42b30fd2221318d92c5238a6d3b82dc"` [INFO] [stderr] Checking ulp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ulp.rs:87:30 [INFO] [stderr] | [INFO] [stderr] 87 | self.magic_number == 0x464c457f [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x464c_457f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ulp.rs:87:30 [INFO] [stderr] | [INFO] [stderr] 87 | self.magic_number == 0x464c457f [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x464c_457f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `section` [INFO] [stderr] --> src/ulp.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | for section in &elf.sections { [INFO] [stderr] | ^^^^^^^ help: consider using `_section` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `default` [INFO] [stderr] --> src/ulp.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn default() -> ELFHeader { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ULP` [INFO] [stderr] --> src/ulp.rs:193:1 [INFO] [stderr] | [INFO] [stderr] 193 | pub struct ULP { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `section` [INFO] [stderr] --> src/ulp.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | for section in &elf.sections { [INFO] [stderr] | ^^^^^^^ help: consider using `_section` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | bytes[0] as u16 | ((bytes[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | bytes[0] as u16 | ((bytes[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | u16_from_slice(&bytes[0..2]) as u32 | ((u16_from_slice(&bytes[2..4]) as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u16_from_slice(&bytes[0..2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | u16_from_slice(&bytes[0..2]) as u32 | ((u16_from_slice(&bytes[2..4]) as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u16_from_slice(&bytes[2..4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | u32_from_slice(&bytes[0..4]) as u64 | ((u32_from_slice(&bytes[4..8]) as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32_from_slice(&bytes[0..4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:24:44 [INFO] [stderr] | [INFO] [stderr] 24 | u32_from_slice(&bytes[0..4]) as u64 | ((u32_from_slice(&bytes[4..8]) as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32_from_slice(&bytes[4..8]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ulp.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | let ref mut file_buffer = ::std::vec::Vec::new(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^-------------------------- help: try: `let file_buffer = &mut ::std::vec::Vec::new();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:216:19 [INFO] [stderr] | [INFO] [stderr] 216 | + (i * elf.header.program_header_size) as u32) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(i * elf.header.program_header_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:224:52 [INFO] [stderr] | [INFO] [stderr] 224 | (elf.header.section_header_start + (i * elf.header.section_size) as u32) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(i * elf.header.section_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method is never used: `default` [INFO] [stderr] --> src/ulp.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn default() -> ELFHeader { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ULP` [INFO] [stderr] --> src/ulp.rs:193:1 [INFO] [stderr] | [INFO] [stderr] 193 | pub struct ULP { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | bytes[0] as u16 | ((bytes[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | bytes[0] as u16 | ((bytes[1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | u16_from_slice(&bytes[0..2]) as u32 | ((u16_from_slice(&bytes[2..4]) as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u16_from_slice(&bytes[0..2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | u16_from_slice(&bytes[0..2]) as u32 | ((u16_from_slice(&bytes[2..4]) as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u16_from_slice(&bytes[2..4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | u32_from_slice(&bytes[0..4]) as u64 | ((u32_from_slice(&bytes[4..8]) as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32_from_slice(&bytes[0..4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:24:44 [INFO] [stderr] | [INFO] [stderr] 24 | u32_from_slice(&bytes[0..4]) as u64 | ((u32_from_slice(&bytes[4..8]) as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32_from_slice(&bytes[4..8]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ulp.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | let ref mut file_buffer = ::std::vec::Vec::new(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^-------------------------- help: try: `let file_buffer = &mut ::std::vec::Vec::new();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:216:19 [INFO] [stderr] | [INFO] [stderr] 216 | + (i * elf.header.program_header_size) as u32) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(i * elf.header.program_header_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ulp.rs:224:52 [INFO] [stderr] | [INFO] [stderr] 224 | (elf.header.section_header_start + (i * elf.header.section_size) as u32) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(i * elf.header.section_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `"docker" "inspect" "a91ee12d8a50dff7f4fdaae23060286ab42b30fd2221318d92c5238a6d3b82dc"` [INFO] running `"docker" "rm" "-f" "a91ee12d8a50dff7f4fdaae23060286ab42b30fd2221318d92c5238a6d3b82dc"` [INFO] [stdout] a91ee12d8a50dff7f4fdaae23060286ab42b30fd2221318d92c5238a6d3b82dc