[INFO] updating cached repository AndersonReyes/RustVM [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AndersonReyes/RustVM [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AndersonReyes/RustVM" "work/ex/clippy-test-run/sources/stable/gh/AndersonReyes/RustVM"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AndersonReyes/RustVM'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AndersonReyes/RustVM" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AndersonReyes/RustVM"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AndersonReyes/RustVM'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cb3205b2e901e276a198544ada28258419b8acb1 [INFO] sha for GitHub repo AndersonReyes/RustVM: cb3205b2e901e276a198544ada28258419b8acb1 [INFO] validating manifest of AndersonReyes/RustVM on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AndersonReyes/RustVM on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AndersonReyes/RustVM [INFO] finished frobbing AndersonReyes/RustVM [INFO] frobbed toml for AndersonReyes/RustVM written to work/ex/clippy-test-run/sources/stable/gh/AndersonReyes/RustVM/Cargo.toml [INFO] started frobbing AndersonReyes/RustVM [INFO] finished frobbing AndersonReyes/RustVM [INFO] frobbed toml for AndersonReyes/RustVM written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AndersonReyes/RustVM/Cargo.toml [INFO] crate AndersonReyes/RustVM has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AndersonReyes/RustVM against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AndersonReyes/RustVM:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 79fb69197bbe6f658a327bd7bbe126c3427c644b12948f02d27ea2c5f77a00e4 [INFO] running `"docker" "start" "-a" "79fb69197bbe6f658a327bd7bbe126c3427c644b12948f02d27ea2c5f77a00e4"` [INFO] [stderr] Checking rustvm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::VM` [INFO] [stderr] --> src/vm.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> VM { [INFO] [stderr] 13 | | VM { [INFO] [stderr] 14 | | registers: [0; 32], [INFO] [stderr] 15 | | program: vec![], [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | let result = ((self.program[self.program_counter] as u16) << 8) | self.program[self.program_counter + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.program_counter])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:41:75 [INFO] [stderr] | [INFO] [stderr] 41 | let result = ((self.program[self.program_counter] as u16) << 8) | self.program[self.program_counter + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.program_counter + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:69:44 [INFO] [stderr] | [INFO] [stderr] 69 | self.registers[register] = number as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | stdout().flush().ok().expect("Coould not flush"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::VM` [INFO] [stderr] --> src/vm.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> VM { [INFO] [stderr] 13 | | VM { [INFO] [stderr] 14 | | registers: [0; 32], [INFO] [stderr] 15 | | program: vec![], [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | let result = ((self.program[self.program_counter] as u16) << 8) | self.program[self.program_counter + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.program_counter])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:41:75 [INFO] [stderr] | [INFO] [stderr] 41 | let result = ((self.program[self.program_counter] as u16) << 8) | self.program[self.program_counter + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.program_counter + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:69:44 [INFO] [stderr] | [INFO] [stderr] 69 | self.registers[register] = number as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | stdout().flush().ok().expect("Coould not flush"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.74s [INFO] running `"docker" "inspect" "79fb69197bbe6f658a327bd7bbe126c3427c644b12948f02d27ea2c5f77a00e4"` [INFO] running `"docker" "rm" "-f" "79fb69197bbe6f658a327bd7bbe126c3427c644b12948f02d27ea2c5f77a00e4"` [INFO] [stdout] 79fb69197bbe6f658a327bd7bbe126c3427c644b12948f02d27ea2c5f77a00e4