[INFO] updating cached repository AlvinSamuelsson/stack_machine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AlvinSamuelsson/stack_machine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AlvinSamuelsson/stack_machine" "work/ex/clippy-test-run/sources/stable/gh/AlvinSamuelsson/stack_machine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AlvinSamuelsson/stack_machine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AlvinSamuelsson/stack_machine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlvinSamuelsson/stack_machine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlvinSamuelsson/stack_machine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 132bf5c40ea6fe4503262ca4c3b70d50b278b184 [INFO] sha for GitHub repo AlvinSamuelsson/stack_machine: 132bf5c40ea6fe4503262ca4c3b70d50b278b184 [INFO] validating manifest of AlvinSamuelsson/stack_machine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AlvinSamuelsson/stack_machine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AlvinSamuelsson/stack_machine [INFO] finished frobbing AlvinSamuelsson/stack_machine [INFO] frobbed toml for AlvinSamuelsson/stack_machine written to work/ex/clippy-test-run/sources/stable/gh/AlvinSamuelsson/stack_machine/Cargo.toml [INFO] started frobbing AlvinSamuelsson/stack_machine [INFO] finished frobbing AlvinSamuelsson/stack_machine [INFO] frobbed toml for AlvinSamuelsson/stack_machine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlvinSamuelsson/stack_machine/Cargo.toml [INFO] crate AlvinSamuelsson/stack_machine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AlvinSamuelsson/stack_machine against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlvinSamuelsson/stack_machine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 02028e9f22ac8df84f94d7248fef568d297679262dbb0248abe63348dd8aa43e [INFO] running `"docker" "start" "-a" "02028e9f22ac8df84f94d7248fef568d297679262dbb0248abe63348dd8aa43e"` [INFO] [stderr] Checking stack_machine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: item `stack::Stack` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/stack.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | / impl Stack { [INFO] [stderr] 6 | | [INFO] [stderr] 7 | | pub fn new() -> Stack { [INFO] [stderr] 8 | | Stack { [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `stack::Stack` [INFO] [stderr] --> src/stack.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn new() -> Stack { [INFO] [stderr] 8 | | Stack { [INFO] [stderr] 9 | | _stack: Vec::::new(), [INFO] [stderr] 10 | | } [INFO] [stderr] 11 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Default)] [INFO] [stderr] 2 | pub struct Stack { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/stack.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | if self._stack.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self._stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `stack_machine::StackMachine` [INFO] [stderr] --> src/stack_machine.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> StackMachine { [INFO] [stderr] 9 | | StackMachine { [INFO] [stderr] 10 | | stack: stack::Stack::new(), [INFO] [stderr] 11 | | } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | impl Default for stack_machine::StackMachine { [INFO] [stderr] 8 | fn default() -> Self { [INFO] [stderr] 9 | Self::new() [INFO] [stderr] 10 | } [INFO] [stderr] 11 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `stack::Stack` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/stack.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | / impl Stack { [INFO] [stderr] 6 | | [INFO] [stderr] 7 | | pub fn new() -> Stack { [INFO] [stderr] 8 | | Stack { [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `stack::Stack` [INFO] [stderr] --> src/stack.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn new() -> Stack { [INFO] [stderr] 8 | | Stack { [INFO] [stderr] 9 | | _stack: Vec::::new(), [INFO] [stderr] 10 | | } [INFO] [stderr] 11 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Default)] [INFO] [stderr] 2 | pub struct Stack { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/stack.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | if self._stack.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self._stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `stack_machine::StackMachine` [INFO] [stderr] --> src/stack_machine.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> StackMachine { [INFO] [stderr] 9 | | StackMachine { [INFO] [stderr] 10 | | stack: stack::Stack::new(), [INFO] [stderr] 11 | | } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | impl Default for stack_machine::StackMachine { [INFO] [stderr] 8 | fn default() -> Self { [INFO] [stderr] 9 | Self::new() [INFO] [stderr] 10 | } [INFO] [stderr] 11 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/stack.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | if self._stack.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self._stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:14:51 [INFO] [stderr] | [INFO] [stderr] 14 | let split_line:Vec<&str> = l.trim().split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/stack.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | if self._stack.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self._stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:14:51 [INFO] [stderr] | [INFO] [stderr] 14 | let split_line:Vec<&str> = l.trim().split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.29s [INFO] running `"docker" "inspect" "02028e9f22ac8df84f94d7248fef568d297679262dbb0248abe63348dd8aa43e"` [INFO] running `"docker" "rm" "-f" "02028e9f22ac8df84f94d7248fef568d297679262dbb0248abe63348dd8aa43e"` [INFO] [stdout] 02028e9f22ac8df84f94d7248fef568d297679262dbb0248abe63348dd8aa43e