[INFO] updating cached repository AliSchlereth/rectangles [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AliSchlereth/rectangles [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AliSchlereth/rectangles" "work/ex/clippy-test-run/sources/stable/gh/AliSchlereth/rectangles"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AliSchlereth/rectangles'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AliSchlereth/rectangles" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AliSchlereth/rectangles"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AliSchlereth/rectangles'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0f1d7b49fe710dac7e3e6523652611cdfafd0723 [INFO] sha for GitHub repo AliSchlereth/rectangles: 0f1d7b49fe710dac7e3e6523652611cdfafd0723 [INFO] validating manifest of AliSchlereth/rectangles on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AliSchlereth/rectangles on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AliSchlereth/rectangles [INFO] finished frobbing AliSchlereth/rectangles [INFO] frobbed toml for AliSchlereth/rectangles written to work/ex/clippy-test-run/sources/stable/gh/AliSchlereth/rectangles/Cargo.toml [INFO] started frobbing AliSchlereth/rectangles [INFO] finished frobbing AliSchlereth/rectangles [INFO] frobbed toml for AliSchlereth/rectangles written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AliSchlereth/rectangles/Cargo.toml [INFO] crate AliSchlereth/rectangles has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AliSchlereth/rectangles against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AliSchlereth/rectangles:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2dda9281f61f1e4cce0d9f9e7dc4f26cd0a73baba9a441ed8ff332d0145f8292 [INFO] running `"docker" "start" "-a" "2dda9281f61f1e4cce0d9f9e7dc4f26cd0a73baba9a441ed8ff332d0145f8292"` [INFO] [stderr] Checking rectangles v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / if self.length > other_rect.length && self.width > other_rect.width { [INFO] [stderr] 14 | | true [INFO] [stderr] 15 | | } else { [INFO] [stderr] 16 | | false [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `self.length > other_rect.length && self.width > other_rect.width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / if self.length > other_rect.length && self.width > other_rect.width { [INFO] [stderr] 14 | | true [INFO] [stderr] 15 | | } else { [INFO] [stderr] 16 | | false [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `self.length > other_rect.length && self.width > other_rect.width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.80s [INFO] running `"docker" "inspect" "2dda9281f61f1e4cce0d9f9e7dc4f26cd0a73baba9a441ed8ff332d0145f8292"` [INFO] running `"docker" "rm" "-f" "2dda9281f61f1e4cce0d9f9e7dc4f26cd0a73baba9a441ed8ff332d0145f8292"` [INFO] [stdout] 2dda9281f61f1e4cce0d9f9e7dc4f26cd0a73baba9a441ed8ff332d0145f8292