[INFO] updating cached repository AlexanderEkdahl/snowstorm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AlexanderEkdahl/snowstorm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AlexanderEkdahl/snowstorm" "work/ex/clippy-test-run/sources/stable/gh/AlexanderEkdahl/snowstorm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AlexanderEkdahl/snowstorm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AlexanderEkdahl/snowstorm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexanderEkdahl/snowstorm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexanderEkdahl/snowstorm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1dc19791f623d9aeb2616410d7d74f0cbfb8d74c [INFO] sha for GitHub repo AlexanderEkdahl/snowstorm: 1dc19791f623d9aeb2616410d7d74f0cbfb8d74c [INFO] validating manifest of AlexanderEkdahl/snowstorm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AlexanderEkdahl/snowstorm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AlexanderEkdahl/snowstorm [INFO] finished frobbing AlexanderEkdahl/snowstorm [INFO] frobbed toml for AlexanderEkdahl/snowstorm written to work/ex/clippy-test-run/sources/stable/gh/AlexanderEkdahl/snowstorm/Cargo.toml [INFO] started frobbing AlexanderEkdahl/snowstorm [INFO] finished frobbing AlexanderEkdahl/snowstorm [INFO] frobbed toml for AlexanderEkdahl/snowstorm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexanderEkdahl/snowstorm/Cargo.toml [INFO] crate AlexanderEkdahl/snowstorm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AlexanderEkdahl/snowstorm against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexanderEkdahl/snowstorm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f30996f415d4eca393aaa32467fbfbf2fcc9296d8ac74bdd466a8661144b4a5 [INFO] running `"docker" "start" "-a" "9f30996f415d4eca393aaa32467fbfbf2fcc9296d8ac74bdd466a8661144b4a5"` [INFO] [stderr] Checking snowstorm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | compare_type: compare_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compare_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:48:29 [INFO] [stderr] | [INFO] [stderr] 48 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:49:29 [INFO] [stderr] | [INFO] [stderr] 49 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | compare_type: compare_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compare_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:48:29 [INFO] [stderr] | [INFO] [stderr] 48 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:49:29 [INFO] [stderr] | [INFO] [stderr] 49 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:21:38 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn evaluate_values(&self, a: &u16, b: &u16) -> (bool, f32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:21:47 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn evaluate_values(&self, a: &u16, b: &u16) -> (bool, f32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:43:32 [INFO] [stderr] | [INFO] [stderr] 43 | 1.0 - (*b - *a) as f32 * 0.5 / up as f32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(*b - *a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:43:57 [INFO] [stderr] | [INFO] [stderr] 43 | 1.0 - (*b - *a) as f32 * 0.5 / up as f32 [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(up)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:45:32 [INFO] [stderr] | [INFO] [stderr] 45 | 1.0 - (*a - *b) as f32 * 0.5 / down as f32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(*a - *b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:45:57 [INFO] [stderr] | [INFO] [stderr] 45 | 1.0 - (*a - *b) as f32 * 0.5 / down as f32 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(down)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/simple.rs:41:28 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn score(&self, a: &ProductId, b: &ProductId) -> f32 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProductId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/simple.rs:41:43 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn score(&self, a: &ProductId, b: &ProductId) -> f32 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProductId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/simple.rs:53:38 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn visualize_score(&self, a: &ProductId, b: &ProductId) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProductId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/simple.rs:53:53 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn visualize_score(&self, a: &ProductId, b: &ProductId) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProductId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/simple.rs:86:46 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn find_all_matches(&self, original: &ProductId) -> Vec<(f32, ProductId)> { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProductId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parse.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn products(attributes: &Vec) -> Result, csv::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:21:38 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn evaluate_values(&self, a: &u16, b: &u16) -> (bool, f32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:21:47 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn evaluate_values(&self, a: &u16, b: &u16) -> (bool, f32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:43:32 [INFO] [stderr] | [INFO] [stderr] 43 | 1.0 - (*b - *a) as f32 * 0.5 / up as f32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(*b - *a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:43:57 [INFO] [stderr] | [INFO] [stderr] 43 | 1.0 - (*b - *a) as f32 * 0.5 / up as f32 [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(up)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:45:32 [INFO] [stderr] | [INFO] [stderr] 45 | 1.0 - (*a - *b) as f32 * 0.5 / down as f32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(*a - *b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:45:57 [INFO] [stderr] | [INFO] [stderr] 45 | 1.0 - (*a - *b) as f32 * 0.5 / down as f32 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(down)` [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/parse.rs:56:27 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn matches(products: &HashMap) -> Result, csv::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 56 | pub fn matches(products: &HashMap) -> Result, csv::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/simple.rs:41:28 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn score(&self, a: &ProductId, b: &ProductId) -> f32 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProductId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/simple.rs:41:43 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn score(&self, a: &ProductId, b: &ProductId) -> f32 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProductId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/simple.rs:53:38 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn visualize_score(&self, a: &ProductId, b: &ProductId) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProductId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/simple.rs:53:53 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn visualize_score(&self, a: &ProductId, b: &ProductId) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProductId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/simple.rs:86:46 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn find_all_matches(&self, original: &ProductId) -> Vec<(f32, ProductId)> { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ProductId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parse.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn products(attributes: &Vec) -> Result, csv::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/parse.rs:56:27 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn matches(products: &HashMap) -> Result, csv::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 56 | pub fn matches(products: &HashMap) -> Result, csv::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/train.rs:50:52 [INFO] [stderr] | [INFO] [stderr] 50 | .map(|&(score, x)| format!("({}, {})", products.get(&x).unwrap().name.clone(), score)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&products[&x]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/train.rs:50:52 [INFO] [stderr] | [INFO] [stderr] 50 | .map(|&(score, x)| format!("({}, {})", products.get(&x).unwrap().name.clone(), score)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&products[&x]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.87s [INFO] running `"docker" "inspect" "9f30996f415d4eca393aaa32467fbfbf2fcc9296d8ac74bdd466a8661144b4a5"` [INFO] running `"docker" "rm" "-f" "9f30996f415d4eca393aaa32467fbfbf2fcc9296d8ac74bdd466a8661144b4a5"` [INFO] [stdout] 9f30996f415d4eca393aaa32467fbfbf2fcc9296d8ac74bdd466a8661144b4a5