[INFO] updating cached repository AlexanderChen1989/halo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AlexanderChen1989/halo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AlexanderChen1989/halo" "work/ex/clippy-test-run/sources/stable/gh/AlexanderChen1989/halo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AlexanderChen1989/halo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AlexanderChen1989/halo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexanderChen1989/halo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexanderChen1989/halo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3f581c711c40bafe84b75df81345c179e21b7ecf [INFO] sha for GitHub repo AlexanderChen1989/halo: 3f581c711c40bafe84b75df81345c179e21b7ecf [INFO] validating manifest of AlexanderChen1989/halo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AlexanderChen1989/halo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AlexanderChen1989/halo [INFO] removed 0 missing examples [INFO] finished frobbing AlexanderChen1989/halo [INFO] frobbed toml for AlexanderChen1989/halo written to work/ex/clippy-test-run/sources/stable/gh/AlexanderChen1989/halo/Cargo.toml [INFO] started frobbing AlexanderChen1989/halo [INFO] removed 0 missing examples [INFO] finished frobbing AlexanderChen1989/halo [INFO] frobbed toml for AlexanderChen1989/halo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexanderChen1989/halo/Cargo.toml [INFO] crate AlexanderChen1989/halo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AlexanderChen1989/halo against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexanderChen1989/halo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 05e572c5d06c3264620ea725464757c2969a53295c4ed2446bba92b60a38575f [INFO] running `"docker" "start" "-a" "05e572c5d06c3264620ea725464757c2969a53295c4ed2446bba92b60a38575f"` [INFO] [stderr] Checking halo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | update: update, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `update` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | update: update, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `update` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return self.key; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return self.key; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/counter/counter.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.72s [INFO] running `"docker" "inspect" "05e572c5d06c3264620ea725464757c2969a53295c4ed2446bba92b60a38575f"` [INFO] running `"docker" "rm" "-f" "05e572c5d06c3264620ea725464757c2969a53295c4ed2446bba92b60a38575f"` [INFO] [stdout] 05e572c5d06c3264620ea725464757c2969a53295c4ed2446bba92b60a38575f