[INFO] updating cached repository AlexPikalov/rsmath [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AlexPikalov/rsmath [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AlexPikalov/rsmath" "work/ex/clippy-test-run/sources/stable/gh/AlexPikalov/rsmath"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AlexPikalov/rsmath'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AlexPikalov/rsmath" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexPikalov/rsmath"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexPikalov/rsmath'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 123492b49605cafe839b18080d3bc550392fa1b6 [INFO] sha for GitHub repo AlexPikalov/rsmath: 123492b49605cafe839b18080d3bc550392fa1b6 [INFO] validating manifest of AlexPikalov/rsmath on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AlexPikalov/rsmath on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AlexPikalov/rsmath [INFO] finished frobbing AlexPikalov/rsmath [INFO] frobbed toml for AlexPikalov/rsmath written to work/ex/clippy-test-run/sources/stable/gh/AlexPikalov/rsmath/Cargo.toml [INFO] started frobbing AlexPikalov/rsmath [INFO] finished frobbing AlexPikalov/rsmath [INFO] frobbed toml for AlexPikalov/rsmath written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexPikalov/rsmath/Cargo.toml [INFO] crate AlexPikalov/rsmath has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AlexPikalov/rsmath against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexPikalov/rsmath:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2406fafb0ee643b5c29dc5d5a6396fe882b43584e5bcfd68e7636699f7d01b1b [INFO] running `"docker" "start" "-a" "2406fafb0ee643b5c29dc5d5a6396fe882b43584e5bcfd68e7636699f7d01b1b"` [INFO] [stderr] Checking rsmath v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | / return Complex { [INFO] [stderr] 11 | | im: exp.re.exp() * exp.im.sin(), [INFO] [stderr] 12 | | re: exp.re.exp() * exp.im.cos(), [INFO] [stderr] 13 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 10 | Complex { [INFO] [stderr] 11 | im: exp.re.exp() * exp.im.sin(), [INFO] [stderr] 12 | re: exp.re.exp() * exp.im.cos(), [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / return Complex { [INFO] [stderr] 18 | | im: -self.im, [INFO] [stderr] 19 | | re: self.re, [INFO] [stderr] 20 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | Complex { [INFO] [stderr] 18 | im: -self.im, [INFO] [stderr] 19 | re: self.re, [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return (self.re.powi(2) + self.im.powi(2)).sqrt(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.re.powi(2) + self.im.powi(2)).sqrt()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return (self.im / self.re).atan(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.im / self.re).atan()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / return Complex { [INFO] [stderr] 35 | | im: norm * (-arg * p.im).exp() * (arg * p.re).sin(), [INFO] [stderr] 36 | | re: norm * (-arg * p.im).exp() * (arg * p.re).cos(), [INFO] [stderr] 37 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 34 | Complex { [INFO] [stderr] 35 | im: norm * (-arg * p.im).exp() * (arg * p.re).sin(), [INFO] [stderr] 36 | re: norm * (-arg * p.im).exp() * (arg * p.re).cos(), [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / return Complex { [INFO] [stderr] 45 | | im: arg, [INFO] [stderr] 46 | | re: norm.ln(), [INFO] [stderr] 47 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 44 | Complex { [INFO] [stderr] 45 | im: arg, [INFO] [stderr] 46 | re: norm.ln(), [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / return Complex { [INFO] [stderr] 52 | | im: -self.re.sin() * self.im.sinh(), [INFO] [stderr] 53 | | re: self.re.cos() * self.im.cosh(), [INFO] [stderr] 54 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | Complex { [INFO] [stderr] 52 | im: -self.re.sin() * self.im.sinh(), [INFO] [stderr] 53 | re: self.re.cos() * self.im.cosh(), [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / return Complex { [INFO] [stderr] 63 | | im: self.im + rhs.im, [INFO] [stderr] 64 | | re: self.re + rhs.re, [INFO] [stderr] 65 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 62 | Complex { [INFO] [stderr] 63 | im: self.im + rhs.im, [INFO] [stderr] 64 | re: self.re + rhs.re, [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | / return Complex { [INFO] [stderr] 74 | | im: self.re * rhs.im + self.im * rhs.re, [INFO] [stderr] 75 | | re: self.re * rhs.re - self.im * rhs.im, [INFO] [stderr] 76 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 73 | Complex { [INFO] [stderr] 74 | im: self.re * rhs.im + self.im * rhs.re, [INFO] [stderr] 75 | re: self.re * rhs.re - self.im * rhs.im, [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return Complex { im: 0.0, re: n }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Complex { im: 0.0, re: n }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | / return Complex { [INFO] [stderr] 11 | | im: exp.re.exp() * exp.im.sin(), [INFO] [stderr] 12 | | re: exp.re.exp() * exp.im.cos(), [INFO] [stderr] 13 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 10 | Complex { [INFO] [stderr] 11 | im: exp.re.exp() * exp.im.sin(), [INFO] [stderr] 12 | re: exp.re.exp() * exp.im.cos(), [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / return Complex { [INFO] [stderr] 18 | | im: -self.im, [INFO] [stderr] 19 | | re: self.re, [INFO] [stderr] 20 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | Complex { [INFO] [stderr] 18 | im: -self.im, [INFO] [stderr] 19 | re: self.re, [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return (self.re.powi(2) + self.im.powi(2)).sqrt(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.re.powi(2) + self.im.powi(2)).sqrt()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return (self.im / self.re).atan(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.im / self.re).atan()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / return Complex { [INFO] [stderr] 35 | | im: norm * (-arg * p.im).exp() * (arg * p.re).sin(), [INFO] [stderr] 36 | | re: norm * (-arg * p.im).exp() * (arg * p.re).cos(), [INFO] [stderr] 37 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 34 | Complex { [INFO] [stderr] 35 | im: norm * (-arg * p.im).exp() * (arg * p.re).sin(), [INFO] [stderr] 36 | re: norm * (-arg * p.im).exp() * (arg * p.re).cos(), [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / return Complex { [INFO] [stderr] 45 | | im: arg, [INFO] [stderr] 46 | | re: norm.ln(), [INFO] [stderr] 47 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 44 | Complex { [INFO] [stderr] 45 | im: arg, [INFO] [stderr] 46 | re: norm.ln(), [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / return Complex { [INFO] [stderr] 52 | | im: -self.re.sin() * self.im.sinh(), [INFO] [stderr] 53 | | re: self.re.cos() * self.im.cosh(), [INFO] [stderr] 54 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | Complex { [INFO] [stderr] 52 | im: -self.re.sin() * self.im.sinh(), [INFO] [stderr] 53 | re: self.re.cos() * self.im.cosh(), [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / return Complex { [INFO] [stderr] 63 | | im: self.im + rhs.im, [INFO] [stderr] 64 | | re: self.re + rhs.re, [INFO] [stderr] 65 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 62 | Complex { [INFO] [stderr] 63 | im: self.im + rhs.im, [INFO] [stderr] 64 | re: self.re + rhs.re, [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | / return Complex { [INFO] [stderr] 74 | | im: self.re * rhs.im + self.im * rhs.re, [INFO] [stderr] 75 | | re: self.re * rhs.re - self.im * rhs.im, [INFO] [stderr] 76 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 73 | Complex { [INFO] [stderr] 74 | im: self.re * rhs.im + self.im * rhs.re, [INFO] [stderr] 75 | re: self.re * rhs.re - self.im * rhs.im, [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/basic/complex.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return Complex { im: 0.0, re: n }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Complex { im: 0.0, re: n }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.36s [INFO] running `"docker" "inspect" "2406fafb0ee643b5c29dc5d5a6396fe882b43584e5bcfd68e7636699f7d01b1b"` [INFO] running `"docker" "rm" "-f" "2406fafb0ee643b5c29dc5d5a6396fe882b43584e5bcfd68e7636699f7d01b1b"` [INFO] [stdout] 2406fafb0ee643b5c29dc5d5a6396fe882b43584e5bcfd68e7636699f7d01b1b