[INFO] updating cached repository AlexLloyd0/house_display [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AlexLloyd0/house_display [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AlexLloyd0/house_display" "work/ex/clippy-test-run/sources/stable/gh/AlexLloyd0/house_display"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AlexLloyd0/house_display'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AlexLloyd0/house_display" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexLloyd0/house_display"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexLloyd0/house_display'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9f2975c460c0abbaf82e711e713b352aed55b1da [INFO] sha for GitHub repo AlexLloyd0/house_display: 9f2975c460c0abbaf82e711e713b352aed55b1da [INFO] validating manifest of AlexLloyd0/house_display on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AlexLloyd0/house_display on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AlexLloyd0/house_display [INFO] finished frobbing AlexLloyd0/house_display [INFO] frobbed toml for AlexLloyd0/house_display written to work/ex/clippy-test-run/sources/stable/gh/AlexLloyd0/house_display/Cargo.toml [INFO] started frobbing AlexLloyd0/house_display [INFO] finished frobbing AlexLloyd0/house_display [INFO] frobbed toml for AlexLloyd0/house_display written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexLloyd0/house_display/Cargo.toml [INFO] crate AlexLloyd0/house_display has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AlexLloyd0/house_display against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexLloyd0/house_display:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3004835c11001078e0850fe9eba15ea13a60f6364bed59762b5f7b17d14d9a7e [INFO] running `"docker" "start" "-a" "3004835c11001078e0850fe9eba15ea13a60f6364bed59762b5f7b17d14d9a7e"` [INFO] [stderr] Checking house_display v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/algorithms/maze_gen/random_traversal.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | fn char(&self) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/algorithms/maze_gen/random_traversal.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match self { [INFO] [stderr] 19 | | &MazeCell::Passage => '█', [INFO] [stderr] 20 | | &MazeCell::Wall => ' ', [INFO] [stderr] 21 | | &MazeCell::Candidate => '?', [INFO] [stderr] 22 | | &MazeCell::Unseen => ' ', [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *self { [INFO] [stderr] 19 | MazeCell::Passage => '█', [INFO] [stderr] 20 | MazeCell::Wall => ' ', [INFO] [stderr] 21 | MazeCell::Candidate => '?', [INFO] [stderr] 22 | MazeCell::Unseen => ' ', [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `ix` is only used to index `maze`. [INFO] [stderr] --> src/algorithms/maze_gen/random_traversal.rs:143:23 [INFO] [stderr] | [INFO] [stderr] 143 | for ix in 0..WIDTH { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 143 | for in maze.iter().take(WIDTH) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/algorithms/maze_gen/random_traversal.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | fn char(&self) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/algorithms/maze_gen/random_traversal.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match self { [INFO] [stderr] 19 | | &MazeCell::Passage => '█', [INFO] [stderr] 20 | | &MazeCell::Wall => ' ', [INFO] [stderr] 21 | | &MazeCell::Candidate => '?', [INFO] [stderr] 22 | | &MazeCell::Unseen => ' ', [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *self { [INFO] [stderr] 19 | MazeCell::Passage => '█', [INFO] [stderr] 20 | MazeCell::Wall => ' ', [INFO] [stderr] 21 | MazeCell::Candidate => '?', [INFO] [stderr] 22 | MazeCell::Unseen => ' ', [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `ix` is only used to index `maze`. [INFO] [stderr] --> src/algorithms/maze_gen/random_traversal.rs:143:23 [INFO] [stderr] | [INFO] [stderr] 143 | for ix in 0..WIDTH { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 143 | for in maze.iter().take(WIDTH) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.76s [INFO] running `"docker" "inspect" "3004835c11001078e0850fe9eba15ea13a60f6364bed59762b5f7b17d14d9a7e"` [INFO] running `"docker" "rm" "-f" "3004835c11001078e0850fe9eba15ea13a60f6364bed59762b5f7b17d14d9a7e"` [INFO] [stdout] 3004835c11001078e0850fe9eba15ea13a60f6364bed59762b5f7b17d14d9a7e