[INFO] updating cached repository AlexABallWebDev/rust_playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AlexABallWebDev/rust_playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AlexABallWebDev/rust_playground" "work/ex/clippy-test-run/sources/stable/gh/AlexABallWebDev/rust_playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AlexABallWebDev/rust_playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AlexABallWebDev/rust_playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexABallWebDev/rust_playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexABallWebDev/rust_playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1784c69f7bb2a7c150a86ea21e63bc1b73cb90dc [INFO] sha for GitHub repo AlexABallWebDev/rust_playground: 1784c69f7bb2a7c150a86ea21e63bc1b73cb90dc [INFO] validating manifest of AlexABallWebDev/rust_playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AlexABallWebDev/rust_playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AlexABallWebDev/rust_playground [INFO] finished frobbing AlexABallWebDev/rust_playground [INFO] frobbed toml for AlexABallWebDev/rust_playground written to work/ex/clippy-test-run/sources/stable/gh/AlexABallWebDev/rust_playground/Cargo.toml [INFO] started frobbing AlexABallWebDev/rust_playground [INFO] finished frobbing AlexABallWebDev/rust_playground [INFO] frobbed toml for AlexABallWebDev/rust_playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexABallWebDev/rust_playground/Cargo.toml [INFO] crate AlexABallWebDev/rust_playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AlexABallWebDev/rust_playground against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexABallWebDev/rust_playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7e2f25a77229e2248813beaf2c24b78f3be73d9755754d2cfdd7e11d0945d970 [INFO] running `"docker" "start" "-a" "7e2f25a77229e2248813beaf2c24b78f3be73d9755754d2cfdd7e11d0945d970"` [INFO] [stderr] Checking rust_playground v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: All variants have the same postfix: `Key` [INFO] [stderr] --> src/intro_1.rs:470:5 [INFO] [stderr] | [INFO] [stderr] 470 | / enum Keys { [INFO] [stderr] 471 | | _UpKey(String), [INFO] [stderr] 472 | | _DownKey(String), [INFO] [stderr] 473 | | _LeftKey(String), [INFO] [stderr] 474 | | _RightKey(String), [INFO] [stderr] 475 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Key` [INFO] [stderr] --> src/intro_1.rs:470:5 [INFO] [stderr] | [INFO] [stderr] 470 | / enum Keys { [INFO] [stderr] 471 | | _UpKey(String), [INFO] [stderr] 472 | | _DownKey(String), [INFO] [stderr] 473 | | _LeftKey(String), [INFO] [stderr] 474 | | _RightKey(String), [INFO] [stderr] 475 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/intro_1.rs:149:30 [INFO] [stderr] | [INFO] [stderr] 149 | fn borrow_dereference(v: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/intro_1.rs:158:38 [INFO] [stderr] | [INFO] [stderr] 158 | fn borrow_without_dereference(v: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/intro_1.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | fn count(v: &Vec, value: i32) -> usize { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/intro_1.rs:174:11 [INFO] [stderr] | [INFO] [stderr] 174 | v.into_iter().filter(|&&x| x == value).count() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: unused label `'c` [INFO] [stderr] --> src/intro_1.rs:320:13 [INFO] [stderr] | [INFO] [stderr] 320 | / 'c: loop { [INFO] [stderr] 321 | | println!("loop c"); [INFO] [stderr] 322 | | [INFO] [stderr] 323 | | if end_condition { [INFO] [stderr] ... | [INFO] [stderr] 330 | | break 'b; [INFO] [stderr] 331 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/intro_1.rs:320:13 [INFO] [stderr] | [INFO] [stderr] 320 | / 'c: loop { [INFO] [stderr] 321 | | println!("loop c"); [INFO] [stderr] 322 | | [INFO] [stderr] 323 | | if end_condition { [INFO] [stderr] ... | [INFO] [stderr] 330 | | break 'b; [INFO] [stderr] 331 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/intro_1.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | let x = loop { [INFO] [stderr] | _____________^ [INFO] [stderr] 343 | | // break acts like "return" in this context. [INFO] [stderr] 344 | | break 10; [INFO] [stderr] 345 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/intro_1.rs:352:9 [INFO] [stderr] | [INFO] [stderr] 352 | get_to_zero = get_to_zero - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `get_to_zero -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/intro_1.rs:510:9 [INFO] [stderr] | [INFO] [stderr] 510 | let ref z = u; // z gets a reference to the 10 that u owns [INFO] [stderr] | ----^^^^^----- help: try: `let z = &u;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/intro_1.rs:533:53 [INFO] [stderr] | [INFO] [stderr] 533 | Shape::Rectangle {width, height} => (width * height) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(width * height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/intro_1.rs:534:41 [INFO] [stderr] | [INFO] [stderr] 534 | Shape::Square(ref s) => (s * s) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(s * s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/intro_1.rs:535:41 [INFO] [stderr] | [INFO] [stderr] 535 | Shape::Circle(ref r) => 3.14 * (r * r), [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:45:8 [INFO] [stderr] | [INFO] [stderr] 45 | (3.141 * self.radius * self.radius) as u32 [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | let _c = _a.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `_a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/intro_1.rs:149:30 [INFO] [stderr] | [INFO] [stderr] 149 | fn borrow_dereference(v: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/intro_1.rs:158:38 [INFO] [stderr] | [INFO] [stderr] 158 | fn borrow_without_dereference(v: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/intro_1.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | fn count(v: &Vec, value: i32) -> usize { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/intro_1.rs:174:11 [INFO] [stderr] | [INFO] [stderr] 174 | v.into_iter().filter(|&&x| x == value).count() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_playground`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused label `'c` [INFO] [stderr] --> src/intro_1.rs:320:13 [INFO] [stderr] | [INFO] [stderr] 320 | / 'c: loop { [INFO] [stderr] 321 | | println!("loop c"); [INFO] [stderr] 322 | | [INFO] [stderr] 323 | | if end_condition { [INFO] [stderr] ... | [INFO] [stderr] 330 | | break 'b; [INFO] [stderr] 331 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/intro_1.rs:320:13 [INFO] [stderr] | [INFO] [stderr] 320 | / 'c: loop { [INFO] [stderr] 321 | | println!("loop c"); [INFO] [stderr] 322 | | [INFO] [stderr] 323 | | if end_condition { [INFO] [stderr] ... | [INFO] [stderr] 330 | | break 'b; [INFO] [stderr] 331 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/intro_1.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | let x = loop { [INFO] [stderr] | _____________^ [INFO] [stderr] 343 | | // break acts like "return" in this context. [INFO] [stderr] 344 | | break 10; [INFO] [stderr] 345 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/intro_1.rs:352:9 [INFO] [stderr] | [INFO] [stderr] 352 | get_to_zero = get_to_zero - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `get_to_zero -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/intro_1.rs:510:9 [INFO] [stderr] | [INFO] [stderr] 510 | let ref z = u; // z gets a reference to the 10 that u owns [INFO] [stderr] | ----^^^^^----- help: try: `let z = &u;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/intro_1.rs:533:53 [INFO] [stderr] | [INFO] [stderr] 533 | Shape::Rectangle {width, height} => (width * height) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(width * height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/intro_1.rs:534:41 [INFO] [stderr] | [INFO] [stderr] 534 | Shape::Square(ref s) => (s * s) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(s * s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/intro_1.rs:535:41 [INFO] [stderr] | [INFO] [stderr] 535 | Shape::Circle(ref r) => 3.14 * (r * r), [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:45:8 [INFO] [stderr] | [INFO] [stderr] 45 | (3.141 * self.radius * self.radius) as u32 [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | let _c = _a.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `_a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_playground`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7e2f25a77229e2248813beaf2c24b78f3be73d9755754d2cfdd7e11d0945d970"` [INFO] running `"docker" "rm" "-f" "7e2f25a77229e2248813beaf2c24b78f3be73d9755754d2cfdd7e11d0945d970"` [INFO] [stdout] 7e2f25a77229e2248813beaf2c24b78f3be73d9755754d2cfdd7e11d0945d970