[INFO] updating cached repository Addisonbean/Homespring-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Addisonbean/Homespring-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Addisonbean/Homespring-rs" "work/ex/clippy-test-run/sources/stable/gh/Addisonbean/Homespring-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Addisonbean/Homespring-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Addisonbean/Homespring-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Addisonbean/Homespring-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Addisonbean/Homespring-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 095c631be6a976751e5a5524fa3de9381f4f25f6 [INFO] sha for GitHub repo Addisonbean/Homespring-rs: 095c631be6a976751e5a5524fa3de9381f4f25f6 [INFO] validating manifest of Addisonbean/Homespring-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Addisonbean/Homespring-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Addisonbean/Homespring-rs [INFO] finished frobbing Addisonbean/Homespring-rs [INFO] frobbed toml for Addisonbean/Homespring-rs written to work/ex/clippy-test-run/sources/stable/gh/Addisonbean/Homespring-rs/Cargo.toml [INFO] started frobbing Addisonbean/Homespring-rs [INFO] finished frobbing Addisonbean/Homespring-rs [INFO] frobbed toml for Addisonbean/Homespring-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Addisonbean/Homespring-rs/Cargo.toml [INFO] crate Addisonbean/Homespring-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Addisonbean/Homespring-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Addisonbean/Homespring-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2ecb336126ed6c69f9de5ed1ea6ed11fd4aa099491bf98c699127ec6c95b2f93 [INFO] running `"docker" "start" "-a" "2ecb336126ed6c69f9de5ed1ea6ed11fd4aa099491bf98c699127ec6c95b2f93"` [INFO] [stderr] Checking homespring v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/river.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / match &self.node_type { [INFO] [stderr] 163 | | &Snowmelt => self.snowy = true, [INFO] [stderr] 164 | | &Powers => self.powered = true, [INFO] [stderr] 165 | | _ => (), [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 162 | match self.node_type { [INFO] [stderr] 163 | Snowmelt => self.snowy = true, [INFO] [stderr] 164 | Powers => self.powered = true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/river.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | / match self.borrow_child(0).find_node(name) { [INFO] [stderr] 201 | | true => return true, [INFO] [stderr] 202 | | false => (), [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if self.borrow_child(0).find_node(name) { return true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/river.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | / match self.borrow_child(i).find_node(name) { [INFO] [stderr] 209 | | true => return true, [INFO] [stderr] 210 | | false => (), [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if self.borrow_child(i).find_node(name) { return true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/river.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | / match &mut self.node_type { [INFO] [stderr] 220 | | &mut NodeType::Shallows(ref mut i) => [INFO] [stderr] 221 | | if *i > 0 { [INFO] [stderr] 222 | | *i -= 1; [INFO] [stderr] ... | [INFO] [stderr] 230 | | _ => (), [INFO] [stderr] 231 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 219 | match *(&mut self.node_type) { [INFO] [stderr] 220 | NodeType::Shallows(ref mut i) => [INFO] [stderr] 221 | if *i > 0 { [INFO] [stderr] 222 | *i -= 1; [INFO] [stderr] 223 | return [INFO] [stderr] 224 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/river.rs:344:9 [INFO] [stderr] | [INFO] [stderr] 344 | / match self.node_type { [INFO] [stderr] 345 | | HydroPower => self.destroyed = true, [INFO] [stderr] 346 | | _ => (), [INFO] [stderr] 347 | | } [INFO] [stderr] | |_________^ help: try this: `if let HydroPower = self.node_type { self.destroyed = true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/split_custom_escape.rs:31:15 [INFO] [stderr] | [INFO] [stderr] 31 | while curr.chars().last() == Some('.') || self.next_str.and_then(|s| s.chars().nth(0)) == Some('.') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `curr.ends_with('.')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/program.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match self { [INFO] [stderr] 15 | | &mut Quine => println!("In Homespring, the null program is not a quine."), [INFO] [stderr] 16 | | &mut River(..) => unimplemented!(), [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *self { [INFO] [stderr] 15 | Quine => println!("In Homespring, the null program is not a quine."), [INFO] [stderr] 16 | River(..) => unimplemented!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/program.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn to_node(self) -> Option>>> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Checking gag v0.1.9 [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/river.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / match &self.node_type { [INFO] [stderr] 163 | | &Snowmelt => self.snowy = true, [INFO] [stderr] 164 | | &Powers => self.powered = true, [INFO] [stderr] 165 | | _ => (), [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 162 | match self.node_type { [INFO] [stderr] 163 | Snowmelt => self.snowy = true, [INFO] [stderr] 164 | Powers => self.powered = true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/river.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | / match self.borrow_child(0).find_node(name) { [INFO] [stderr] 201 | | true => return true, [INFO] [stderr] 202 | | false => (), [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if self.borrow_child(0).find_node(name) { return true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/river.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | / match self.borrow_child(i).find_node(name) { [INFO] [stderr] 209 | | true => return true, [INFO] [stderr] 210 | | false => (), [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if self.borrow_child(i).find_node(name) { return true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/river.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | / match &mut self.node_type { [INFO] [stderr] 220 | | &mut NodeType::Shallows(ref mut i) => [INFO] [stderr] 221 | | if *i > 0 { [INFO] [stderr] 222 | | *i -= 1; [INFO] [stderr] ... | [INFO] [stderr] 230 | | _ => (), [INFO] [stderr] 231 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 219 | match *(&mut self.node_type) { [INFO] [stderr] 220 | NodeType::Shallows(ref mut i) => [INFO] [stderr] 221 | if *i > 0 { [INFO] [stderr] 222 | *i -= 1; [INFO] [stderr] 223 | return [INFO] [stderr] 224 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/river.rs:344:9 [INFO] [stderr] | [INFO] [stderr] 344 | / match self.node_type { [INFO] [stderr] 345 | | HydroPower => self.destroyed = true, [INFO] [stderr] 346 | | _ => (), [INFO] [stderr] 347 | | } [INFO] [stderr] | |_________^ help: try this: `if let HydroPower = self.node_type { self.destroyed = true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/split_custom_escape.rs:31:15 [INFO] [stderr] | [INFO] [stderr] 31 | while curr.chars().last() == Some('.') || self.next_str.and_then(|s| s.chars().nth(0)) == Some('.') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `curr.ends_with('.')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/program.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match self { [INFO] [stderr] 15 | | &mut Quine => println!("In Homespring, the null program is not a quine."), [INFO] [stderr] 16 | | &mut River(..) => unimplemented!(), [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *self { [INFO] [stderr] 15 | Quine => println!("In Homespring, the null program is not a quine."), [INFO] [stderr] 16 | River(..) => unimplemented!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/program.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn to_node(self) -> Option>>> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.87s [INFO] running `"docker" "inspect" "2ecb336126ed6c69f9de5ed1ea6ed11fd4aa099491bf98c699127ec6c95b2f93"` [INFO] running `"docker" "rm" "-f" "2ecb336126ed6c69f9de5ed1ea6ed11fd4aa099491bf98c699127ec6c95b2f93"` [INFO] [stdout] 2ecb336126ed6c69f9de5ed1ea6ed11fd4aa099491bf98c699127ec6c95b2f93