[INFO] updating cached repository ARomppainen/wunderpahkina-vol9 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ARomppainen/wunderpahkina-vol9 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ARomppainen/wunderpahkina-vol9" "work/ex/clippy-test-run/sources/stable/gh/ARomppainen/wunderpahkina-vol9"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ARomppainen/wunderpahkina-vol9'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ARomppainen/wunderpahkina-vol9" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ARomppainen/wunderpahkina-vol9"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ARomppainen/wunderpahkina-vol9'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9fb34835b24102fad052e1cddb05a492ba689372 [INFO] sha for GitHub repo ARomppainen/wunderpahkina-vol9: 9fb34835b24102fad052e1cddb05a492ba689372 [INFO] validating manifest of ARomppainen/wunderpahkina-vol9 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ARomppainen/wunderpahkina-vol9 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ARomppainen/wunderpahkina-vol9 [INFO] finished frobbing ARomppainen/wunderpahkina-vol9 [INFO] frobbed toml for ARomppainen/wunderpahkina-vol9 written to work/ex/clippy-test-run/sources/stable/gh/ARomppainen/wunderpahkina-vol9/Cargo.toml [INFO] started frobbing ARomppainen/wunderpahkina-vol9 [INFO] finished frobbing ARomppainen/wunderpahkina-vol9 [INFO] frobbed toml for ARomppainen/wunderpahkina-vol9 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ARomppainen/wunderpahkina-vol9/Cargo.toml [INFO] crate ARomppainen/wunderpahkina-vol9 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ARomppainen/wunderpahkina-vol9 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ARomppainen/wunderpahkina-vol9:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 09d40f49f868c8513df9bd5fdc09a272cfacaf9b70a153ff25ca07703fcbe2a7 [INFO] running `"docker" "start" "-a" "09d40f49f868c8513df9bd5fdc09a272cfacaf9b70a153ff25ca07703fcbe2a7"` [INFO] [stderr] Checking wunderpahkina_vol9 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:257:5 [INFO] [stderr] | [INFO] [stderr] 257 | return next.detect_pattern_recursive(max_depth, current_depth + 1, previous_rows); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `next.detect_pattern_recursive(max_depth, current_depth + 1, previous_rows)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:257:5 [INFO] [stderr] | [INFO] [stderr] 257 | return next.detect_pattern_recursive(max_depth, current_depth + 1, previous_rows); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `next.detect_pattern_recursive(max_depth, current_depth + 1, previous_rows)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in s.chars().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:119:14 [INFO] [stderr] | [INFO] [stderr] 119 | for c in s.chars() { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:142:20 [INFO] [stderr] | [INFO] [stderr] 142 | let insert = match self.values.contains(&num) { [INFO] [stderr] | ____________________^ [INFO] [stderr] 143 | | true => self.test_rule_2(num), [INFO] [stderr] 144 | | false => self.test_rule_1(num), [INFO] [stderr] 145 | | }; [INFO] [stderr] | |_______^ help: consider using an if/else expression: `if self.values.contains(&num) { self.test_rule_2(num) } else { self.test_rule_1(num) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:173:16 [INFO] [stderr] | [INFO] [stderr] 173 | .map(|x| match self.values.contains(x) { [INFO] [stderr] | ________________^ [INFO] [stderr] 174 | | true => 1, [INFO] [stderr] 175 | | false => 0, [INFO] [stderr] 176 | | }).sum() [INFO] [stderr] | |_______^ help: consider using an if/else expression: `if self.values.contains(x) { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in s.chars().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:119:14 [INFO] [stderr] | [INFO] [stderr] 119 | for c in s.chars() { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:142:20 [INFO] [stderr] | [INFO] [stderr] 142 | let insert = match self.values.contains(&num) { [INFO] [stderr] | ____________________^ [INFO] [stderr] 143 | | true => self.test_rule_2(num), [INFO] [stderr] 144 | | false => self.test_rule_1(num), [INFO] [stderr] 145 | | }; [INFO] [stderr] | |_______^ help: consider using an if/else expression: `if self.values.contains(&num) { self.test_rule_2(num) } else { self.test_rule_1(num) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:173:16 [INFO] [stderr] | [INFO] [stderr] 173 | .map(|x| match self.values.contains(x) { [INFO] [stderr] | ________________^ [INFO] [stderr] 174 | | true => 1, [INFO] [stderr] 175 | | false => 0, [INFO] [stderr] 176 | | }).sum() [INFO] [stderr] | |_______^ help: consider using an if/else expression: `if self.values.contains(x) { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.11s [INFO] running `"docker" "inspect" "09d40f49f868c8513df9bd5fdc09a272cfacaf9b70a153ff25ca07703fcbe2a7"` [INFO] running `"docker" "rm" "-f" "09d40f49f868c8513df9bd5fdc09a272cfacaf9b70a153ff25ca07703fcbe2a7"` [INFO] [stdout] 09d40f49f868c8513df9bd5fdc09a272cfacaf9b70a153ff25ca07703fcbe2a7