[INFO] updating cached repository 4hiziri/my-bf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/4hiziri/my-bf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/4hiziri/my-bf" "work/ex/clippy-test-run/sources/stable/gh/4hiziri/my-bf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/4hiziri/my-bf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/4hiziri/my-bf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/4hiziri/my-bf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/4hiziri/my-bf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1ede4493defcba40e0cc9e48fa0dc9dd30b940e4 [INFO] sha for GitHub repo 4hiziri/my-bf: 1ede4493defcba40e0cc9e48fa0dc9dd30b940e4 [INFO] validating manifest of 4hiziri/my-bf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of 4hiziri/my-bf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing 4hiziri/my-bf [INFO] finished frobbing 4hiziri/my-bf [INFO] frobbed toml for 4hiziri/my-bf written to work/ex/clippy-test-run/sources/stable/gh/4hiziri/my-bf/Cargo.toml [INFO] started frobbing 4hiziri/my-bf [INFO] finished frobbing 4hiziri/my-bf [INFO] frobbed toml for 4hiziri/my-bf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/4hiziri/my-bf/Cargo.toml [INFO] crate 4hiziri/my-bf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting 4hiziri/my-bf against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/4hiziri/my-bf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8643585f980f78705b2d61925af57b48018f9d825c7550e4e03d031ce58a5537 [INFO] running `"docker" "start" "-a" "8643585f980f78705b2d61925af57b48018f9d825c7550e4e03d031ce58a5537"` [INFO] [stderr] Checking brain-fucker v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | let repr = match self { [INFO] [stderr] | ____________________^ [INFO] [stderr] 20 | | &Inst::PInc => "pinc", [INFO] [stderr] 21 | | &Inst::PDec => "pdec", [INFO] [stderr] 22 | | &Inst::Inc => "inc", [INFO] [stderr] ... | [INFO] [stderr] 28 | | &Inst::Nop => "nop", [INFO] [stderr] 29 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | let repr = match *self { [INFO] [stderr] 20 | Inst::PInc => "pinc", [INFO] [stderr] 21 | Inst::PDec => "pdec", [INFO] [stderr] 22 | Inst::Inc => "inc", [INFO] [stderr] 23 | Inst::Dec => "dec", [INFO] [stderr] 24 | Inst::Put => "put", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | let repr = match self { [INFO] [stderr] | ____________________^ [INFO] [stderr] 20 | | &Inst::PInc => "pinc", [INFO] [stderr] 21 | | &Inst::PDec => "pdec", [INFO] [stderr] 22 | | &Inst::Inc => "inc", [INFO] [stderr] ... | [INFO] [stderr] 28 | | &Inst::Nop => "nop", [INFO] [stderr] 29 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | let repr = match *self { [INFO] [stderr] 20 | Inst::PInc => "pinc", [INFO] [stderr] 21 | Inst::PDec => "pdec", [INFO] [stderr] 22 | Inst::Inc => "inc", [INFO] [stderr] 23 | Inst::Dec => "dec", [INFO] [stderr] 24 | Inst::Put => "put", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | fn bgn(&mut self, exec: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Inst]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:155:29 [INFO] [stderr] | [INFO] [stderr] 155 | fn end(&mut self, exec: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Inst]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:185:30 [INFO] [stderr] | [INFO] [stderr] 185 | fn exec(&mut self, exec: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Inst]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | / match &exec[self.ip] { [INFO] [stderr] 192 | | &PInc => self.pinc(), [INFO] [stderr] 193 | | &PDec => self.pdec(), [INFO] [stderr] 194 | | &Inc => self.inc(), [INFO] [stderr] ... | [INFO] [stderr] 200 | | &Nop => self.nop(), [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 191 | match exec[self.ip] { [INFO] [stderr] 192 | PInc => self.pinc(), [INFO] [stderr] 193 | PDec => self.pdec(), [INFO] [stderr] 194 | Inc => self.inc(), [INFO] [stderr] 195 | Dec => self.dec(), [INFO] [stderr] 196 | Put => self.put(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | fn bgn(&mut self, exec: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Inst]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:155:29 [INFO] [stderr] | [INFO] [stderr] 155 | fn end(&mut self, exec: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Inst]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:185:30 [INFO] [stderr] | [INFO] [stderr] 185 | fn exec(&mut self, exec: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Inst]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | / match &exec[self.ip] { [INFO] [stderr] 192 | | &PInc => self.pinc(), [INFO] [stderr] 193 | | &PDec => self.pdec(), [INFO] [stderr] 194 | | &Inc => self.inc(), [INFO] [stderr] ... | [INFO] [stderr] 200 | | &Nop => self.nop(), [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 191 | match exec[self.ip] { [INFO] [stderr] 192 | PInc => self.pinc(), [INFO] [stderr] 193 | PDec => self.pdec(), [INFO] [stderr] 194 | Inc => self.inc(), [INFO] [stderr] 195 | Dec => self.dec(), [INFO] [stderr] 196 | Put => self.put(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.92s [INFO] running `"docker" "inspect" "8643585f980f78705b2d61925af57b48018f9d825c7550e4e03d031ce58a5537"` [INFO] running `"docker" "rm" "-f" "8643585f980f78705b2d61925af57b48018f9d825c7550e4e03d031ce58a5537"` [INFO] [stdout] 8643585f980f78705b2d61925af57b48018f9d825c7550e4e03d031ce58a5537