[INFO] updating cached repository 23prime/completion-judgment [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/23prime/completion-judgment [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/23prime/completion-judgment" "work/ex/clippy-test-run/sources/stable/gh/23prime/completion-judgment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/23prime/completion-judgment'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/23prime/completion-judgment" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/23prime/completion-judgment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/23prime/completion-judgment'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ce153eb945eb5bbfaff614494854900926cf05d8 [INFO] sha for GitHub repo 23prime/completion-judgment: ce153eb945eb5bbfaff614494854900926cf05d8 [INFO] validating manifest of 23prime/completion-judgment on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of 23prime/completion-judgment on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing 23prime/completion-judgment [INFO] finished frobbing 23prime/completion-judgment [INFO] frobbed toml for 23prime/completion-judgment written to work/ex/clippy-test-run/sources/stable/gh/23prime/completion-judgment/Cargo.toml [INFO] started frobbing 23prime/completion-judgment [INFO] finished frobbing 23prime/completion-judgment [INFO] frobbed toml for 23prime/completion-judgment written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/23prime/completion-judgment/Cargo.toml [INFO] crate 23prime/completion-judgment has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting 23prime/completion-judgment against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/23prime/completion-judgment:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69725ebbc97c5190cc1d7f430e5fc9efe6a28530355e5e77138dc39d0dbe72a8 [INFO] running `"docker" "start" "-a" "69725ebbc97c5190cc1d7f430e5fc9efe6a28530355e5e77138dc39d0dbe72a8"` [INFO] [stderr] Checking completion-judgment v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/csv.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return csv; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `csv` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/csv.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return req; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `req` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return "その他".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"その他".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:30:10 [INFO] [stderr] | [INFO] [stderr] 30 | return "基礎科目".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"基礎科目".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | return "専攻共通 必修".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"専攻共通 必修".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | return "専攻共通 選択".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"専攻共通 選択".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:36:10 [INFO] [stderr] | [INFO] [stderr] 36 | return "その他".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"その他".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:38:10 [INFO] [stderr] | [INFO] [stderr] 38 | return "教科教育(数学教育)".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"教科教育(数学教育)".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:40:10 [INFO] [stderr] | [INFO] [stderr] 40 | return "教科選択(研究)".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"教科選択(研究)".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return "教科専門(数学)".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"教科専門(数学)".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | Some(i) => return i, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / return Credit { [INFO] [stderr] 63 | | code: cd.to_string(), [INFO] [stderr] 64 | | title: title.to_string(), [INFO] [stderr] 65 | | num: ds[find_term_index("単位数", &ss)].parse().unwrap(), [INFO] [stderr] 66 | | grade: grade.to_string(), [INFO] [stderr] 67 | | group: mk_group(cd) [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 62 | Credit { [INFO] [stderr] 63 | code: cd.to_string(), [INFO] [stderr] 64 | title: title.to_string(), [INFO] [stderr] 65 | num: ds[find_term_index("単位数", &ss)].parse().unwrap(), [INFO] [stderr] 66 | grade: grade.to_string(), [INFO] [stderr] 67 | group: mk_group(cd) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:61:49 [INFO] [stderr] | [INFO] [stderr] 61 | fn print_group_num(grp: &Group, cdn: CreditNum) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:65:49 [INFO] [stderr] | [INFO] [stderr] 65 | fn print_group_num2(cds: &Credits, grp: &Group) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return cds; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `cds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | return eval; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `eval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return cd.num; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `cd.num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | return 0.0; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | return cdn; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `cdn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return cds; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `cds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | return (grp, req_num - num); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(grp, req_num - num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | return grps; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `grps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | return (grp, false, diff); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(grp, false, diff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return (grp, true, diff); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(grp, true, diff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | return jdgs; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `jdgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | return jdg; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `jdg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | return "結果: ".to_string() + rlt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"結果: ".to_string() + rlt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | return gcs; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `gcs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/csv.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return csv; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `csv` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/csv.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return req; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `req` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return "その他".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"その他".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:30:10 [INFO] [stderr] | [INFO] [stderr] 30 | return "基礎科目".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"基礎科目".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | return "専攻共通 必修".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"専攻共通 必修".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | return "専攻共通 選択".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"専攻共通 選択".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:36:10 [INFO] [stderr] | [INFO] [stderr] 36 | return "その他".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"その他".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:38:10 [INFO] [stderr] | [INFO] [stderr] 38 | return "教科教育(数学教育)".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"教科教育(数学教育)".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:40:10 [INFO] [stderr] | [INFO] [stderr] 40 | return "教科選択(研究)".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"教科選択(研究)".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return "教科専門(数学)".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"教科専門(数学)".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | Some(i) => return i, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / return Credit { [INFO] [stderr] 63 | | code: cd.to_string(), [INFO] [stderr] 64 | | title: title.to_string(), [INFO] [stderr] 65 | | num: ds[find_term_index("単位数", &ss)].parse().unwrap(), [INFO] [stderr] 66 | | grade: grade.to_string(), [INFO] [stderr] 67 | | group: mk_group(cd) [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 62 | Credit { [INFO] [stderr] 63 | code: cd.to_string(), [INFO] [stderr] 64 | title: title.to_string(), [INFO] [stderr] 65 | num: ds[find_term_index("単位数", &ss)].parse().unwrap(), [INFO] [stderr] 66 | grade: grade.to_string(), [INFO] [stderr] 67 | group: mk_group(cd) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:61:49 [INFO] [stderr] | [INFO] [stderr] 61 | fn print_group_num(grp: &Group, cdn: CreditNum) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:65:49 [INFO] [stderr] | [INFO] [stderr] 65 | fn print_group_num2(cds: &Credits, grp: &Group) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return cds; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `cds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | return eval; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `eval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return cd.num; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `cd.num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | return 0.0; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | return cdn; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `cdn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return cds; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `cds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | return (grp, req_num - num); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(grp, req_num - num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | return grps; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `grps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | return (grp, false, diff); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(grp, false, diff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return (grp, true, diff); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(grp, true, diff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | return jdgs; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `jdgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | return jdg; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `jdg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | return "結果: ".to_string() + rlt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"結果: ".to_string() + rlt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | return gcs; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `gcs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rules.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn mk_group(cd: &Code) -> Group { [INFO] [stderr] | ^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rules.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn mk_group(cd: &Code) -> Group { [INFO] [stderr] | ^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rules.rs:48:34 [INFO] [stderr] | [INFO] [stderr] 48 | fn find_term_index (s: &str, ss: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/rules.rs:49:35 [INFO] [stderr] | [INFO] [stderr] 49 | let idx = ss.iter().position(|&ref ssi| ssi == &s); [INFO] [stderr] | ^^^^^^^^ help: try removing the `&ref` part and just keep: `ssi` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rules.rs:49:45 [INFO] [stderr] | [INFO] [stderr] 49 | let idx = ss.iter().position(|&ref ssi| ssi == &s); [INFO] [stderr] | ^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rules.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn mk_credit(ss: &Vec, ds: &Vec) -> Credit { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rules.rs:57:40 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn mk_credit(ss: &Vec, ds: &Vec) -> Credit { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rules.rs:48:34 [INFO] [stderr] | [INFO] [stderr] 48 | fn find_term_index (s: &str, ss: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/rules.rs:49:35 [INFO] [stderr] | [INFO] [stderr] 49 | let idx = ss.iter().position(|&ref ssi| ssi == &s); [INFO] [stderr] | ^^^^^^^^ help: try removing the `&ref` part and just keep: `ssi` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rules.rs:49:45 [INFO] [stderr] | [INFO] [stderr] 49 | let idx = ss.iter().position(|&ref ssi| ssi == &s); [INFO] [stderr] | ^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rules.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn mk_credit(ss: &Vec, ds: &Vec) -> Credit { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rules.rs:57:40 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn mk_credit(ss: &Vec, ds: &Vec) -> Credit { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:61:25 [INFO] [stderr] | [INFO] [stderr] 61 | fn print_group_num(grp: &Group, cdn: CreditNum) -> () { [INFO] [stderr] | ^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:61:25 [INFO] [stderr] | [INFO] [stderr] 61 | fn print_group_num(grp: &Group, cdn: CreditNum) -> () { [INFO] [stderr] | ^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:65:26 [INFO] [stderr] | [INFO] [stderr] 65 | fn print_group_num2(cds: &Credits, grp: &Group) -> () { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] 66 | let fcds = filter_group(cds.clone(), &grp); [INFO] [stderr] | ----------- help: change `cds.clone()` to: `cds.to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:65:41 [INFO] [stderr] | [INFO] [stderr] 65 | fn print_group_num2(cds: &Credits, grp: &Group) -> () { [INFO] [stderr] | ^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:65:26 [INFO] [stderr] | [INFO] [stderr] 65 | fn print_group_num2(cds: &Credits, grp: &Group) -> () { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] 66 | let fcds = filter_group(cds.clone(), &grp); [INFO] [stderr] | ----------- help: change `cds.clone()` to: `cds.to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | let &ref terms = &csv[0]; [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `&ref` part and just keep: `terms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:65:41 [INFO] [stderr] | [INFO] [stderr] 65 | fn print_group_num2(cds: &Credits, grp: &Group) -> () { [INFO] [stderr] | ^^^^^^ help: change this to: `&str` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:86:22 [INFO] [stderr] | [INFO] [stderr] 86 | fn is_available(grd: &Grade) -> bool { [INFO] [stderr] | ^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:107:26 [INFO] [stderr] | [INFO] [stderr] 107 | fn count_credit_num(cds: &Credits) -> CreditNum { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/main.rs:109:29 [INFO] [stderr] | [INFO] [stderr] 109 | .map(|&ref cd| available_credit_num(cd)) [INFO] [stderr] | ^^^^^^^ help: try removing the `&ref` part and just keep: `cd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:116:40 [INFO] [stderr] | [INFO] [stderr] 116 | fn filter_group(mut cds: Credits, grp: &Group) -> Credits { [INFO] [stderr] | ^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | let &ref terms = &csv[0]; [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `&ref` part and just keep: `terms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:124:35 [INFO] [stderr] | [INFO] [stderr] 124 | fn difference (cds: Credits, grp: &Group, req: Require) -> (&Group, CreditNum) { [INFO] [stderr] | ^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:86:22 [INFO] [stderr] | [INFO] [stderr] 86 | fn is_available(grd: &Grade) -> bool { [INFO] [stderr] | ^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:107:26 [INFO] [stderr] | [INFO] [stderr] 107 | fn count_credit_num(cds: &Credits) -> CreditNum { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/main.rs:109:29 [INFO] [stderr] | [INFO] [stderr] 109 | .map(|&ref cd| available_credit_num(cd)) [INFO] [stderr] | ^^^^^^^ help: try removing the `&ref` part and just keep: `cd` [INFO] [stderr] | [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | fn judge_groups(cds: &Credits, req: &Require) -> Vec<(Group, bool, CreditNum)> { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:116:40 [INFO] [stderr] | [INFO] [stderr] 116 | fn filter_group(mut cds: Credits, grp: &Group) -> Credits { [INFO] [stderr] | ^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/main.rs:157:26 [INFO] [stderr] | [INFO] [stderr] 157 | .map(|&ref grp| judge_group(cds.clone(), grp.clone(), req.clone())) [INFO] [stderr] | ^^^^^^^^ help: try removing the `&ref` part and just keep: `grp` [INFO] [stderr] --> src/main.rs:124:35 [INFO] [stderr] | [INFO] [stderr] 124 | fn difference (cds: Credits, grp: &Group, req: Require) -> (&Group, CreditNum) { [INFO] [stderr] | ^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | fn judge_groups(cds: &Credits, req: &Require) -> Vec<(Group, bool, CreditNum)> { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/main.rs:157:26 [INFO] [stderr] | [INFO] [stderr] 157 | .map(|&ref grp| judge_group(cds.clone(), grp.clone(), req.clone())) [INFO] [stderr] | ^^^^^^^^ help: try removing the `&ref` part and just keep: `grp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:165:15 [INFO] [stderr] | [INFO] [stderr] 165 | fn judge(cds: &Credits, req: &Require) -> bool { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:175:20 [INFO] [stderr] | [INFO] [stderr] 175 | fn get_result(cds: &Credits, req: &Require) -> String { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:189:48 [INFO] [stderr] | [INFO] [stderr] 189 | .map(|(g, _, c)| (g.clone(), c.clone())) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:165:15 [INFO] [stderr] | [INFO] [stderr] 165 | fn judge(cds: &Credits, req: &Require) -> bool { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:175:20 [INFO] [stderr] | [INFO] [stderr] 175 | fn get_result(cds: &Credits, req: &Require) -> String { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:189:48 [INFO] [stderr] | [INFO] [stderr] 189 | .map(|(g, _, c)| (g.clone(), c.clone())) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.18s [INFO] running `"docker" "inspect" "69725ebbc97c5190cc1d7f430e5fc9efe6a28530355e5e77138dc39d0dbe72a8"` [INFO] running `"docker" "rm" "-f" "69725ebbc97c5190cc1d7f430e5fc9efe6a28530355e5e77138dc39d0dbe72a8"` [INFO] [stdout] 69725ebbc97c5190cc1d7f430e5fc9efe6a28530355e5e77138dc39d0dbe72a8