[INFO] updating cached repository 1011X/REL-16 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/1011X/REL-16 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/1011X/REL-16" "work/ex/clippy-test-run/sources/stable/gh/1011X/REL-16"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/1011X/REL-16'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/1011X/REL-16" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/1011X/REL-16"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/1011X/REL-16'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 80925465663807047026012eccbc067074a4f122 [INFO] sha for GitHub repo 1011X/REL-16: 80925465663807047026012eccbc067074a4f122 [INFO] validating manifest of 1011X/REL-16 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of 1011X/REL-16 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing 1011X/REL-16 [INFO] finished frobbing 1011X/REL-16 [INFO] frobbed toml for 1011X/REL-16 written to work/ex/clippy-test-run/sources/stable/gh/1011X/REL-16/Cargo.toml [INFO] started frobbing 1011X/REL-16 [INFO] finished frobbing 1011X/REL-16 [INFO] frobbed toml for 1011X/REL-16 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/1011X/REL-16/Cargo.toml [INFO] crate 1011X/REL-16 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting 1011X/REL-16 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/1011X/REL-16:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 44c08a6940b73f87fa2a103157d7084e44444f416c83944d4db4f6610b837c85 [INFO] running `"docker" "start" "-a" "44c08a6940b73f87fa2a103157d7084e44444f416c83944d4db4f6610b837c85"` [INFO] [stderr] Checking rel v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: method is never used: `mneu_usage` [INFO] [stderr] --> src/isa/op.rs:339:2 [INFO] [stderr] | [INFO] [stderr] 339 | fn mneu_usage(s: &str) -> &'static str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mneu_usage` [INFO] [stderr] --> src/isa/op.rs:339:2 [INFO] [stderr] | [INFO] [stderr] 339 | fn mneu_usage(s: &str) -> &'static str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/vm/cpu.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | print!("{:04x}]\n", self.reg[BP]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/vm/cpu.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | print!("{:04x}]\n", self.reg[BP]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/vm/cpu.rs:239:11 [INFO] [stderr] | [INFO] [stderr] 239 | Op::IO(r, p) => { [INFO] [stderr] | ^ help: consider using `_r` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/vm/cpu.rs:239:14 [INFO] [stderr] | [INFO] [stderr] 239 | Op::IO(r, p) => { [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mneu_usage` [INFO] [stderr] --> src/isa/op.rs:339:2 [INFO] [stderr] | [INFO] [stderr] 339 | fn mneu_usage(s: &str) -> &'static str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `ALL_REGISTERS` [INFO] [stderr] --> src/isa/reg.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / pub static ALL_REGISTERS: [Reg; 8] = [ [INFO] [stderr] 19 | | Reg::R0, Reg::R1, Reg::R2, Reg::R3, Reg::R4, Reg::R5, [INFO] [stderr] 20 | | Reg::R6, Reg::SP, [INFO] [stderr] 21 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 39 [INFO] [stderr] --> src/vm/cpu.rs:54:2 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn step(&mut self) -> bool { [INFO] [stderr] | _____^ [INFO] [stderr] 55 | | if self.logging_enabled { [INFO] [stderr] 56 | | println!("pc = {:04x} br = {:04x} dir = {}", self.pc, self.br, self.dir); [INFO] [stderr] 57 | | [INFO] [stderr] ... | [INFO] [stderr] 351 | | false [INFO] [stderr] 352 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm/cpu.rs:193:23 [INFO] [stderr] | [INFO] [stderr] 193 | r = r.rotate_left(self.reg[ro] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.reg[ro])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm/cpu.rs:203:24 [INFO] [stderr] | [INFO] [stderr] 203 | r = r.rotate_right(self.reg[ro] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.reg[ro])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm/cpu.rs:211:20 [INFO] [stderr] | [INFO] [stderr] 211 | self.reg[r] ^= v as u16, [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm/cpu.rs:217:24 [INFO] [stderr] | [INFO] [stderr] 217 | a = a.wrapping_add(i as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm/cpu.rs:227:24 [INFO] [stderr] | [INFO] [stderr] 227 | s = s.wrapping_sub(i as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm/cpu.rs:234:43 [INFO] [stderr] | [INFO] [stderr] 234 | self.reg[r] = self.reg[r].rotate_left(v as u32), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm/cpu.rs:237:44 [INFO] [stderr] | [INFO] [stderr] 237 | self.reg[r] = self.reg[r].rotate_right(v as u32), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/vm/cpu.rs:239:11 [INFO] [stderr] | [INFO] [stderr] 239 | Op::IO(r, p) => { [INFO] [stderr] | ^ help: consider using `_r` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/vm/cpu.rs:239:14 [INFO] [stderr] | [INFO] [stderr] 239 | Op::IO(r, p) => { [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mneu_usage` [INFO] [stderr] --> src/isa/op.rs:339:2 [INFO] [stderr] | [INFO] [stderr] 339 | fn mneu_usage(s: &str) -> &'static str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `ALL_REGISTERS` [INFO] [stderr] --> src/isa/reg.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / pub static ALL_REGISTERS: [Reg; 8] = [ [INFO] [stderr] 19 | | Reg::R0, Reg::R1, Reg::R2, Reg::R3, Reg::R4, Reg::R5, [INFO] [stderr] 20 | | Reg::R6, Reg::SP, [INFO] [stderr] 21 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 39 [INFO] [stderr] --> src/vm/cpu.rs:54:2 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn step(&mut self) -> bool { [INFO] [stderr] | _____^ [INFO] [stderr] 55 | | if self.logging_enabled { [INFO] [stderr] 56 | | println!("pc = {:04x} br = {:04x} dir = {}", self.pc, self.br, self.dir); [INFO] [stderr] 57 | | [INFO] [stderr] ... | [INFO] [stderr] 351 | | false [INFO] [stderr] 352 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm/cpu.rs:193:23 [INFO] [stderr] | [INFO] [stderr] 193 | r = r.rotate_left(self.reg[ro] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.reg[ro])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm/cpu.rs:203:24 [INFO] [stderr] | [INFO] [stderr] 203 | r = r.rotate_right(self.reg[ro] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.reg[ro])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm/cpu.rs:211:20 [INFO] [stderr] | [INFO] [stderr] 211 | self.reg[r] ^= v as u16, [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm/cpu.rs:217:24 [INFO] [stderr] | [INFO] [stderr] 217 | a = a.wrapping_add(i as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm/cpu.rs:227:24 [INFO] [stderr] | [INFO] [stderr] 227 | s = s.wrapping_sub(i as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm/cpu.rs:234:43 [INFO] [stderr] | [INFO] [stderr] 234 | self.reg[r] = self.reg[r].rotate_left(v as u32), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm/cpu.rs:237:44 [INFO] [stderr] | [INFO] [stderr] 237 | self.reg[r] = self.reg[r].rotate_right(v as u32), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.42s [INFO] running `"docker" "inspect" "44c08a6940b73f87fa2a103157d7084e44444f416c83944d4db4f6610b837c85"` [INFO] running `"docker" "rm" "-f" "44c08a6940b73f87fa2a103157d7084e44444f416c83944d4db4f6610b837c85"` [INFO] [stdout] 44c08a6940b73f87fa2a103157d7084e44444f416c83944d4db4f6610b837c85