[INFO] updating cached repository 0nkery/rust-monkey [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/0nkery/rust-monkey [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/0nkery/rust-monkey" "work/ex/clippy-test-run/sources/stable/gh/0nkery/rust-monkey"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/0nkery/rust-monkey'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/0nkery/rust-monkey" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/0nkery/rust-monkey"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/0nkery/rust-monkey'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8d443e9211a9a3b6fc0bdd2c217365a82d006275 [INFO] sha for GitHub repo 0nkery/rust-monkey: 8d443e9211a9a3b6fc0bdd2c217365a82d006275 [INFO] validating manifest of 0nkery/rust-monkey on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of 0nkery/rust-monkey on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing 0nkery/rust-monkey [INFO] finished frobbing 0nkery/rust-monkey [INFO] frobbed toml for 0nkery/rust-monkey written to work/ex/clippy-test-run/sources/stable/gh/0nkery/rust-monkey/Cargo.toml [INFO] started frobbing 0nkery/rust-monkey [INFO] finished frobbing 0nkery/rust-monkey [INFO] frobbed toml for 0nkery/rust-monkey written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/0nkery/rust-monkey/Cargo.toml [INFO] crate 0nkery/rust-monkey has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting 0nkery/rust-monkey against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/0nkery/rust-monkey:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 60e3787a6ee9d97a85a2c5d32e228de98dd68004d77b4eec5927ffb1f1856141 [INFO] running `"docker" "start" "-a" "60e3787a6ee9d97a85a2c5d32e228de98dd68004d77b4eec5927ffb1f1856141"` [INFO] [stderr] Checking users v0.5.2 [INFO] [stderr] Checking monkey v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | literal: literal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `literal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/repl.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | write!(&mut out, "{}\n", evaluated.inspect()).expect("Failed to write to stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/repl.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | write!(out, "{}\n", err).expect("Failed to write to stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | cur_token: cur_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | peek_token: peek_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peek_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | statements: statements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `statements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:195:21 [INFO] [stderr] | [INFO] [stderr] 195 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:220:17 [INFO] [stderr] | [INFO] [stderr] 220 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | pairs: pairs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pairs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:328:13 [INFO] [stderr] | [INFO] [stderr] 328 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | alternative: alternative, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alternative` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:357:13 [INFO] [stderr] | [INFO] [stderr] 357 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:407:17 [INFO] [stderr] | [INFO] [stderr] 407 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:408:17 [INFO] [stderr] | [INFO] [stderr] 408 | operator: operator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:453:25 [INFO] [stderr] | [INFO] [stderr] 453 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:483:13 [INFO] [stderr] | [INFO] [stderr] 483 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:500:17 [INFO] [stderr] | [INFO] [stderr] 500 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | builtins: builtins, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `builtins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | literal: literal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `literal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/repl.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | write!(&mut out, "{}\n", evaluated.inspect()).expect("Failed to write to stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/repl.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | write!(out, "{}\n", err).expect("Failed to write to stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | cur_token: cur_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | peek_token: peek_token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peek_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | statements: statements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `statements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:195:21 [INFO] [stderr] | [INFO] [stderr] 195 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:220:17 [INFO] [stderr] | [INFO] [stderr] 220 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | pairs: pairs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pairs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:328:13 [INFO] [stderr] | [INFO] [stderr] 328 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | alternative: alternative, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alternative` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:357:13 [INFO] [stderr] | [INFO] [stderr] 357 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:407:17 [INFO] [stderr] | [INFO] [stderr] 407 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:408:17 [INFO] [stderr] | [INFO] [stderr] 408 | operator: operator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:453:25 [INFO] [stderr] | [INFO] [stderr] 453 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:483:13 [INFO] [stderr] | [INFO] [stderr] 483 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:500:17 [INFO] [stderr] | [INFO] [stderr] 500 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | builtins: builtins, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `builtins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | return EOF; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `EOF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | return self.input.chars().nth(self.read_position).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.input.chars().nth(self.read_position).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/repl.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | const PROMPT: &'static str = ">> "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ast.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | s [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ast.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | let s = match *self { [INFO] [stderr] | _________________^ [INFO] [stderr] 41 | | Statement::Let { ref name, ref value, .. } => { [INFO] [stderr] 42 | | format!("{} {} = {};", self.token_literal(), name.string(), value.string()) [INFO] [stderr] 43 | | } [INFO] [stderr] ... | [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/eval.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | return return_val; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `return_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/eval.rs:91:21 [INFO] [stderr] | [INFO] [stderr] 91 | return Object::ReturnValue(Box::new(return_val)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Object::ReturnValue(Box::new(return_val))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | return EOF; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `EOF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | return self.input.chars().nth(self.read_position).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.input.chars().nth(self.read_position).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/repl.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | const PROMPT: &'static str = ">> "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ast.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | s [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ast.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | let s = match *self { [INFO] [stderr] | _________________^ [INFO] [stderr] 41 | | Statement::Let { ref name, ref value, .. } => { [INFO] [stderr] 42 | | format!("{} {} = {};", self.token_literal(), name.string(), value.string()) [INFO] [stderr] 43 | | } [INFO] [stderr] ... | [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/eval.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | return return_val; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `return_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/eval.rs:91:21 [INFO] [stderr] | [INFO] [stderr] 91 | return Object::ReturnValue(Box::new(return_val)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Object::ReturnValue(Box::new(return_val))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the `ch @ _` pattern can be written as just `ch` [INFO] [stderr] --> src/lexer.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | ch @ _ if self.is_letter(ch) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `ch @ _` pattern can be written as just `ch` [INFO] [stderr] --> src/lexer.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | ch @ _ if ch.is_digit(10) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/repl.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | if p.errors().len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!p.errors().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ast.rs:53:61 [INFO] [stderr] | [INFO] [stderr] 53 | Statement::Expression { ref expression, .. } => format!("{}", expression.string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `expression.string().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ast.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | / let mut appendix = String::new(); [INFO] [stderr] 160 | | if alternative.is_some() { [INFO] [stderr] 161 | | appendix = format!("else {}", alternative.as_ref().unwrap().string()); [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let appendix = if alternative.is_some() { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { String::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast.rs:212:12 [INFO] [stderr] | [INFO] [stderr] 212 | if self.statements.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.statements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / if value.is_none() { [INFO] [stderr] 75 | | return None; [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `value?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: the `tt @ _` pattern can be written as just `tt` [INFO] [stderr] --> src/parser.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | ref tt @ _ => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | / if value.is_none() { [INFO] [stderr] 245 | | return None; [INFO] [stderr] 246 | | } [INFO] [stderr] | |_____________^ help: replace_it_with: `value?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | / if condition.is_none() { [INFO] [stderr] 296 | | return None; [INFO] [stderr] 297 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `condition?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:308:9 [INFO] [stderr] | [INFO] [stderr] 308 | / if consequence.is_none() { [INFO] [stderr] 309 | | return None; [INFO] [stderr] 310 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `consequence?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:343:9 [INFO] [stderr] | [INFO] [stderr] 343 | / if parameters.is_none() { [INFO] [stderr] 344 | | return None; [INFO] [stderr] 345 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `parameters?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:352:9 [INFO] [stderr] | [INFO] [stderr] 352 | / if body.is_none() { [INFO] [stderr] 353 | | return None; [INFO] [stderr] 354 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `body?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: the `tt @ _` pattern can be written as just `tt` [INFO] [stderr] --> src/parser.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | ref tt @ _ => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:478:9 [INFO] [stderr] | [INFO] [stderr] 478 | / if args.is_none() { [INFO] [stderr] 479 | | return None; [INFO] [stderr] 480 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `args?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:494:9 [INFO] [stderr] | [INFO] [stderr] 494 | / if index.is_none() { [INFO] [stderr] 495 | | return None; [INFO] [stderr] 496 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `index?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:519:9 [INFO] [stderr] | [INFO] [stderr] 519 | / if expr.is_none() { [INFO] [stderr] 520 | | return None; [INFO] [stderr] 521 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `expr?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:529:13 [INFO] [stderr] | [INFO] [stderr] 529 | / if expr.is_none() { [INFO] [stderr] 530 | | return None; [INFO] [stderr] 531 | | } [INFO] [stderr] | |_____________^ help: replace_it_with: `expr?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/object.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / Function { [INFO] [stderr] 39 | | parameters: Vec, [INFO] [stderr] 40 | | body: Statement, [INFO] [stderr] 41 | | env: Env, [INFO] [stderr] 42 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/object.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / Function { [INFO] [stderr] 39 | | parameters: Vec, [INFO] [stderr] 40 | | body: Statement, [INFO] [stderr] 41 | | env: Env, [INFO] [stderr] 42 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/object.rs:53:40 [INFO] [stderr] | [INFO] [stderr] 53 | Object::String(ref val) => format!("{}", val), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `val.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/eval.rs:52:42 [INFO] [stderr] | [INFO] [stderr] 52 | fn eval_statements(&mut self, stmts: &Vec, nested: bool) -> Object { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Statement]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the `r @ _` pattern can be written as just `r` [INFO] [stderr] --> src/eval.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | r @ _ => Object::Error(format!("Unknown operator: -{}", r)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `o @ _` pattern can be written as just `o` [INFO] [stderr] --> src/builtins.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | ref o @ _ => Object::Error(format!("Argument to 'len' is not supported. Got {}", o)), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builtins.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if elems.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!elems.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `ch @ _` pattern can be written as just `ch` [INFO] [stderr] --> src/lexer.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | ch @ _ if self.is_letter(ch) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `ch @ _` pattern can be written as just `ch` [INFO] [stderr] --> src/lexer.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | ch @ _ if ch.is_digit(10) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/repl.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | if p.errors().len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!p.errors().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ast.rs:53:61 [INFO] [stderr] | [INFO] [stderr] 53 | Statement::Expression { ref expression, .. } => format!("{}", expression.string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `expression.string().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ast.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | / let mut appendix = String::new(); [INFO] [stderr] 160 | | if alternative.is_some() { [INFO] [stderr] 161 | | appendix = format!("else {}", alternative.as_ref().unwrap().string()); [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let appendix = if alternative.is_some() { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { String::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast.rs:212:12 [INFO] [stderr] | [INFO] [stderr] 212 | if self.statements.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.statements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / if value.is_none() { [INFO] [stderr] 75 | | return None; [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `value?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: the `tt @ _` pattern can be written as just `tt` [INFO] [stderr] --> src/parser.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | ref tt @ _ => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | / if value.is_none() { [INFO] [stderr] 245 | | return None; [INFO] [stderr] 246 | | } [INFO] [stderr] | |_____________^ help: replace_it_with: `value?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | / if condition.is_none() { [INFO] [stderr] 296 | | return None; [INFO] [stderr] 297 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `condition?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:308:9 [INFO] [stderr] | [INFO] [stderr] 308 | / if consequence.is_none() { [INFO] [stderr] 309 | | return None; [INFO] [stderr] 310 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `consequence?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:343:9 [INFO] [stderr] | [INFO] [stderr] 343 | / if parameters.is_none() { [INFO] [stderr] 344 | | return None; [INFO] [stderr] 345 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `parameters?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:352:9 [INFO] [stderr] | [INFO] [stderr] 352 | / if body.is_none() { [INFO] [stderr] 353 | | return None; [INFO] [stderr] 354 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `body?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: the `tt @ _` pattern can be written as just `tt` [INFO] [stderr] --> src/parser.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | ref tt @ _ => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:478:9 [INFO] [stderr] | [INFO] [stderr] 478 | / if args.is_none() { [INFO] [stderr] 479 | | return None; [INFO] [stderr] 480 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `args?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:494:9 [INFO] [stderr] | [INFO] [stderr] 494 | / if index.is_none() { [INFO] [stderr] 495 | | return None; [INFO] [stderr] 496 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `index?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:519:9 [INFO] [stderr] | [INFO] [stderr] 519 | / if expr.is_none() { [INFO] [stderr] 520 | | return None; [INFO] [stderr] 521 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `expr?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/parser.rs:529:13 [INFO] [stderr] | [INFO] [stderr] 529 | / if expr.is_none() { [INFO] [stderr] 530 | | return None; [INFO] [stderr] 531 | | } [INFO] [stderr] | |_____________^ help: replace_it_with: `expr?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:580:1 [INFO] [stderr] | [INFO] [stderr] 580 | / fn check_parser_errors<'a>(parser: &'a Parser) { [INFO] [stderr] 581 | | if parser.errors.len() == 0 { [INFO] [stderr] 582 | | return; [INFO] [stderr] 583 | | } [INFO] [stderr] ... | [INFO] [stderr] 587 | | panic!("There are parser errors!"); [INFO] [stderr] 588 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:581:8 [INFO] [stderr] | [INFO] [stderr] 581 | if parser.errors.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parser.errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/object.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / Function { [INFO] [stderr] 39 | | parameters: Vec, [INFO] [stderr] 40 | | body: Statement, [INFO] [stderr] 41 | | env: Env, [INFO] [stderr] 42 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/object.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / Function { [INFO] [stderr] 39 | | parameters: Vec, [INFO] [stderr] 40 | | body: Statement, [INFO] [stderr] 41 | | env: Env, [INFO] [stderr] 42 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/object.rs:53:40 [INFO] [stderr] | [INFO] [stderr] 53 | Object::String(ref val) => format!("{}", val), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `val.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/eval.rs:52:42 [INFO] [stderr] | [INFO] [stderr] 52 | fn eval_statements(&mut self, stmts: &Vec, nested: bool) -> Object { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Statement]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the `r @ _` pattern can be written as just `r` [INFO] [stderr] --> src/eval.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | r @ _ => Object::Error(format!("Unknown operator: -{}", r)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `o @ _` pattern can be written as just `o` [INFO] [stderr] --> src/builtins.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | ref o @ _ => Object::Error(format!("Argument to 'len' is not supported. Got {}", o)), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builtins.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if elems.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!elems.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.19s [INFO] running `"docker" "inspect" "60e3787a6ee9d97a85a2c5d32e228de98dd68004d77b4eec5927ffb1f1856141"` [INFO] running `"docker" "rm" "-f" "60e3787a6ee9d97a85a2c5d32e228de98dd68004d77b4eec5927ffb1f1856141"` [INFO] [stdout] 60e3787a6ee9d97a85a2c5d32e228de98dd68004d77b4eec5927ffb1f1856141