[INFO] updating cached repository 0X1A/raytracerweekend
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/0X1A/raytracerweekend
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/0X1A/raytracerweekend" "work/ex/clippy-test-run/sources/stable/gh/0X1A/raytracerweekend"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/0X1A/raytracerweekend'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/0X1A/raytracerweekend" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/0X1A/raytracerweekend"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/0X1A/raytracerweekend'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 9362731605f3f7cfcef3e8c69cf7abd81bb5b9bb
[INFO] sha for GitHub repo 0X1A/raytracerweekend: 9362731605f3f7cfcef3e8c69cf7abd81bb5b9bb
[INFO] validating manifest of 0X1A/raytracerweekend on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of 0X1A/raytracerweekend on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing 0X1A/raytracerweekend
[INFO] finished frobbing 0X1A/raytracerweekend
[INFO] frobbed toml for 0X1A/raytracerweekend written to work/ex/clippy-test-run/sources/stable/gh/0X1A/raytracerweekend/Cargo.toml
[INFO] started frobbing 0X1A/raytracerweekend
[INFO] finished frobbing 0X1A/raytracerweekend
[INFO] frobbed toml for 0X1A/raytracerweekend written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/0X1A/raytracerweekend/Cargo.toml
[INFO] crate 0X1A/raytracerweekend has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting 0X1A/raytracerweekend against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/0X1A/raytracerweekend:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] da775bedc1a5634f15d05c1cc8912cb6f070c0fee75534eb04578aaf17beeb9a
[INFO] running `"docker" "start" "-a" "da775bedc1a5634f15d05c1cc8912cb6f070c0fee75534eb04578aaf17beeb9a"`
[INFO] [stderr]     Checking raytracer-weekend v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lib/vec.rs:22:16
[INFO] [stderr]    |
[INFO] [stderr] 22 |         Vec3 { x: x, y: y, z: z }
[INFO] [stderr]    |                ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lib/vec.rs:22:22
[INFO] [stderr]    |
[INFO] [stderr] 22 |         Vec3 { x: x, y: y, z: z }
[INFO] [stderr]    |                      ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lib/vec.rs:22:28
[INFO] [stderr]    |
[INFO] [stderr] 22 |         Vec3 { x: x, y: y, z: z }
[INFO] [stderr]    |                            ^^^^ help: replace it with: `z`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lib/materials.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             fuzz: fuzz,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `fuzz`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lib/lib.rs:80:15
[INFO] [stderr]    |
[INFO] [stderr] 80 |         Ray { a: a, b: b }
[INFO] [stderr]    |               ^^^^ help: replace it with: `a`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lib/lib.rs:80:21
[INFO] [stderr]    |
[INFO] [stderr] 80 |         Ray { a: a, b: b }
[INFO] [stderr]    |                     ^^^^ help: replace it with: `b`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lib/lib.rs:128:13
[INFO] [stderr]     |
[INFO] [stderr] 128 |             center: center,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `center`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lib/lib.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             radius: radius,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `radius`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lib/vec.rs:22:16
[INFO] [stderr]    |
[INFO] [stderr] 22 |         Vec3 { x: x, y: y, z: z }
[INFO] [stderr]    |                ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lib/vec.rs:22:22
[INFO] [stderr]    |
[INFO] [stderr] 22 |         Vec3 { x: x, y: y, z: z }
[INFO] [stderr]    |                      ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lib/vec.rs:22:28
[INFO] [stderr]    |
[INFO] [stderr] 22 |         Vec3 { x: x, y: y, z: z }
[INFO] [stderr]    |                            ^^^^ help: replace it with: `z`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lib/materials.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             fuzz: fuzz,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `fuzz`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lib/lib.rs:80:15
[INFO] [stderr]    |
[INFO] [stderr] 80 |         Ray { a: a, b: b }
[INFO] [stderr]    |               ^^^^ help: replace it with: `a`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> lib/lib.rs:80:21
[INFO] [stderr]    |
[INFO] [stderr] 80 |         Ray { a: a, b: b }
[INFO] [stderr]    |                     ^^^^ help: replace it with: `b`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lib/lib.rs:128:13
[INFO] [stderr]     |
[INFO] [stderr] 128 |             center: center,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `center`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> lib/lib.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             radius: radius,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `radius`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> lib/materials.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> lib/lib.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 |     return v - &(2.0 * dot(v, n) * n);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v - &(2.0 * dot(v, n) * n)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> lib/lib.rs:69:5
[INFO] [stderr]    |
[INFO] [stderr] 69 |     return r0 + (1.0 - r0) * (1.0 - cos).powf(5.0);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `r0 + (1.0 - r0) * (1.0 - cos).powf(5.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> lib/lib.rs:160:9
[INFO] [stderr]     |
[INFO] [stderr] 160 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> lib/materials.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> lib/lib.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 |     return v - &(2.0 * dot(v, n) * n);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v - &(2.0 * dot(v, n) * n)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> lib/lib.rs:69:5
[INFO] [stderr]    |
[INFO] [stderr] 69 |     return r0 + (1.0 - r0) * (1.0 - cos).powf(5.0);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `r0 + (1.0 - r0) * (1.0 - cos).powf(5.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> lib/lib.rs:160:9
[INFO] [stderr]     |
[INFO] [stderr] 160 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> lib/vec.rs:58:16
[INFO] [stderr]    |
[INFO] [stderr] 58 |             x: &self.x + other.x,
[INFO] [stderr]    |                -------^^^^^^^^^^
[INFO] [stderr]    |                |
[INFO] [stderr]    |                help: use the left value directly: `self.x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> lib/vec.rs:59:16
[INFO] [stderr]    |
[INFO] [stderr] 59 |             y: &self.y + other.y,
[INFO] [stderr]    |                -------^^^^^^^^^^
[INFO] [stderr]    |                |
[INFO] [stderr]    |                help: use the left value directly: `self.y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> lib/vec.rs:60:16
[INFO] [stderr]    |
[INFO] [stderr] 60 |             z: &self.z + other.z,
[INFO] [stderr]    |                -------^^^^^^^^^^
[INFO] [stderr]    |                |
[INFO] [stderr]    |                help: use the left value directly: `self.z`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> lib/vec.rs:259:16
[INFO] [stderr]     |
[INFO] [stderr] 259 |             x: &self * other.x,
[INFO] [stderr]     |                -----^^^^^^^^^^
[INFO] [stderr]     |                |
[INFO] [stderr]     |                help: use the left value directly: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> lib/vec.rs:260:16
[INFO] [stderr]     |
[INFO] [stderr] 260 |             y: &self * other.y,
[INFO] [stderr]     |                -----^^^^^^^^^^
[INFO] [stderr]     |                |
[INFO] [stderr]     |                help: use the left value directly: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> lib/vec.rs:261:16
[INFO] [stderr]     |
[INFO] [stderr] 261 |             z: &self * other.z,
[INFO] [stderr]     |                -----^^^^^^^^^^
[INFO] [stderr]     |                |
[INFO] [stderr]     |                help: use the left value directly: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> lib/vec.rs:271:16
[INFO] [stderr]     |
[INFO] [stderr] 271 |             x: &self * other.x,
[INFO] [stderr]     |                -----^^^^^^^^^^
[INFO] [stderr]     |                |
[INFO] [stderr]     |                help: use the left value directly: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> lib/vec.rs:272:16
[INFO] [stderr]     |
[INFO] [stderr] 272 |             y: &self * other.y,
[INFO] [stderr]     |                -----^^^^^^^^^^
[INFO] [stderr]     |                |
[INFO] [stderr]     |                help: use the left value directly: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> lib/vec.rs:273:16
[INFO] [stderr]     |
[INFO] [stderr] 273 |             z: &self * other.z,
[INFO] [stderr]     |                -----^^^^^^^^^^
[INFO] [stderr]     |                |
[INFO] [stderr]     |                help: use the left value directly: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> lib/vec.rs:58:16
[INFO] [stderr]    |
[INFO] [stderr] 58 |             x: &self.x + other.x,
[INFO] [stderr]    |                -------^^^^^^^^^^
[INFO] [stderr]    |                |
[INFO] [stderr]    |                help: use the left value directly: `self.x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> lib/vec.rs:59:16
[INFO] [stderr]    |
[INFO] [stderr] 59 |             y: &self.y + other.y,
[INFO] [stderr]    |                -------^^^^^^^^^^
[INFO] [stderr]    |                |
[INFO] [stderr]    |                help: use the left value directly: `self.y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> lib/vec.rs:60:16
[INFO] [stderr]    |
[INFO] [stderr] 60 |             z: &self.z + other.z,
[INFO] [stderr]    |                -------^^^^^^^^^^
[INFO] [stderr]    |                |
[INFO] [stderr]    |                help: use the left value directly: `self.z`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> lib/materials.rs:121:9
[INFO] [stderr]     |
[INFO] [stderr] 121 | /         let cos;
[INFO] [stderr] 122 | |         if dot(&ray.direction(), &hit_record.normal) > 0.0 {
[INFO] [stderr] 123 | |             outward_normal = &hit_record.normal * -1.0;
[INFO] [stderr] 124 | |             ni_nt = self.index;
[INFO] [stderr] ...   |
[INFO] [stderr] 129 | |             cos = -dot(&ray.direction(), &hit_record.normal) / ray.direction().length();
[INFO] [stderr] 130 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let cos = if dot(&ray.direction(), &hit_record.normal) > 0.0 { ..; self.index + dot(&ray.direction(), &hit_record.normal) / ray.direction().length() } else { ..; -dot(&ray.direction(), &hit_record.normal) / ray.direction().length() };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable.
[INFO] [stderr]   --> lib/camera.rs:46:12
[INFO] [stderr]    |
[INFO] [stderr] 46 |         if !(dot(&p, &p) >= 1.0) {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> lib/vec.rs:259:16
[INFO] [stderr]     |
[INFO] [stderr] 259 |             x: &self * other.x,
[INFO] [stderr]     |                -----^^^^^^^^^^
[INFO] [stderr]     |                |
[INFO] [stderr]     |                help: use the left value directly: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> lib/vec.rs:260:16
[INFO] [stderr]     |
[INFO] [stderr] 260 |             y: &self * other.y,
[INFO] [stderr]     |                -----^^^^^^^^^^
[INFO] [stderr]     |                |
[INFO] [stderr]     |                help: use the left value directly: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> lib/vec.rs:261:16
[INFO] [stderr]     |
[INFO] [stderr] 261 |             z: &self * other.z,
[INFO] [stderr]     |                -----^^^^^^^^^^
[INFO] [stderr]     |                |
[INFO] [stderr]     |                help: use the left value directly: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> lib/vec.rs:271:16
[INFO] [stderr]     |
[INFO] [stderr] 271 |             x: &self * other.x,
[INFO] [stderr]     |                -----^^^^^^^^^^
[INFO] [stderr]     |                |
[INFO] [stderr]     |                help: use the left value directly: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> lib/vec.rs:272:16
[INFO] [stderr]     |
[INFO] [stderr] 272 |             y: &self * other.y,
[INFO] [stderr]     |                -----^^^^^^^^^^
[INFO] [stderr]     |                |
[INFO] [stderr]     |                help: use the left value directly: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> lib/vec.rs:273:16
[INFO] [stderr]     |
[INFO] [stderr] 273 |             z: &self * other.z,
[INFO] [stderr]     |                -----^^^^^^^^^^
[INFO] [stderr]     |                |
[INFO] [stderr]     |                help: use the left value directly: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable.
[INFO] [stderr]   --> lib/lib.rs:53:12
[INFO] [stderr]    |
[INFO] [stderr] 53 |         if !(p.squared_length() >= 1.0) {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `HitRecord`
[INFO] [stderr]    --> lib/lib.rs:105:5
[INFO] [stderr]     |
[INFO] [stderr] 105 | /     pub fn new() -> HitRecord {
[INFO] [stderr] 106 | |         HitRecord {
[INFO] [stderr] 107 | |             t: 0.0,
[INFO] [stderr] 108 | |             p: Vec3::new(0.0, 0.0, 0.0),
[INFO] [stderr] ...   |
[INFO] [stderr] 111 | |         }
[INFO] [stderr] 112 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 97  | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> lib/lib.rs:140:33
[INFO] [stderr]     |
[INFO] [stderr] 140 |         let c = dot(&oc, &oc) - (&self.radius * &self.radius);
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 140 |         let c = dot(&oc, &oc) - (self.radius * self.radius);
[INFO] [stderr]     |                                  ^^^^^^^^^^^   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> lib/materials.rs:121:9
[INFO] [stderr]     |
[INFO] [stderr] 121 | /         let cos;
[INFO] [stderr] 122 | |         if dot(&ray.direction(), &hit_record.normal) > 0.0 {
[INFO] [stderr] 123 | |             outward_normal = &hit_record.normal * -1.0;
[INFO] [stderr] 124 | |             ni_nt = self.index;
[INFO] [stderr] ...   |
[INFO] [stderr] 129 | |             cos = -dot(&ray.direction(), &hit_record.normal) / ray.direction().length();
[INFO] [stderr] 130 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let cos = if dot(&ray.direction(), &hit_record.normal) > 0.0 { ..; self.index + dot(&ray.direction(), &hit_record.normal) / ray.direction().length() } else { ..; -dot(&ray.direction(), &hit_record.normal) / ray.direction().length() };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable.
[INFO] [stderr]   --> lib/camera.rs:46:12
[INFO] [stderr]    |
[INFO] [stderr] 46 |         if !(dot(&p, &p) >= 1.0) {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord
[INFO] [stderr] 
[INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable.
[INFO] [stderr]   --> lib/lib.rs:53:12
[INFO] [stderr]    |
[INFO] [stderr] 53 |         if !(p.squared_length() >= 1.0) {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `HitRecord`
[INFO] [stderr]    --> lib/lib.rs:105:5
[INFO] [stderr]     |
[INFO] [stderr] 105 | /     pub fn new() -> HitRecord {
[INFO] [stderr] 106 | |         HitRecord {
[INFO] [stderr] 107 | |             t: 0.0,
[INFO] [stderr] 108 | |             p: Vec3::new(0.0, 0.0, 0.0),
[INFO] [stderr] ...   |
[INFO] [stderr] 111 | |         }
[INFO] [stderr] 112 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 97  | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> lib/lib.rs:140:33
[INFO] [stderr]     |
[INFO] [stderr] 140 |         let c = dot(&oc, &oc) - (&self.radius * &self.radius);
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 140 |         let c = dot(&oc, &oc) - (self.radius * self.radius);
[INFO] [stderr]     |                                  ^^^^^^^^^^^   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             return attenuation * color::<T>(&scattered, world_hit_record, depth + 1);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `attenuation * color::<T>(&scattered, world_hit_record, depth + 1)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |             return Vec3::new(0f32, 0f32, 0f32);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(0f32, 0f32, 0f32)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return (1.0 - t) * Vec3::new(1.0, 1.0, 1.0) + t * Vec3::new(0.5, 0.7, 1.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(1.0 - t) * Vec3::new(1.0, 1.0, 1.0) + t * Vec3::new(0.5, 0.7, 1.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             return attenuation * color::<T>(&scattered, world_hit_record, depth + 1);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `attenuation * color::<T>(&scattered, world_hit_record, depth + 1)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |             return Vec3::new(0f32, 0f32, 0f32);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(0f32, 0f32, 0f32)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return (1.0 - t) * Vec3::new(1.0, 1.0, 1.0) + t * Vec3::new(0.5, 0.7, 1.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(1.0 - t) * Vec3::new(1.0, 1.0, 1.0) + t * Vec3::new(0.5, 0.7, 1.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.24s
[INFO] running `"docker" "inspect" "da775bedc1a5634f15d05c1cc8912cb6f070c0fee75534eb04578aaf17beeb9a"`
[INFO] running `"docker" "rm" "-f" "da775bedc1a5634f15d05c1cc8912cb6f070c0fee75534eb04578aaf17beeb9a"`
[INFO] [stdout] da775bedc1a5634f15d05c1cc8912cb6f070c0fee75534eb04578aaf17beeb9a