[INFO] fetching crate zrquic 0.1.6... [INFO] linting zrquic-0.1.6 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate zrquic 0.1.6 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate zrquic 0.1.6 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate zrquic 0.1.6 [INFO] tweaked toml for crates.io crate zrquic 0.1.6 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate zrquic 0.1.6 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate zrquic 0.1.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded unty v0.0.4 [INFO] [stderr] Downloaded test-fuzz-internal v7.2.4 [INFO] [stderr] Downloaded bincode v2.0.1 [INFO] [stderr] Downloaded clap v4.5.41 [INFO] [stderr] Downloaded wit-bindgen v0.45.1 [INFO] [stderr] Downloaded condtype v1.3.0 [INFO] [stderr] Downloaded regex-lite v0.1.7 [INFO] [stderr] Downloaded divan v0.1.21 [INFO] [stderr] Downloaded humantime v2.2.0 [INFO] [stderr] Downloaded priority-queue v2.5.0 [INFO] [stderr] Downloaded wasi v0.14.4+wasi-0.2.4 [INFO] [stderr] Downloaded indexmap v2.11.1 [INFO] [stderr] Downloaded enum_dispatch v0.3.13 [INFO] [stderr] Downloaded test-fuzz-macro v7.2.4 [INFO] [stderr] Downloaded serde_combinators v0.1.0 [INFO] [stderr] Downloaded virtue v0.0.18 [INFO] [stderr] Downloaded bincode_derive v2.0.1 [INFO] [stderr] Downloaded camino v1.1.12 [INFO] [stderr] Downloaded is-terminal v0.4.16 [INFO] [stderr] Downloaded fslock v0.2.1 [INFO] [stderr] Downloaded pretty_env_logger v0.5.0 [INFO] [stderr] Downloaded cc v1.2.36 [INFO] [stderr] Downloaded octets v0.3.0 [INFO] [stderr] Downloaded divan-macros v0.1.21 [INFO] [stderr] Downloaded test-fuzz v7.2.4 [INFO] [stderr] Downloaded bindgen v0.72.1 [INFO] [stderr] Downloaded test-fuzz-runtime v7.2.4 [INFO] [stderr] Downloaded boring v4.19.0 [INFO] [stderr] Downloaded fixedbuf v0.1.1 [INFO] [stderr] Downloaded debug_panic v0.2.1 [INFO] [stderr] Downloaded quiche v0.24.6 [INFO] [stderr] Downloaded boring-sys v4.19.0 [INFO] [stderr] Downloaded clap_builder v4.5.41 [INFO] [stderr] Downloaded intrusive-collections v0.9.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 289e1997f7272e735956f7e566975b1eaada153dd7a420255b009394fbc37548 [INFO] running `Command { std: "docker" "start" "-a" "289e1997f7272e735956f7e566975b1eaada153dd7a420255b009394fbc37548", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "289e1997f7272e735956f7e566975b1eaada153dd7a420255b009394fbc37548", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "289e1997f7272e735956f7e566975b1eaada153dd7a420255b009394fbc37548", kill_on_drop: false }` [INFO] [stdout] 289e1997f7272e735956f7e566975b1eaada153dd7a420255b009394fbc37548 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ce18b9ff24492b590bc87e95aad5b69b755c97dde71ae368e4f10ba643e1bef1 [INFO] running `Command { std: "docker" "start" "-a" "ce18b9ff24492b590bc87e95aad5b69b755c97dde71ae368e4f10ba643e1bef1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Compiling glob v0.3.3 [INFO] [stderr] Checking cfg-if v1.0.3 [INFO] [stderr] Compiling find-msvc-tools v0.1.1 [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Compiling regex-syntax v0.8.6 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling libloading v0.8.8 [INFO] [stderr] Compiling bindgen v0.72.1 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling thiserror v2.0.16 [INFO] [stderr] Compiling rustc-hash v2.1.1 [INFO] [stderr] Compiling cc v1.2.36 [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Compiling camino v1.1.12 [INFO] [stderr] Compiling serde_json v1.0.143 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Compiling virtue v0.0.18 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Checking unty v0.0.4 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking foreign-types-shared v0.3.1 [INFO] [stderr] Compiling fslock v0.2.1 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling test-fuzz-internal v7.2.4 [INFO] [stderr] Compiling bincode_derive v2.0.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking slab v0.4.11 [INFO] [stderr] Compiling regex-automata v0.4.10 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking terminal_size v0.4.3 [INFO] [stderr] Compiling once_cell v1.21.3 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking intrusive-collections v0.9.7 [INFO] [stderr] Checking clap_builder v4.5.41 [INFO] [stderr] Compiling quiche v0.24.6 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Compiling itertools v0.14.0 [INFO] [stderr] Checking octets v0.3.0 [INFO] [stderr] Checking humantime v2.2.0 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking indexmap v2.11.1 [INFO] [stderr] Compiling test-fuzz v7.2.4 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking debug_panic v0.2.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking condtype v1.3.0 [INFO] [stderr] Checking regex-lite v0.1.7 [INFO] [stderr] Checking fixedbuf v0.1.1 [INFO] [stderr] Checking priority-queue v2.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling regex v1.11.2 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking clap v4.5.41 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Compiling prettyplease v0.2.37 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling thiserror-impl v2.0.16 [INFO] [stderr] Compiling foreign-types-macros v0.2.3 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Compiling divan-macros v0.1.21 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking foreign-types v0.5.0 [INFO] [stderr] Checking divan v0.1.21 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Compiling test-fuzz-macro v7.2.4 [INFO] [stderr] Compiling boring-sys v4.19.0 [INFO] [stderr] Checking cargo-platform v0.1.9 [INFO] [stderr] Checking bincode v2.0.1 [INFO] [stderr] Checking serde_combinators v0.1.0 [INFO] [stderr] Checking cargo_metadata v0.19.2 [INFO] [stderr] Checking test-fuzz-runtime v7.2.4 [INFO] [stderr] Checking boring v4.19.0 [INFO] [stderr] Checking zrquic v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/poll/conn.rs:43:1 [INFO] [stdout] | [INFO] [stdout] 43 | / impl Default for LocKind { [INFO] [stdout] 44 | | fn default() -> Self { [INFO] [stdout] 45 | | Self::None [INFO] [stdout] 46 | | } [INFO] [stdout] 47 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 21 + #[derive(Default)] [INFO] [stdout] 22 | pub enum LocKind { [INFO] [stdout] 23 ~ #[default] [INFO] [stdout] 24 ~ None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/poll/conn.rs:43:1 [INFO] [stdout] | [INFO] [stdout] 43 | / impl Default for LocKind { [INFO] [stdout] 44 | | fn default() -> Self { [INFO] [stdout] 45 | | Self::None [INFO] [stdout] 46 | | } [INFO] [stdout] 47 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 21 + #[derive(Default)] [INFO] [stdout] 22 | pub enum LocKind { [INFO] [stdout] 23 ~ #[default] [INFO] [stdout] 24 ~ None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/poll/conn.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | / match self { [INFO] [stdout] 52 | | LocKind::Send | LocKind::None => false, [INFO] [stdout] 53 | | _ => true, [INFO] [stdout] 54 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 51 - match self { [INFO] [stdout] 52 - LocKind::Send | LocKind::None => false, [INFO] [stdout] 53 - _ => true, [INFO] [stdout] 54 - } [INFO] [stdout] 51 + !matches!(self, LocKind::Send | LocKind::None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/poll/conn.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | / match self { [INFO] [stdout] 52 | | LocKind::Send | LocKind::None => false, [INFO] [stdout] 53 | | _ => true, [INFO] [stdout] 54 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 51 - match self { [INFO] [stdout] 52 - LocKind::Send | LocKind::None => false, [INFO] [stdout] 53 - _ => true, [INFO] [stdout] 54 - } [INFO] [stdout] 51 + !matches!(self, LocKind::Send | LocKind::None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:225:9 [INFO] [stdout] | [INFO] [stdout] 225 | / if let Err(err) = conn.close(app, err, &reason) { [INFO] [stdout] 226 | | if err != quiche::Error::Done { [INFO] [stdout] 227 | | self.unlock(_guard.lock_count, false, readiness); [INFO] [stdout] 228 | | return Err(err.into()); [INFO] [stdout] 229 | | } [INFO] [stdout] 230 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 225 ~ if let Err(err) = conn.close(app, err, &reason) [INFO] [stdout] 226 ~ && err != quiche::Error::Done { [INFO] [stdout] 227 | self.unlock(_guard.lock_count, false, readiness); [INFO] [stdout] 228 | return Err(err.into()); [INFO] [stdout] 229 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:225:9 [INFO] [stdout] | [INFO] [stdout] 225 | / if let Err(err) = conn.close(app, err, &reason) { [INFO] [stdout] 226 | | if err != quiche::Error::Done { [INFO] [stdout] 227 | | self.unlock(_guard.lock_count, false, readiness); [INFO] [stdout] 228 | | return Err(err.into()); [INFO] [stdout] 229 | | } [INFO] [stdout] 230 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 225 ~ if let Err(err) = conn.close(app, err, &reason) [INFO] [stdout] 226 ~ && err != quiche::Error::Done { [INFO] [stdout] 227 | self.unlock(_guard.lock_count, false, readiness); [INFO] [stdout] 228 | return Err(err.into()); [INFO] [stdout] 229 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:293:13 [INFO] [stdout] | [INFO] [stdout] 293 | / if !conn.stream_finished(stream_id) { [INFO] [stdout] 294 | | if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) { [INFO] [stdout] 295 | | if err != quiche::Error::Done { [INFO] [stdout] 296 | | return Err(err.into()); [INFO] [stdout] ... | [INFO] [stdout] 299 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 293 ~ if !conn.stream_finished(stream_id) [INFO] [stdout] 294 ~ && let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) { [INFO] [stdout] 295 | if err != quiche::Error::Done { [INFO] [stdout] 296 | return Err(err.into()); [INFO] [stdout] 297 | } [INFO] [stdout] 298 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:294:17 [INFO] [stdout] | [INFO] [stdout] 294 | / if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) { [INFO] [stdout] 295 | | if err != quiche::Error::Done { [INFO] [stdout] 296 | | return Err(err.into()); [INFO] [stdout] 297 | | } [INFO] [stdout] 298 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 294 ~ if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) [INFO] [stdout] 295 ~ && err != quiche::Error::Done { [INFO] [stdout] 296 | return Err(err.into()); [INFO] [stdout] 297 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:302:13 [INFO] [stdout] | [INFO] [stdout] 302 | / if let Err(err) = conn.stream_send(stream_id, b"", true) { [INFO] [stdout] 303 | | if err != quiche::Error::Done { [INFO] [stdout] 304 | | return Err(err.into()); [INFO] [stdout] 305 | | } [INFO] [stdout] 306 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 302 ~ if let Err(err) = conn.stream_send(stream_id, b"", true) [INFO] [stdout] 303 ~ && err != quiche::Error::Done { [INFO] [stdout] 304 | return Err(err.into()); [INFO] [stdout] 305 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:309:17 [INFO] [stdout] | [INFO] [stdout] 309 | / if let Err(err) = conn.stream_send(stream_id, b"", true) { [INFO] [stdout] 310 | | if err != quiche::Error::Done { [INFO] [stdout] 311 | | return Err(err.into()); [INFO] [stdout] 312 | | } [INFO] [stdout] 313 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 309 ~ if let Err(err) = conn.stream_send(stream_id, b"", true) [INFO] [stdout] 310 ~ && err != quiche::Error::Done { [INFO] [stdout] 311 | return Err(err.into()); [INFO] [stdout] 312 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:315:17 [INFO] [stdout] | [INFO] [stdout] 315 | / if !conn.stream_finished(stream_id) { [INFO] [stdout] 316 | | if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) { [INFO] [stdout] 317 | | if err != quiche::Error::Done { [INFO] [stdout] 318 | | return Err(err.into()); [INFO] [stdout] ... | [INFO] [stdout] 321 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 315 ~ if !conn.stream_finished(stream_id) [INFO] [stdout] 316 ~ && let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) { [INFO] [stdout] 317 | if err != quiche::Error::Done { [INFO] [stdout] 318 | return Err(err.into()); [INFO] [stdout] 319 | } [INFO] [stdout] 320 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:293:13 [INFO] [stdout] | [INFO] [stdout] 293 | / if !conn.stream_finished(stream_id) { [INFO] [stdout] 294 | | if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) { [INFO] [stdout] 295 | | if err != quiche::Error::Done { [INFO] [stdout] 296 | | return Err(err.into()); [INFO] [stdout] ... | [INFO] [stdout] 299 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 293 ~ if !conn.stream_finished(stream_id) [INFO] [stdout] 294 ~ && let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) { [INFO] [stdout] 295 | if err != quiche::Error::Done { [INFO] [stdout] 296 | return Err(err.into()); [INFO] [stdout] 297 | } [INFO] [stdout] 298 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:316:21 [INFO] [stdout] | [INFO] [stdout] 316 | / if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) { [INFO] [stdout] 317 | | if err != quiche::Error::Done { [INFO] [stdout] 318 | | return Err(err.into()); [INFO] [stdout] 319 | | } [INFO] [stdout] 320 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 316 ~ if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) [INFO] [stdout] 317 ~ && err != quiche::Error::Done { [INFO] [stdout] 318 | return Err(err.into()); [INFO] [stdout] 319 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:294:17 [INFO] [stdout] | [INFO] [stdout] 294 | / if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) { [INFO] [stdout] 295 | | if err != quiche::Error::Done { [INFO] [stdout] 296 | | return Err(err.into()); [INFO] [stdout] 297 | | } [INFO] [stdout] 298 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 294 ~ if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) [INFO] [stdout] 295 ~ && err != quiche::Error::Done { [INFO] [stdout] 296 | return Err(err.into()); [INFO] [stdout] 297 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/conn.rs:360:9 [INFO] [stdout] | [INFO] [stdout] 360 | return Ok(stream_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 360 - return Ok(stream_id); [INFO] [stdout] 360 + Ok(stream_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:302:13 [INFO] [stdout] | [INFO] [stdout] 302 | / if let Err(err) = conn.stream_send(stream_id, b"", true) { [INFO] [stdout] 303 | | if err != quiche::Error::Done { [INFO] [stdout] 304 | | return Err(err.into()); [INFO] [stdout] 305 | | } [INFO] [stdout] 306 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 302 ~ if let Err(err) = conn.stream_send(stream_id, b"", true) [INFO] [stdout] 303 ~ && err != quiche::Error::Done { [INFO] [stdout] 304 | return Err(err.into()); [INFO] [stdout] 305 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:309:17 [INFO] [stdout] | [INFO] [stdout] 309 | / if let Err(err) = conn.stream_send(stream_id, b"", true) { [INFO] [stdout] 310 | | if err != quiche::Error::Done { [INFO] [stdout] 311 | | return Err(err.into()); [INFO] [stdout] 312 | | } [INFO] [stdout] 313 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 309 ~ if let Err(err) = conn.stream_send(stream_id, b"", true) [INFO] [stdout] 310 ~ && err != quiche::Error::Done { [INFO] [stdout] 311 | return Err(err.into()); [INFO] [stdout] 312 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:315:17 [INFO] [stdout] | [INFO] [stdout] 315 | / if !conn.stream_finished(stream_id) { [INFO] [stdout] 316 | | if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) { [INFO] [stdout] 317 | | if err != quiche::Error::Done { [INFO] [stdout] 318 | | return Err(err.into()); [INFO] [stdout] ... | [INFO] [stdout] 321 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 315 ~ if !conn.stream_finished(stream_id) [INFO] [stdout] 316 ~ && let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) { [INFO] [stdout] 317 | if err != quiche::Error::Done { [INFO] [stdout] 318 | return Err(err.into()); [INFO] [stdout] 319 | } [INFO] [stdout] 320 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:316:21 [INFO] [stdout] | [INFO] [stdout] 316 | / if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) { [INFO] [stdout] 317 | | if err != quiche::Error::Done { [INFO] [stdout] 318 | | return Err(err.into()); [INFO] [stdout] 319 | | } [INFO] [stdout] 320 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 316 ~ if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) [INFO] [stdout] 317 ~ && err != quiche::Error::Done { [INFO] [stdout] 318 | return Err(err.into()); [INFO] [stdout] 319 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/conn.rs:360:9 [INFO] [stdout] | [INFO] [stdout] 360 | return Ok(stream_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 360 - return Ok(stream_id); [INFO] [stdout] 360 + Ok(stream_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:417:21 [INFO] [stdout] | [INFO] [stdout] 417 | / if let Err(err) = conn.close(app, err, &reason) { [INFO] [stdout] 418 | | if err != quiche::Error::Done { [INFO] [stdout] 419 | | log::error!("close connection, id={}, err={}", conn.trace_id(), err); [INFO] [stdout] ... | [INFO] [stdout] 432 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 417 ~ if let Err(err) = conn.close(app, err, &reason) [INFO] [stdout] 418 ~ && err != quiche::Error::Done { [INFO] [stdout] 419 | log::error!("close connection, id={}, err={}", conn.trace_id(), err); [INFO] [stdout] ... [INFO] [stdout] 430 | ); [INFO] [stdout] 431 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/poll/conn.rs:417:21 [INFO] [stdout] | [INFO] [stdout] 417 | / if let Err(err) = conn.close(app, err, &reason) { [INFO] [stdout] 418 | | if err != quiche::Error::Done { [INFO] [stdout] 419 | | log::error!("close connection, id={}, err={}", conn.trace_id(), err); [INFO] [stdout] ... | [INFO] [stdout] 432 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 417 ~ if let Err(err) = conn.close(app, err, &reason) [INFO] [stdout] 418 ~ && err != quiche::Error::Done { [INFO] [stdout] 419 | log::error!("close connection, id={}, err={}", conn.trace_id(), err); [INFO] [stdout] ... [INFO] [stdout] 430 | ); [INFO] [stdout] 431 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/poll/events.rs:106:16 [INFO] [stdout] | [INFO] [stdout] 106 | if !(deadline.checked_duration_since(now).unwrap_or_default() > release_timer_threshold) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(deadline.checked_duration_since(now).unwrap_or_default() <= release_timer_threshold)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/events.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return None; [INFO] [stdout] 117 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/poll/group.rs:52:1 [INFO] [stdout] | [INFO] [stdout] 52 | / impl Default for Group { [INFO] [stdout] 53 | | fn default() -> Self { [INFO] [stdout] 54 | | Self { [INFO] [stdout] 55 | | state: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 47 + #[derive(Default)] [INFO] [stdout] 48 | pub struct Group { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/poll/events.rs:106:16 [INFO] [stdout] | [INFO] [stdout] 106 | if !(deadline.checked_duration_since(now).unwrap_or_default() > release_timer_threshold) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(deadline.checked_duration_since(now).unwrap_or_default() <= release_timer_threshold)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/events.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return None; [INFO] [stdout] 117 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/poll/group.rs:117:40 [INFO] [stdout] | [INFO] [stdout] 117 | let conn: quiche::Connection = state [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 118 | | .conns [INFO] [stdout] 119 | | .remove(&token) [INFO] [stdout] 120 | | .ok_or_else(|| Error::NotFound)? [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 120 - .ok_or_else(|| Error::NotFound)? [INFO] [stdout] 120 + .ok_or(Error::NotFound)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Group` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/poll/group.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Token` which implements the `Copy` trait [INFO] [stdout] --> src/poll/group.rs:177:21 [INFO] [stdout] | [INFO] [stdout] 177 | let token = self [INFO] [stdout] | _____________________^ [INFO] [stdout] 178 | | .scids [INFO] [stdout] 179 | | .read() [INFO] [stdout] 180 | | .get(&scid) [INFO] [stdout] 181 | | .ok_or_else(|| Error::NotFound)? [INFO] [stdout] 182 | | .clone(); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] help: try dereferencing it [INFO] [stdout] | [INFO] [stdout] 177 ~ let token = *self [INFO] [stdout] 178 + .scids [INFO] [stdout] 179 + .read() [INFO] [stdout] 180 + .get(&scid) [INFO] [stdout] 181 ~ .ok_or_else(|| Error::NotFound)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/poll/group.rs:177:21 [INFO] [stdout] | [INFO] [stdout] 177 | let token = self [INFO] [stdout] | _____________________^ [INFO] [stdout] 178 | | .scids [INFO] [stdout] 179 | | .read() [INFO] [stdout] 180 | | .get(&scid) [INFO] [stdout] 181 | | .ok_or_else(|| Error::NotFound)? [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 181 - .ok_or_else(|| Error::NotFound)? [INFO] [stdout] 181 + .ok_or(Error::NotFound)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/poll/group.rs:180:18 [INFO] [stdout] | [INFO] [stdout] 180 | .get(&scid) [INFO] [stdout] | ^^^^^ help: change this to: `scid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/poll/group.rs:186:28 [INFO] [stdout] | [INFO] [stdout] 186 | let Ok(mut conn) = state [INFO] [stdout] | ____________________________^ [INFO] [stdout] 187 | | .conns [INFO] [stdout] 188 | | .get(&token) [INFO] [stdout] 189 | | .ok_or_else(|| Error::NotFound)? [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 189 - .ok_or_else(|| Error::NotFound)? [INFO] [stdout] 189 + .ok_or(Error::NotFound)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/poll/group.rs:52:1 [INFO] [stdout] | [INFO] [stdout] 52 | / impl Default for Group { [INFO] [stdout] 53 | | fn default() -> Self { [INFO] [stdout] 54 | | Self { [INFO] [stdout] 55 | | state: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 47 + #[derive(Default)] [INFO] [stdout] 48 | pub struct Group { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/poll/group.rs:117:40 [INFO] [stdout] | [INFO] [stdout] 117 | let conn: quiche::Connection = state [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 118 | | .conns [INFO] [stdout] 119 | | .remove(&token) [INFO] [stdout] 120 | | .ok_or_else(|| Error::NotFound)? [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 120 - .ok_or_else(|| Error::NotFound)? [INFO] [stdout] 120 + .ok_or(Error::NotFound)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:255:17 [INFO] [stdout] | [INFO] [stdout] 255 | return Ok((send_size, send_info)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 255 - return Ok((send_size, send_info)); [INFO] [stdout] 255 + Ok((send_size, send_info)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:260:17 [INFO] [stdout] | [INFO] [stdout] 260 | return Err(Error::Retry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 260 - return Err(Error::Retry); [INFO] [stdout] 260 + Err(Error::Retry) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:264:17 [INFO] [stdout] | [INFO] [stdout] 264 | return Err(Error::Quiche(err)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 264 - return Err(Error::Quiche(err)); [INFO] [stdout] 264 + Err(Error::Quiche(err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Group` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/poll/group.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Token` which implements the `Copy` trait [INFO] [stdout] --> src/poll/group.rs:177:21 [INFO] [stdout] | [INFO] [stdout] 177 | let token = self [INFO] [stdout] | _____________________^ [INFO] [stdout] 178 | | .scids [INFO] [stdout] 179 | | .read() [INFO] [stdout] 180 | | .get(&scid) [INFO] [stdout] 181 | | .ok_or_else(|| Error::NotFound)? [INFO] [stdout] 182 | | .clone(); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] help: try dereferencing it [INFO] [stdout] | [INFO] [stdout] 177 ~ let token = *self [INFO] [stdout] 178 + .scids [INFO] [stdout] 179 + .read() [INFO] [stdout] 180 + .get(&scid) [INFO] [stdout] 181 ~ .ok_or_else(|| Error::NotFound)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/poll/group.rs:177:21 [INFO] [stdout] | [INFO] [stdout] 177 | let token = self [INFO] [stdout] | _____________________^ [INFO] [stdout] 178 | | .scids [INFO] [stdout] 179 | | .read() [INFO] [stdout] 180 | | .get(&scid) [INFO] [stdout] 181 | | .ok_or_else(|| Error::NotFound)? [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 181 - .ok_or_else(|| Error::NotFound)? [INFO] [stdout] 181 + .ok_or(Error::NotFound)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/poll/group.rs:180:18 [INFO] [stdout] | [INFO] [stdout] 180 | .get(&scid) [INFO] [stdout] | ^^^^^ help: change this to: `scid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/poll/group.rs:278:20 [INFO] [stdout] | [INFO] [stdout] 278 | let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 278 - let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?; [INFO] [stdout] 278 + let conn = state.conns.get(&token).ok_or(Error::NotFound)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/poll/group.rs:186:28 [INFO] [stdout] | [INFO] [stdout] 186 | let Ok(mut conn) = state [INFO] [stdout] | ____________________________^ [INFO] [stdout] 187 | | .conns [INFO] [stdout] 188 | | .get(&token) [INFO] [stdout] 189 | | .ok_or_else(|| Error::NotFound)? [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 189 - .ok_or_else(|| Error::NotFound)? [INFO] [stdout] 189 + .ok_or(Error::NotFound)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/poll/group.rs:287:20 [INFO] [stdout] | [INFO] [stdout] 287 | let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 287 - let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?; [INFO] [stdout] 287 + let conn = state.conns.get(&token).ok_or(Error::NotFound)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/poll/group.rs:296:20 [INFO] [stdout] | [INFO] [stdout] 296 | let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 296 - let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?; [INFO] [stdout] 296 + let conn = state.conns.get(&token).ok_or(Error::NotFound)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:328:17 [INFO] [stdout] | [INFO] [stdout] 328 | return Ok(send_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 328 - return Ok(send_size); [INFO] [stdout] 328 + Ok(send_size) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:337:17 [INFO] [stdout] | [INFO] [stdout] 337 | return Err(Error::Retry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 337 - return Err(Error::Retry); [INFO] [stdout] 337 + Err(Error::Retry) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:255:17 [INFO] [stdout] | [INFO] [stdout] 255 | return Ok((send_size, send_info)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 255 - return Ok((send_size, send_info)); [INFO] [stdout] 255 + Ok((send_size, send_info)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:348:17 [INFO] [stdout] | [INFO] [stdout] 348 | return Err(Error::Quiche(err)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 348 - return Err(Error::Quiche(err)); [INFO] [stdout] 348 + Err(Error::Quiche(err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:371:17 [INFO] [stdout] | [INFO] [stdout] 371 | return Ok((recv_size, fin)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 371 - return Ok((recv_size, fin)); [INFO] [stdout] 371 + Ok((recv_size, fin)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:260:17 [INFO] [stdout] | [INFO] [stdout] 260 | return Err(Error::Retry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 260 - return Err(Error::Retry); [INFO] [stdout] 260 + Err(Error::Retry) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:264:17 [INFO] [stdout] | [INFO] [stdout] 264 | return Err(Error::Quiche(err)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 264 - return Err(Error::Quiche(err)); [INFO] [stdout] 264 + Err(Error::Quiche(err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:391:17 [INFO] [stdout] | [INFO] [stdout] 391 | return Err(Error::Retry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 391 - return Err(Error::Retry); [INFO] [stdout] 391 + Err(Error::Retry) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:401:17 [INFO] [stdout] | [INFO] [stdout] 401 | return Err(Error::Quiche(err)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 401 - return Err(Error::Quiche(err)); [INFO] [stdout] 401 + Err(Error::Quiche(err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/poll/group.rs:278:20 [INFO] [stdout] | [INFO] [stdout] 278 | let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 278 - let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?; [INFO] [stdout] 278 + let conn = state.conns.get(&token).ok_or(Error::NotFound)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/poll/group.rs:287:20 [INFO] [stdout] | [INFO] [stdout] 287 | let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 287 - let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?; [INFO] [stdout] 287 + let conn = state.conns.get(&token).ok_or(Error::NotFound)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/poll/group.rs:296:20 [INFO] [stdout] | [INFO] [stdout] 296 | let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 296 - let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?; [INFO] [stdout] 296 + let conn = state.conns.get(&token).ok_or(Error::NotFound)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:328:17 [INFO] [stdout] | [INFO] [stdout] 328 | return Ok(send_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 328 - return Ok(send_size); [INFO] [stdout] 328 + Ok(send_size) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:337:17 [INFO] [stdout] | [INFO] [stdout] 337 | return Err(Error::Retry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 337 - return Err(Error::Retry); [INFO] [stdout] 337 + Err(Error::Retry) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:348:17 [INFO] [stdout] | [INFO] [stdout] 348 | return Err(Error::Quiche(err)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 348 - return Err(Error::Quiche(err)); [INFO] [stdout] 348 + Err(Error::Quiche(err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/poll/server.rs:79:23 [INFO] [stdout] | [INFO] [stdout] 79 | hasher.update(&new_scid); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `new_scid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:371:17 [INFO] [stdout] | [INFO] [stdout] 371 | return Ok((recv_size, fin)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 371 - return Ok((recv_size, fin)); [INFO] [stdout] 371 + Ok((recv_size, fin)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:391:17 [INFO] [stdout] | [INFO] [stdout] 391 | return Err(Error::Retry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 391 - return Err(Error::Retry); [INFO] [stdout] 391 + Err(Error::Retry) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/poll/group.rs:401:17 [INFO] [stdout] | [INFO] [stdout] 401 | return Err(Error::Quiche(err)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 401 - return Err(Error::Quiche(err)); [INFO] [stdout] 401 + Err(Error::Quiche(err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/poll/server.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 104 | if addr != &token[..addr.len()] { [INFO] [stdout] | ^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `token[..addr.len()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/poll/server.rs:129:23 [INFO] [stdout] | [INFO] [stdout] 129 | hasher.update(&dcid); [INFO] [stdout] | ^^^^^ help: change this to: `dcid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/poll/server.rs:143:1 [INFO] [stdout] | [INFO] [stdout] 143 | / pub enum Handshake { [INFO] [stdout] 144 | | Handshake(usize), [INFO] [stdout] | | ---------------- the second-largest variant contains at least 8 bytes [INFO] [stdout] 145 | | Accept(quiche::Connection), [INFO] [stdout] | | -------------------------- the largest variant contains at least 15008 bytes [INFO] [stdout] 146 | | } [INFO] [stdout] | |_^ the entire enum is at least 15008 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 145 - Accept(quiche::Connection), [INFO] [stdout] 145 + Accept(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/poll/server.rs:79:23 [INFO] [stdout] | [INFO] [stdout] 79 | hasher.update(&new_scid); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `new_scid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/poll/server.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 104 | if addr != &token[..addr.len()] { [INFO] [stdout] | ^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `token[..addr.len()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/poll/server.rs:129:23 [INFO] [stdout] | [INFO] [stdout] 129 | hasher.update(&dcid); [INFO] [stdout] | ^^^^^ help: change this to: `dcid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/poll/server.rs:143:1 [INFO] [stdout] | [INFO] [stdout] 143 | / pub enum Handshake { [INFO] [stdout] 144 | | Handshake(usize), [INFO] [stdout] | | ---------------- the second-largest variant contains at least 8 bytes [INFO] [stdout] 145 | | Accept(quiche::Connection), [INFO] [stdout] | | -------------------------- the largest variant contains at least 15008 bytes [INFO] [stdout] 146 | | } [INFO] [stdout] | |_^ the entire enum is at least 15008 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 145 - Accept(quiche::Connection), [INFO] [stdout] 145 + Accept(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Group` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/mio/group.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mio/group.rs:151:17 [INFO] [stdout] | [INFO] [stdout] 151 | return Err(crate::poll::Error::Retry.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return Err(crate::poll::Error::Retry.into()); [INFO] [stdout] 151 + Err(crate::poll::Error::Retry.into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Group` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/mio/group.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mio/group.rs:231:20 [INFO] [stdout] | [INFO] [stdout] 231 | if !(deadline > Instant::now()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(deadline <= Instant::now())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mio/group.rs:151:17 [INFO] [stdout] | [INFO] [stdout] 151 | return Err(crate::poll::Error::Retry.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return Err(crate::poll::Error::Retry.into()); [INFO] [stdout] 151 + Err(crate::poll::Error::Retry.into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to move all elements into a new `Vec` [INFO] [stdout] --> src/mio/group.rs:212:26 [INFO] [stdout] | [INFO] [stdout] 212 | for event in events.drain(..).collect::>() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `mem::take`: `std::mem::take(events)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drain_collect [INFO] [stdout] = note: `#[warn(clippy::drain_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/mio/group.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | / if let Some(deadline) = deadline { [INFO] [stdout] 231 | | if !(deadline > Instant::now()) { [INFO] [stdout] 232 | | return Ok(()); [INFO] [stdout] 233 | | } [INFO] [stdout] 234 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 230 ~ if let Some(deadline) = deadline [INFO] [stdout] 231 ~ && !(deadline > Instant::now()) { [INFO] [stdout] 232 | return Ok(()); [INFO] [stdout] 233 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mio/group.rs:231:20 [INFO] [stdout] | [INFO] [stdout] 231 | if !(deadline > Instant::now()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(deadline <= Instant::now())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to move all elements into a new `Vec` [INFO] [stdout] --> src/mio/group.rs:212:26 [INFO] [stdout] | [INFO] [stdout] 212 | for event in events.drain(..).collect::>() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `mem::take`: `std::mem::take(events)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drain_collect [INFO] [stdout] = note: `#[warn(clippy::drain_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/mio/group.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | / if let Some(deadline) = deadline { [INFO] [stdout] 231 | | if !(deadline > Instant::now()) { [INFO] [stdout] 232 | | return Ok(()); [INFO] [stdout] 233 | | } [INFO] [stdout] 234 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 230 ~ if let Some(deadline) = deadline [INFO] [stdout] 231 ~ && !(deadline > Instant::now()) { [INFO] [stdout] 232 | return Ok(()); [INFO] [stdout] 233 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/mio/group.rs:435:9 [INFO] [stdout] | [INFO] [stdout] 435 | Ok(token?) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 435 - Ok(token?) [INFO] [stdout] 435 + token [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/mio/group.rs:435:9 [INFO] [stdout] | [INFO] [stdout] 435 | Ok(token?) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 435 - Ok(token?) [INFO] [stdout] 435 + token [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mio/udp.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 130 | assert!(!(self.sending.len() > self.sending_buffer_limits)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.sending.len() <= self.sending_buffer_limits)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `mio::udp::QuicSocketError` [INFO] [stdout] --> src/mio/udp.rs:126:24 [INFO] [stdout] | [INFO] [stdout] 126 | return Err(QuicSocketError::IsFull(buf).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `QuicSocketError::IsFull(buf)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mio/udp.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 130 | assert!(!(self.sending.len() > self.sending_buffer_limits)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.sending.len() <= self.sending_buffer_limits)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `mio::udp::QuicSocketError` [INFO] [stdout] --> src/mio/udp.rs:126:24 [INFO] [stdout] | [INFO] [stdout] 126 | return Err(QuicSocketError::IsFull(buf).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `QuicSocketError::IsFull(buf)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/futures.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | / if let Some(conn) = state.wakers.get_mut(&token) { [INFO] [stdout] 154 | | if let Some(waker) = conn.remove(&event) { [INFO] [stdout] 155 | | log::trace!("wakeup, event={:?}", event); [INFO] [stdout] 156 | | waker.wake(); [INFO] [stdout] 157 | | } [INFO] [stdout] 158 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 153 ~ if let Some(conn) = state.wakers.get_mut(&token) [INFO] [stdout] 154 ~ && let Some(waker) = conn.remove(&event) { [INFO] [stdout] 155 | log::trace!("wakeup, event={:?}", event); [INFO] [stdout] 156 | waker.wake(); [INFO] [stdout] 157 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/futures.rs:214:29 [INFO] [stdout] | [INFO] [stdout] 214 | .or_insert_with(|| VecDeque::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `VecDeque::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/futures.rs:269:17 [INFO] [stdout] | [INFO] [stdout] 269 | return Poll::Ready(Ok(())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 269 - return Poll::Ready(Ok(())); [INFO] [stdout] 269 + Poll::Ready(Ok(())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/futures.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | / if let Some(conn) = state.wakers.get_mut(&token) { [INFO] [stdout] 154 | | if let Some(waker) = conn.remove(&event) { [INFO] [stdout] 155 | | log::trace!("wakeup, event={:?}", event); [INFO] [stdout] 156 | | waker.wake(); [INFO] [stdout] 157 | | } [INFO] [stdout] 158 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 153 ~ if let Some(conn) = state.wakers.get_mut(&token) [INFO] [stdout] 154 ~ && let Some(waker) = conn.remove(&event) { [INFO] [stdout] 155 | log::trace!("wakeup, event={:?}", event); [INFO] [stdout] 156 | waker.wake(); [INFO] [stdout] 157 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/futures.rs:274:37 [INFO] [stdout] | [INFO] [stdout] 274 | .or_insert_with(|| Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Default::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/futures.rs:299:33 [INFO] [stdout] | [INFO] [stdout] 299 | .or_insert_with(|| Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Default::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/futures.rs:312:33 [INFO] [stdout] | [INFO] [stdout] 312 | .or_insert_with(|| Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Default::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/futures.rs:340:33 [INFO] [stdout] | [INFO] [stdout] 340 | .or_insert_with(|| Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Default::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/futures.rs:214:29 [INFO] [stdout] | [INFO] [stdout] 214 | .or_insert_with(|| VecDeque::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `VecDeque::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/futures.rs:422:33 [INFO] [stdout] | [INFO] [stdout] 422 | .or_insert_with(|| Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Default::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/futures.rs:463:33 [INFO] [stdout] | [INFO] [stdout] 463 | .or_insert_with(|| Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Default::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/futures.rs:269:17 [INFO] [stdout] | [INFO] [stdout] 269 | return Poll::Ready(Ok(())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 269 - return Poll::Ready(Ok(())); [INFO] [stdout] 269 + Poll::Ready(Ok(())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/futures.rs:274:37 [INFO] [stdout] | [INFO] [stdout] 274 | .or_insert_with(|| Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Default::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/futures.rs:299:33 [INFO] [stdout] | [INFO] [stdout] 299 | .or_insert_with(|| Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Default::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/futures.rs:312:33 [INFO] [stdout] | [INFO] [stdout] 312 | .or_insert_with(|| Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Default::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/futures.rs:340:33 [INFO] [stdout] | [INFO] [stdout] 340 | .or_insert_with(|| Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Default::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/futures.rs:422:33 [INFO] [stdout] | [INFO] [stdout] 422 | .or_insert_with(|| Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Default::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/futures.rs:463:33 [INFO] [stdout] | [INFO] [stdout] 463 | .or_insert_with(|| Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Default::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> src/futures.rs:919:25 [INFO] [stdout] | [INFO] [stdout] 919 | let local = group.local_addrs().next().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*group.local_addrs().next().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> src/futures.rs:919:25 [INFO] [stdout] | [INFO] [stdout] 919 | let local = group.local_addrs().next().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*group.local_addrs().next().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> tests/async.rs:61:1 [INFO] [stdout] | [INFO] [stdout] 61 | / #[inline] [INFO] [stdout] 62 | | [INFO] [stdout] | |_^ [INFO] [stdout] 63 | fn make_acceptor() -> Acceptor { [INFO] [stdout] | ---------------- the attribute applies to this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/poll.rs:252:21 [INFO] [stdout] | [INFO] [stdout] 252 | assert_eq!(fin, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 252 - assert_eq!(fin, true); [INFO] [stdout] 252 + assert!(fin); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/poll.rs:301:21 [INFO] [stdout] | [INFO] [stdout] 301 | assert_eq!(fin, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 301 - assert_eq!(fin, true); [INFO] [stdout] 301 + assert!(fin); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/poll.rs:352:21 [INFO] [stdout] | [INFO] [stdout] 352 | assert_eq!(fin, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 352 - assert_eq!(fin, true); [INFO] [stdout] 352 + assert!(fin); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/poll.rs:430:21 [INFO] [stdout] | [INFO] [stdout] 430 | assert_eq!(fin, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 430 - assert_eq!(fin, true); [INFO] [stdout] 430 + assert!(fin); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/async.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 130 | assert_eq!(fin, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 130 - assert_eq!(fin, true); [INFO] [stdout] 130 + assert!(fin); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/async.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | assert_eq!(fin, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 148 - assert_eq!(fin, true); [INFO] [stdout] 148 + assert!(fin); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/async.rs:177:13 [INFO] [stdout] | [INFO] [stdout] 177 | assert_eq!(fin, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 177 - assert_eq!(fin, true); [INFO] [stdout] 177 + assert!(fin); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/async.rs:260:13 [INFO] [stdout] | [INFO] [stdout] 260 | assert_eq!(fin, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 260 - assert_eq!(fin, true); [INFO] [stdout] 260 + assert!(fin); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 20s [INFO] running `Command { std: "docker" "inspect" "ce18b9ff24492b590bc87e95aad5b69b755c97dde71ae368e4f10ba643e1bef1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ce18b9ff24492b590bc87e95aad5b69b755c97dde71ae368e4f10ba643e1bef1", kill_on_drop: false }` [INFO] [stdout] ce18b9ff24492b590bc87e95aad5b69b755c97dde71ae368e4f10ba643e1bef1