[INFO] fetching crate znotify 0.2.0... [INFO] linting znotify-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate znotify 0.2.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate znotify 0.2.0 [INFO] finished tweaking crates.io crate znotify 0.2.0 [INFO] tweaked toml for crates.io crate znotify 0.2.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate znotify 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 171 packages to latest compatible versions [INFO] [stderr] Adding reqwest v0.11.27 (available: v0.13.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 98cdbd7ed3d8ac7e26c6c017cf9162756055e80a362a60dae0e3e1187fb39573 [INFO] running `Command { std: "docker" "start" "-a" "98cdbd7ed3d8ac7e26c6c017cf9162756055e80a362a60dae0e3e1187fb39573", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "98cdbd7ed3d8ac7e26c6c017cf9162756055e80a362a60dae0e3e1187fb39573", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98cdbd7ed3d8ac7e26c6c017cf9162756055e80a362a60dae0e3e1187fb39573", kill_on_drop: false }` [INFO] [stdout] 98cdbd7ed3d8ac7e26c6c017cf9162756055e80a362a60dae0e3e1187fb39573 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9d74a0d576e3f47c6e86b24264849c58d33437ae4dd31f4a7148d84047acd524 [INFO] running `Command { std: "docker" "start" "-a" "9d74a0d576e3f47c6e86b24264849c58d33437ae4dd31f4a7148d84047acd524", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking uuid v1.22.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking openssl v0.10.76 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking native-tls v0.2.18 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking znotify v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `mock` [INFO] [stdout] --> src/constant.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | #[cfg(not(mock))] [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(mock)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(mock)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `mock` [INFO] [stdout] --> src/constant.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 4 | #[cfg(mock)] [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(mock)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(mock)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `mock` [INFO] [stdout] --> src/constant.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | #[cfg(not(mock))] [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(mock)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(mock)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `mock` [INFO] [stdout] --> src/constant.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 4 | #[cfg(mock)] [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(mock)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(mock)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/client.rs:71:34 [INFO] [stdout] | [INFO] [stdout] 71 | data.insert("long", long.unwrap_or_else(String::new)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/client.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 114 | if !Uuid::parse_str(&device_id).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Uuid::parse_str(&device_id).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/entity.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | / impl ToString for Priority { [INFO] [stdout] 18 | | fn to_string(&self) -> String { [INFO] [stdout] 19 | | match self { [INFO] [stdout] 20 | | Priority::High => "high", [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/entity.rs:46:1 [INFO] [stdout] | [INFO] [stdout] 46 | / impl ToString for Channel { [INFO] [stdout] 47 | | fn to_string(&self) -> String { [INFO] [stdout] 48 | | match self { [INFO] [stdout] 49 | | Channel::WebSocket => "WebSocket", [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/entity.rs:59:1 [INFO] [stdout] | [INFO] [stdout] 59 | / impl Default for Priority { [INFO] [stdout] 60 | | fn default() -> Self { [INFO] [stdout] 61 | | Priority::Normal [INFO] [stdout] 62 | | } [INFO] [stdout] 63 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Default)] [INFO] [stdout] 7 | pub enum Priority { [INFO] [stdout] 8 | #[serde(rename = "high")] [INFO] [stdout] ... [INFO] [stdout] 11 | #[serde(rename = "normal")] [INFO] [stdout] 12 ~ #[default] [INFO] [stdout] 13 ~ Normal, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/client.rs:71:34 [INFO] [stdout] | [INFO] [stdout] 71 | data.insert("long", long.unwrap_or_else(String::new)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/client.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 114 | if !Uuid::parse_str(&device_id).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Uuid::parse_str(&device_id).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/entity.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | / impl ToString for Priority { [INFO] [stdout] 18 | | fn to_string(&self) -> String { [INFO] [stdout] 19 | | match self { [INFO] [stdout] 20 | | Priority::High => "high", [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/entity.rs:46:1 [INFO] [stdout] | [INFO] [stdout] 46 | / impl ToString for Channel { [INFO] [stdout] 47 | | fn to_string(&self) -> String { [INFO] [stdout] 48 | | match self { [INFO] [stdout] 49 | | Channel::WebSocket => "WebSocket", [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/entity.rs:59:1 [INFO] [stdout] | [INFO] [stdout] 59 | / impl Default for Priority { [INFO] [stdout] 60 | | fn default() -> Self { [INFO] [stdout] 61 | | Priority::Normal [INFO] [stdout] 62 | | } [INFO] [stdout] 63 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Default)] [INFO] [stdout] 7 | pub enum Priority { [INFO] [stdout] 8 | #[serde(rename = "high")] [INFO] [stdout] ... [INFO] [stdout] 11 | #[serde(rename = "normal")] [INFO] [stdout] 12 ~ #[default] [INFO] [stdout] 13 ~ Normal, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on `Some` value [INFO] [stdout] --> tests/client_test.rs:37:31 [INFO] [stdout] | [INFO] [stdout] 37 | assert_eq!(message.title, title.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the `Some` and `unwrap()` [INFO] [stdout] --> tests/client_test.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 23 | let title = Some("test_title".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on `Some` value [INFO] [stdout] --> tests/client_test.rs:38:30 [INFO] [stdout] | [INFO] [stdout] 38 | assert_eq!(message.long, long.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the `Some` and `unwrap()` [INFO] [stdout] --> tests/client_test.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | let long = Some("test_long".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 26.52s [INFO] running `Command { std: "docker" "inspect" "9d74a0d576e3f47c6e86b24264849c58d33437ae4dd31f4a7148d84047acd524", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d74a0d576e3f47c6e86b24264849c58d33437ae4dd31f4a7148d84047acd524", kill_on_drop: false }` [INFO] [stdout] 9d74a0d576e3f47c6e86b24264849c58d33437ae4dd31f4a7148d84047acd524