[INFO] fetching crate zerortt-poll 0.1.21...
[INFO] linting zerortt-poll-0.1.21 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate zerortt-poll 0.1.21 into /workspace/builds/worker-7-tc1/source
[INFO] started tweaking crates.io crate zerortt-poll 0.1.21
[INFO] finished tweaking crates.io crate zerortt-poll 0.1.21
[INFO] tweaked toml for crates.io crate zerortt-poll 0.1.21 written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate zerortt-poll 0.1.21 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate crates.io crate zerortt-poll 0.1.21 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded priority-queue v2.7.0
[INFO] [stderr]   Downloaded debug_panic v0.2.1
[INFO] [stderr]   Downloaded octets v0.3.3
[INFO] [stderr]   Downloaded zerortt-api v0.1.21
[INFO] [stderr]   Downloaded cc v1.2.43
[INFO] [stderr]   Downloaded boring v4.19.0
[INFO] [stderr]   Downloaded quiche v0.24.6
[INFO] [stderr]   Downloaded boring-sys v4.19.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] a4a68f0dae85818a8b5bf6af4e43928ca7fa282d93c124da53516c22f297847b
[INFO] running `Command { std: "docker" "start" "-a" "a4a68f0dae85818a8b5bf6af4e43928ca7fa282d93c124da53516c22f297847b", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "a4a68f0dae85818a8b5bf6af4e43928ca7fa282d93c124da53516c22f297847b", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a4a68f0dae85818a8b5bf6af4e43928ca7fa282d93c124da53516c22f297847b", kill_on_drop: false }`
[INFO] [stdout] a4a68f0dae85818a8b5bf6af4e43928ca7fa282d93c124da53516c22f297847b
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] cc94d937af7797c447e985affb0867e4b8d277ba6522780b23dea7bd5786bbb7
[INFO] running `Command { std: "docker" "start" "-a" "cc94d937af7797c447e985affb0867e4b8d277ba6522780b23dea7bd5786bbb7", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.177
[INFO] [stderr]    Compiling clang-sys v1.8.1
[INFO] [stderr]    Compiling cc v1.2.43
[INFO] [stderr]    Compiling either v1.15.0
[INFO] [stderr]    Compiling syn v2.0.108
[INFO] [stderr]    Compiling nom v7.1.3
[INFO] [stderr]    Compiling bindgen v0.72.1
[INFO] [stderr]    Compiling bitflags v2.10.0
[INFO] [stderr]     Checking foreign-types-shared v0.3.1
[INFO] [stderr]     Checking smallvec v1.15.1
[INFO] [stderr]    Compiling itertools v0.13.0
[INFO] [stderr]     Checking intrusive-collections v0.9.7
[INFO] [stderr]     Checking debug_panic v0.2.1
[INFO] [stderr]     Checking octets v0.3.3
[INFO] [stderr]     Checking parking_lot_core v0.9.12
[INFO] [stderr]     Checking indexmap v2.12.0
[INFO] [stderr]     Checking parking_lot v0.12.5
[INFO] [stderr]    Compiling cmake v0.1.54
[INFO] [stderr]    Compiling quiche v0.24.6
[INFO] [stderr]     Checking priority-queue v2.7.0
[INFO] [stderr]    Compiling fslock v0.2.1
[INFO] [stderr]    Compiling cexpr v0.6.0
[INFO] [stderr]    Compiling foreign-types-macros v0.2.3
[INFO] [stderr]    Compiling openssl-macros v0.1.1
[INFO] [stderr]    Compiling enum_dispatch v0.3.13
[INFO] [stderr]    Compiling thiserror-impl v2.0.17
[INFO] [stderr]     Checking foreign-types v0.5.0
[INFO] [stderr]     Checking thiserror v2.0.17
[INFO] [stderr]    Compiling boring-sys v4.19.0
[INFO] [stderr]     Checking boring v4.19.0
[INFO] [stderr]     Checking zerortt-api v0.1.21
[INFO] [stderr]     Checking zerortt-poll v0.1.21 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this `impl` can be derived
[INFO] [stdout]   --> src/conn.rs:43:1
[INFO] [stdout]    |
[INFO] [stdout] 43 | / impl Default for LocKind {
[INFO] [stdout] 44 | |     fn default() -> Self {
[INFO] [stdout] 45 | |         Self::None
[INFO] [stdout] 46 | |     }
[INFO] [stdout] 47 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
[INFO] [stdout]    = note: `#[warn(clippy::derivable_impls)]` on by default
[INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant
[INFO] [stdout]    |
[INFO] [stdout] 21 + #[derive(Default)]
[INFO] [stdout] 22 | pub enum LocKind {
[INFO] [stdout] 23 ~     #[default]
[INFO] [stdout] 24 ~     None,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]   --> src/conn.rs:51:9
[INFO] [stdout]    |
[INFO] [stdout] 51 | /         match self {
[INFO] [stdout] 52 | |             LocKind::Send | LocKind::None => false,
[INFO] [stdout] 53 | |             _ => true,
[INFO] [stdout] 54 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]    = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]    |
[INFO] [stdout] 51 -         match self {
[INFO] [stdout] 52 -             LocKind::Send | LocKind::None => false,
[INFO] [stdout] 53 -             _ => true,
[INFO] [stdout] 54 -         }
[INFO] [stdout] 51 +         !matches!(self, LocKind::Send | LocKind::None)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:230:9
[INFO] [stdout]     |
[INFO] [stdout] 230 | /         if let Err(err) = conn.close(app, err, &reason) {
[INFO] [stdout] 231 | |             if err != quiche::Error::Done {
[INFO] [stdout] 232 | |                 self.unlock(_guard.lock_count, false, readiness);
[INFO] [stdout] 233 | |                 return Err(err.into());
[INFO] [stdout] 234 | |             }
[INFO] [stdout] 235 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 230 ~         if let Err(err) = conn.close(app, err, &reason)
[INFO] [stdout] 231 ~             && err != quiche::Error::Done {
[INFO] [stdout] 232 |                 self.unlock(_guard.lock_count, false, readiness);
[INFO] [stdout] 233 |                 return Err(err.into());
[INFO] [stdout] 234 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/conn.rs:269:23
[INFO] [stdout]     |
[INFO] [stdout] 269 |                 r.map(|id| Some(id))
[INFO] [stdout]     |                       ^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]     = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:307:13
[INFO] [stdout]     |
[INFO] [stdout] 307 | /             if !conn.stream_finished(stream_id) {
[INFO] [stdout] 308 | |                 if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) {
[INFO] [stdout] 309 | |                     if err != quiche::Error::Done {
[INFO] [stdout] 310 | |                         return Err(err.into());
[INFO] [stdout] ...   |
[INFO] [stdout] 313 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 307 ~             if !conn.stream_finished(stream_id)
[INFO] [stdout] 308 ~                 && let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) {
[INFO] [stdout] 309 |                     if err != quiche::Error::Done {
[INFO] [stdout] 310 |                         return Err(err.into());
[INFO] [stdout] 311 |                     }
[INFO] [stdout] 312 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:308:17
[INFO] [stdout]     |
[INFO] [stdout] 308 | /                 if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) {
[INFO] [stdout] 309 | |                     if err != quiche::Error::Done {
[INFO] [stdout] 310 | |                         return Err(err.into());
[INFO] [stdout] 311 | |                     }
[INFO] [stdout] 312 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 308 ~                 if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err)
[INFO] [stdout] 309 ~                     && err != quiche::Error::Done {
[INFO] [stdout] 310 |                         return Err(err.into());
[INFO] [stdout] 311 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:316:13
[INFO] [stdout]     |
[INFO] [stdout] 316 | /             if let Err(err) = conn.stream_send(stream_id, b"", true) {
[INFO] [stdout] 317 | |                 if err != quiche::Error::Done {
[INFO] [stdout] 318 | |                     return Err(err.into());
[INFO] [stdout] 319 | |                 }
[INFO] [stdout] 320 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 316 ~             if let Err(err) = conn.stream_send(stream_id, b"", true)
[INFO] [stdout] 317 ~                 && err != quiche::Error::Done {
[INFO] [stdout] 318 |                     return Err(err.into());
[INFO] [stdout] 319 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:323:17
[INFO] [stdout]     |
[INFO] [stdout] 323 | /                 if let Err(err) = conn.stream_send(stream_id, b"", true) {
[INFO] [stdout] 324 | |                     if err != quiche::Error::Done {
[INFO] [stdout] 325 | |                         return Err(err.into());
[INFO] [stdout] 326 | |                     }
[INFO] [stdout] 327 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 323 ~                 if let Err(err) = conn.stream_send(stream_id, b"", true)
[INFO] [stdout] 324 ~                     && err != quiche::Error::Done {
[INFO] [stdout] 325 |                         return Err(err.into());
[INFO] [stdout] 326 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:329:17
[INFO] [stdout]     |
[INFO] [stdout] 329 | /                 if !conn.stream_finished(stream_id) {
[INFO] [stdout] 330 | |                     if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) {
[INFO] [stdout] 331 | |                         if err != quiche::Error::Done {
[INFO] [stdout] 332 | |                             return Err(err.into());
[INFO] [stdout] ...   |
[INFO] [stdout] 335 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 329 ~                 if !conn.stream_finished(stream_id)
[INFO] [stdout] 330 ~                     && let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) {
[INFO] [stdout] 331 |                         if err != quiche::Error::Done {
[INFO] [stdout] 332 |                             return Err(err.into());
[INFO] [stdout] 333 |                         }
[INFO] [stdout] 334 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:330:21
[INFO] [stdout]     |
[INFO] [stdout] 330 | /                     if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) {
[INFO] [stdout] 331 | |                         if err != quiche::Error::Done {
[INFO] [stdout] 332 | |                             return Err(err.into());
[INFO] [stdout] 333 | |                         }
[INFO] [stdout] 334 | |                     }
[INFO] [stdout]     | |_____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 330 ~                     if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err)
[INFO] [stdout] 331 ~                         && err != quiche::Error::Done {
[INFO] [stdout] 332 |                             return Err(err.into());
[INFO] [stdout] 333 ~                         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/conn.rs:374:9
[INFO] [stdout]     |
[INFO] [stdout] 374 |         return Ok(stream_id);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 374 -         return Ok(stream_id);
[INFO] [stdout] 374 +         Ok(stream_id)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:431:21
[INFO] [stdout]     |
[INFO] [stdout] 431 | /                     if let Err(err) = conn.close(app, err, &reason) {
[INFO] [stdout] 432 | |                         if err != quiche::Error::Done {
[INFO] [stdout] 433 | |                             log::error!("close connection, id={}, err={}", conn.trace_id(), err);
[INFO] [stdout] ...   |
[INFO] [stdout] 446 | |                     }
[INFO] [stdout]     | |_____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 431 ~                     if let Err(err) = conn.close(app, err, &reason)
[INFO] [stdout] 432 ~                         && err != quiche::Error::Done {
[INFO] [stdout] 433 |                             log::error!("close connection, id={}, err={}", conn.trace_id(), err);
[INFO] [stdout] ...
[INFO] [stdout] 444 |                             );
[INFO] [stdout] 445 ~                         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/readiness.rs:59:16
[INFO] [stdout]    |
[INFO] [stdout] 59 |             if !(deadline.checked_duration_since(now).unwrap_or_default() > release_timer_threshold)
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(deadline.checked_duration_since(now).unwrap_or_default() <= release_timer_threshold)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/readiness.rs:70:9
[INFO] [stdout]    |
[INFO] [stdout] 70 |         return None;
[INFO] [stdout]    |         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 70 -         return None;
[INFO] [stdout] 70 +         None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `impl` can be derived
[INFO] [stdout]   --> src/group.rs:60:1
[INFO] [stdout]    |
[INFO] [stdout] 60 | / impl Default for Group {
[INFO] [stdout] 61 | |     fn default() -> Self {
[INFO] [stdout] 62 | |         Self {
[INFO] [stdout] 63 | |             state: Default::default(),
[INFO] [stdout] ...  |
[INFO] [stdout] 67 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
[INFO] [stdout] help: replace the manual implementation with a derive attribute
[INFO] [stdout]    |
[INFO] [stdout] 55 + #[derive(Default)]
[INFO] [stdout] 56 | pub struct Group {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Token` which implements the `Copy` trait
[INFO] [stdout]    --> src/group.rs:112:21
[INFO] [stdout]     |
[INFO] [stdout] 112 |           let token = self
[INFO] [stdout]     |  _____________________^
[INFO] [stdout] 113 | |             .scids
[INFO] [stdout] 114 | |             .read()
[INFO] [stdout] 115 | |             .get(&scid)
[INFO] [stdout] 116 | |             .ok_or_else(|| Error::NotFound)?
[INFO] [stdout] 117 | |             .clone();
[INFO] [stdout]     | |____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] help: try dereferencing it
[INFO] [stdout]     |
[INFO] [stdout] 112 ~         let token = *self
[INFO] [stdout] 113 +             .scids
[INFO] [stdout] 114 +             .read()
[INFO] [stdout] 115 +             .get(&scid)
[INFO] [stdout] 116 ~             .ok_or_else(|| Error::NotFound)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/group.rs:112:21
[INFO] [stdout]     |
[INFO] [stdout] 112 |           let token = self
[INFO] [stdout]     |  _____________________^
[INFO] [stdout] 113 | |             .scids
[INFO] [stdout] 114 | |             .read()
[INFO] [stdout] 115 | |             .get(&scid)
[INFO] [stdout] 116 | |             .ok_or_else(|| Error::NotFound)?
[INFO] [stdout]     | |___________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 116 -             .ok_or_else(|| Error::NotFound)?
[INFO] [stdout] 116 +             .ok_or(Error::NotFound)?
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/group.rs:115:18
[INFO] [stdout]     |
[INFO] [stdout] 115 |             .get(&scid)
[INFO] [stdout]     |                  ^^^^^ help: change this to: `scid`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/group.rs:121:28
[INFO] [stdout]     |
[INFO] [stdout] 121 |           let Ok(mut conn) = state
[INFO] [stdout]     |  ____________________________^
[INFO] [stdout] 122 | |             .conns
[INFO] [stdout] 123 | |             .get(&token)
[INFO] [stdout] 124 | |             .ok_or_else(|| Error::NotFound)?
[INFO] [stdout]     | |___________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 124 -             .ok_or_else(|| Error::NotFound)?
[INFO] [stdout] 124 +             .ok_or(Error::NotFound)?
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/group.rs:208:40
[INFO] [stdout]     |
[INFO] [stdout] 208 |           let conn: quiche::Connection = state
[INFO] [stdout]     |  ________________________________________^
[INFO] [stdout] 209 | |             .conns
[INFO] [stdout] 210 | |             .remove(&token)
[INFO] [stdout] 211 | |             .ok_or_else(|| Error::NotFound)?
[INFO] [stdout]     | |___________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 211 -             .ok_or_else(|| Error::NotFound)?
[INFO] [stdout] 211 +             .ok_or(Error::NotFound)?
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/group.rs:235:20
[INFO] [stdout]     |
[INFO] [stdout] 235 |         let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?;
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 235 -         let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?;
[INFO] [stdout] 235 +         let conn = state.conns.get(&token).ok_or(Error::NotFound)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/group.rs:250:20
[INFO] [stdout]     |
[INFO] [stdout] 250 |         let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?;
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 250 -         let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?;
[INFO] [stdout] 250 +         let conn = state.conns.get(&token).ok_or(Error::NotFound)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/group.rs:260:20
[INFO] [stdout]     |
[INFO] [stdout] 260 |         let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?;
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 260 -         let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?;
[INFO] [stdout] 260 +         let conn = state.conns.get(&token).ok_or(Error::NotFound)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:287:17
[INFO] [stdout]     |
[INFO] [stdout] 287 |                 return Ok(send_size);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 287 -                 return Ok(send_size);
[INFO] [stdout] 287 +                 Ok(send_size)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:296:17
[INFO] [stdout]     |
[INFO] [stdout] 296 |                 return Err(Error::Retry);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 296 -                 return Err(Error::Retry);
[INFO] [stdout] 296 +                 Err(Error::Retry)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:307:17
[INFO] [stdout]     |
[INFO] [stdout] 307 |                 return Err(Error::Quiche(err));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 307 -                 return Err(Error::Quiche(err));
[INFO] [stdout] 307 +                 Err(Error::Quiche(err))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:327:17
[INFO] [stdout]     |
[INFO] [stdout] 327 |                 return Ok((recv_size, fin));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 327 -                 return Ok((recv_size, fin));
[INFO] [stdout] 327 +                 Ok((recv_size, fin))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:349:17
[INFO] [stdout]     |
[INFO] [stdout] 349 |                 return Err(Error::Retry);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 349 -                 return Err(Error::Retry);
[INFO] [stdout] 349 +                 Err(Error::Retry)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:360:17
[INFO] [stdout]     |
[INFO] [stdout] 360 |                 return Err(Error::Quiche(err));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 360 -                 return Err(Error::Quiche(err));
[INFO] [stdout] 360 +                 Err(Error::Quiche(err))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:416:17
[INFO] [stdout]     |
[INFO] [stdout] 416 |                 return Ok((send_size, send_info));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 416 -                 return Ok((send_size, send_info));
[INFO] [stdout] 416 +                 Ok((send_size, send_info))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:421:17
[INFO] [stdout]     |
[INFO] [stdout] 421 |                 return Err(Error::Retry);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 421 -                 return Err(Error::Retry);
[INFO] [stdout] 421 +                 Err(Error::Retry)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:425:17
[INFO] [stdout]     |
[INFO] [stdout] 425 |                 return Err(Error::Quiche(err));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 425 -                 return Err(Error::Quiche(err));
[INFO] [stdout] 425 +                 Err(Error::Quiche(err))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `impl` can be derived
[INFO] [stdout]   --> src/conn.rs:43:1
[INFO] [stdout]    |
[INFO] [stdout] 43 | / impl Default for LocKind {
[INFO] [stdout] 44 | |     fn default() -> Self {
[INFO] [stdout] 45 | |         Self::None
[INFO] [stdout] 46 | |     }
[INFO] [stdout] 47 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
[INFO] [stdout]    = note: `#[warn(clippy::derivable_impls)]` on by default
[INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant
[INFO] [stdout]    |
[INFO] [stdout] 21 + #[derive(Default)]
[INFO] [stdout] 22 | pub enum LocKind {
[INFO] [stdout] 23 ~     #[default]
[INFO] [stdout] 24 ~     None,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]   --> src/conn.rs:51:9
[INFO] [stdout]    |
[INFO] [stdout] 51 | /         match self {
[INFO] [stdout] 52 | |             LocKind::Send | LocKind::None => false,
[INFO] [stdout] 53 | |             _ => true,
[INFO] [stdout] 54 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]    = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]    |
[INFO] [stdout] 51 -         match self {
[INFO] [stdout] 52 -             LocKind::Send | LocKind::None => false,
[INFO] [stdout] 53 -             _ => true,
[INFO] [stdout] 54 -         }
[INFO] [stdout] 51 +         !matches!(self, LocKind::Send | LocKind::None)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:230:9
[INFO] [stdout]     |
[INFO] [stdout] 230 | /         if let Err(err) = conn.close(app, err, &reason) {
[INFO] [stdout] 231 | |             if err != quiche::Error::Done {
[INFO] [stdout] 232 | |                 self.unlock(_guard.lock_count, false, readiness);
[INFO] [stdout] 233 | |                 return Err(err.into());
[INFO] [stdout] 234 | |             }
[INFO] [stdout] 235 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 230 ~         if let Err(err) = conn.close(app, err, &reason)
[INFO] [stdout] 231 ~             && err != quiche::Error::Done {
[INFO] [stdout] 232 |                 self.unlock(_guard.lock_count, false, readiness);
[INFO] [stdout] 233 |                 return Err(err.into());
[INFO] [stdout] 234 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/conn.rs:269:23
[INFO] [stdout]     |
[INFO] [stdout] 269 |                 r.map(|id| Some(id))
[INFO] [stdout]     |                       ^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]     = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:307:13
[INFO] [stdout]     |
[INFO] [stdout] 307 | /             if !conn.stream_finished(stream_id) {
[INFO] [stdout] 308 | |                 if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) {
[INFO] [stdout] 309 | |                     if err != quiche::Error::Done {
[INFO] [stdout] 310 | |                         return Err(err.into());
[INFO] [stdout] ...   |
[INFO] [stdout] 313 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 307 ~             if !conn.stream_finished(stream_id)
[INFO] [stdout] 308 ~                 && let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) {
[INFO] [stdout] 309 |                     if err != quiche::Error::Done {
[INFO] [stdout] 310 |                         return Err(err.into());
[INFO] [stdout] 311 |                     }
[INFO] [stdout] 312 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:308:17
[INFO] [stdout]     |
[INFO] [stdout] 308 | /                 if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) {
[INFO] [stdout] 309 | |                     if err != quiche::Error::Done {
[INFO] [stdout] 310 | |                         return Err(err.into());
[INFO] [stdout] 311 | |                     }
[INFO] [stdout] 312 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 308 ~                 if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err)
[INFO] [stdout] 309 ~                     && err != quiche::Error::Done {
[INFO] [stdout] 310 |                         return Err(err.into());
[INFO] [stdout] 311 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:316:13
[INFO] [stdout]     |
[INFO] [stdout] 316 | /             if let Err(err) = conn.stream_send(stream_id, b"", true) {
[INFO] [stdout] 317 | |                 if err != quiche::Error::Done {
[INFO] [stdout] 318 | |                     return Err(err.into());
[INFO] [stdout] 319 | |                 }
[INFO] [stdout] 320 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 316 ~             if let Err(err) = conn.stream_send(stream_id, b"", true)
[INFO] [stdout] 317 ~                 && err != quiche::Error::Done {
[INFO] [stdout] 318 |                     return Err(err.into());
[INFO] [stdout] 319 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:323:17
[INFO] [stdout]     |
[INFO] [stdout] 323 | /                 if let Err(err) = conn.stream_send(stream_id, b"", true) {
[INFO] [stdout] 324 | |                     if err != quiche::Error::Done {
[INFO] [stdout] 325 | |                         return Err(err.into());
[INFO] [stdout] 326 | |                     }
[INFO] [stdout] 327 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 323 ~                 if let Err(err) = conn.stream_send(stream_id, b"", true)
[INFO] [stdout] 324 ~                     && err != quiche::Error::Done {
[INFO] [stdout] 325 |                         return Err(err.into());
[INFO] [stdout] 326 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:329:17
[INFO] [stdout]     |
[INFO] [stdout] 329 | /                 if !conn.stream_finished(stream_id) {
[INFO] [stdout] 330 | |                     if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) {
[INFO] [stdout] 331 | |                         if err != quiche::Error::Done {
[INFO] [stdout] 332 | |                             return Err(err.into());
[INFO] [stdout] ...   |
[INFO] [stdout] 335 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 329 ~                 if !conn.stream_finished(stream_id)
[INFO] [stdout] 330 ~                     && let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) {
[INFO] [stdout] 331 |                         if err != quiche::Error::Done {
[INFO] [stdout] 332 |                             return Err(err.into());
[INFO] [stdout] 333 |                         }
[INFO] [stdout] 334 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:330:21
[INFO] [stdout]     |
[INFO] [stdout] 330 | /                     if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err) {
[INFO] [stdout] 331 | |                         if err != quiche::Error::Done {
[INFO] [stdout] 332 | |                             return Err(err.into());
[INFO] [stdout] 333 | |                         }
[INFO] [stdout] 334 | |                     }
[INFO] [stdout]     | |_____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 330 ~                     if let Err(err) = conn.stream_shutdown(stream_id, Shutdown::Read, err)
[INFO] [stdout] 331 ~                         && err != quiche::Error::Done {
[INFO] [stdout] 332 |                             return Err(err.into());
[INFO] [stdout] 333 ~                         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/conn.rs:374:9
[INFO] [stdout]     |
[INFO] [stdout] 374 |         return Ok(stream_id);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 374 -         return Ok(stream_id);
[INFO] [stdout] 374 +         Ok(stream_id)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/conn.rs:431:21
[INFO] [stdout]     |
[INFO] [stdout] 431 | /                     if let Err(err) = conn.close(app, err, &reason) {
[INFO] [stdout] 432 | |                         if err != quiche::Error::Done {
[INFO] [stdout] 433 | |                             log::error!("close connection, id={}, err={}", conn.trace_id(), err);
[INFO] [stdout] ...   |
[INFO] [stdout] 446 | |                     }
[INFO] [stdout]     | |_____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 431 ~                     if let Err(err) = conn.close(app, err, &reason)
[INFO] [stdout] 432 ~                         && err != quiche::Error::Done {
[INFO] [stdout] 433 |                             log::error!("close connection, id={}, err={}", conn.trace_id(), err);
[INFO] [stdout] ...
[INFO] [stdout] 444 |                             );
[INFO] [stdout] 445 ~                         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/readiness.rs:59:16
[INFO] [stdout]    |
[INFO] [stdout] 59 |             if !(deadline.checked_duration_since(now).unwrap_or_default() > release_timer_threshold)
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(deadline.checked_duration_since(now).unwrap_or_default() <= release_timer_threshold)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/readiness.rs:70:9
[INFO] [stdout]    |
[INFO] [stdout] 70 |         return None;
[INFO] [stdout]    |         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 70 -         return None;
[INFO] [stdout] 70 +         None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `impl` can be derived
[INFO] [stdout]   --> src/group.rs:60:1
[INFO] [stdout]    |
[INFO] [stdout] 60 | / impl Default for Group {
[INFO] [stdout] 61 | |     fn default() -> Self {
[INFO] [stdout] 62 | |         Self {
[INFO] [stdout] 63 | |             state: Default::default(),
[INFO] [stdout] ...  |
[INFO] [stdout] 67 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
[INFO] [stdout] help: replace the manual implementation with a derive attribute
[INFO] [stdout]    |
[INFO] [stdout] 55 + #[derive(Default)]
[INFO] [stdout] 56 | pub struct Group {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Token` which implements the `Copy` trait
[INFO] [stdout]    --> src/group.rs:112:21
[INFO] [stdout]     |
[INFO] [stdout] 112 |           let token = self
[INFO] [stdout]     |  _____________________^
[INFO] [stdout] 113 | |             .scids
[INFO] [stdout] 114 | |             .read()
[INFO] [stdout] 115 | |             .get(&scid)
[INFO] [stdout] 116 | |             .ok_or_else(|| Error::NotFound)?
[INFO] [stdout] 117 | |             .clone();
[INFO] [stdout]     | |____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] help: try dereferencing it
[INFO] [stdout]     |
[INFO] [stdout] 112 ~         let token = *self
[INFO] [stdout] 113 +             .scids
[INFO] [stdout] 114 +             .read()
[INFO] [stdout] 115 +             .get(&scid)
[INFO] [stdout] 116 ~             .ok_or_else(|| Error::NotFound)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/group.rs:112:21
[INFO] [stdout]     |
[INFO] [stdout] 112 |           let token = self
[INFO] [stdout]     |  _____________________^
[INFO] [stdout] 113 | |             .scids
[INFO] [stdout] 114 | |             .read()
[INFO] [stdout] 115 | |             .get(&scid)
[INFO] [stdout] 116 | |             .ok_or_else(|| Error::NotFound)?
[INFO] [stdout]     | |___________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 116 -             .ok_or_else(|| Error::NotFound)?
[INFO] [stdout] 116 +             .ok_or(Error::NotFound)?
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/group.rs:115:18
[INFO] [stdout]     |
[INFO] [stdout] 115 |             .get(&scid)
[INFO] [stdout]     |                  ^^^^^ help: change this to: `scid`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/group.rs:121:28
[INFO] [stdout]     |
[INFO] [stdout] 121 |           let Ok(mut conn) = state
[INFO] [stdout]     |  ____________________________^
[INFO] [stdout] 122 | |             .conns
[INFO] [stdout] 123 | |             .get(&token)
[INFO] [stdout] 124 | |             .ok_or_else(|| Error::NotFound)?
[INFO] [stdout]     | |___________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 124 -             .ok_or_else(|| Error::NotFound)?
[INFO] [stdout] 124 +             .ok_or(Error::NotFound)?
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/group.rs:208:40
[INFO] [stdout]     |
[INFO] [stdout] 208 |           let conn: quiche::Connection = state
[INFO] [stdout]     |  ________________________________________^
[INFO] [stdout] 209 | |             .conns
[INFO] [stdout] 210 | |             .remove(&token)
[INFO] [stdout] 211 | |             .ok_or_else(|| Error::NotFound)?
[INFO] [stdout]     | |___________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 211 -             .ok_or_else(|| Error::NotFound)?
[INFO] [stdout] 211 +             .ok_or(Error::NotFound)?
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/group.rs:235:20
[INFO] [stdout]     |
[INFO] [stdout] 235 |         let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?;
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 235 -         let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?;
[INFO] [stdout] 235 +         let conn = state.conns.get(&token).ok_or(Error::NotFound)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/group.rs:250:20
[INFO] [stdout]     |
[INFO] [stdout] 250 |         let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?;
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 250 -         let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?;
[INFO] [stdout] 250 +         let conn = state.conns.get(&token).ok_or(Error::NotFound)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/group.rs:260:20
[INFO] [stdout]     |
[INFO] [stdout] 260 |         let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?;
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 260 -         let conn = state.conns.get(&token).ok_or_else(|| Error::NotFound)?;
[INFO] [stdout] 260 +         let conn = state.conns.get(&token).ok_or(Error::NotFound)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:287:17
[INFO] [stdout]     |
[INFO] [stdout] 287 |                 return Ok(send_size);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 287 -                 return Ok(send_size);
[INFO] [stdout] 287 +                 Ok(send_size)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:296:17
[INFO] [stdout]     |
[INFO] [stdout] 296 |                 return Err(Error::Retry);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 296 -                 return Err(Error::Retry);
[INFO] [stdout] 296 +                 Err(Error::Retry)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:307:17
[INFO] [stdout]     |
[INFO] [stdout] 307 |                 return Err(Error::Quiche(err));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 307 -                 return Err(Error::Quiche(err));
[INFO] [stdout] 307 +                 Err(Error::Quiche(err))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:327:17
[INFO] [stdout]     |
[INFO] [stdout] 327 |                 return Ok((recv_size, fin));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 327 -                 return Ok((recv_size, fin));
[INFO] [stdout] 327 +                 Ok((recv_size, fin))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:349:17
[INFO] [stdout]     |
[INFO] [stdout] 349 |                 return Err(Error::Retry);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 349 -                 return Err(Error::Retry);
[INFO] [stdout] 349 +                 Err(Error::Retry)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:360:17
[INFO] [stdout]     |
[INFO] [stdout] 360 |                 return Err(Error::Quiche(err));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 360 -                 return Err(Error::Quiche(err));
[INFO] [stdout] 360 +                 Err(Error::Quiche(err))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:416:17
[INFO] [stdout]     |
[INFO] [stdout] 416 |                 return Ok((send_size, send_info));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 416 -                 return Ok((send_size, send_info));
[INFO] [stdout] 416 +                 Ok((send_size, send_info))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:421:17
[INFO] [stdout]     |
[INFO] [stdout] 421 |                 return Err(Error::Retry);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 421 -                 return Err(Error::Retry);
[INFO] [stdout] 421 +                 Err(Error::Retry)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:425:17
[INFO] [stdout]     |
[INFO] [stdout] 425 |                 return Err(Error::Quiche(err));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 425 -                 return Err(Error::Quiche(err));
[INFO] [stdout] 425 +                 Err(Error::Quiche(err))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 43s
[INFO] running `Command { std: "docker" "inspect" "cc94d937af7797c447e985affb0867e4b8d277ba6522780b23dea7bd5786bbb7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "cc94d937af7797c447e985affb0867e4b8d277ba6522780b23dea7bd5786bbb7", kill_on_drop: false }`
[INFO] [stdout] cc94d937af7797c447e985affb0867e4b8d277ba6522780b23dea7bd5786bbb7