[INFO] fetching crate zerortt-mio 0.1.21... [INFO] linting zerortt-mio-0.1.21 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate zerortt-mio 0.1.21 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate zerortt-mio 0.1.21 [INFO] finished tweaking crates.io crate zerortt-mio 0.1.21 [INFO] tweaked toml for crates.io crate zerortt-mio 0.1.21 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate zerortt-mio 0.1.21 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate zerortt-mio 0.1.21 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded metricrs-derive v0.1.2 [INFO] [stderr] Downloaded debug_panic v0.2.1 [INFO] [stderr] Downloaded zerortt-api v0.1.21 [INFO] [stderr] Downloaded octets v0.3.3 [INFO] [stderr] Downloaded metricrs v0.1.2 [INFO] [stderr] Downloaded fixedbuf v0.1.2 [INFO] [stderr] Downloaded boring v4.19.0 [INFO] [stderr] Downloaded boring-sys v4.19.0 [INFO] [stderr] Downloaded zerortt-futures v0.1.21 [INFO] [stderr] Downloaded priority-queue v2.7.0 [INFO] [stderr] Downloaded zerortt-poll v0.1.21 [INFO] [stderr] Downloaded quiche v0.24.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cdebe265bceb00be796565445b6900e510627694f1d059597b484b787140924a [INFO] running `Command { std: "docker" "start" "-a" "cdebe265bceb00be796565445b6900e510627694f1d059597b484b787140924a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cdebe265bceb00be796565445b6900e510627694f1d059597b484b787140924a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cdebe265bceb00be796565445b6900e510627694f1d059597b484b787140924a", kill_on_drop: false }` [INFO] [stdout] cdebe265bceb00be796565445b6900e510627694f1d059597b484b787140924a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bfbd422653c6276409f1ee759fd06c57ee19347c3ddc0081f5d328cbc9380457 [INFO] running `Command { std: "docker" "start" "-a" "bfbd422653c6276409f1ee759fd06c57ee19347c3ddc0081f5d328cbc9380457", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.20 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Compiling bindgen v0.72.1 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling cc v1.2.43 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling bitflags v2.10.0 [INFO] [stderr] Checking foreign-types-shared v0.3.1 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking octets v0.3.3 [INFO] [stderr] Checking debug_panic v0.2.1 [INFO] [stderr] Checking indexmap v2.12.0 [INFO] [stderr] Checking mio v1.1.0 [INFO] [stderr] Checking fixedbuf v0.1.2 [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Checking priority-queue v2.7.0 [INFO] [stderr] Compiling syn v2.0.108 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling fslock v0.2.1 [INFO] [stderr] Compiling quiche v0.24.6 [INFO] [stderr] Compiling regex-automata v0.4.13 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling regex v1.12.2 [INFO] [stderr] Compiling foreign-types-macros v0.2.3 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling metricrs-derive v0.1.2 [INFO] [stderr] Checking foreign-types v0.5.0 [INFO] [stderr] Checking metricrs v0.1.2 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Compiling boring-sys v4.19.0 [INFO] [stderr] Checking boring v4.19.0 [INFO] [stderr] Checking zerortt-api v0.1.21 [INFO] [stderr] Checking zerortt-poll v0.1.21 [INFO] [stderr] Checking zerortt-futures v0.1.21 [INFO] [stderr] Checking zerortt-mio v0.1.21 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/group.rs:136:26 [INFO] [stdout] | [INFO] [stdout] 136 | .map_err(|err| Error::from(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Error::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/group.rs:224:22 [INFO] [stdout] | [INFO] [stdout] 224 | .map_err(|err| Error::from(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Error::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to move all elements into a new `Vec` [INFO] [stdout] --> src/group.rs:321:26 [INFO] [stdout] | [INFO] [stdout] 321 | for event in events.drain(..).collect::>() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `mem::take`: `std::mem::take(events)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drain_collect [INFO] [stdout] = note: `#[warn(clippy::drain_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/group.rs:136:26 [INFO] [stdout] | [INFO] [stdout] 136 | .map_err(|err| Error::from(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Error::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/group.rs:224:22 [INFO] [stdout] | [INFO] [stdout] 224 | .map_err(|err| Error::from(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Error::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to move all elements into a new `Vec` [INFO] [stdout] --> src/group.rs:321:26 [INFO] [stdout] | [INFO] [stdout] 321 | for event in events.drain(..).collect::>() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `mem::take`: `std::mem::take(events)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drain_collect [INFO] [stdout] = note: `#[warn(clippy::drain_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/udp.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 158 | assert!(!(self.sending.len() > self.sending_buffer_limits)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.sending.len() <= self.sending_buffer_limits)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `udp::QuicSocketError` [INFO] [stdout] --> src/udp.rs:154:24 [INFO] [stdout] | [INFO] [stdout] 154 | return Err(QuicSocketError::IsFull(buf).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `QuicSocketError::IsFull(buf)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/udp.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 179 | / if read_size > 0 { [INFO] [stdout] 180 | | if let Some(counter) = &self.recv_counter { [INFO] [stdout] 181 | | counter.increment(read_size as u64); [INFO] [stdout] 182 | | } [INFO] [stdout] 183 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 179 ~ if read_size > 0 [INFO] [stdout] 180 ~ && let Some(counter) = &self.recv_counter { [INFO] [stdout] 181 | counter.increment(read_size as u64); [INFO] [stdout] 182 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/udp.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 158 | assert!(!(self.sending.len() > self.sending_buffer_limits)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.sending.len() <= self.sending_buffer_limits)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `udp::QuicSocketError` [INFO] [stdout] --> src/udp.rs:154:24 [INFO] [stdout] | [INFO] [stdout] 154 | return Err(QuicSocketError::IsFull(buf).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `QuicSocketError::IsFull(buf)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/udp.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 179 | / if read_size > 0 { [INFO] [stdout] 180 | | if let Some(counter) = &self.recv_counter { [INFO] [stdout] 181 | | counter.increment(read_size as u64); [INFO] [stdout] 182 | | } [INFO] [stdout] 183 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 179 ~ if read_size > 0 [INFO] [stdout] 180 ~ && let Some(counter) = &self.recv_counter { [INFO] [stdout] 181 | counter.increment(read_size as u64); [INFO] [stdout] 182 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 02s [INFO] running `Command { std: "docker" "inspect" "bfbd422653c6276409f1ee759fd06c57ee19347c3ddc0081f5d328cbc9380457", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bfbd422653c6276409f1ee759fd06c57ee19347c3ddc0081f5d328cbc9380457", kill_on_drop: false }` [INFO] [stdout] bfbd422653c6276409f1ee759fd06c57ee19347c3ddc0081f5d328cbc9380457