[INFO] fetching crate z1info_rust 0.1.4... [INFO] linting z1info_rust-0.1.4 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate z1info_rust 0.1.4 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate z1info_rust 0.1.4 [INFO] finished tweaking crates.io crate z1info_rust 0.1.4 [INFO] tweaked toml for crates.io crate z1info_rust 0.1.4 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate z1info_rust 0.1.4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c595e52efa8b165e360b760c62d759a3ec128dda72e6d15020ae52408b659ab7 [INFO] running `Command { std: "docker" "start" "-a" "c595e52efa8b165e360b760c62d759a3ec128dda72e6d15020ae52408b659ab7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c595e52efa8b165e360b760c62d759a3ec128dda72e6d15020ae52408b659ab7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c595e52efa8b165e360b760c62d759a3ec128dda72e6d15020ae52408b659ab7", kill_on_drop: false }` [INFO] [stdout] c595e52efa8b165e360b760c62d759a3ec128dda72e6d15020ae52408b659ab7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 806937da6aea616fd83aee03a93b84ac86ae7aed48b157592d37f686b9740573 [INFO] running `Command { std: "docker" "start" "-a" "806937da6aea616fd83aee03a93b84ac86ae7aed48b157592d37f686b9740573", kill_on_drop: false }` [INFO] [stderr] Checking z1info_rust v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `get_current_timestamp` is never used [INFO] [stdout] --> src/lib.rs:133:4 [INFO] [stdout] | [INFO] [stdout] 133 | fn get_current_timestamp()->u64{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless `fn main` in doctest [INFO] [stdout] --> src/lib.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | //! fn main() { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main [INFO] [stdout] = note: `#[warn(clippy::needless_doctest_main)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:77:61 [INFO] [stdout] | [INFO] [stdout] 77 | content = str::replace(&content[..],"{build_time}",&format!("{}",get_current_time())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `get_current_time().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:96:20 [INFO] [stdout] | [INFO] [stdout] 96 | return !(flag == &args[lenght-1][0..flag_length]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(flag != &args[lenght-1][0..flag_length])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return true; [INFO] [stdout] 100 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:88:21 [INFO] [stdout] | [INFO] [stdout] 88 | fn is_runtime(args: &Vec)->bool{ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 88 - fn is_runtime(args: &Vec)->bool{ [INFO] [stdout] 88 + fn is_runtime(args: &[String])->bool{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | return ret_end; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return ret_end; [INFO] [stdout] 130 + ret_end [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | let out_str: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `out_str` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 106 ~ [INFO] [stdout] 107 | [INFO] [stdout] 108 ~ let out_str: String = if cfg!(target_os = "windows") { [INFO] [stdout] 109 | let output = Command::new("cmd") [INFO] [stdout] ... [INFO] [stdout] 115 | [INFO] [stdout] 116 ~ format!("{}", String::from_utf8_lossy(&output.stdout)) [INFO] [stdout] 117 | } else { [INFO] [stdout] ... [INFO] [stdout] 124 | [INFO] [stdout] 125 ~ format!("{}", String::from_utf8_lossy(&output.stdout)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:114:10 [INFO] [stdout] | [INFO] [stdout] 114 | .expect(&format!("cmd exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("cmd exec error!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:111:14 [INFO] [stdout] | [INFO] [stdout] 111 | .arg(&cmd_str) [INFO] [stdout] | ^^^^^^^^ help: change this to: `cmd_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:114:18 [INFO] [stdout] | [INFO] [stdout] 114 | .expect(&format!("cmd exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"cmd exec error!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:123:10 [INFO] [stdout] | [INFO] [stdout] 123 | .expect(&format!("sh exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("sh exec error!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:120:14 [INFO] [stdout] | [INFO] [stdout] 120 | .arg(&cmd_str) [INFO] [stdout] | ^^^^^^^^ help: change this to: `cmd_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:123:18 [INFO] [stdout] | [INFO] [stdout] 123 | .expect(&format!("sh exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"sh exec error!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 139 | return since_the_epoch.as_secs(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return since_the_epoch.as_secs(); [INFO] [stdout] 139 + since_the_epoch.as_secs() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | / return match std::path::Path::new(path).canonicalize() { [INFO] [stdout] 144 | | Ok(_buf) => true, [INFO] [stdout] 145 | | Err(_error) => false, [INFO] [stdout] 146 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 ~ match std::path::Path::new(path).canonicalize() { [INFO] [stdout] 144 + Ok(_buf) => true, [INFO] [stdout] 145 + Err(_error) => false, [INFO] [stdout] 146 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_current_timestamp` is never used [INFO] [stdout] --> src/lib.rs:133:4 [INFO] [stdout] | [INFO] [stdout] 133 | fn get_current_timestamp()->u64{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless `fn main` in doctest [INFO] [stdout] --> src/lib.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | //! fn main() { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main [INFO] [stdout] = note: `#[warn(clippy::needless_doctest_main)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:211:5 [INFO] [stdout] | [INFO] [stdout] 211 | return ret_end; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return ret_end; [INFO] [stdout] 211 + ret_end [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 187 | let out_str: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `out_str` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 187 ~ [INFO] [stdout] 188 | [INFO] [stdout] 189 ~ let out_str: String = if cfg!(target_os = "windows") { [INFO] [stdout] 190 | let output = Command::new("cmd") [INFO] [stdout] ... [INFO] [stdout] 196 | [INFO] [stdout] 197 ~ format!("{}", String::from_utf8_lossy(&output.stdout)) [INFO] [stdout] 198 | } else { [INFO] [stdout] ... [INFO] [stdout] 205 | [INFO] [stdout] 206 ~ format!("{}", String::from_utf8_lossy(&output.stdout)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:195:10 [INFO] [stdout] | [INFO] [stdout] 195 | .expect(&format!("cmd exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("cmd exec error!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:195:18 [INFO] [stdout] | [INFO] [stdout] 195 | .expect(&format!("cmd exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"cmd exec error!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:204:10 [INFO] [stdout] | [INFO] [stdout] 204 | .expect(&format!("sh exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("sh exec error!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:77:61 [INFO] [stdout] | [INFO] [stdout] 77 | content = str::replace(&content[..],"{build_time}",&format!("{}",get_current_time())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `get_current_time().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:204:18 [INFO] [stdout] | [INFO] [stdout] 204 | .expect(&format!("sh exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"sh exec error!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:96:20 [INFO] [stdout] | [INFO] [stdout] 96 | return !(flag == &args[lenght-1][0..flag_length]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(flag != &args[lenght-1][0..flag_length])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return true; [INFO] [stdout] 100 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:88:21 [INFO] [stdout] | [INFO] [stdout] 88 | fn is_runtime(args: &Vec)->bool{ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 88 - fn is_runtime(args: &Vec)->bool{ [INFO] [stdout] 88 + fn is_runtime(args: &[String])->bool{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | return ret_end; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return ret_end; [INFO] [stdout] 130 + ret_end [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | let out_str: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `out_str` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 106 ~ [INFO] [stdout] 107 | [INFO] [stdout] 108 ~ let out_str: String = if cfg!(target_os = "windows") { [INFO] [stdout] 109 | let output = Command::new("cmd") [INFO] [stdout] ... [INFO] [stdout] 115 | [INFO] [stdout] 116 ~ format!("{}", String::from_utf8_lossy(&output.stdout)) [INFO] [stdout] 117 | } else { [INFO] [stdout] ... [INFO] [stdout] 124 | [INFO] [stdout] 125 ~ format!("{}", String::from_utf8_lossy(&output.stdout)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:114:10 [INFO] [stdout] | [INFO] [stdout] 114 | .expect(&format!("cmd exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("cmd exec error!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:111:14 [INFO] [stdout] | [INFO] [stdout] 111 | .arg(&cmd_str) [INFO] [stdout] | ^^^^^^^^ help: change this to: `cmd_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:114:18 [INFO] [stdout] | [INFO] [stdout] 114 | .expect(&format!("cmd exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"cmd exec error!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:123:10 [INFO] [stdout] | [INFO] [stdout] 123 | .expect(&format!("sh exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("sh exec error!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:120:14 [INFO] [stdout] | [INFO] [stdout] 120 | .arg(&cmd_str) [INFO] [stdout] | ^^^^^^^^ help: change this to: `cmd_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:123:18 [INFO] [stdout] | [INFO] [stdout] 123 | .expect(&format!("sh exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"sh exec error!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 139 | return since_the_epoch.as_secs(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return since_the_epoch.as_secs(); [INFO] [stdout] 139 + since_the_epoch.as_secs() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | / return match std::path::Path::new(path).canonicalize() { [INFO] [stdout] 144 | | Ok(_buf) => true, [INFO] [stdout] 145 | | Err(_error) => false, [INFO] [stdout] 146 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 ~ match std::path::Path::new(path).canonicalize() { [INFO] [stdout] 144 + Ok(_buf) => true, [INFO] [stdout] 145 + Err(_error) => false, [INFO] [stdout] 146 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:211:5 [INFO] [stdout] | [INFO] [stdout] 211 | return ret_end; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return ret_end; [INFO] [stdout] 211 + ret_end [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 187 | let out_str: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `out_str` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 187 ~ [INFO] [stdout] 188 | [INFO] [stdout] 189 ~ let out_str: String = if cfg!(target_os = "windows") { [INFO] [stdout] 190 | let output = Command::new("cmd") [INFO] [stdout] ... [INFO] [stdout] 196 | [INFO] [stdout] 197 ~ format!("{}", String::from_utf8_lossy(&output.stdout)) [INFO] [stdout] 198 | } else { [INFO] [stdout] ... [INFO] [stdout] 205 | [INFO] [stdout] 206 ~ format!("{}", String::from_utf8_lossy(&output.stdout)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:195:10 [INFO] [stdout] | [INFO] [stdout] 195 | .expect(&format!("cmd exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("cmd exec error!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:195:18 [INFO] [stdout] | [INFO] [stdout] 195 | .expect(&format!("cmd exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"cmd exec error!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:204:10 [INFO] [stdout] | [INFO] [stdout] 204 | .expect(&format!("sh exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("sh exec error!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:204:18 [INFO] [stdout] | [INFO] [stdout] 204 | .expect(&format!("sh exec error!")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"sh exec error!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.31s [INFO] running `Command { std: "docker" "inspect" "806937da6aea616fd83aee03a93b84ac86ae7aed48b157592d37f686b9740573", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "806937da6aea616fd83aee03a93b84ac86ae7aed48b157592d37f686b9740573", kill_on_drop: false }` [INFO] [stdout] 806937da6aea616fd83aee03a93b84ac86ae7aed48b157592d37f686b9740573