[INFO] fetching crate yultsur 0.1.0... [INFO] linting yultsur-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate yultsur 0.1.0 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate yultsur 0.1.0 [INFO] finished tweaking crates.io crate yultsur 0.1.0 [INFO] tweaked toml for crates.io crate yultsur 0.1.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate yultsur 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c08100d05a35aac9e3f1642c4c13ec6420241d1527a3b8bc04ef9fe8a569a07e [INFO] running `Command { std: "docker" "start" "-a" "c08100d05a35aac9e3f1642c4c13ec6420241d1527a3b8bc04ef9fe8a569a07e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c08100d05a35aac9e3f1642c4c13ec6420241d1527a3b8bc04ef9fe8a569a07e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c08100d05a35aac9e3f1642c4c13ec6420241d1527a3b8bc04ef9fe8a569a07e", kill_on_drop: false }` [INFO] [stdout] c08100d05a35aac9e3f1642c4c13ec6420241d1527a3b8bc04ef9fe8a569a07e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d9723905cd6e3136b7c553767277a0699d57beab4b6a6a53ea305c577dc0c88d [INFO] running `Command { std: "docker" "start" "-a" "d9723905cd6e3136b7c553767277a0699d57beab4b6a6a53ea305c577dc0c88d", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking yultsur v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | try!(write!(f, "{}", self.literal)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | try!(write!(f, "{}", self.identifier)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | try!(write!(f, "{}(", self.identifier)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | try!(write!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | try!(write!(f, "function {}(", self.name)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | try!(write!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | try!(write!(f, ")")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | try!(write!(f, " -> ")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:199:13 [INFO] [stdout] | [INFO] [stdout] 199 | try!(write!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | try!(write!(f, "let ")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | try!(write!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | try!(write!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | try!(write!(f, "switch {} ", self.expression)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:290:13 [INFO] [stdout] | [INFO] [stdout] 290 | try!(write!(f, "{} ", case)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | try!(write!(f, "{{")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:329:13 [INFO] [stdout] | [INFO] [stdout] 329 | try!(write!(f, " {}", statement)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | try!(write!(f, "{}", self.literal)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | try!(write!(f, "{}", self.identifier)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | try!(write!(f, "{}(", self.identifier)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | try!(write!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | try!(write!(f, "function {}(", self.name)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | try!(write!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | try!(write!(f, ")")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | try!(write!(f, " -> ")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:199:13 [INFO] [stdout] | [INFO] [stdout] 199 | try!(write!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | try!(write!(f, "let ")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | try!(write!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | try!(write!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | try!(write!(f, "switch {} ", self.expression)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:290:13 [INFO] [stdout] | [INFO] [stdout] 290 | try!(write!(f, "{} ", case)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | try!(write!(f, "{{")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/yul.rs:329:13 [INFO] [stdout] | [INFO] [stdout] 329 | try!(write!(f, " {}", statement)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `typed` [INFO] [stdout] --> src/validator.rs:8:24 [INFO] [stdout] | [INFO] [stdout] 8 | fn validate(&self, typed: bool) -> Result<(), String> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_typed` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `custom` [INFO] [stdout] --> src/validator.rs:11:26 [INFO] [stdout] | [INFO] [stdout] 11 | Type::Custom(ref custom) => Ok(()), [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_custom` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/yul.rs:197:12 [INFO] [stdout] | [INFO] [stdout] 197 | if self.returns.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.returns.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `typed` [INFO] [stdout] --> src/validator.rs:8:24 [INFO] [stdout] | [INFO] [stdout] 8 | fn validate(&self, typed: bool) -> Result<(), String> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_typed` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/yul.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 216 | if self.identifiers.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.identifiers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `custom` [INFO] [stdout] --> src/validator.rs:11:26 [INFO] [stdout] | [INFO] [stdout] 11 | Type::Custom(ref custom) => Ok(()), [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_custom` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/yul.rs:240:12 [INFO] [stdout] | [INFO] [stdout] 240 | if self.identifiers.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.identifiers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/yul.rs:276:16 [INFO] [stdout] | [INFO] [stdout] 276 | if literal.literal.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `literal.literal.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/yul.rs:328:53 [INFO] [stdout] | [INFO] [stdout] 328 | for (_, statement) in self.statements.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 328 - for (_, statement) in self.statements.iter().enumerate() { [INFO] [stdout] 328 + for statement in self.statements.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/yul.rs:197:12 [INFO] [stdout] | [INFO] [stdout] 197 | if self.returns.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.returns.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/yul.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 216 | if self.identifiers.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.identifiers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/validator.rs:20:16 [INFO] [stdout] | [INFO] [stdout] 20 | if self.yultype == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.yultype.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/yul.rs:240:12 [INFO] [stdout] | [INFO] [stdout] 240 | if self.identifiers.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.identifiers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/validator.rs:35:16 [INFO] [stdout] | [INFO] [stdout] 35 | if self.yultype == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.yultype.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/validator.rs:68:16 [INFO] [stdout] | [INFO] [stdout] 68 | if literal.literal.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `literal.literal.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/yul.rs:276:16 [INFO] [stdout] | [INFO] [stdout] 276 | if literal.literal.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `literal.literal.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/validator.rs:91:17 [INFO] [stdout] | [INFO] [stdout] 91 | assert!(!Type::Bool.validate(true).is_err(), ""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Type::Bool.validate(true).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/validator.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | !Type::Custom("test".to_string()).validate(true).is_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Type::Custom("test".to_string()).validate(true).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/validator.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | / !Type::Custom("test invalid type".to_string()) [INFO] [stdout] 106 | | .validate(true) [INFO] [stdout] 107 | | .is_err(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 105 ~ Type::Custom("test invalid type".to_string()) [INFO] [stdout] 106 ~ .validate(true).is_ok(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/validator.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | / !Literal { [INFO] [stdout] 116 | | literal: "test".to_string(), [INFO] [stdout] 117 | | yultype: None [INFO] [stdout] 118 | | }.validate(false) [INFO] [stdout] 119 | | .is_err(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 115 ~ Literal { [INFO] [stdout] 116 + literal: "test".to_string(), [INFO] [stdout] 117 + yultype: None [INFO] [stdout] 118 ~ }.validate(false).is_ok(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/validator.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | / !Literal { [INFO] [stdout] 136 | | literal: "test".to_string(), [INFO] [stdout] 137 | | yultype: Some(Type::Bool) [INFO] [stdout] 138 | | }.validate(true) [INFO] [stdout] 139 | | .is_err(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 135 ~ Literal { [INFO] [stdout] 136 + literal: "test".to_string(), [INFO] [stdout] 137 + yultype: Some(Type::Bool) [INFO] [stdout] 138 ~ }.validate(true).is_ok(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/validator.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 162 | / !Block { [INFO] [stdout] 163 | | statements: vec![Statement::Switch(Switch { [INFO] [stdout] 164 | | expression: Expression::Identifier(Identifier { [INFO] [stdout] 165 | | identifier: "shouldbebool".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 182 | | }.validate(false) [INFO] [stdout] 183 | | .is_err(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 162 ~ Block { [INFO] [stdout] 163 + statements: vec![Statement::Switch(Switch { [INFO] [stdout] 164 + expression: Expression::Identifier(Identifier { [INFO] [stdout] 165 + identifier: "shouldbebool".to_string(), [INFO] [stdout] 166 + yultype: Some(Type::Bool), [INFO] [stdout] 167 + }), [INFO] [stdout] 168 + cases: vec![ [INFO] [stdout] 169 + Case { [INFO] [stdout] 170 + literal: Some(Literal { [INFO] [stdout] 171 + literal: "true".to_string(), [INFO] [stdout] 172 + yultype: Some(Type::Bool), [INFO] [stdout] 173 + }), [INFO] [stdout] 174 + block: Block { statements: vec![] }, [INFO] [stdout] 175 + }, [INFO] [stdout] 176 + Case { [INFO] [stdout] 177 + literal: None, [INFO] [stdout] 178 + block: Block { statements: vec![] }, [INFO] [stdout] 179 + }, [INFO] [stdout] 180 + ], [INFO] [stdout] 181 + })], [INFO] [stdout] 182 ~ }.validate(false).is_ok(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/yul.rs:328:53 [INFO] [stdout] | [INFO] [stdout] 328 | for (_, statement) in self.statements.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 328 - for (_, statement) in self.statements.iter().enumerate() { [INFO] [stdout] 328 + for statement in self.statements.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/validator.rs:20:16 [INFO] [stdout] | [INFO] [stdout] 20 | if self.yultype == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.yultype.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/validator.rs:35:16 [INFO] [stdout] | [INFO] [stdout] 35 | if self.yultype == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.yultype.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/validator.rs:68:16 [INFO] [stdout] | [INFO] [stdout] 68 | if literal.literal.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `literal.literal.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.34s [INFO] running `Command { std: "docker" "inspect" "d9723905cd6e3136b7c553767277a0699d57beab4b6a6a53ea305c577dc0c88d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9723905cd6e3136b7c553767277a0699d57beab4b6a6a53ea305c577dc0c88d", kill_on_drop: false }` [INFO] [stdout] d9723905cd6e3136b7c553767277a0699d57beab4b6a6a53ea305c577dc0c88d