[INFO] fetching crate yui-link 0.4.0... [INFO] linting yui-link-0.4.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate yui-link 0.4.0 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate yui-link 0.4.0 [INFO] finished tweaking crates.io crate yui-link 0.4.0 [INFO] tweaked toml for crates.io crate yui-link 0.4.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate yui-link 0.4.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate yui-link 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 32084bb3aeefaaae892a6ae2fae55f91c83dc93d3b5e554de4169f23036f1b52 [INFO] running `Command { std: "docker" "start" "-a" "32084bb3aeefaaae892a6ae2fae55f91c83dc93d3b5e554de4169f23036f1b52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "32084bb3aeefaaae892a6ae2fae55f91c83dc93d3b5e554de4169f23036f1b52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32084bb3aeefaaae892a6ae2fae55f91c83dc93d3b5e554de4169f23036f1b52", kill_on_drop: false }` [INFO] [stdout] 32084bb3aeefaaae892a6ae2fae55f91c83dc93d3b5e554de4169f23036f1b52 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae2300dad31aa7ecd1166fab63e202bdffce70638496a45f514dc1a55a0b9eaa [INFO] running `Command { std: "docker" "start" "-a" "ae2300dad31aa7ecd1166fab63e202bdffce70638496a45f514dc1a55a0b9eaa", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling unicode-ident v1.0.14 [INFO] [stderr] Compiling libc v0.2.167 [INFO] [stderr] Compiling rustversion v1.0.18 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking is-odd v1.1.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Checking bimap v0.6.3 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking is-even v1.0.0 [INFO] [stderr] Checking dinglebit_combinatorics v1.1.0 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking csv v1.3.1 [INFO] [stderr] Checking indexmap v2.12.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking prettytable v0.10.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Checking petgraph v0.8.3 [INFO] [stderr] Checking simplelog v0.12.2 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Compiling derive-syn-parse v0.1.5 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling delegate v0.13.4 [INFO] [stderr] Compiling strum v0.24.1 [INFO] [stderr] Compiling auto-impl-ops v0.2.1 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking yui-core v0.4.0 [INFO] [stderr] Checking yui-link v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/link/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod link; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/link/link.rs:138:31 [INFO] [stdout] | [INFO] [stdout] 138 | comps.into_iter().map(|edges| [INFO] [stdout] | _______________________________^ [INFO] [stdout] 139 | | Path::circ(edges) [INFO] [stdout] | |_____________________________^ help: replace the closure with the associated function itself: `Path::circ` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/link/link.rs:243:20 [INFO] [stdout] | [INFO] [stdout] 243 | if e == f && (n_index != i || (n_index == i && e_index != j)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 243 - if e == f && (n_index != i || (n_index == i && e_index != j)) { [INFO] [stdout] 243 + if !(e != f || n_index == i && e_index == j) { [INFO] [stdout] | [INFO] [stdout] 243 - if e == f && (n_index != i || (n_index == i && e_index != j)) { [INFO] [stdout] 243 + if (e_index != j || n_index != i) && e == f { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/link/link.rs:243:30 [INFO] [stdout] | [INFO] [stdout] 243 | if e == f && (n_index != i || (n_index == i && e_index != j)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 243 - if e == f && (n_index != i || (n_index == i && e_index != j)) { [INFO] [stdout] 243 + if e == f && !(n_index == i && e_index == j) { [INFO] [stdout] | [INFO] [stdout] 243 - if e == f && (n_index != i || (n_index == i && e_index != j)) { [INFO] [stdout] 243 + if e == f && n_index != i || e_index != j { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/link/node.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | self.edges.iter().min().unwrap().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.edges.iter().min().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/link/node.rs:111:35 [INFO] [stdout] | [INFO] [stdout] 111 | edges: self.edges.map(|e| f(e)) [INFO] [stdout] | ^^^^^^^^ help: replace the closure with the function itself: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Path` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/link/path.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i32::abs()` to usize [INFO] [stdout] --> src/braid.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | self.0.abs() as usize [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `self.0.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Braid` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/braid.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn len(&self) -> usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `impl std::iter::Iterator` [INFO] [stdout] --> src/util/jones.rs:18:23 [INFO] [stdout] | [INFO] [stdout] 18 | let body = P::sum(State::generate(n).into_iter().map(|s| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `State::generate(n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/link/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod link; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/link/link.rs:138:31 [INFO] [stdout] | [INFO] [stdout] 138 | comps.into_iter().map(|edges| [INFO] [stdout] | _______________________________^ [INFO] [stdout] 139 | | Path::circ(edges) [INFO] [stdout] | |_____________________________^ help: replace the closure with the associated function itself: `Path::circ` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/link/link.rs:243:20 [INFO] [stdout] | [INFO] [stdout] 243 | if e == f && (n_index != i || (n_index == i && e_index != j)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 243 - if e == f && (n_index != i || (n_index == i && e_index != j)) { [INFO] [stdout] 243 + if !(e != f || n_index == i && e_index == j) { [INFO] [stdout] | [INFO] [stdout] 243 - if e == f && (n_index != i || (n_index == i && e_index != j)) { [INFO] [stdout] 243 + if (e_index != j || n_index != i) && e == f { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/link/link.rs:243:30 [INFO] [stdout] | [INFO] [stdout] 243 | if e == f && (n_index != i || (n_index == i && e_index != j)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 243 - if e == f && (n_index != i || (n_index == i && e_index != j)) { [INFO] [stdout] 243 + if e == f && !(n_index == i && e_index == j) { [INFO] [stdout] | [INFO] [stdout] 243 - if e == f && (n_index != i || (n_index == i && e_index != j)) { [INFO] [stdout] 243 + if e == f && n_index != i || e_index != j { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/link/node.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | self.edges.iter().min().unwrap().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.edges.iter().min().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/link/node.rs:111:35 [INFO] [stdout] | [INFO] [stdout] 111 | edges: self.edges.map(|e| f(e)) [INFO] [stdout] | ^^^^^^^^ help: replace the closure with the function itself: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Path` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/link/path.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/inv_link.rs:192:28 [INFO] [stdout] | [INFO] [stdout] 192 | assert_eq!(l.inv_x(&nodes[0]), nodes[1]); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `nodes[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/inv_link.rs:193:28 [INFO] [stdout] | [INFO] [stdout] 193 | assert_eq!(l.inv_x(&nodes[1]), nodes[0]); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `nodes[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/inv_link.rs:194:28 [INFO] [stdout] | [INFO] [stdout] 194 | assert_eq!(l.inv_x(&nodes[2]), nodes[2]); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `nodes[2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i32::abs()` to usize [INFO] [stdout] --> src/braid.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | self.0.abs() as usize [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `self.0.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Braid` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/braid.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn len(&self) -> usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `impl std::iter::Iterator` [INFO] [stdout] --> src/util/jones.rs:18:23 [INFO] [stdout] | [INFO] [stdout] 18 | let body = P::sum(State::generate(n).into_iter().map(|s| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `State::generate(n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.35s [INFO] running `Command { std: "docker" "inspect" "ae2300dad31aa7ecd1166fab63e202bdffce70638496a45f514dc1a55a0b9eaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae2300dad31aa7ecd1166fab63e202bdffce70638496a45f514dc1a55a0b9eaa", kill_on_drop: false }` [INFO] [stdout] ae2300dad31aa7ecd1166fab63e202bdffce70638496a45f514dc1a55a0b9eaa