[INFO] fetching crate youtube 0.1.1... [INFO] linting youtube-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate youtube 0.1.1 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate youtube 0.1.1 [INFO] finished tweaking crates.io crate youtube 0.1.1 [INFO] tweaked toml for crates.io crate youtube 0.1.1 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate youtube 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate youtube 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hyper v1.5.0 [INFO] [stderr] Downloaded thiserror-impl v1.0.65 [INFO] [stderr] Downloaded redox_syscall v0.5.7 [INFO] [stderr] Downloaded unicode-ident v1.0.13 [INFO] [stderr] Downloaded schannel v0.1.26 [INFO] [stderr] Downloaded tempfile v3.13.0 [INFO] [stderr] Downloaded security-framework-sys v2.12.0 [INFO] [stderr] Downloaded anyhow v1.0.91 [INFO] [stderr] Downloaded hyper-util v0.1.9 [INFO] [stderr] Downloaded fastrand v2.1.1 [INFO] [stderr] Downloaded h2 v0.4.6 [INFO] [stderr] Downloaded cc v1.1.31 [INFO] [stderr] Downloaded hashbrown v0.15.0 [INFO] [stderr] Downloaded chrono v0.4.38 [INFO] [stderr] Downloaded syn v2.0.82 [INFO] [stderr] Downloaded serde_json v1.0.132 [INFO] [stderr] Downloaded serde_derive v1.0.213 [INFO] [stderr] Downloaded thiserror v1.0.65 [INFO] [stderr] Downloaded tokio v1.41.0 [INFO] [stderr] Downloaded prost v0.13.3 [INFO] [stderr] Downloaded proc-macro2 v1.0.89 [INFO] [stderr] Downloaded rustix v0.38.37 [INFO] [stderr] Downloaded prost-derive v0.13.3 [INFO] [stderr] Downloaded serde v1.0.213 [INFO] [stderr] Downloaded libc v0.2.161 [INFO] [stderr] Downloaded tokio-util v0.7.12 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef7f067ea5e89a2f100faedef95d2314be64b732f1f3152f51fa05c7eb0e9bd8 [INFO] running `Command { std: "docker" "start" "-a" "ef7f067ea5e89a2f100faedef95d2314be64b732f1f3152f51fa05c7eb0e9bd8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef7f067ea5e89a2f100faedef95d2314be64b732f1f3152f51fa05c7eb0e9bd8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef7f067ea5e89a2f100faedef95d2314be64b732f1f3152f51fa05c7eb0e9bd8", kill_on_drop: false }` [INFO] [stdout] ef7f067ea5e89a2f100faedef95d2314be64b732f1f3152f51fa05c7eb0e9bd8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d5f265ba0b30367900276eea8e9efa1ee1a66b75e186447968379ea44711a399 [INFO] running `Command { std: "docker" "start" "-a" "d5f265ba0b30367900276eea8e9efa1ee1a66b75e186447968379ea44711a399", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling libc v0.2.161 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking bytes v1.8.0 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking hashbrown v0.15.0 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Compiling httparse v1.9.5 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling openssl v0.10.68 [INFO] [stderr] Compiling anyhow v1.0.91 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Compiling serde v1.0.213 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Compiling cc v1.1.31 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking indexmap v2.6.0 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Compiling thiserror v1.0.65 [INFO] [stderr] Compiling serde_json v1.0.132 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v2.0.82 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling openssl-sys v0.9.104 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.213 [INFO] [stderr] Compiling thiserror-impl v1.0.65 [INFO] [stderr] Compiling prost-derive v0.13.3 [INFO] [stderr] Checking tokio v1.41.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking prost v0.13.3 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking hyper v1.5.0 [INFO] [stderr] Checking hyper-util v0.1.9 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking youtube v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/tests.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use tokio; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/comments.rs:227:36 [INFO] [stdout] | [INFO] [stdout] 227 | .unwrap_or(&parent_id); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `parent_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:100:46 [INFO] [stdout] | [INFO] [stdout] 100 | StatusCode::TOO_MANY_REQUESTS => return Err(YouTubeError::Ratelimited), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 ~ StatusCode::TOO_MANY_REQUESTS => Err(YouTubeError::Ratelimited), [INFO] [stdout] 101 | StatusCode::FORBIDDEN => { [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:107:33 [INFO] [stdout] | [INFO] [stdout] 107 | ... return Err(YouTubeError::Ratelimited) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 107 ~ Err(YouTubeError::Ratelimited) [INFO] [stdout] 108 | }, [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:111:33 [INFO] [stdout] | [INFO] [stdout] 111 | ... return Err(YouTubeError::Forbidden) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 ~ Err(YouTubeError::Forbidden) [INFO] [stdout] 112 | } [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:118:25 [INFO] [stdout] | [INFO] [stdout] 118 | return Err(YouTubeError::Forbidden) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 ~ Err(YouTubeError::Forbidden) [INFO] [stdout] 119 | } [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:122:38 [INFO] [stdout] | [INFO] [stdout] 122 | StatusCode::NOT_FOUND => return Err(YouTubeError::NotFound), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 ~ StatusCode::NOT_FOUND => Err(YouTubeError::NotFound), [INFO] [stdout] 123 | StatusCode::UNAUTHORIZED => { [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:127:17 [INFO] [stdout] | [INFO] [stdout] 127 | return Err(YouTubeError::Unauthorized); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 ~ Err(YouTubeError::Unauthorized) [INFO] [stdout] 128 | }, [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 130 | return Err(YouTubeError::InternalServerError); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 ~ Err(YouTubeError::InternalServerError) [INFO] [stdout] 131 | } [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | return Err(YouTubeError::InternalServerError); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 133 ~ Err(YouTubeError::InternalServerError) [INFO] [stdout] 134 | } [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:135:39 [INFO] [stdout] | [INFO] [stdout] 135 | StatusCode::NO_CONTENT => return Ok(true), // Success case for DELETE [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 ~ StatusCode::NO_CONTENT => Ok(true), // Success case for DELETE [INFO] [stdout] 136 | status => { [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | return Err(YouTubeError::UnknownStatusCode(status)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 ~ Err(YouTubeError::UnknownStatusCode(status)) [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tests.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | assert!(!subscriptions.next_page_token.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `subscriptions.next_page_token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 104 | assert_eq!(channel.made_for_kids, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 104 - assert_eq!(channel.made_for_kids, false); [INFO] [stdout] 104 + assert!(!channel.made_for_kids); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | assert_eq!(channel.made_for_kids, false); // default value when status is empty [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 151 - assert_eq!(channel.made_for_kids, false); // default value when status is empty [INFO] [stdout] 151 + assert!(!channel.made_for_kids); // default value when status is empty [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tests.rs:173:13 [INFO] [stdout] | [INFO] [stdout] 173 | assert!(!comments.next_page_token.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `comments.next_page_token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/comments.rs:227:36 [INFO] [stdout] | [INFO] [stdout] 227 | .unwrap_or(&parent_id); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `parent_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:100:46 [INFO] [stdout] | [INFO] [stdout] 100 | StatusCode::TOO_MANY_REQUESTS => return Err(YouTubeError::Ratelimited), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 ~ StatusCode::TOO_MANY_REQUESTS => Err(YouTubeError::Ratelimited), [INFO] [stdout] 101 | StatusCode::FORBIDDEN => { [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:107:33 [INFO] [stdout] | [INFO] [stdout] 107 | ... return Err(YouTubeError::Ratelimited) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 107 ~ Err(YouTubeError::Ratelimited) [INFO] [stdout] 108 | }, [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:111:33 [INFO] [stdout] | [INFO] [stdout] 111 | ... return Err(YouTubeError::Forbidden) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 ~ Err(YouTubeError::Forbidden) [INFO] [stdout] 112 | } [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:118:25 [INFO] [stdout] | [INFO] [stdout] 118 | return Err(YouTubeError::Forbidden) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 ~ Err(YouTubeError::Forbidden) [INFO] [stdout] 119 | } [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:122:38 [INFO] [stdout] | [INFO] [stdout] 122 | StatusCode::NOT_FOUND => return Err(YouTubeError::NotFound), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 ~ StatusCode::NOT_FOUND => Err(YouTubeError::NotFound), [INFO] [stdout] 123 | StatusCode::UNAUTHORIZED => { [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:127:17 [INFO] [stdout] | [INFO] [stdout] 127 | return Err(YouTubeError::Unauthorized); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 ~ Err(YouTubeError::Unauthorized) [INFO] [stdout] 128 | }, [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 130 | return Err(YouTubeError::InternalServerError); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 ~ Err(YouTubeError::InternalServerError) [INFO] [stdout] 131 | } [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | return Err(YouTubeError::InternalServerError); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 133 ~ Err(YouTubeError::InternalServerError) [INFO] [stdout] 134 | } [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:135:39 [INFO] [stdout] | [INFO] [stdout] 135 | StatusCode::NO_CONTENT => return Ok(true), // Success case for DELETE [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 ~ StatusCode::NO_CONTENT => Ok(true), // Success case for DELETE [INFO] [stdout] 136 | status => { [INFO] [stdout] ... [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/channel_section.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | return Err(YouTubeError::UnknownStatusCode(status)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 ~ Err(YouTubeError::UnknownStatusCode(status)) [INFO] [stdout] 141 | }, [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.54s [INFO] running `Command { std: "docker" "inspect" "d5f265ba0b30367900276eea8e9efa1ee1a66b75e186447968379ea44711a399", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d5f265ba0b30367900276eea8e9efa1ee1a66b75e186447968379ea44711a399", kill_on_drop: false }` [INFO] [stdout] d5f265ba0b30367900276eea8e9efa1ee1a66b75e186447968379ea44711a399