[INFO] fetching crate yahoo_finance_api 4.1.0... [INFO] linting yahoo_finance_api-4.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate yahoo_finance_api 4.1.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate yahoo_finance_api 4.1.0 [INFO] finished tweaking crates.io crate yahoo_finance_api 4.1.0 [INFO] tweaked toml for crates.io crate yahoo_finance_api 4.1.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate yahoo_finance_api 4.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate yahoo_finance_api 4.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_json_path_to_error v0.1.5 [INFO] [stderr] Downloaded rust_decimal v1.37.2 [INFO] [stderr] Downloaded serde_json v1.0.141 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 08ec4ffa8afb1f5a5f9a7e1a929178c9b565a41ac45ca5435790b3d09e80cc42 [INFO] running `Command { std: "docker" "start" "-a" "08ec4ffa8afb1f5a5f9a7e1a929178c9b565a41ac45ca5435790b3d09e80cc42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "08ec4ffa8afb1f5a5f9a7e1a929178c9b565a41ac45ca5435790b3d09e80cc42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "08ec4ffa8afb1f5a5f9a7e1a929178c9b565a41ac45ca5435790b3d09e80cc42", kill_on_drop: false }` [INFO] [stdout] 08ec4ffa8afb1f5a5f9a7e1a929178c9b565a41ac45ca5435790b3d09e80cc42 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 386003e49420552dca8f6725618f3eb9209a32c1d5118b73ed130f86555ed937 [INFO] running `Command { std: "docker" "start" "-a" "386003e49420552dca8f6725618f3eb9209a32c1d5118b73ed130f86555ed937", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.2.30 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling rustls v0.23.29 [INFO] [stderr] Compiling time-macros v0.2.22 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling serde_json v1.0.141 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking webpki-roots v1.0.2 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking cookie v0.18.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Checking tokio v1.47.0 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking rustls-webpki v0.103.4 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking publicsuffix v2.3.0 [INFO] [stderr] Checking tokio-rustls v0.26.2 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking hyper-util v0.1.16 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking cookie_store v0.21.1 [INFO] [stderr] Checking reqwest v0.12.22 [INFO] [stderr] Checking yahoo_finance_api v4.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/async_impl.rs:305:28 [INFO] [stdout] | [INFO] [stdout] 305 | return Ok(self.parse_earnings_response(earnings_response)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 305 - return Ok(self.parse_earnings_response(earnings_response)?); [INFO] [stdout] 305 + return self.parse_earnings_response(earnings_response); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/async_impl.rs:305:28 [INFO] [stdout] | [INFO] [stdout] 305 | return Ok(self.parse_earnings_response(earnings_response)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 305 - return Ok(self.parse_earnings_response(earnings_response)?); [INFO] [stdout] 305 + return self.parse_earnings_response(earnings_response); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `response` after checking its variant with `is_ok` [INFO] [stdout] --> src/async_impl.rs:607:28 [INFO] [stdout] | [INFO] [stdout] 606 | if response.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = response` [INFO] [stdout] 607 | let response = response.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/async_impl.rs:681:56 [INFO] [stdout] | [INFO] [stdout] 681 | provider.get_quote_period_interval("AAPL", &range, &interval, true), [INFO] [stdout] | ^^^^^^ help: change this to: `range` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/async_impl.rs:681:64 [INFO] [stdout] | [INFO] [stdout] 681 | provider.get_quote_period_interval("AAPL", &range, &interval, true), [INFO] [stdout] | ^^^^^^^^^ help: change this to: `interval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/async_impl.rs:697:17 [INFO] [stdout] | [INFO] [stdout] 697 | assert!(quotes.len() > 0usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!quotes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `response` after checking its variant with `is_ok` [INFO] [stdout] --> src/async_impl.rs:726:28 [INFO] [stdout] | [INFO] [stdout] 725 | if response.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = response` [INFO] [stdout] 726 | let response = response.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/async_impl.rs:782:17 [INFO] [stdout] | [INFO] [stdout] 782 | assert!(capital_gains.len() > 0usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!capital_gains.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/async_impl.rs:836:17 [INFO] [stdout] | [INFO] [stdout] 836 | assert!(!quotes.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `quotes.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 52.53s [INFO] running `Command { std: "docker" "inspect" "386003e49420552dca8f6725618f3eb9209a32c1d5118b73ed130f86555ed937", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "386003e49420552dca8f6725618f3eb9209a32c1d5118b73ed130f86555ed937", kill_on_drop: false }` [INFO] [stdout] 386003e49420552dca8f6725618f3eb9209a32c1d5118b73ed130f86555ed937