[INFO] fetching crate yacrd 0.6.2... [INFO] linting yacrd-0.6.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate yacrd 0.6.2 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate yacrd 0.6.2 [INFO] finished tweaking crates.io crate yacrd 0.6.2 [INFO] tweaked toml for crates.io crate yacrd 0.6.2 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate yacrd 0.6.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate yacrd 0.6.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tempfile v3.1.0 [INFO] [stderr] Downloaded niffler v2.2.0 [INFO] [stderr] Downloaded ryu v1.0.5 [INFO] [stderr] Downloaded either v1.5.3 [INFO] [stderr] Downloaded newtype_derive v0.1.6 [INFO] [stderr] Downloaded version_check v0.9.2 [INFO] [stderr] Downloaded humantime v1.3.0 [INFO] [stderr] Downloaded multimap v0.6.0 [INFO] [stderr] Downloaded num-complex v0.2.4 [INFO] [stderr] Downloaded rawpointer v0.2.1 [INFO] [stderr] Downloaded num-integer v0.1.43 [INFO] [stderr] Downloaded bytecount v0.6.0 [INFO] [stderr] Downloaded bio-types v0.7.0 [INFO] [stderr] Downloaded anyhow v1.0.31 [INFO] [stderr] Downloaded derive-new v0.5.8 [INFO] [stderr] Downloaded bit-vec v0.6.2 [INFO] [stderr] Downloaded feature-probe v0.1.1 [INFO] [stderr] Downloaded regex v1.3.9 [INFO] [stderr] Downloaded regex-automata v0.1.9 [INFO] [stderr] Downloaded ndarray v0.13.1 [INFO] [stderr] Downloaded unicode-segmentation v1.6.0 [INFO] [stderr] Downloaded hashbrown v0.8.1 [INFO] [stderr] Downloaded bzip2-sys v0.1.9+1.0.8 [INFO] [stderr] Downloaded itertools-num v0.1.3 [INFO] [stderr] Downloaded matrixmultiply v0.2.3 [INFO] [stderr] Downloaded csv v1.1.3 [INFO] [stderr] Downloaded bstr v0.2.13 [INFO] [stderr] Downloaded proc-macro2 v1.0.18 [INFO] [stderr] Downloaded approx v0.3.2 [INFO] [stderr] Downloaded num-traits v0.1.43 [INFO] [stderr] Downloaded thiserror-impl v1.0.20 [INFO] [stderr] Downloaded log v0.4.11 [INFO] [stderr] Downloaded cc v1.0.58 [INFO] [stderr] Downloaded rustc_version v0.1.7 [INFO] [stderr] Downloaded petgraph v0.4.13 [INFO] [stderr] Downloaded lzma-sys v0.1.16 [INFO] [stderr] Downloaded serde_derive v1.0.114 [INFO] [stderr] Downloaded bitflags v1.2.1 [INFO] [stderr] Downloaded proc-macro-error v0.4.12 [INFO] [stderr] Downloaded regex-syntax v0.6.18 [INFO] [stderr] Downloaded remove_dir_all v0.5.3 [INFO] [stderr] Downloaded custom_derive v0.1.7 [INFO] [stderr] Downloaded getset v0.0.9 [INFO] [stderr] Downloaded snafu v0.6.8 [INFO] [stderr] Downloaded bio v0.31.0 [INFO] [stderr] Downloaded unicode-width v0.1.8 [INFO] [stderr] Downloaded vec_map v0.8.2 [INFO] [stderr] Downloaded clap v3.0.0-beta.1 [INFO] [stderr] Downloaded aho-corasick v0.7.13 [INFO] [stderr] Downloaded fxhash v0.2.1 [INFO] [stderr] Downloaded winapi-util v0.1.5 [INFO] [stderr] Downloaded env_logger v0.7.1 [INFO] [stderr] Downloaded pkg-config v0.3.18 [INFO] [stderr] Downloaded xz2 v0.1.6 [INFO] [stderr] Downloaded quote v1.0.7 [INFO] [stderr] Downloaded unicode-xid v0.2.1 [INFO] [stderr] Downloaded bv v0.11.1 [INFO] [stderr] Downloaded itertools v0.9.0 [INFO] [stderr] Downloaded ordermap v0.3.5 [INFO] [stderr] Downloaded snafu-derive v0.6.8 [INFO] [stderr] Downloaded strum_macros v0.18.0 [INFO] [stderr] Downloaded csv-core v0.1.10 [INFO] [stderr] Downloaded memchr v2.3.3 [INFO] [stderr] Downloaded crc32fast v1.2.0 [INFO] [stderr] Downloaded miniz_oxide v0.4.0 [INFO] [stderr] Downloaded bit-set v0.5.2 [INFO] [stderr] Downloaded statrs v0.12.0 [INFO] [stderr] Downloaded indexmap v1.5.0 [INFO] [stderr] Downloaded termcolor v1.1.0 [INFO] [stderr] Downloaded bzip2 v0.3.3 [INFO] [stderr] Downloaded num-traits v0.2.12 [INFO] [stderr] Downloaded enum_primitive v0.1.1 [INFO] [stderr] Downloaded syn v1.0.34 [INFO] [stderr] Downloaded semver v0.1.20 [INFO] [stderr] Downloaded doc-comment v0.3.3 [INFO] [stderr] Downloaded syn-mid v0.5.0 [INFO] [stderr] Downloaded clap_derive v3.0.0-beta.1 [INFO] [stderr] Downloaded serde v1.0.114 [INFO] [stderr] Downloaded hermit-abi v0.1.15 [INFO] [stderr] Downloaded flate2 v1.0.16 [INFO] [stderr] Downloaded strum v0.18.0 [INFO] [stderr] Downloaded textwrap v0.11.0 [INFO] [stderr] Downloaded adler v0.2.3 [INFO] [stderr] Downloaded heck v0.3.1 [INFO] [stderr] Downloaded os_str_bytes v2.3.1 [INFO] [stderr] Downloaded itoa v0.4.6 [INFO] [stderr] Downloaded thread_local v1.0.1 [INFO] [stderr] Downloaded thiserror v1.0.20 [INFO] [stderr] Downloaded ordered-float v1.1.0 [INFO] [stderr] Downloaded fixedbitset v0.1.9 [INFO] [stderr] Downloaded atty v0.2.14 [INFO] [stderr] Downloaded proc-macro-error-attr v0.4.12 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fc75842a7d2bca5f0f80f8e92f68eb838e7144d02840abb59e2f8482fcb760e1 [INFO] running `Command { std: "docker" "start" "-a" "fc75842a7d2bca5f0f80f8e92f68eb838e7144d02840abb59e2f8482fcb760e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fc75842a7d2bca5f0f80f8e92f68eb838e7144d02840abb59e2f8482fcb760e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc75842a7d2bca5f0f80f8e92f68eb838e7144d02840abb59e2f8482fcb760e1", kill_on_drop: false }` [INFO] [stdout] fc75842a7d2bca5f0f80f8e92f68eb838e7144d02840abb59e2f8482fcb760e1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c80d44fd0027f917143bc5f85baed02014e5d5b4368446a44f0d6f6ed836d100 [INFO] running `Command { std: "docker" "start" "-a" "c80d44fd0027f917143bc5f85baed02014e5d5b4368446a44f0d6f6ed836d100", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling syn v1.0.34 [INFO] [stderr] Compiling libc v0.2.72 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling serde_derive v1.0.114 [INFO] [stderr] Compiling serde v1.0.114 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling cc v1.0.58 [INFO] [stderr] Compiling pkg-config v0.3.18 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling semver v0.1.20 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Compiling rustc_version v0.1.7 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.12 [INFO] [stderr] Compiling proc-macro-error v0.4.12 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Compiling feature-probe v0.1.1 [INFO] [stderr] Checking aho-corasick v0.7.13 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling hashbrown v0.8.1 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling newtype_derive v0.1.6 [INFO] [stderr] Compiling indexmap v1.5.0 [INFO] [stderr] Compiling ndarray v0.13.1 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Compiling bv v0.11.1 [INFO] [stderr] Checking miniz_oxide v0.4.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Compiling anyhow v1.0.31 [INFO] [stderr] Checking bit-vec v0.6.2 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking fixedbitset v0.1.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling bio v0.31.0 [INFO] [stderr] Checking ordermap v0.3.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking bit-set v0.5.2 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking bytecount v0.6.0 [INFO] [stderr] Compiling lzma-sys v0.1.16 [INFO] [stderr] Compiling bzip2-sys v0.1.9+1.0.8 [INFO] [stderr] Checking flate2 v1.0.16 [INFO] [stderr] Checking os_str_bytes v2.3.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking strum v0.18.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking petgraph v0.4.13 [INFO] [stderr] Checking xz2 v0.1.6 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking itertools-num v0.1.3 [INFO] [stderr] Checking ordered-float v1.1.0 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking statrs v0.12.0 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling snafu-derive v0.6.8 [INFO] [stderr] Compiling derive-new v0.5.8 [INFO] [stderr] Compiling thiserror-impl v1.0.20 [INFO] [stderr] Compiling getset v0.0.9 [INFO] [stderr] Compiling strum_macros v0.18.0 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.1 [INFO] [stderr] Checking thiserror v1.0.20 [INFO] [stderr] Checking niffler v2.2.0 [INFO] [stderr] Checking snafu v0.6.8 [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking bio-types v0.7.0 [INFO] [stderr] Checking multimap v0.6.0 [INFO] [stderr] Checking clap v3.0.0-beta.1 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking yacrd v0.6.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self::fullmemory::*` [INFO] [stdout] --> src/reads2ovl/mod.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | pub use self::fullmemory::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/extract.rs:231:24 [INFO] [stdout] | [INFO] [stdout] 231 | const FASTA_FILE: &'static [u8] = b">1 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/extract.rs:239:34 [INFO] [stdout] | [INFO] [stdout] 239 | const FASTA_FILE_EXTRACTED: &'static [u8] = b">1 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/extract.rs:259:24 [INFO] [stdout] | [INFO] [stdout] 259 | const FASTQ_FILE: &'static [u8] = b"@1 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/extract.rs:273:34 [INFO] [stdout] | [INFO] [stdout] 273 | const FASTQ_FILE_EXTRACTED: &'static [u8] = b"@1 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/extract.rs:295:22 [INFO] [stdout] | [INFO] [stdout] 295 | const PAF_FILE: &'static [u8] = b"1\t12000\t20\t4500\t-\t2\t10000\t5500\t10000\t4500\t4500\t255 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/extract.rs:299:32 [INFO] [stdout] | [INFO] [stdout] 299 | const PAF_FILE_EXTRACTED: &'static [u8] = [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/extract.rs:320:21 [INFO] [stdout] | [INFO] [stdout] 320 | const M4_FILE: &'static [u8] = b"1 2 0.1 2 0 100 450 1000 0 550 900 1000 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/extract.rs:324:31 [INFO] [stdout] | [INFO] [stdout] 324 | const M4_FILE_EXTRACTED: &'static [u8] = b"1 2 0.1 2 0 100 450 1000 0 550 900 1000 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/filter.rs:231:24 [INFO] [stdout] | [INFO] [stdout] 231 | const FASTA_FILE: &'static [u8] = b">1 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/filter.rs:239:32 [INFO] [stdout] | [INFO] [stdout] 239 | const FASTA_FILE_FILTRED: &'static [u8] = b">2 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/filter.rs:261:24 [INFO] [stdout] | [INFO] [stdout] 261 | const FASTQ_FILE: &'static [u8] = b"@1 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/filter.rs:275:32 [INFO] [stdout] | [INFO] [stdout] 275 | const FASTQ_FILE_FILTRED: &'static [u8] = b"@2 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/filter.rs:301:22 [INFO] [stdout] | [INFO] [stdout] 301 | const PAF_FILE: &'static [u8] = b"1\t12000\t20\t4500\t-\t2\t10000\t5500\t10000\t4500\t4500\t255 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/filter.rs:305:30 [INFO] [stdout] | [INFO] [stdout] 305 | const PAF_FILE_FILTRED: &'static [u8] = b""; [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/filter.rs:323:21 [INFO] [stdout] | [INFO] [stdout] 323 | const M4_FILE: &'static [u8] = b"1 2 0.1 2 0 100 450 1000 0 550 900 1000 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/filter.rs:327:29 [INFO] [stdout] | [INFO] [stdout] 327 | const M4_FILE_FILTRED: &'static [u8] = b""; [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/scrubbing.rs:219:24 [INFO] [stdout] | [INFO] [stdout] 219 | const FASTA_FILE: &'static [u8] = b">1 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/scrubbing.rs:227:33 [INFO] [stdout] | [INFO] [stdout] 227 | const FASTA_FILE_SCRUBBED: &'static [u8] = b">1_0_4 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/scrubbing.rs:256:34 [INFO] [stdout] | [INFO] [stdout] 256 | const FASTA_FILE_SCRUBBED2: &'static [u8] = b">1_4_18 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/scrubbing.rs:279:24 [INFO] [stdout] | [INFO] [stdout] 279 | const FASTQ_FILE: &'static [u8] = b"@1 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/scrubbing.rs:293:33 [INFO] [stdout] | [INFO] [stdout] 293 | const FASTQ_FILE_SCRUBBED: &'static [u8] = b"@1_0_4 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/scrubbing.rs:332:34 [INFO] [stdout] | [INFO] [stdout] 332 | const FASTQ_FILE_SCRUBBED2: &'static [u8] = b"@1_4_18 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/split.rs:209:24 [INFO] [stdout] | [INFO] [stdout] 209 | const FASTA_FILE: &'static [u8] = b">1 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/split.rs:217:32 [INFO] [stdout] | [INFO] [stdout] 217 | const FASTA_FILE_SPLITED: &'static [u8] = b">1_0_13 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/split.rs:243:24 [INFO] [stdout] | [INFO] [stdout] 243 | const FASTQ_FILE: &'static [u8] = b"@1 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/editor/split.rs:257:32 [INFO] [stdout] | [INFO] [stdout] 257 | const FASTQ_FILE_FILTRED: &'static [u8] = b"@1_0_13 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::fullmemory::*` [INFO] [stdout] --> src/reads2ovl/mod.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | pub use self::fullmemory::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/reads2ovl/mod.rs:171:22 [INFO] [stdout] | [INFO] [stdout] 171 | const PAF_FILE: &'static [u8] = b"1\t12000\t20\t4500\t-\t2\t10000\t5500\t10000\t4500\t4500\t255 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/reads2ovl/mod.rs:175:21 [INFO] [stdout] | [INFO] [stdout] 175 | const M4_FILE: &'static [u8] = b"1 2 0.1 2 0 20 4500 12000 0 5500 10000 10000 [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/extract.rs:84:59 [INFO] [stdout] | [INFO] [stdout] 84 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/extract.rs:118:59 [INFO] [stdout] | [INFO] [stdout] 118 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/filter.rs:84:59 [INFO] [stdout] | [INFO] [stdout] 84 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/filter.rs:118:59 [INFO] [stdout] | [INFO] [stdout] 118 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/scrubbing.rs:91:59 [INFO] [stdout] | [INFO] [stdout] 91 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/scrubbing.rs:160:59 [INFO] [stdout] | [INFO] [stdout] 160 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/split.rs:91:59 [INFO] [stdout] | [INFO] [stdout] 91 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/split.rs:155:59 [INFO] [stdout] | [INFO] [stdout] 155 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / ReadingError { [INFO] [stdout] 53 | | filename: String, [INFO] [stdout] 54 | | format: util::FileType, [INFO] [stdout] 55 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | / WritingError { [INFO] [stdout] 62 | | filename: String, [INFO] [stdout] 63 | | format: util::FileType, [INFO] [stdout] 64 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | PathCreationError { path: std::path::PathBuf }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | PathDestructionError { path: std::path::PathBuf }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/reads2ovl/fullmemory.rs:45:52 [INFO] [stdout] | [INFO] [stdout] 45 | if let Some((vec, _)) = self.reads2ovl.get(&id.to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/reads2ovl/fullmemory.rs:53:52 [INFO] [stdout] | [INFO] [stdout] 53 | if let Some((_, len)) = self.reads2ovl.get(&id.to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/reads2ovl/ondisk.rs:152:29 [INFO] [stdout] | [INFO] [stdout] 152 | *self.reads2len.get(&id.to_string()).unwrap_or(&0) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/reads2ovl/ondisk.rs:156:34 [INFO] [stdout] | [INFO] [stdout] 156 | self.reads2ovl.entry(id).or_insert_with(Vec::new).push(ovl); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/stack.rs:60:40 [INFO] [stdout] | [INFO] [stdout] 60 | let mut ovl = self.ovl.overlap(&id)?; [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/stack.rs:63:38 [INFO] [stdout] | [INFO] [stdout] 63 | let length = self.ovl.length(&id); [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/stack.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | / Ok(self [INFO] [stdout] 146 | | .buffer [INFO] [stdout] 147 | | .get(id) [INFO] [stdout] 148 | | .with_context(|| error::Error::NotReachableCode { [INFO] [stdout] 149 | | name: format!("{} {}", file!(), line!()), [INFO] [stdout] 150 | | })?) [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 145 ~ self [INFO] [stdout] 146 | .buffer [INFO] [stdout] ... [INFO] [stdout] 149 | name: format!("{} {}", file!(), line!()), [INFO] [stdout] 150 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/extract.rs:84:59 [INFO] [stdout] | [INFO] [stdout] 84 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/extract.rs:118:59 [INFO] [stdout] | [INFO] [stdout] 118 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/editor/extract.rs:244:20 [INFO] [stdout] | [INFO] [stdout] 244 | fn fasta_file() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/filter.rs:84:59 [INFO] [stdout] | [INFO] [stdout] 84 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/filter.rs:118:59 [INFO] [stdout] | [INFO] [stdout] 118 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/editor/filter.rs:246:20 [INFO] [stdout] | [INFO] [stdout] 246 | fn fasta_file() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/scrubbing.rs:91:59 [INFO] [stdout] | [INFO] [stdout] 91 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/scrubbing.rs:160:59 [INFO] [stdout] | [INFO] [stdout] 160 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/editor/scrubbing.rs:240:30 [INFO] [stdout] | [INFO] [stdout] 240 | fn fasta_keep_begin_end() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/editor/scrubbing.rs:265:27 [INFO] [stdout] | [INFO] [stdout] 265 | fn fasta_keep_middle() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/split.rs:91:59 [INFO] [stdout] | [INFO] [stdout] 91 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/editor/split.rs:155:59 [INFO] [stdout] | [INFO] [stdout] 155 | let (badregion, length) = badregions.get_bad_part(&record.id().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `record.id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/editor/split.rs:228:20 [INFO] [stdout] | [INFO] [stdout] 228 | fn fasta_file() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / ReadingError { [INFO] [stdout] 53 | | filename: String, [INFO] [stdout] 54 | | format: util::FileType, [INFO] [stdout] 55 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | / WritingError { [INFO] [stdout] 62 | | filename: String, [INFO] [stdout] 63 | | format: util::FileType, [INFO] [stdout] 64 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | PathCreationError { path: std::path::PathBuf }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | PathDestructionError { path: std::path::PathBuf }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/reads2ovl/fullmemory.rs:45:52 [INFO] [stdout] | [INFO] [stdout] 45 | if let Some((vec, _)) = self.reads2ovl.get(&id.to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/reads2ovl/fullmemory.rs:53:52 [INFO] [stdout] | [INFO] [stdout] 53 | if let Some((_, len)) = self.reads2ovl.get(&id.to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/reads2ovl/ondisk.rs:152:29 [INFO] [stdout] | [INFO] [stdout] 152 | *self.reads2len.get(&id.to_string()).unwrap_or(&0) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/reads2ovl/ondisk.rs:156:34 [INFO] [stdout] | [INFO] [stdout] 156 | self.reads2ovl.entry(id).or_insert_with(Vec::new).push(ovl); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/stack.rs:60:40 [INFO] [stdout] | [INFO] [stdout] 60 | let mut ovl = self.ovl.overlap(&id)?; [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/stack.rs:63:38 [INFO] [stdout] | [INFO] [stdout] 63 | let length = self.ovl.length(&id); [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/stack.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | / Ok(self [INFO] [stdout] 146 | | .buffer [INFO] [stdout] 147 | | .get(id) [INFO] [stdout] 148 | | .with_context(|| error::Error::NotReachableCode { [INFO] [stdout] 149 | | name: format!("{} {}", file!(), line!()), [INFO] [stdout] 150 | | })?) [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 145 ~ self [INFO] [stdout] 146 | .buffer [INFO] [stdout] ... [INFO] [stdout] 149 | name: format!("{} {}", file!(), line!()), [INFO] [stdout] 150 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/stack.rs:403:12 [INFO] [stdout] | [INFO] [stdout] 403 | if !stack.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `stack.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/stack.rs:404:13 [INFO] [stdout] | [INFO] [stdout] 404 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/util.rs:120:27 [INFO] [stdout] | [INFO] [stdout] 120 | Err(e) => assert!(true, "Error message {:?}", e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/util.rs:121:26 [INFO] [stdout] | [INFO] [stdout] 121 | Ok(a) => assert!(false, "str2usize('2,5') return {}", a), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/util.rs:125:27 [INFO] [stdout] | [INFO] [stdout] 125 | Err(e) => assert!(true, "Error message {:?}", e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/util.rs:126:26 [INFO] [stdout] | [INFO] [stdout] 126 | Ok(a) => assert!(false, "str2usize('2.5') return {}", a), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/util.rs:133:26 [INFO] [stdout] | [INFO] [stdout] 133 | Ok(a) => assert!(true, "Value {}", a), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/util.rs:134:27 [INFO] [stdout] | [INFO] [stdout] 134 | Err(e) => assert!(false, "str2usize('2') return {}", e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/util.rs:145:27 [INFO] [stdout] | [INFO] [stdout] 145 | Err(e) => assert!(true, "Error message {:?}", e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/util.rs:146:26 [INFO] [stdout] | [INFO] [stdout] 146 | Ok(a) => assert!(false, "str2u32('2,5') return {}", a), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/util.rs:150:27 [INFO] [stdout] | [INFO] [stdout] 150 | Err(e) => assert!(true, "Error message {:?}", e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/util.rs:151:26 [INFO] [stdout] | [INFO] [stdout] 151 | Ok(a) => assert!(false, "str2u32('2.5') return {}", a), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/util.rs:158:26 [INFO] [stdout] | [INFO] [stdout] 158 | Ok(a) => assert!(true, "Value {}", a), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/util.rs:159:27 [INFO] [stdout] | [INFO] [stdout] 159 | Err(e) => assert!(false, "str2u32('2') return {}", e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/util.rs:170:27 [INFO] [stdout] | [INFO] [stdout] 170 | Err(e) => assert!(true, "Error message {:?}", e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/util.rs:171:26 [INFO] [stdout] | [INFO] [stdout] 171 | Ok(a) => assert!(false, "str2u64('2,5') return {}", a), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/util.rs:175:27 [INFO] [stdout] | [INFO] [stdout] 175 | Err(e) => assert!(true, "Error message {:?}", e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/util.rs:176:26 [INFO] [stdout] | [INFO] [stdout] 176 | Ok(a) => assert!(false, "str2u64('2.5') return {}", a), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/util.rs:183:26 [INFO] [stdout] | [INFO] [stdout] 183 | Ok(a) => assert!(true, "Value {}", a), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/util.rs:184:27 [INFO] [stdout] | [INFO] [stdout] 184 | Err(e) => assert!(false, "str2u64('2') return {}", e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 29.07s [INFO] running `Command { std: "docker" "inspect" "c80d44fd0027f917143bc5f85baed02014e5d5b4368446a44f0d6f6ed836d100", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c80d44fd0027f917143bc5f85baed02014e5d5b4368446a44f0d6f6ed836d100", kill_on_drop: false }` [INFO] [stdout] c80d44fd0027f917143bc5f85baed02014e5d5b4368446a44f0d6f6ed836d100