[INFO] fetching crate yabs 0.2.2...
[INFO] linting yabs-0.2.2 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate yabs 0.2.2 into /workspace/builds/worker-4-tc1/source
[INFO] started tweaking crates.io crate yabs 0.2.2
[INFO] finished tweaking crates.io crate yabs 0.2.2
[INFO] tweaked toml for crates.io crate yabs 0.2.2 written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate yabs 0.2.2 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]      Locking 57 packages to latest compatible versions
[INFO] [stderr]       Adding ansi_term v0.9.0 (available: v0.12.1)
[INFO] [stderr]       Adding clap v2.34.0 (available: v4.6.0)
[INFO] [stderr]       Adding error-chain v0.10.0 (available: v0.12.4)
[INFO] [stderr]       Adding log v0.3.9 (available: v0.4.29)
[INFO] [stderr]       Adding regex v0.2.11 (available: v1.12.3)
[INFO] [stderr]       Adding serde_json v0.8.6 (available: v1.0.149)
[INFO] [stderr]       Adding toml v0.4.10 (available: v1.0.7+spec-1.1.0)
[INFO] [stderr]       Adding walkdir v1.0.7 (available: v2.5.0)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded yaml-rust v0.3.5
[INFO] [stderr]   Downloaded ansi_term v0.9.0
[INFO] [stderr]   Downloaded ucd-util v0.1.10
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 33b36ad3bd26c2dc708a469ee0afc866d200a822de1ddbd572f1194c1bc25e15
[INFO] running `Command { std: "docker" "start" "-a" "33b36ad3bd26c2dc708a469ee0afc866d200a822de1ddbd572f1194c1bc25e15", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "33b36ad3bd26c2dc708a469ee0afc866d200a822de1ddbd572f1194c1bc25e15", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "33b36ad3bd26c2dc708a469ee0afc866d200a822de1ddbd572f1194c1bc25e15", kill_on_drop: false }`
[INFO] [stdout] 33b36ad3bd26c2dc708a469ee0afc866d200a822de1ddbd572f1194c1bc25e15
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 28bc1babaeb8880a498a22ae622d0c0a735245b0163ec31394362634baaa69af
[INFO] running `Command { std: "docker" "start" "-a" "28bc1babaeb8880a498a22ae622d0c0a735245b0163ec31394362634baaa69af", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]    Compiling regex v0.2.11
[INFO] [stderr]    Compiling quote v1.0.45
[INFO] [stderr]     Checking ucd-util v0.1.10
[INFO] [stderr]     Checking aho-corasick v0.6.10
[INFO] [stderr]     Checking thread_local v0.3.6
[INFO] [stderr]     Checking yaml-rust v0.3.5
[INFO] [stderr]     Checking same-file v0.1.3
[INFO] [stderr]     Checking itoa v0.1.1
[INFO] [stderr]     Checking utf8-ranges v1.0.5
[INFO] [stderr]     Checking serde v1.0.228
[INFO] [stderr]     Checking dtoa v0.2.2
[INFO] [stderr]     Checking serde v0.8.23
[INFO] [stderr]     Checking num-traits v0.1.43
[INFO] [stderr]     Checking error-chain v0.10.0
[INFO] [stderr]     Checking ansi_term v0.9.0
[INFO] [stderr]     Checking regex-syntax v0.5.6
[INFO] [stderr]     Checking walkdir v1.0.7
[INFO] [stderr]     Checking clap v2.34.0
[INFO] [stderr]    Compiling syn v2.0.117
[INFO] [stderr]     Checking toml v0.4.10
[INFO] [stderr]     Checking serde_json v0.8.6
[INFO] [stderr]    Compiling serde_derive v1.0.228
[INFO] [stderr]     Checking yabs v0.2.2 (/opt/rustwide/workdir)
[INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string()
[INFO] [stdout]   --> lib/error.rs:13:1
[INFO] [stdout]    |
[INFO] [stdout] 13 | / error_chain! {
[INFO] [stdout] 14 | |     types {
[INFO] [stdout] 15 | |         YabsError, YabsErrorKind, Result;
[INFO] [stdout] ...  |
[INFO] [stdout] 45 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(deprecated)]` on by default
[INFO] [stdout]    = note: this warning originates in the macro `error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info)
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string()
[INFO] [stdout]   --> lib/error.rs:13:1
[INFO] [stdout]    |
[INFO] [stdout] 13 | / error_chain! {
[INFO] [stdout] 14 | |     types {
[INFO] [stdout] 15 | |         YabsError, YabsErrorKind, Result;
[INFO] [stdout] ...  |
[INFO] [stdout] 45 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(deprecated)]` on by default
[INFO] [stdout]    = note: this warning originates in the macro `error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info)
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting
[INFO] [stdout]   --> lib/error.rs:13:1
[INFO] [stdout]    |
[INFO] [stdout] 13 | / error_chain! {
[INFO] [stdout] 14 | |     types {
[INFO] [stdout] 15 | |         YabsError, YabsErrorKind, Result;
[INFO] [stdout] ...  |
[INFO] [stdout] 45 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this warning originates in the macro `error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info)
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting
[INFO] [stdout]   --> lib/error.rs:13:1
[INFO] [stdout]    |
[INFO] [stdout] 13 | / error_chain! {
[INFO] [stdout] 14 | |     types {
[INFO] [stdout] 15 | |         YabsError, YabsErrorKind, Result;
[INFO] [stdout] ...  |
[INFO] [stdout] 45 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = note: this warning originates in the macro `error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info)
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> lib/build.rs:156:9
[INFO] [stdout]     |
[INFO] [stdout] 156 | /         Ok(run_cmd(&format!("{CC} {LFLAGS} -o {BIN} {OBJ_LIST} {LIB_DIR} {LIBS}",
[INFO] [stdout] 157 | |                            CC = &self.project.compiler.as_ref().unwrap_or(&String::from("gcc")),
[INFO] [stdout] 158 | |                            LFLAGS = &self.project
[INFO] [stdout] 159 | |                                          .lflags
[INFO] [stdout] ...   |
[INFO] [stdout] 171 | |                                           .join(" "),
[INFO] [stdout] 172 | |                            LIBS = &self.project.libs_as_string()))?)
[INFO] [stdout]     | |____________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout]     = note: `#[warn(clippy::needless_question_mark)]` on by default
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 156 ~         run_cmd(&format!("{CC} {LFLAGS} -o {BIN} {OBJ_LIST} {LIB_DIR} {LIBS}",
[INFO] [stdout] 157 |                            CC = &self.project.compiler.as_ref().unwrap_or(&String::from("gcc")),
[INFO] [stdout] ...
[INFO] [stdout] 171 |                                           .join(" "),
[INFO] [stdout] 172 ~                            LIBS = &self.project.libs_as_string()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> lib/build.rs:177:9
[INFO] [stdout]     |
[INFO] [stdout] 177 | /         Ok(run_cmd(&format!("{AR} {ARFLAGS} {LIB} {OBJ_LIST}",
[INFO] [stdout] 178 | |                            AR = &self.project.ar.as_ref().unwrap_or(&String::from("ar")),
[INFO] [stdout] 179 | |                            ARFLAGS =
[INFO] [stdout] 180 | |                                &self.project.arflags.as_ref().unwrap_or(&String::from("rcs")),
[INFO] [stdout] 181 | |                            LIB = library.static_file_name().display(),
[INFO] [stdout] 182 | |                            OBJ_LIST = object_list))?)
[INFO] [stdout]     | |_____________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 177 ~         run_cmd(&format!("{AR} {ARFLAGS} {LIB} {OBJ_LIST}",
[INFO] [stdout] 178 |                            AR = &self.project.ar.as_ref().unwrap_or(&String::from("ar")),
[INFO] [stdout] ...
[INFO] [stdout] 181 |                            LIB = library.static_file_name().display(),
[INFO] [stdout] 182 ~                            OBJ_LIST = object_list))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> lib/build.rs:187:9
[INFO] [stdout]     |
[INFO] [stdout] 187 | /         Ok(run_cmd(&format!("{CC} -shared -o {LIB} {OBJ_LIST} {LIBS}",
[INFO] [stdout] 188 | |                            CC = &self.project.compiler.as_ref().unwrap_or(&String::from("gcc")),
[INFO] [stdout] 189 | |                            LIB = library.dynamic_file_name().display(),
[INFO] [stdout] 190 | |                            OBJ_LIST = object_list,
[INFO] [stdout] 191 | |                            LIBS = &self.project.libs_as_string()))?)
[INFO] [stdout]     | |____________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 187 ~         run_cmd(&format!("{CC} -shared -o {LIB} {OBJ_LIST} {LIBS}",
[INFO] [stdout] 188 |                            CC = &self.project.compiler.as_ref().unwrap_or(&String::from("gcc")),
[INFO] [stdout] 189 |                            LIB = library.dynamic_file_name().display(),
[INFO] [stdout] 190 |                            OBJ_LIST = object_list,
[INFO] [stdout] 191 ~                            LIBS = &self.project.libs_as_string()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
[INFO] [stdout]    --> lib/build.rs:206:46
[INFO] [stdout]     |
[INFO] [stdout] 206 |             if let Some(library) = libraries.into_iter()
[INFO] [stdout]     |                                              ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout]     = note: `#[warn(clippy::into_iter_on_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
[INFO] [stdout]    --> lib/build.rs:222:44
[INFO] [stdout]     |
[INFO] [stdout] 222 |             if let Some(binary) = binaries.into_iter()
[INFO] [stdout]     |                                            ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> lib/build.rs:237:12
[INFO] [stdout]     |
[INFO] [stdout] 237 |         if !self.libraries.is_some() {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.libraries.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> lib/build.rs:292:20
[INFO] [stdout]     |
[INFO] [stdout] 292 |             return Ok(BuildFile::from_file(&dir.join(filepath))?);
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 292 -             return Ok(BuildFile::from_file(&dir.join(filepath))?);
[INFO] [stdout] 292 +             return BuildFile::from_file(&dir.join(filepath));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> lib/build.rs:156:9
[INFO] [stdout]     |
[INFO] [stdout] 156 | /         Ok(run_cmd(&format!("{CC} {LFLAGS} -o {BIN} {OBJ_LIST} {LIB_DIR} {LIBS}",
[INFO] [stdout] 157 | |                            CC = &self.project.compiler.as_ref().unwrap_or(&String::from("gcc")),
[INFO] [stdout] 158 | |                            LFLAGS = &self.project
[INFO] [stdout] 159 | |                                          .lflags
[INFO] [stdout] ...   |
[INFO] [stdout] 171 | |                                           .join(" "),
[INFO] [stdout] 172 | |                            LIBS = &self.project.libs_as_string()))?)
[INFO] [stdout]     | |____________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout]     = note: `#[warn(clippy::needless_question_mark)]` on by default
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 156 ~         run_cmd(&format!("{CC} {LFLAGS} -o {BIN} {OBJ_LIST} {LIB_DIR} {LIBS}",
[INFO] [stdout] 157 |                            CC = &self.project.compiler.as_ref().unwrap_or(&String::from("gcc")),
[INFO] [stdout] ...
[INFO] [stdout] 171 |                                           .join(" "),
[INFO] [stdout] 172 ~                            LIBS = &self.project.libs_as_string()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> lib/build.rs:177:9
[INFO] [stdout]     |
[INFO] [stdout] 177 | /         Ok(run_cmd(&format!("{AR} {ARFLAGS} {LIB} {OBJ_LIST}",
[INFO] [stdout] 178 | |                            AR = &self.project.ar.as_ref().unwrap_or(&String::from("ar")),
[INFO] [stdout] 179 | |                            ARFLAGS =
[INFO] [stdout] 180 | |                                &self.project.arflags.as_ref().unwrap_or(&String::from("rcs")),
[INFO] [stdout] 181 | |                            LIB = library.static_file_name().display(),
[INFO] [stdout] 182 | |                            OBJ_LIST = object_list))?)
[INFO] [stdout]     | |_____________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 177 ~         run_cmd(&format!("{AR} {ARFLAGS} {LIB} {OBJ_LIST}",
[INFO] [stdout] 178 |                            AR = &self.project.ar.as_ref().unwrap_or(&String::from("ar")),
[INFO] [stdout] ...
[INFO] [stdout] 181 |                            LIB = library.static_file_name().display(),
[INFO] [stdout] 182 ~                            OBJ_LIST = object_list))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> lib/build.rs:187:9
[INFO] [stdout]     |
[INFO] [stdout] 187 | /         Ok(run_cmd(&format!("{CC} -shared -o {LIB} {OBJ_LIST} {LIBS}",
[INFO] [stdout] 188 | |                            CC = &self.project.compiler.as_ref().unwrap_or(&String::from("gcc")),
[INFO] [stdout] 189 | |                            LIB = library.dynamic_file_name().display(),
[INFO] [stdout] 190 | |                            OBJ_LIST = object_list,
[INFO] [stdout] 191 | |                            LIBS = &self.project.libs_as_string()))?)
[INFO] [stdout]     | |____________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 187 ~         run_cmd(&format!("{CC} -shared -o {LIB} {OBJ_LIST} {LIBS}",
[INFO] [stdout] 188 |                            CC = &self.project.compiler.as_ref().unwrap_or(&String::from("gcc")),
[INFO] [stdout] 189 |                            LIB = library.dynamic_file_name().display(),
[INFO] [stdout] 190 |                            OBJ_LIST = object_list,
[INFO] [stdout] 191 ~                            LIBS = &self.project.libs_as_string()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
[INFO] [stdout]    --> lib/build.rs:206:46
[INFO] [stdout]     |
[INFO] [stdout] 206 |             if let Some(library) = libraries.into_iter()
[INFO] [stdout]     |                                              ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout]     = note: `#[warn(clippy::into_iter_on_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
[INFO] [stdout]    --> lib/build.rs:222:44
[INFO] [stdout]     |
[INFO] [stdout] 222 |             if let Some(binary) = binaries.into_iter()
[INFO] [stdout]     |                                            ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> lib/build.rs:237:12
[INFO] [stdout]     |
[INFO] [stdout] 237 |         if !self.libraries.is_some() {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.libraries.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
[INFO] [stdout]   --> lib/ext.rs:63:42
[INFO] [stdout]    |
[INFO] [stdout] 63 | pub fn get_assumed_filename_for_dir(dir: &PathBuf) -> Option<PathBuf> {
[INFO] [stdout]    |                                          ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 63 - pub fn get_assumed_filename_for_dir(dir: &PathBuf) -> Option<PathBuf> {
[INFO] [stdout] 63 + pub fn get_assumed_filename_for_dir(dir: &Path) -> Option<PathBuf> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> lib/ext.rs:71:52
[INFO] [stdout]    |
[INFO] [stdout] 71 |     let command = Command::new("sh").arg("-c").arg(&cmd).spawn()?.wait_with_output()?;
[INFO] [stdout]    |                                                    ^^^^ help: change this to: `cmd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> lib/build.rs:292:20
[INFO] [stdout]     |
[INFO] [stdout] 292 |             return Ok(BuildFile::from_file(&dir.join(filepath))?);
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 292 -             return Ok(BuildFile::from_file(&dir.join(filepath))?);
[INFO] [stdout] 292 +             return BuildFile::from_file(&dir.join(filepath));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> lib/ext.rs:82:41
[INFO] [stdout]    |
[INFO] [stdout] 82 |     Ok(Command::new("sh").arg("-c").arg(&cmd).spawn()?)
[INFO] [stdout]    |                                         ^^^^ help: change this to: `cmd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]   --> lib/new.rs:17:5
[INFO] [stdout]    |
[INFO] [stdout] 17 |     Ok(create_bin_files(&dir.to_path_buf(), name)?)
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]    |
[INFO] [stdout] 17 -     Ok(create_bin_files(&dir.to_path_buf(), name)?)
[INFO] [stdout] 17 +     create_bin_files(&dir.to_path_buf(), name)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
[INFO] [stdout]   --> lib/new.rs:20:31
[INFO] [stdout]    |
[INFO] [stdout] 20 | pub fn create_bin_files(path: &PathBuf, name: &str) -> Result<(), YabsError> {
[INFO] [stdout]    |                               ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 20 - pub fn create_bin_files(path: &PathBuf, name: &str) -> Result<(), YabsError> {
[INFO] [stdout] 20 + pub fn create_bin_files(path: &Path, name: &str) -> Result<(), YabsError> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]   --> lib/new.rs:23:13
[INFO] [stdout]    |
[INFO] [stdout] 23 | /             Ok(file.write_all(format!("[project]\n\
[INFO] [stdout] 24 | |                 name = \"{0}\"\n\
[INFO] [stdout] 25 | |                 version = \"0.0.1\"\n\
[INFO] [stdout] 26 | |                 target = [\"{0}\"]\n\
[INFO] [stdout] ...  |
[INFO] [stdout] 44 | |                                       name)
[INFO] [stdout] 45 | |                                   .as_bytes())?)
[INFO] [stdout]    | |________________________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]    |
[INFO] [stdout] 23 ~             file.write_all(format!("[project]\n\
[INFO] [stdout] 24 |                 name = \"{0}\"\n\
[INFO] [stdout] ...
[INFO] [stdout] 44 |                                       name)
[INFO] [stdout] 45 ~                                   .as_bytes())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]   --> lib/new.rs:49:23
[INFO] [stdout]    |
[INFO] [stdout] 49 | /                       Ok(src.write_all(b"#include <iostream>\n\n\
[INFO] [stdout] 50 | |             int main() {\n\
[INFO] [stdout] 51 | |             \treturn 0;\n\
[INFO] [stdout] 52 | |             }")?)
[INFO] [stdout]    | |_________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]    |
[INFO] [stdout] 49 ~                       src.write_all(b"#include <iostream>\n\n\
[INFO] [stdout] 50 |             int main() {\n\
[INFO] [stdout] 51 |             \treturn 0;\n\
[INFO] [stdout] 52 ~             }")
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
[INFO] [stdout]   --> lib/ext.rs:63:42
[INFO] [stdout]    |
[INFO] [stdout] 63 | pub fn get_assumed_filename_for_dir(dir: &PathBuf) -> Option<PathBuf> {
[INFO] [stdout]    |                                          ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 63 - pub fn get_assumed_filename_for_dir(dir: &PathBuf) -> Option<PathBuf> {
[INFO] [stdout] 63 + pub fn get_assumed_filename_for_dir(dir: &Path) -> Option<PathBuf> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> lib/ext.rs:71:52
[INFO] [stdout]    |
[INFO] [stdout] 71 |     let command = Command::new("sh").arg("-c").arg(&cmd).spawn()?.wait_with_output()?;
[INFO] [stdout]    |                                                    ^^^^ help: change this to: `cmd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> lib/ext.rs:82:41
[INFO] [stdout]    |
[INFO] [stdout] 82 |     Ok(Command::new("sh").arg("-c").arg(&cmd).spawn()?)
[INFO] [stdout]    |                                         ^^^^ help: change this to: `cmd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]   --> lib/new.rs:17:5
[INFO] [stdout]    |
[INFO] [stdout] 17 |     Ok(create_bin_files(&dir.to_path_buf(), name)?)
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]    |
[INFO] [stdout] 17 -     Ok(create_bin_files(&dir.to_path_buf(), name)?)
[INFO] [stdout] 17 +     create_bin_files(&dir.to_path_buf(), name)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
[INFO] [stdout]   --> lib/new.rs:20:31
[INFO] [stdout]    |
[INFO] [stdout] 20 | pub fn create_bin_files(path: &PathBuf, name: &str) -> Result<(), YabsError> {
[INFO] [stdout]    |                               ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 20 - pub fn create_bin_files(path: &PathBuf, name: &str) -> Result<(), YabsError> {
[INFO] [stdout] 20 + pub fn create_bin_files(path: &Path, name: &str) -> Result<(), YabsError> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]   --> lib/new.rs:23:13
[INFO] [stdout]    |
[INFO] [stdout] 23 | /             Ok(file.write_all(format!("[project]\n\
[INFO] [stdout] 24 | |                 name = \"{0}\"\n\
[INFO] [stdout] 25 | |                 version = \"0.0.1\"\n\
[INFO] [stdout] 26 | |                 target = [\"{0}\"]\n\
[INFO] [stdout] ...  |
[INFO] [stdout] 44 | |                                       name)
[INFO] [stdout] 45 | |                                   .as_bytes())?)
[INFO] [stdout]    | |________________________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]    |
[INFO] [stdout] 23 ~             file.write_all(format!("[project]\n\
[INFO] [stdout] 24 |                 name = \"{0}\"\n\
[INFO] [stdout] ...
[INFO] [stdout] 44 |                                       name)
[INFO] [stdout] 45 ~                                   .as_bytes())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]   --> lib/new.rs:49:23
[INFO] [stdout]    |
[INFO] [stdout] 49 | /                       Ok(src.write_all(b"#include <iostream>\n\n\
[INFO] [stdout] 50 | |             int main() {\n\
[INFO] [stdout] 51 | |             \treturn 0;\n\
[INFO] [stdout] 52 | |             }")?)
[INFO] [stdout]    | |_________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]    |
[INFO] [stdout] 49 ~                       src.write_all(b"#include <iostream>\n\n\
[INFO] [stdout] 50 |             int main() {\n\
[INFO] [stdout] 51 |             \treturn 0;\n\
[INFO] [stdout] 52 ~             }")
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:28:9
[INFO] [stdout]    |
[INFO] [stdout] 28 |         return status;
[INFO] [stdout]    |         ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 28 -         return status;
[INFO] [stdout] 28 +         status
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:30:9
[INFO] [stdout]    |
[INFO] [stdout] 30 |         return ExitStatus::Success;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 30 -         return ExitStatus::Success;
[INFO] [stdout] 30 +         ExitStatus::Success
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary use of `to_owned`
[INFO] [stdout]   --> src/main.rs:44:54
[INFO] [stdout]    |
[INFO] [stdout] 44 |                 if let Err(error) = new::new_project(&value.to_owned(), false) {
[INFO] [stdout]    |                                                      ^^^^^^^^^^^^^^^^^ help: use: `value`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_to_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this match could be written as a `let` statement
[INFO] [stdout]   --> src/main.rs:90:5
[INFO] [stdout]    |
[INFO] [stdout] 90 | /     match run() {
[INFO] [stdout] 91 | |         error => exit(error as i32),
[INFO] [stdout] 92 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
[INFO] [stdout]    = note: `#[warn(clippy::match_single_binding)]` on by default
[INFO] [stdout] help: consider using a `let` statement
[INFO] [stdout]    |
[INFO] [stdout] 90 ~     let error = run();
[INFO] [stdout] 91 +     exit(error as i32)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:28:9
[INFO] [stdout]    |
[INFO] [stdout] 28 |         return status;
[INFO] [stdout]    |         ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 28 -         return status;
[INFO] [stdout] 28 +         status
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:30:9
[INFO] [stdout]    |
[INFO] [stdout] 30 |         return ExitStatus::Success;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 30 -         return ExitStatus::Success;
[INFO] [stdout] 30 +         ExitStatus::Success
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary use of `to_owned`
[INFO] [stdout]   --> src/main.rs:44:54
[INFO] [stdout]    |
[INFO] [stdout] 44 |                 if let Err(error) = new::new_project(&value.to_owned(), false) {
[INFO] [stdout]    |                                                      ^^^^^^^^^^^^^^^^^ help: use: `value`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_to_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this match could be written as a `let` statement
[INFO] [stdout]   --> src/main.rs:90:5
[INFO] [stdout]    |
[INFO] [stdout] 90 | /     match run() {
[INFO] [stdout] 91 | |         error => exit(error as i32),
[INFO] [stdout] 92 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
[INFO] [stdout]    = note: `#[warn(clippy::match_single_binding)]` on by default
[INFO] [stdout] help: consider using a `let` statement
[INFO] [stdout]    |
[INFO] [stdout] 90 ~     let error = run();
[INFO] [stdout] 91 +     exit(error as i32)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.29s
[INFO] running `Command { std: "docker" "inspect" "28bc1babaeb8880a498a22ae622d0c0a735245b0163ec31394362634baaa69af", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "28bc1babaeb8880a498a22ae622d0c0a735245b0163ec31394362634baaa69af", kill_on_drop: false }`
[INFO] [stdout] 28bc1babaeb8880a498a22ae622d0c0a735245b0163ec31394362634baaa69af