[INFO] fetching crate xtagger 1.2.1... [INFO] linting xtagger-1.2.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate xtagger 1.2.1 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate xtagger 1.2.1 [INFO] finished tweaking crates.io crate xtagger 1.2.1 [INFO] tweaked toml for crates.io crate xtagger 1.2.1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate xtagger 1.2.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate xtagger 1.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded xtag v1.1.1 [INFO] [stderr] Downloaded pest_generator v2.7.10 [INFO] [stderr] Downloaded clap_derive v4.5.5 [INFO] [stderr] Downloaded anstyle-wincon v3.0.3 [INFO] [stderr] Downloaded pest_meta v2.7.10 [INFO] [stderr] Downloaded anstream v0.6.14 [INFO] [stderr] Downloaded anstyle-query v1.1.0 [INFO] [stderr] Downloaded colorchoice v1.0.1 [INFO] [stderr] Downloaded is_terminal_polyfill v1.70.0 [INFO] [stderr] Downloaded pest v2.7.10 [INFO] [stderr] Downloaded pest_derive v2.7.10 [INFO] [stderr] Downloaded anstyle-parse v0.2.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 04df34ed3288124aa62f0487a9b9a330fbcf9aaa2cacac50ace45fe55eba4226 [INFO] running `Command { std: "docker" "start" "-a" "04df34ed3288124aa62f0487a9b9a330fbcf9aaa2cacac50ace45fe55eba4226", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "04df34ed3288124aa62f0487a9b9a330fbcf9aaa2cacac50ace45fe55eba4226", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04df34ed3288124aa62f0487a9b9a330fbcf9aaa2cacac50ace45fe55eba4226", kill_on_drop: false }` [INFO] [stdout] 04df34ed3288124aa62f0487a9b9a330fbcf9aaa2cacac50ace45fe55eba4226 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 17fe3b964ca31457a0d7004acbfc531e21701e0a6634b5af62be7f82bf6717ef [INFO] running `Command { std: "docker" "start" "-a" "17fe3b964ca31457a0d7004acbfc531e21701e0a6634b5af62be7f82bf6717ef", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Compiling pest v2.7.10 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Compiling pest_meta v2.7.10 [INFO] [stderr] Compiling pest_generator v2.7.10 [INFO] [stderr] Compiling pest_derive v2.7.10 [INFO] [stderr] Checking xtag v1.1.1 [INFO] [stderr] Checking xtagger v1.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/lib.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/lib.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/lib.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/lib.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | if !find_dollar.find(&replace).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_dollar.find(&replace).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:39:38 [INFO] [stdout] | [INFO] [stdout] 39 | if find_capture_group_start.find(&find).is_some() { [INFO] [stdout] | ^^^^^ help: change this to: `find` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:41:30 [INFO] [stdout] | [INFO] [stdout] 41 | if !find_dollar.find(&replace).is_some() { [INFO] [stdout] | ^^^^^^^^ help: change this to: `replace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | if !find_dollar.find(&replace).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_dollar.find(&replace).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:39:38 [INFO] [stdout] | [INFO] [stdout] 39 | if find_capture_group_start.find(&find).is_some() { [INFO] [stdout] | ^^^^^ help: change this to: `find` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:41:30 [INFO] [stdout] | [INFO] [stdout] 41 | if !find_dollar.find(&replace).is_some() { [INFO] [stdout] | ^^^^^^^^ help: change this to: `replace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | fn print_file(path: &PathBuf, hyperlink: bool) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - fn print_file(path: &PathBuf, hyperlink: bool) { [INFO] [stdout] 16 + fn print_file(path: &Path, hyperlink: bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:29:16 [INFO] [stdout] | [INFO] [stdout] 29 | print_file(&path, hyperlink); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | print_file(&path, hyperlink); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/lib.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 54 | .or_insert(HashSet::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/lib.rs:59:50 [INFO] [stdout] | [INFO] [stdout] 59 | collection.entry(key.to_owned()).or_insert(HashSet::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:76:35 [INFO] [stdout] | [INFO] [stdout] 76 | let mut tags = xtag::get_tags(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 94 | tags = xtag::rename(&find, &replace, tags)?; [INFO] [stdout] | ^^^^^ help: change this to: `find` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:94:36 [INFO] [stdout] | [INFO] [stdout] 94 | tags = xtag::rename(&find, &replace, tags)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `replace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/lib.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 100 | if let Some(_) = tags.remove(tag) { [INFO] [stdout] | -------^^^^^^^------------------- help: try: `if tags.remove(tag).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:111:21 [INFO] [stdout] | [INFO] [stdout] 111 | output_callback(&path, &tags); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:115:28 [INFO] [stdout] | [INFO] [stdout] 115 | xtag::set_tags(&path, &tags)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:119:31 [INFO] [stdout] | [INFO] [stdout] 119 | xtag::delete_tags(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:139:32 [INFO] [stdout] | [INFO] [stdout] 139 | handle_endpoint(&path, &app, ©tags, output_callback)?; [INFO] [stdout] | ^^^^ help: change this to: `app` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | fn print_file(path: &PathBuf, hyperlink: bool) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - fn print_file(path: &PathBuf, hyperlink: bool) { [INFO] [stdout] 16 + fn print_file(path: &Path, hyperlink: bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:29:16 [INFO] [stdout] | [INFO] [stdout] 29 | print_file(&path, hyperlink); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | print_file(&path, hyperlink); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/lib.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 54 | .or_insert(HashSet::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/lib.rs:59:50 [INFO] [stdout] | [INFO] [stdout] 59 | collection.entry(key.to_owned()).or_insert(HashSet::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:76:35 [INFO] [stdout] | [INFO] [stdout] 76 | let mut tags = xtag::get_tags(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 94 | tags = xtag::rename(&find, &replace, tags)?; [INFO] [stdout] | ^^^^^ help: change this to: `find` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:94:36 [INFO] [stdout] | [INFO] [stdout] 94 | tags = xtag::rename(&find, &replace, tags)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `replace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/lib.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 100 | if let Some(_) = tags.remove(tag) { [INFO] [stdout] | -------^^^^^^^------------------- help: try: `if tags.remove(tag).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:111:21 [INFO] [stdout] | [INFO] [stdout] 111 | output_callback(&path, &tags); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:115:28 [INFO] [stdout] | [INFO] [stdout] 115 | xtag::set_tags(&path, &tags)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:119:31 [INFO] [stdout] | [INFO] [stdout] 119 | xtag::delete_tags(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:139:32 [INFO] [stdout] | [INFO] [stdout] 139 | handle_endpoint(&path, &app, ©tags, output_callback)?; [INFO] [stdout] | ^^^^ help: change this to: `app` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.99s [INFO] running `Command { std: "docker" "inspect" "17fe3b964ca31457a0d7004acbfc531e21701e0a6634b5af62be7f82bf6717ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "17fe3b964ca31457a0d7004acbfc531e21701e0a6634b5af62be7f82bf6717ef", kill_on_drop: false }` [INFO] [stdout] 17fe3b964ca31457a0d7004acbfc531e21701e0a6634b5af62be7f82bf6717ef